Re: [PATCH 4/7] mm/page_alloc.c: remove unneeded codes in !NUMA version of build_zonelists()

[Baoquan He <bhe@redhat.com>]

On 03/27/24 at 09:53am, kernel test robot wrote:
> Hi Baoquan,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on akpm-mm/mm-everything]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Baoquan-He/mm-move-array-mem_section-init-code-out-of-memory_present/20240326-141458
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
> patch link:    https://lore.kernel.org/r/20240326061134.1055295-5-bhe%40redhat.com
> patch subject: [PATCH 4/7] mm/page_alloc.c: remove unneeded codes in !NUMA version of build_zonelists()
> config: riscv-allnoconfig (https://download.01.org/0day-ci/archive/20240327/202403270916.8ARzkyqB-lkp@intel.com/config)
> compiler: riscv64-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240327/202403270916.8ARzkyqB-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202403270916.8ARzkyqB-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    mm/page_alloc.c: In function 'build_zonelists':
> >> mm/page_alloc.c:5324:19: warning: variable 'local_node' set but not used [-Wunused-but-set-variable]
>     5324 |         int node, local_node;
>          |                   ^~~~~~~~~~
> >> mm/page_alloc.c:5324:13: warning: unused variable 'node' [-Wunused-variable]
>     5324 |         int node, local_node;
>          |             ^~~~

Thanks, below change can fix the warning. Will update and send out v2.

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index b60cdcda46d2..b3872063ea63 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5180,12 +5180,9 @@ static void setup_min_slab_ratio(void);
 
 static void build_zonelists(pg_data_t *pgdat)
 {
-	int node, local_node;
 	struct zoneref *zonerefs;
 	int nr_zones;
 
-	local_node = pgdat->node_id;
-
 	zonerefs = pgdat->node_zonelists[ZONELIST_FALLBACK]._zonerefs;
 	nr_zones = build_zonerefs_node(pgdat, zonerefs);
 	zonerefs += nr_zones;