From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-185.mta1.migadu.com (out-185.mta1.migadu.com [95.215.58.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFD3AC8E1 for ; Thu, 28 Mar 2024 02:25:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.185 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711592732; cv=none; b=lOedG8Mlx6CbNwKKe0VNsEKSOkKRGmATJSZxWUQ1BiYOecl6XjdtuslQHqf4m9zrCHPYlctXdV2lzd+U3FWTcnB6InkQCT+QfBX+IjV1u911I5ULDeKyrOr0wtl0QbDtDEL01WcNBqRfhtpsycuQ75hzA7Vm3eTl7nsxjLBla/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711592732; c=relaxed/simple; bh=F+2PBUITY1EMreS647dj+r5aRdhFyJY4oSvc7+Zjjm0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R3HRn7ogMI88MfAAhBHLtVSzRKwQtyxr0xKBFgwBPsWiAim36VcOcCNfJHYk8xeqnFe/ZmtFfBDuPSk6x0I3AsOHJx3DASEwFpCY3HlUMAlPigUmGNNFMneoi+IFjv2N58qoPAJJMIboXMkEodDWHJW8w8VybDQBMc7FRH+M/ZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=jookia.org; spf=none smtp.mailfrom=jookia.org; dkim=pass (2048-bit key) header.d=jookia.org header.i=@jookia.org header.b=G2OD3wfV; arc=none smtp.client-ip=95.215.58.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=jookia.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=jookia.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=jookia.org header.i=@jookia.org header.b="G2OD3wfV" Date: Thu, 28 Mar 2024 13:21:21 +1100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jookia.org; s=key1; t=1711592727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dVrUwsE3K2gkHszUejGPBHKGdhDZo6IS90T9be1UVRk=; b=G2OD3wfVYM0ss3YS0/hftkRoFZurKH//5tklL8kaS1+kbz7cV9JwDJQEkjafN9YyOYVga7 iAtKt0h33dl4cqSGD9SpSVTKa5a2HZFKJDwhvXdHdu1Yg7PgnU5u12HM9DNO8jaFkGLDZ/ l9XiKSjm9JUd8hL3hHyG4+jDBX2AueMmetrPawbPGyroTIuOvJ57QrH3B6qjM0jWZT8sQI YPCpwn8je+YSB8wN/v/oXVTFgKH7oL468NXorJ23NSdPiuRDKz32jVPRoh6x2/wi9MavwN 1doruKSlm1g2UntpnxUDvOn5+QJWriuYDpi/056MOyPWY/gjhSTeMT/JE5WaMg== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: John Watts To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Samuel Holland , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: sunxi: sun4i-i2s: Enable 32-bit audio formats Message-ID: References: <20240326-sunxi_s32-v1-1-899f71dcb1e6@jookia.org> <23447395.6Emhk5qWAg@jernej-laptop> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <23447395.6Emhk5qWAg@jernej-laptop> X-Migadu-Flow: FLOW_OUT On Wed, Mar 27, 2024 at 08:53:32PM +0100, Jernej Škrabec wrote: > I wish it would be that simple. SUN4I_FORMATS is cross section of all I2S > variants that are supported by this driver. If you check A10, you'll see that > it doesn't support S32. > > If you want to add support for S32, you'll have to add new quirk for each > variant. Yes, A10 doesn't support it. But it should error out in hw_params due to get_sr not supporting 32-bit, no? > > Best regards, > Jernej John. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40BE0C47DD9 for ; Thu, 28 Mar 2024 02:25:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xUddQLz6R720CdbT6vUVyOeJWtCmF6+HPSOshh8KkJw=; b=jgrPaIexJtuK+e jiqkAU2sETr+smZPHoELhV4dxgDCWp3aFvU929DSZwvyQk0J1dS4R1MHMJmf1/flJiC/fLL+AFRvh P+JWEr9AIUiLf4WWciJMn8f4RXf2ujX3hHty4JXjAlVo2Mi/M9CyAZrUelRkWLGO6Klx/xIJFWfEI XyxeBzZMqaoVfBYPHna4mh2dq45yW/8ft2AmIk/nGCpS1BF/g+onM8B2324ZV+hNO6VFU1t7C4XFN Kdv/H6oVKzRmqVps01ijFNTdA8VwZac9Pw9brGJVY0Qy4v2RzEMD/+zftrLeEOSunzH191AWWW6/V DqZNAjqxJ2l6IGPUmO7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpfSU-0000000C5xq-459g; Thu, 28 Mar 2024 02:25:38 +0000 Received: from out-175.mta1.migadu.com ([2001:41d0:203:375::af]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpfSR-0000000C5ui-0d70 for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2024 02:25:37 +0000 Date: Thu, 28 Mar 2024 13:21:21 +1100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jookia.org; s=key1; t=1711592727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dVrUwsE3K2gkHszUejGPBHKGdhDZo6IS90T9be1UVRk=; b=G2OD3wfVYM0ss3YS0/hftkRoFZurKH//5tklL8kaS1+kbz7cV9JwDJQEkjafN9YyOYVga7 iAtKt0h33dl4cqSGD9SpSVTKa5a2HZFKJDwhvXdHdu1Yg7PgnU5u12HM9DNO8jaFkGLDZ/ l9XiKSjm9JUd8hL3hHyG4+jDBX2AueMmetrPawbPGyroTIuOvJ57QrH3B6qjM0jWZT8sQI YPCpwn8je+YSB8wN/v/oXVTFgKH7oL468NXorJ23NSdPiuRDKz32jVPRoh6x2/wi9MavwN 1doruKSlm1g2UntpnxUDvOn5+QJWriuYDpi/056MOyPWY/gjhSTeMT/JE5WaMg== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: John Watts To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Samuel Holland , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: sunxi: sun4i-i2s: Enable 32-bit audio formats Message-ID: References: <20240326-sunxi_s32-v1-1-899f71dcb1e6@jookia.org> <23447395.6Emhk5qWAg@jernej-laptop> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <23447395.6Emhk5qWAg@jernej-laptop> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_192535_870335_8F95428B X-CRM114-Status: GOOD ( 11.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBNYXIgMjcsIDIwMjQgYXQgMDg6NTM6MzJQTSArMDEwMCwgSmVybmVqIMWga3JhYmVj IHdyb3RlOgo+IEkgd2lzaCBpdCB3b3VsZCBiZSB0aGF0IHNpbXBsZS4gU1VONElfRk9STUFUUyBp cyBjcm9zcyBzZWN0aW9uIG9mIGFsbCBJMlMKPiB2YXJpYW50cyB0aGF0IGFyZSBzdXBwb3J0ZWQg YnkgdGhpcyBkcml2ZXIuIElmIHlvdSBjaGVjayBBMTAsIHlvdSdsbCBzZWUgdGhhdAo+IGl0IGRv ZXNuJ3Qgc3VwcG9ydCBTMzIuCj4gCj4gSWYgeW91IHdhbnQgdG8gYWRkIHN1cHBvcnQgZm9yIFMz MiwgeW91J2xsIGhhdmUgdG8gYWRkIG5ldyBxdWlyayBmb3IgZWFjaAo+IHZhcmlhbnQuCgpZZXMs IEExMCBkb2Vzbid0IHN1cHBvcnQgaXQuIEJ1dCBpdCBzaG91bGQgZXJyb3Igb3V0IGluIGh3X3Bh cmFtcyBkdWUgdG8KZ2V0X3NyIG5vdCBzdXBwb3J0aW5nIDMyLWJpdCwgbm8/Cgo+IAo+IEJlc3Qg cmVnYXJkcywKPiBKZXJuZWoKCkpvaG4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==