From: Andi Shyti <andi.shyti@linux.intel.com>
To: Andi Shyti <andi.shyti@linux.intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH] drm/i915/gem: Replace dev_priv with i915
Date: Thu, 28 Mar 2024 09:37:15 +0100 [thread overview]
Message-ID: <ZgUsO9OTrHO7HaPC@ashyti-mobl2.lan> (raw)
In-Reply-To: <20240328071833.664001-1-andi.shyti@linux.intel.com>
Hi,
On Thu, Mar 28, 2024 at 08:18:33AM +0100, Andi Shyti wrote:
> Anyone using 'dev_priv' instead of 'i915' in a cleaned-up area
> should be fined and required to do community service for a few
> days.
Not to scare people off, I would add another sentence in between:
"Using 'i915' instead of 'dev_priv' has been the preferred
practice over the past years and some effort has been spent to
replace 'dev_priv' with 'i915'. Therefore, 'dev_priv' should
almost never be used (unless it breaks some defines which are
dependent on the naming)."
> I thought I had cleaned up the 'gem/' directory in the past, but
> still, old aficionados of the 'dev_priv' name keep sneaking it
> in.
>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Tvrtko Ursulin <tursulin@ursulin.net>
Thanks,
Andi
next prev parent reply other threads:[~2024-03-28 8:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 7:18 [PATCH] drm/i915/gem: Replace dev_priv with i915 Andi Shyti
2024-03-28 7:57 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-03-28 7:57 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-03-28 8:37 ` Andi Shyti [this message]
2024-03-28 8:44 ` [PATCH] " Tvrtko Ursulin
2024-03-28 15:33 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-03-28 18:03 ` ✓ Fi.CI.IGT: " Patchwork
2024-03-28 23:41 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgUsO9OTrHO7HaPC@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=rodrigo.vivi@intel.com \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.