From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E55E380BE3 for ; Thu, 28 Mar 2024 13:18:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711631900; cv=none; b=GUgUeyI1UIVB9H7r8IKfsz3Bt7qBV6UEr+tqe2WJWbxR5ex8pPdbKsZ8tQ7sTOZxuf+Wo+P+Zz57oETNpLO97/BXZevl+hpQsFsnMYX55oycAlXSwonfJxGFnphRans+AqepL1MembM1fioTYs7pJ6bKmNhSpM1k4JapcBe4Vmc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711631900; c=relaxed/simple; bh=m9Xq5g3ZIfAlKNLnX3jBhbUBxEU3DFQEizqgxV2mYAo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hdo9V7hlhaAT43MKKFZVUaipUprZaEUBZ939fVpOd6J8yZHTSH/9jfJ4/R/ovNkakqj3Y/aPhLSCKkqKsHRuolPRDCzU+la/LpbJ6/K4XRIg26W1f5u0buQ9DBCMiMzS+sSltosMfcEMnEopLaZJ1upF8duYojEGDTiQ/Ihfm0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=PAuay5rl; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PAuay5rl" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-41549a13fabso26375e9.1 for ; Thu, 28 Mar 2024 06:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711631896; x=1712236696; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=KRxD2qE2SiE5U4r15yWiOr1p4ZGvqGTpNga6hUR8pFQ=; b=PAuay5rlNfUAstYrYWSn4zjogFFtL/ZNqeKZrxjnXvrBi9yf0EVo4Ukk7pQLU2+sid FukwWsZHX2IUQcr56hsrimnsOaOVyV75fqag2KG/0lDMRTX+TUTia1ot6LcylZLNNdQf nF8L5wwe9JJmhxdyFanbex2gTX08d6/is4DI1FJo0YgWDrJExrAa4O07xPfGQZZkg1kL Ai/FZuYhuSY6wJvsjSAdYQVKTtRUySqnzB2skDbR8i1/pd3gZ4MoWr8feyYTUydRbl8f 2utjoxq9K+Bv2r8x/29C2vS5vgCXNOcp1Ub5gE/dh2RIEHFi4yg9sBI2tN7YsxSYxHkR iqAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711631896; x=1712236696; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KRxD2qE2SiE5U4r15yWiOr1p4ZGvqGTpNga6hUR8pFQ=; b=Wjm/qjYSBLr+Bi+PxNYj3LUZEioDTTx+9MTiSLLSvWQzLaQxi3vB0uKYyxlTOA/N4N ctoBxPHZ3JmG3z/l2TNK0dEbB5jlgzrjhoJndJO+YOGIlBhQesCxX1YP9tjPT5ChxYF/ vd6z8SR00fXji8o4gWC7zko6OsTYlswgg8nknyLbLlbTuv+kjXHbdvXrAIGAVXBZ6jFf t/uNYvlW6FM1lIl3G/Bzv2VUygttc4brmA+QdW9+ooZ7T92tmLDL+zPPyI/2axwV+KrE OL33UcV1jZNPtFrlrGUXARKFdNeZLU3Sa0DhafkP8HSMOrDtNdKv8cHSuGXwKCPLF/KS eEqQ== X-Gm-Message-State: AOJu0YwcuJgT9c85XLoEve7BtVOLrQ0KUz4aXhPKlDDwIJUltWNntQlj QZKG/dD0uNXChaQSUjQKh2+mpG5VD1OtzbnTFo80Jxs6K7ARljdh+/1Lv9sfGw== X-Google-Smtp-Source: AGHT+IGfN0vIqHAcz8qETmuQ8hKB2UR3XHLQnh1dVfD7Xd8Xs5tFMQBmY7N6uswYUuSEJZ6jXZsYlw== X-Received: by 2002:a05:600c:6546:b0:414:7f46:95f with SMTP id dn6-20020a05600c654600b004147f46095fmr152048wmb.5.1711631896097; Thu, 28 Mar 2024 06:18:16 -0700 (PDT) Received: from google.com (180.232.140.34.bc.googleusercontent.com. [34.140.232.180]) by smtp.gmail.com with ESMTPSA id bd11-20020a05600c1f0b00b00415460a63ebsm1581636wmb.29.2024.03.28.06.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 06:18:15 -0700 (PDT) Date: Thu, 28 Mar 2024 13:18:10 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Lu Baolu , Eric Auger , Jean-Philippe Brucker , Joerg Roedel , Kevin Tian , kernel test robot , Moritz Fischer , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameer Kolothum , Tony Zhu , Yi Liu , Zhangfei Gao Subject: Re: [PATCH v6 03/29] iommu/arm-smmu-v3: Do not allow a SVA domain to be set on the wrong PASID Message-ID: References: <0-v6-228e7adf25eb+4155-smmuv3_newapi_p2_jgg@nvidia.com> <3-v6-228e7adf25eb+4155-smmuv3_newapi_p2_jgg@nvidia.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3-v6-228e7adf25eb+4155-smmuv3_newapi_p2_jgg@nvidia.com> Hi Jason, On Wed, Mar 27, 2024 at 03:07:49PM -0300, Jason Gunthorpe wrote: > The SVA code is wired to assume that the SVA is programmed onto the > mm->pasid. The current core code always does this, so it is fine. > > Add a check for clarity. > > Fixes: 386fa64fd52b ("arm-smmu-v3/sva: Add SVA domain support") > Tested-by: Nicolin Chen > Tested-by: Shameer Kolothum > Reviewed-by: Mostafa Saleh I think there might have been a mix up, this was patch 01 in v5, I didn’t add a tag on it. I don’t have a problem with the patch. I just think (based on my limited understanding and rules in[1]) that it is not a fix as (mentioned in the last thread) the only caller in the tree calls it properly. But that’s up to the driver/stable maintainers. [1] https://www.kernel.org/doc/html/next/process/stable-kernel-rules.html > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c > index 2cd433a9c8a0fa..41b44baef15e80 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c > @@ -569,6 +569,9 @@ static int arm_smmu_sva_set_dev_pasid(struct iommu_domain *domain, > int ret = 0; > struct mm_struct *mm = domain->mm; > > + if (mm_get_enqcmd_pasid(mm) != id) > + return -EINVAL; > + > mutex_lock(&sva_lock); > ret = __arm_smmu_sva_bind(dev, id, mm); > mutex_unlock(&sva_lock); > -- > 2.43.2 > Thanks, Mostafa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25F9BC54E64 for ; Thu, 28 Mar 2024 13:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PyMPXZGu3RYy7EUhvN9nHYEMaN6LbYjtMWkwueCyyz8=; b=GtY+8U2DlCDimC 1QnfkKrTTHphrb5QOlH4DRROVe9nJynCo0k34Sjxl2Ycis/M5YKAyZePFca2JVxCmqIy/90WdmVSf wtVRduNc9Hm1PffMTuTrmOz38cHkbtbMLg6qBudNDanlisr4mUAoRdBN38w95t5NsMLE9oLXaarLV mIhHu92k07AyVseGGpSvaPdcE7tQvLCZUo1P+xIIRk9Bp845JUpRpkUEO+IOAgKQgHKmrJDWuHepn /LSfb7N1vZnNBU+UAiDmynA1uFMuoE992wUFub+tpXl5a5KuafD93FLAmofurLcBITacF92CvIwb0 0xUckESeIPTdK3sMN1tA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rppeE-0000000E57x-13nh; Thu, 28 Mar 2024 13:18:26 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rppeB-0000000E55Y-3kCF for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2024 13:18:25 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-413f8c8192eso71415e9.0 for ; Thu, 28 Mar 2024 06:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711631896; x=1712236696; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=KRxD2qE2SiE5U4r15yWiOr1p4ZGvqGTpNga6hUR8pFQ=; b=jYCvg33MU/V6Poy+0LRYHDxjqBK7yHpjjNkrejkx27dRuRxy67flnfRqA79ZD4+Yan Jc6/C5BRD4KnbVKNn/xYiJAVUSDCoIQjF+eiPe/OO6trpNfYR12HcPdwB/NJ2cPp09D0 M3ragG1nNoBnruaEKpa/8ZPLYi+CGqd5V5Hofm7+VwCXRWVK7jKKSjtgjsSBCWdYyzl1 aIo1816DSTKjDpcZQJEYbXZ52+0Puqrpu/WetbbOxWIXrQR1lZfyYe1tStJAzvgo6Iih b+r6e0zypRgAugPIXmla+3sDPipgOl/al5TmfqXRgTCvLXC+dCwM3K6w5/HHq1TifICR VErA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711631896; x=1712236696; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KRxD2qE2SiE5U4r15yWiOr1p4ZGvqGTpNga6hUR8pFQ=; b=YhaXitLBKlmSITjQzJ8VUyV0vIuN4pR9aH+XL/wy1qhCJskyY6PhfwePgNiN0x8Z2m aNZEJqTYcvJ4/1IQ4qamjALei3qNF0Y/lE70ZQ8oBBWgDRQ2hfiv35dEUCwFt7KvdvvW SxntbnaQJA43jnhgZJt7CnyvEnBAz1pqafG9A0t1Osyk0l2P70RWBtQc8vPct6v+OX2C xF4QagZa1SD1rg2/fH3LN8bXi2czyTile0AafAIzhCFqHMBD+fa12+q7kLLaAgs/7Si6 CltNypnMPkG6D+4ndSBUTznNylq8IlJ9G+met/XAd4vQDMQSqQqQUkLJFA0vPzkPWSiG +MXw== X-Forwarded-Encrypted: i=1; AJvYcCXSYdERRvmolG8M+doLm1u6pzkEl+4+v8gLJM7r38euy5C4O3QVTgB1aKP+jHZ8gYtQSNuz4E9BnOKS2Sn+xIysUCpBC0UoS43yNsFlD1efYAB0ThA= X-Gm-Message-State: AOJu0YzKWOlb5d8ZfI42b8+AnV8hn/BIw9iSARMwpTUpW8vRCwA1xIJ5 vr2XNiUbYscY7cDtto9jOKYL0987CapMar83iXDWMIva/ISEgLcmFh/+XLqoKA== X-Google-Smtp-Source: AGHT+IGfN0vIqHAcz8qETmuQ8hKB2UR3XHLQnh1dVfD7Xd8Xs5tFMQBmY7N6uswYUuSEJZ6jXZsYlw== X-Received: by 2002:a05:600c:6546:b0:414:7f46:95f with SMTP id dn6-20020a05600c654600b004147f46095fmr152048wmb.5.1711631896097; Thu, 28 Mar 2024 06:18:16 -0700 (PDT) Received: from google.com (180.232.140.34.bc.googleusercontent.com. [34.140.232.180]) by smtp.gmail.com with ESMTPSA id bd11-20020a05600c1f0b00b00415460a63ebsm1581636wmb.29.2024.03.28.06.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 06:18:15 -0700 (PDT) Date: Thu, 28 Mar 2024 13:18:10 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Lu Baolu , Eric Auger , Jean-Philippe Brucker , Joerg Roedel , Kevin Tian , kernel test robot , Moritz Fischer , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameer Kolothum , Tony Zhu , Yi Liu , Zhangfei Gao Subject: Re: [PATCH v6 03/29] iommu/arm-smmu-v3: Do not allow a SVA domain to be set on the wrong PASID Message-ID: References: <0-v6-228e7adf25eb+4155-smmuv3_newapi_p2_jgg@nvidia.com> <3-v6-228e7adf25eb+4155-smmuv3_newapi_p2_jgg@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3-v6-228e7adf25eb+4155-smmuv3_newapi_p2_jgg@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_061823_968784_3C4C4B72 X-CRM114-Status: GOOD ( 24.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmFzb24sCgpPbiBXZWQsIE1hciAyNywgMjAyNCBhdCAwMzowNzo0OVBNIC0wMzAwLCBKYXNv biBHdW50aG9ycGUgd3JvdGU6Cj4gVGhlIFNWQSBjb2RlIGlzIHdpcmVkIHRvIGFzc3VtZSB0aGF0 IHRoZSBTVkEgaXMgcHJvZ3JhbW1lZCBvbnRvIHRoZQo+IG1tLT5wYXNpZC4gVGhlIGN1cnJlbnQg Y29yZSBjb2RlIGFsd2F5cyBkb2VzIHRoaXMsIHNvIGl0IGlzIGZpbmUuCj4gCj4gQWRkIGEgY2hl Y2sgZm9yIGNsYXJpdHkuCj4gCj4gRml4ZXM6IDM4NmZhNjRmZDUyYiAoImFybS1zbW11LXYzL3N2 YTogQWRkIFNWQSBkb21haW4gc3VwcG9ydCIpCj4gVGVzdGVkLWJ5OiBOaWNvbGluIENoZW4gPG5p Y29saW5jQG52aWRpYS5jb20+Cj4gVGVzdGVkLWJ5OiBTaGFtZWVyIEtvbG90aHVtIDxzaGFtZWVy YWxpLmtvbG90aHVtLnRob2RpQGh1YXdlaS5jb20+Cj4gUmV2aWV3ZWQtYnk6IE1vc3RhZmEgU2Fs ZWggPHNtb3N0YWZhQGdvb2dsZS5jb20+CgpJIHRoaW5rIHRoZXJlIG1pZ2h0IGhhdmUgYmVlbiBh IG1peCB1cCwgdGhpcyB3YXMgcGF0Y2ggMDEgaW4gdjUsCkkgZGlkbuKAmXQgYWRkIGEgdGFnIG9u IGl0LiBJIGRvbuKAmXQgaGF2ZSBhIHByb2JsZW0gd2l0aCB0aGUgcGF0Y2guCkkganVzdCB0aGlu ayAoYmFzZWQgb24gbXkgbGltaXRlZCB1bmRlcnN0YW5kaW5nIGFuZCBydWxlcyBpblsxXSkKdGhh dCBpdCBpcyBub3QgYSBmaXggYXMgKG1lbnRpb25lZCBpbiB0aGUgbGFzdCB0aHJlYWQpIHRoZSBv bmx5CmNhbGxlciBpbiB0aGUgdHJlZSBjYWxscyBpdCBwcm9wZXJseS4KQnV0IHRoYXTigJlzIHVw IHRvIHRoZSBkcml2ZXIvc3RhYmxlIG1haW50YWluZXJzLgoKWzFdIGh0dHBzOi8vd3d3Lmtlcm5l bC5vcmcvZG9jL2h0bWwvbmV4dC9wcm9jZXNzL3N0YWJsZS1rZXJuZWwtcnVsZXMuaHRtbAo+IFNp Z25lZC1vZmYtYnk6IEphc29uIEd1bnRob3JwZSA8amdnQG52aWRpYS5jb20+Cj4gLS0tCj4gIGRy aXZlcnMvaW9tbXUvYXJtL2FybS1zbW11LXYzL2FybS1zbW11LXYzLXN2YS5jIHwgMyArKysKPiAg MSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2lvbW11L2FybS9hcm0tc21tdS12My9hcm0tc21tdS12My1zdmEuYyBiL2RyaXZlcnMvaW9tbXUv YXJtL2FybS1zbW11LXYzL2FybS1zbW11LXYzLXN2YS5jCj4gaW5kZXggMmNkNDMzYTljOGEwZmEu LjQxYjQ0YmFlZjE1ZTgwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvaW9tbXUvYXJtL2FybS1zbW11 LXYzL2FybS1zbW11LXYzLXN2YS5jCj4gKysrIGIvZHJpdmVycy9pb21tdS9hcm0vYXJtLXNtbXUt djMvYXJtLXNtbXUtdjMtc3ZhLmMKPiBAQCAtNTY5LDYgKzU2OSw5IEBAIHN0YXRpYyBpbnQgYXJt X3NtbXVfc3ZhX3NldF9kZXZfcGFzaWQoc3RydWN0IGlvbW11X2RvbWFpbiAqZG9tYWluLAo+ICAJ aW50IHJldCA9IDA7Cj4gIAlzdHJ1Y3QgbW1fc3RydWN0ICptbSA9IGRvbWFpbi0+bW07Cj4gIAo+ ICsJaWYgKG1tX2dldF9lbnFjbWRfcGFzaWQobW0pICE9IGlkKQo+ICsJCXJldHVybiAtRUlOVkFM Owo+ICsKPiAgCW11dGV4X2xvY2soJnN2YV9sb2NrKTsKPiAgCXJldCA9IF9fYXJtX3NtbXVfc3Zh X2JpbmQoZGV2LCBpZCwgbW0pOwo+ICAJbXV0ZXhfdW5sb2NrKCZzdmFfbG9jayk7Cj4gLS0gCj4g Mi40My4yCj4KClRoYW5rcywKTW9zdGFmYQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=