From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D73FC13E6D4; Thu, 28 Mar 2024 19:52:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711655549; cv=none; b=Ts79hrnhWXYE3plhEHcoe6zMe1sxSM1nD1/Yx5eQ2Cqc/0D4B73bEZ+ysXzEvGbQFCp2W9OfUxuisytvOxvVC5nEyAhhGQU4FSyki7DkiT+13D+AyzLGUr2KU2qTEr97JrSJ6dV375cVtGoTDoW4IZBfv9bH65PI9+BI4I4dFdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711655549; c=relaxed/simple; bh=qmQFGHYUei7BOkNgnnntn6VCVy9UtjipJi0ZJ6b8pZo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WJbdZtoySnpArpKIq3Y++q+4noEuikoyvfCKGgU8nniqriLp3WjGlhCSIQN2aO4CrNverX+/B/cC/BW8I6UvBtosmiOx8siUe/3mvobdXBRnWiXZaeixC20ZngOUUvSRuBphg/9H4753nOZ4nW1WhH/TYgI+Dba7Tiwa3tKER0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=acm.org; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BzZO+VTw; arc=none smtp.client-ip=209.85.160.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BzZO+VTw" Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-2218a0f55e1so736398fac.1; Thu, 28 Mar 2024 12:52:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711655547; x=1712260347; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:from:to:cc:subject:date :message-id:reply-to; bh=YT6C4kyGaXJTnO4s5bmEmPWYlNQPKErlDo5CuGDxbV8=; b=BzZO+VTwXeXUMfJp9uaaNk4/luhN8JJWb2nmCyppB8FE5a7zKGcBmsi1/bRgiA19IE EszGeNAhHKlmt+vtVRbaML+vX02rPBw4rj9C4d2UGX0A/fWnTxB+ISF7cF3Skn0E57jn 0uC9dL7CsFZooyDb1lumfmUmR4DdL9D5Y46wXtXQGhQJ4lpYKaUdoZclWDa2CUqY8s3E NWdCLySAgwUC/Csg0VwwkPBSoN2w0qW8Hm8jBz8wlZvpzfJ4u5f6iARYTMMO5HL5GDiz vsasRI2txY/fhPHnkQHG2GfwpvSFzCkhMztyKops+XFI8JaDs4H7cu1znDOdLysCU329 WX1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711655547; x=1712260347; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YT6C4kyGaXJTnO4s5bmEmPWYlNQPKErlDo5CuGDxbV8=; b=CZxb6Ho1780NXsrCzL7uKROfRoXQPEafGh6ZBNlq4v5RQ2tzaLWH7R1bqlvKKDmhwW kWALeF/0b9/que+1klY9/D1jzd1YGOxnd6biZ09MjLgKdz1ubY0Lb7H4Q/Kh8i9/jTOP BBRFuE0Ppmj/6fowrRbbobI0dBYKT4flCbpDzCuTSGxZvus7pcSozPo2DH3ujUj1f8+i tMikwkpNXDJMA6xKgELzHOV2sp1GQYVoRkZ6I67HbS1mN/5Yp4ZXsTLAAo7ZZjdXHS0c RRso4Tgvu5PnOCGpeUiwTmNKaxVInwjhY8BgCmC6GL7MfNEcttJHdQivFVnzSH3s0cbL yWbw== X-Forwarded-Encrypted: i=1; AJvYcCWIH5Q+x9vUlEd3IoM0XT68dB3+pFz13itwtb7rQVqFOCAw1LiXkRa/UBapnGPFZ8pB/UsRZURoiZCrtYI0JQgg/fmLqXSBKTJyF0bIorNIR0O30QhSCFvfw+ebAnTxiCM/Hte/QRp09JVz0s+ZnfFYOvO5X4MuOQ== X-Gm-Message-State: AOJu0YyLgLBOgOfo8AtzhQ01bKzyybiYHuc+UCIWo0mjZumS0jwmkCQZ Go02T/kybBXvGA869VkZuL9MmyXG/LNsxCf02GBfSYc+pMcC1T0= X-Google-Smtp-Source: AGHT+IHzO114l0NerWSB89S0FuZIWvU872Dx5hTOnZas2urBgE80eNZxB2BV9A8JCj8+LYtYL67EKw== X-Received: by 2002:a05:6870:3513:b0:22a:8e5:941 with SMTP id k19-20020a056870351300b0022a08e50941mr177999oah.52.1711655546921; Thu, 28 Mar 2024 12:52:26 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id pd12-20020a0568717a8c00b00229f94bf403sm536320oac.19.2024.03.28.12.52.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 12:52:26 -0700 (PDT) Sender: Corey Minyard Received: from mail.minyard.net (unknown [IPv6:2001:470:b8f6:1b:b987:69e:202a:697a]) by serve.minyard.net (Postfix) with ESMTPSA id 4B51A180059; Thu, 28 Mar 2024 19:52:25 +0000 (UTC) Date: Thu, 28 Mar 2024 14:52:24 -0500 From: Corey Minyard To: Allen Cc: Allen Pais , linux-kernel@vger.kernel.org, tj@kernel.org, keescook@chromium.org, vkoul@kernel.org, marcan@marcan.st, sven@svenpeter.dev, florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, paul@crapouillou.net, Eugeniy.Paltsev@synopsys.com, manivannan.sadhasivam@linaro.org, vireshk@kernel.org, Frank.Li@nxp.com, leoyang.li@nxp.com, zw@zh-kernel.org, wangzhou1@hisilicon.com, haijie1@huawei.com, shawnguo@kernel.org, s.hauer@pengutronix.de, sean.wang@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, afaerber@suse.de, logang@deltatee.com, daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, andersson@kernel.org, konrad.dybcio@linaro.org, orsonzhai@gmail.com, baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com, patrice.chotard@foss.st.com, linus.walleij@linaro.org, wens@csie.org, jernej.skrabec@gmail.com, peter.ujfalusi@gmail.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, jassisinghbrar@gmail.com, mchehab@kernel.org, maintainers@bluecherrydvr.com, aubin.constans@microchip.com, ulf.hansson@linaro.org, manuel.lauss@gmail.com, mirq-linux@rere.qmqm.pl, jh80.chung@samsung.com, oakad@yahoo.com, hayashi.kunihiko@socionext.com, mhiramat@kernel.org, brucechang@via.com.tw, HaraldWelte@viatech.com, pierre@ossman.eu, duncan.sands@free.fr, stern@rowland.harvard.edu, oneukum@suse.com, openipmi-developer@lists.sourceforge.net, dmaengine@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-mediatek@lists.infradead.org, linux-actions@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 6/9] ipmi: Convert from tasklet to BH workqueue Message-ID: Reply-To: minyard@acm.org References: <20240327160314.9982-1-apais@linux.microsoft.com> <20240327160314.9982-7-apais@linux.microsoft.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Mar 28, 2024 at 12:41:22PM -0700, Allen wrote: > > > > I believe that work queues items are execute single-threaded for a work > > > > queue, so this should be good. I need to test this, though. It may be > > > > that an IPMI device can have its own work queue; it may not be important > > > > to run it in bh context. > > > > > > Fair point. Could you please let me know once you have had a chance to test > > > these changes. Meanwhile, I will work on RFC wherein IPMI will have its own > > > workqueue. > > > > > > Thanks for taking time out to review. > > > > After looking and thinking about it a bit, a BH context is still > > probably the best for this. > > > > I have tested this patch under load and various scenarios and it seems > > to work ok. So: > > > > Tested-by: Corey Minyard > > Acked-by: Corey Minyard > > > > Or I can take this into my tree. > > > > -corey > > Thank you very much. I think it should be okay for you to carry it into > your tree. Ok, it's in my for-next tree. I fixed the directory reference, and I changed all the comments where you changed "tasklet" to "work" to instead say "workqueue". -corey > > - Allen > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D86CFCD128D for ; Thu, 28 Mar 2024 19:52:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RAv6IhF51j+LVGLu/IHv+qleggVvzSe9V11U9fe4Tds=; b=jB7vycPLb1mnVe O4EBp2lsWvMgarO23jRSCByi0JJI0ifWKcv+IAV/fFbt8BGa6gjF8TuoaU8v3SgpfxhK84l3yiHbn b2fpr4mzakg4DExXuZwjGqMjNQdEqlmaM0IZZvDTALVN2gFScFu5o98+5wDUh3Mfp0b7vE1rJIqPI EvoLsLB2wF4tbnAZ9/KTkPWTuILcWnOB5uUaSoSG3PGCIKiPfAYfcL59BlXYcWRti0Ev1q9sQqi/Q 8pnN6KVxMnijuEMI78W7JHSdnjivllyupcOXrIe2oUmGhuYcY+T/HvH/R1MDRfHY/Lkh1Edi7igsr LM1w/18IXkvJwtsPNXjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpvnd-0000000FSyI-3Puf; Thu, 28 Mar 2024 19:52:33 +0000 Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpvnZ-0000000FSvw-0GQs; Thu, 28 Mar 2024 19:52:30 +0000 Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-6e6e3eadec8so681305a34.0; Thu, 28 Mar 2024 12:52:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711655547; x=1712260347; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:from:to:cc:subject:date :message-id:reply-to; bh=YT6C4kyGaXJTnO4s5bmEmPWYlNQPKErlDo5CuGDxbV8=; b=Of1A8TLl7pT1NcWV/WSdZvoFpccifSBUje6jPJ3MTacRSRbGXBB9VEKdyF0EK5lPUL iSL7SJZQC0eoI1dTF0+oxZGCTo1vE4CQbufLijenN6nohUi0tOvyVy2xd0UoPiths0A9 JBqVmzK68vCmRl6iJaW/rpAGPdIHLplMfiSvZwqptuGtdUrzRHpdX4gJ2piAEyWb1JxM JLzaNat5+YONsHS0mDSHL7sf47ShAG55NJ6GXasQOg9ZWCmCZWdDDwB44myh+Uc01m4g dUgBD5XrCOi5OymZUm+4ndN9PV4yZ+i0cayAc/SDwmb4iHRm9amndA26KS6U2K9XhJ+Z xBSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711655547; x=1712260347; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YT6C4kyGaXJTnO4s5bmEmPWYlNQPKErlDo5CuGDxbV8=; b=GSgZeEvEroYGKeMxVtaI9WMTn6kAf1muV1sfY+YGdRBzQcNm07I+/gkTKmWfJz1miB 93ZrBqjh5AYP95ZxDyGpT87gSaE5FROlZ11oRiRgo+CHQa50XgrrbVFl5ThVxrkVvOVO +xRyayM/EINBlXN92i+4wL68l2bGK6HB7ZrzgW5xmc+eDbu2Xu1HXmgzUY73KxRyk/q7 mwFqqvyCFDAtfUx5+7nsdfmzs+Ugg4uQpZUn32P/sYiFEnjuioeXXKM0Susg1FpxUHZe atk0HKDbGid9wjL/qin3TaQogwfGG/cJYbwzX5FMYCd6FPciPZSHwCe7YcE1CUdoPkqd cGvw== X-Forwarded-Encrypted: i=1; AJvYcCXTysfzFqNgkaMKfxpqFwiWlaWGqLT4sKCuOX6o3yZiocRvujY0zfujkY0LfAWaEMrqVa+wIKQFTU04rfjDGERfs9WLlDGPc9sL3YM4Ndic95SLkb5sAAV4zjLPuIuaqIM1xe6YHQ3zvJ7tLIxEFMk7E1tks/84rvnlxad70fUyoOIcyrSnB6m+T3+m+bKhIinkz+XJFbn+KfWs1UhtTRsoO2rvnGhfQaIYCvWHccB16ytYf0ZBQq2IUjhoNzdhRLDZT2NncZ1sbgymS06Y9k+amTwJHw9UXO/+FQi2IxhM6F44 X-Gm-Message-State: AOJu0YxIvapyy5xQOTnWxJR8+oAGn0NEzevdZEbcxNwhdm/LSkw8w6mo GpAUTj36+nA25K6UQDScP3cG8/m3tGkaUR6fheeEiUH8LFX1nAs= X-Google-Smtp-Source: AGHT+IHzO114l0NerWSB89S0FuZIWvU872Dx5hTOnZas2urBgE80eNZxB2BV9A8JCj8+LYtYL67EKw== X-Received: by 2002:a05:6870:3513:b0:22a:8e5:941 with SMTP id k19-20020a056870351300b0022a08e50941mr177999oah.52.1711655546921; Thu, 28 Mar 2024 12:52:26 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id pd12-20020a0568717a8c00b00229f94bf403sm536320oac.19.2024.03.28.12.52.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 12:52:26 -0700 (PDT) Received: from mail.minyard.net (unknown [IPv6:2001:470:b8f6:1b:b987:69e:202a:697a]) by serve.minyard.net (Postfix) with ESMTPSA id 4B51A180059; Thu, 28 Mar 2024 19:52:25 +0000 (UTC) Date: Thu, 28 Mar 2024 14:52:24 -0500 From: Corey Minyard To: Allen Cc: Allen Pais , linux-kernel@vger.kernel.org, tj@kernel.org, keescook@chromium.org, vkoul@kernel.org, marcan@marcan.st, sven@svenpeter.dev, florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, paul@crapouillou.net, Eugeniy.Paltsev@synopsys.com, manivannan.sadhasivam@linaro.org, vireshk@kernel.org, Frank.Li@nxp.com, leoyang.li@nxp.com, zw@zh-kernel.org, wangzhou1@hisilicon.com, haijie1@huawei.com, shawnguo@kernel.org, s.hauer@pengutronix.de, sean.wang@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, afaerber@suse.de, logang@deltatee.com, daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, andersson@kernel.org, konrad.dybcio@linaro.org, orsonzhai@gmail.com, baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com, patrice.chotard@foss.st.com, linus.walleij@linaro.org, wens@csie.org, jernej.skrabec@gmail.com, peter.ujfalusi@gmail.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, jassisinghbrar@gmail.com, mchehab@kernel.org, maintainers@bluecherrydvr.com, aubin.constans@microchip.com, ulf.hansson@linaro.org, manuel.lauss@gmail.com, mirq-linux@rere.qmqm.pl, jh80.chung@samsung.com, oakad@yahoo.com, hayashi.kunihiko@socionext.com, mhiramat@kernel.org, brucechang@via.com.tw, HaraldWelte@viatech.com, pierre@ossman.eu, duncan.sands@free.fr, stern@rowland.harvard.edu, oneukum@suse.com, openipmi-developer@lists.sourceforge.net, dmaengine@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-mediatek@lists.infradead.org, linux-actions@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 6/9] ipmi: Convert from tasklet to BH workqueue Message-ID: References: <20240327160314.9982-1-apais@linux.microsoft.com> <20240327160314.9982-7-apais@linux.microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_125229_317877_E098D1CA X-CRM114-Status: GOOD ( 21.98 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Mar 28, 2024 at 12:41:22PM -0700, Allen wrote: > > > > I believe that work queues items are execute single-threaded for a work > > > > queue, so this should be good. I need to test this, though. It may be > > > > that an IPMI device can have its own work queue; it may not be important > > > > to run it in bh context. > > > > > > Fair point. Could you please let me know once you have had a chance to test > > > these changes. Meanwhile, I will work on RFC wherein IPMI will have its own > > > workqueue. > > > > > > Thanks for taking time out to review. > > > > After looking and thinking about it a bit, a BH context is still > > probably the best for this. > > > > I have tested this patch under load and various scenarios and it seems > > to work ok. So: > > > > Tested-by: Corey Minyard > > Acked-by: Corey Minyard > > > > Or I can take this into my tree. > > > > -corey > > Thank you very much. I think it should be okay for you to carry it into > your tree. Ok, it's in my for-next tree. I fixed the directory reference, and I changed all the comments where you changed "tasklet" to "work" to instead say "workqueue". -corey > > - Allen > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5806ECD11DF for ; Thu, 28 Mar 2024 22:04:59 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=TAU65O3r; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4V5Hdk0LMlz3w50 for ; Fri, 29 Mar 2024 09:04:58 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=TAU65O3r; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::334; helo=mail-ot1-x334.google.com; envelope-from=tcminyard@gmail.com; receiver=lists.ozlabs.org) Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4V5Dhv2lRKz3cDw for ; Fri, 29 Mar 2024 06:52:29 +1100 (AEDT) Received: by mail-ot1-x334.google.com with SMTP id 46e09a7af769-6e6e3eadec8so681306a34.0 for ; Thu, 28 Mar 2024 12:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711655547; x=1712260347; darn=lists.ozlabs.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:from:to:cc:subject:date :message-id:reply-to; bh=YT6C4kyGaXJTnO4s5bmEmPWYlNQPKErlDo5CuGDxbV8=; b=TAU65O3re3lGZpzFyZfAmXTDd0kEWchDR0bsVpy4/GsK3Eu+W1s5tyAmqdWFj9vl3V QvGbByV9dNM1mcX8JA98aZpkjEj2qcLvFAbK6w0jw9odJ3vdnjEzCiYtlrC8nXZ3fLnM EJq51vu1BYIT64axz6HI3Fvi9kwZ7q6YlaDXKA1hR+oToyT5yqHwYuWt/Kby+Vdmq/Hj zvrhMpD8K0ektQYgUg6GW8aY5xUYrZYzGE393fblPx4Yg1eKDHCEnKjsua19rDyqBrnw U/6a65LB4e7dPWib14TVxKdDmDSc/FIoCOgLtiUfztK/1JjdXxcJwHveysVWzo0qJZJz BPJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711655547; x=1712260347; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YT6C4kyGaXJTnO4s5bmEmPWYlNQPKErlDo5CuGDxbV8=; b=Z0GWZJovGwZ+g082zBQqZTJNOV51RPJV5KnboCZcq2qhlXuaOk27ABiMwYrEmIsCfi wmMalP5xy1gGbq77MbiVMNlG0dWC7w/i2BN+JlUEObP903h6r8fcJiIf9ElmgYEjO62+ Rj0xT1ImWFwPElpTBa2AV0DykYVVIkulKtUBD+QGWM1oJtrwHX5rvZcNfcyKc4JILJsq CqPMlAmGDoXQU0TWJrfy5Y9vTnzjpygn85jZogersjKMHBsZ244SEuN+A3OE9/GX1XL4 ZhYaRufcrZtC/5xbbKweTeJr68yVbzvnr8LQaw2u51tofPqbs2u50fk60r5hFii8htkw YGkQ== X-Forwarded-Encrypted: i=1; AJvYcCWyaj/i+T/6z3opNDzqx0yRvULYg8AA21WjNpMx+Xh1PryIZ9efNxPf8Snsb5Dib9ib84gWfgj4fdpk4moz1c9njQFa+uChQDzFIWonpQ== X-Gm-Message-State: AOJu0Yx9NF80hgRLRzxt5Ef7c43f06EaRUmzZperrOedW72eXUPQ3lpG k+tYtdLzL9LHAIxBQ2ceS9PbXmYkHI1izKgqdnVXt0FQ40fJ2z8= X-Google-Smtp-Source: AGHT+IHzO114l0NerWSB89S0FuZIWvU872Dx5hTOnZas2urBgE80eNZxB2BV9A8JCj8+LYtYL67EKw== X-Received: by 2002:a05:6870:3513:b0:22a:8e5:941 with SMTP id k19-20020a056870351300b0022a08e50941mr177999oah.52.1711655546921; Thu, 28 Mar 2024 12:52:26 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id pd12-20020a0568717a8c00b00229f94bf403sm536320oac.19.2024.03.28.12.52.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 12:52:26 -0700 (PDT) Received: from mail.minyard.net (unknown [IPv6:2001:470:b8f6:1b:b987:69e:202a:697a]) by serve.minyard.net (Postfix) with ESMTPSA id 4B51A180059; Thu, 28 Mar 2024 19:52:25 +0000 (UTC) Date: Thu, 28 Mar 2024 14:52:24 -0500 From: Corey Minyard To: Allen Subject: Re: [PATCH 6/9] ipmi: Convert from tasklet to BH workqueue Message-ID: References: <20240327160314.9982-1-apais@linux.microsoft.com> <20240327160314.9982-7-apais@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Fri, 29 Mar 2024 08:57:06 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Cc: imx@lists.linux.dev, ulf.hansson@linaro.org, oneukum@suse.com, duncan.sands@free.fr, hayashi.kunihiko@socionext.com, linux-mmc@vger.kernel.org, aubin.constans@microchip.com, linus.walleij@linaro.org, Frank.Li@nxp.com, linux-hyperv@vger.kernel.org, linux-usb@vger.kernel.org, HaraldWelte@viatech.com, paul@crapouillou.net, linux-tegra@vger.kernel.org, netdev@vger.kernel.org, maintainers@bluecherrydvr.com, peter.ujfalusi@gmail.com, manivannan.sadhasivam@linaro.org, linux-riscv@lists.infradead.org, kys@microsoft.com, robert.jarzmik@free.fr, haijie1@huawei.com, linux-renesas-soc@vger.kernel.org, wei.liu@kernel.org, linux-omap@vger.kernel.org, florian.fainelli@broadcom.com, linux-rdma@vger.kernel.org, vireshk@kernel.org, jassisinghbrar@gmail.com, decui@microsoft.com, wangzhou1@hisilicon.com, jernej.skrabec@gmail.com, jh80.chung@samsung.com, zw@zh-kernel.org, wens@csie.org, stern@rowland.harvard.edu, linux-arm-msm@vger.kernel.org, orsonzhai@gmail.com, pierre@ossman.eu, linux-mips@vger.ke rnel.org, Eugeniy.Paltsev@synopsys.com, patrice.chotard@foss.st.com, asahi@lists.linux.dev, brucechang@via.com.tw, keescook@chromium.org, oakad@yahoo.com, sven@svenpeter.dev, rjui@broadcom.com, s.hauer@pengutronix.de, sean.wang@mediatek.com, linux-actions@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, haojian.zhuang@gmail.com, mirq-linux@rere.qmqm.pl, dmaengine@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, baolin.wang@linux.alibaba.com, matthias.bgg@gmail.com, openipmi-developer@lists.sourceforge.net, mchehab@kernel.org, Allen Pais , linux-arm-kernel@lists.infradead.org, angelogioacchino.delregno@collabora.com, sbranden@broadcom.com, logang@deltatee.com, andersson@kernel.org, marcan@marcan.st, haiyangz@microsoft.com, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, konrad.dybcio@linaro.org, linux-sunxi@lists.linux.dev, vkoul@kernel.org, linux-s390@vger.kernel.org, mhiramat@kernel.org, zhang.lyra@gmail.com, tj@kernel.org, manuel.lauss@gmail.com, linux-media@vger.kernel.org, shawnguo@kernel.org, afaerber@suse.de, daniel@zonque.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Mar 28, 2024 at 12:41:22PM -0700, Allen wrote: > > > > I believe that work queues items are execute single-threaded for a work > > > > queue, so this should be good. I need to test this, though. It may be > > > > that an IPMI device can have its own work queue; it may not be important > > > > to run it in bh context. > > > > > > Fair point. Could you please let me know once you have had a chance to test > > > these changes. Meanwhile, I will work on RFC wherein IPMI will have its own > > > workqueue. > > > > > > Thanks for taking time out to review. > > > > After looking and thinking about it a bit, a BH context is still > > probably the best for this. > > > > I have tested this patch under load and various scenarios and it seems > > to work ok. So: > > > > Tested-by: Corey Minyard > > Acked-by: Corey Minyard > > > > Or I can take this into my tree. > > > > -corey > > Thank you very much. I think it should be okay for you to carry it into > your tree. Ok, it's in my for-next tree. I fixed the directory reference, and I changed all the comments where you changed "tasklet" to "work" to instead say "workqueue". -corey > > - Allen >