From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 022DEC6FD1F for ; Sat, 30 Mar 2024 14:24:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g5FjYjx90haakICgqtZDBr8b7OAu3TwOZBNgJoBA9xA=; b=y9kiiDrv0rDtRo n6K0xM7fYmwIhFmk232rCVSMgnjY7LqWzdFSWYOUtpQ46Qpei1i1A521Y0CmTsjgqdBklkHE7Mx2g oYTi3IqLFoBwGKO/ghHT5kL/5MkpKM2zQ+lKA0bSvc7RxP55joRClBLUmkkkDN7BMmdUBKnLlg93K LmtdAgEQ1DGiDdKX5grWwSSjtag2HHyte3dY0TlJz1DShcpuI2h5/whTg2jsTwyaTyzW4KpW4erUC L0V/W9FpMsecmR5ju9AT5JceTDaTwCcQtS+S4zkld6fZMRt6T3w/B7eCibFJJERER08PwbIgHChNH iGeLx7X4GxZpELmbQ+PA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqZd6-00000003cPo-1Jsp; Sat, 30 Mar 2024 14:24:20 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqZd3-00000003cPO-48xf for kexec@lists.infradead.org; Sat, 30 Mar 2024 14:24:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711808656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8HbCGyy1GVrVUNL7zlMzVEy/UJRgHTJ0kZQntvsmDig=; b=VhsZYwqkzQsUZyo0OdPkV9zY3G4/tckLsctVOLe+11dbutSY+VEAGT1UCf/dPynUXEeFUs jTJr3mjQVrEQPofanNM+s2/8aJvCT7n9JJ/nY8sMqrZZkToUf3Fp8eBmbbdbqqWWbOqhP2 k/jDl/PBSfV5qpEXuZkAht/E9NLAWLI= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-658-oZ4t53_4MXydy8zt9jpAOA-1; Sat, 30 Mar 2024 10:24:12 -0400 X-MC-Unique: oZ4t53_4MXydy8zt9jpAOA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9EE4638000A5; Sat, 30 Mar 2024 14:24:11 +0000 (UTC) Received: from localhost (unknown [10.72.116.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 468433C20; Sat, 30 Mar 2024 14:24:09 +0000 (UTC) Date: Sat, 30 Mar 2024 22:23:47 +0800 From: Baoquan He To: Huacai Chen Cc: kexec@lists.infradead.org, akpm@linux-foundation.org, geert@linux-m68k.org, WANG Xuerui , loongarch@lists.linux.dev Subject: Re: [PATCH 1/2] arch/loongarch: clean up the left code and Kconfig item related to CRASH_CORE Message-ID: References: <20240329132825.1102459-1-bhe@redhat.com> <20240329132825.1102459-2-bhe@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240330_072418_135837_E0ED6DBF X-CRM114-Status: GOOD ( 17.12 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org T24gMDMvMzAvMjQgYXQgMDk6NTlwbSwgSHVhY2FpIENoZW4gd3JvdGU6Cj4gUXVldWVkLCB0aGFu a3MuCgpUaGFua3MsIEh1YWNhaS4gV2hpbGUgSSBub3RpY2VkIEFuZHJldyBoYXMgcXVldWVkIHRo aXMgcGF0Y2hzZXQgaW4gaGlzCm1tLXVuc3RhYmxlIGJyYW5jaC4KCj4gCj4gSHVhY2FpCj4gCj4g T24gRnJpLCBNYXIgMjksIDIwMjQgYXQgOToyOOKAr1BNIEJhb3F1YW4gSGUgPGJoZUByZWRoYXQu Y29tPiB3cm90ZToKPiA+Cj4gPiBJbiBjb21taXQgODVmY2RlNDAyZGIxICgia2V4ZWM6IHNwbGl0 IGNyYXNoa2VybmVsIHJlc2VydmF0aW9uIGNvZGUKPiA+IG91dCBmcm9tIGNyYXNoX2NvcmUuYyIp LCBjcmFzaGtlcm5lbCByZXNlcnZhdGlvbiBjb2RlIGlzIHNwbGl0IG91dCBmcm9tCj4gPiBjcmFz aF9jb3JlLmMsIGFuZCBhZGQgQ1JBU0hfUkVTRVJWRSB0byBjb250cm9sIGl0LiBBbmQgYWxzbyBy ZW5hbWUgZWFjaAo+ID4gQVJDSCdzIDxhc20vY3Jhc2hfY29yZS5oPiB0byA8YXNtL2NyYXNoX3Jl c2VydmUuaD4gYWNjb3JkaW5nbHkuCj4gPgo+ID4gQnV0IHRoZSByZWxldmFudCBwYXJ0IGluIGxv b25nYXJjaCBpcyBtaXNzZWQuIERvIGl0IG5vdy4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBCYW9x dWFuIEhlIDxiaGVAcmVkaGF0LmNvbT4KPiA+IENjOiBIdWFjYWkgQ2hlbiA8Y2hlbmh1YWNhaUBr ZXJuZWwub3JnPgo+ID4gQ2M6IFdBTkcgWHVlcnVpIDxrZXJuZWxAeGVuMG4ubmFtZT4KPiA+IENj OiBsb29uZ2FyY2hAbGlzdHMubGludXguZGV2Cj4gPiAtLS0KPiA+ICBhcmNoL2xvb25nYXJjaC9L Y29uZmlnICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAyICstCj4gPiAg YXJjaC9sb29uZ2FyY2gvaW5jbHVkZS9hc20ve2NyYXNoX2NvcmUuaCA9PiBjcmFzaF9yZXNlcnZl Lmh9IHwgNCArKy0tCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVs ZXRpb25zKC0pCj4gPiAgcmVuYW1lIGFyY2gvbG9vbmdhcmNoL2luY2x1ZGUvYXNtL3tjcmFzaF9j b3JlLmggPT4gY3Jhc2hfcmVzZXJ2ZS5ofSAoNzUlKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9hcmNo L2xvb25nYXJjaC9LY29uZmlnIGIvYXJjaC9sb29uZ2FyY2gvS2NvbmZpZwo+ID4gaW5kZXggYTVm MzAwZWM2ZjI4Li41NGFkMDRkYWNkZWUgMTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL2xvb25nYXJjaC9L Y29uZmlnCj4gPiArKysgYi9hcmNoL2xvb25nYXJjaC9LY29uZmlnCj4gPiBAQCAtNTk1LDcgKzU5 NSw3IEBAIGNvbmZpZyBBUkNIX1NFTEVDVFNfQ1JBU0hfRFVNUAo+ID4gICAgICAgICBzZWxlY3Qg UkVMT0NBVEFCTEUKPiA+Cj4gPiAgY29uZmlnIEFSQ0hfSEFTX0dFTkVSSUNfQ1JBU0hLRVJORUxf UkVTRVJWQVRJT04KPiA+IC0gICAgICAgZGVmX2Jvb2wgQ1JBU0hfQ09SRQo+ID4gKyAgICAgICBk ZWZfYm9vbCBDUkFTSF9SRVNFUlZFCj4gPgo+ID4gIGNvbmZpZyBSRUxPQ0FUQUJMRQo+ID4gICAg ICAgICBib29sICJSZWxvY2F0YWJsZSBrZXJuZWwiCj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9sb29u Z2FyY2gvaW5jbHVkZS9hc20vY3Jhc2hfY29yZS5oIGIvYXJjaC9sb29uZ2FyY2gvaW5jbHVkZS9h c20vY3Jhc2hfcmVzZXJ2ZS5oCj4gPiBzaW1pbGFyaXR5IGluZGV4IDc1JQo+ID4gcmVuYW1lIGZy b20gYXJjaC9sb29uZ2FyY2gvaW5jbHVkZS9hc20vY3Jhc2hfY29yZS5oCj4gPiByZW5hbWUgdG8g YXJjaC9sb29uZ2FyY2gvaW5jbHVkZS9hc20vY3Jhc2hfcmVzZXJ2ZS5oCj4gPiBpbmRleCAyMThi ZGJmYTUyN2IuLmExZDliODRiMWM3ZCAxMDA2NDQKPiA+IC0tLSBhL2FyY2gvbG9vbmdhcmNoL2lu Y2x1ZGUvYXNtL2NyYXNoX2NvcmUuaAo+ID4gKysrIGIvYXJjaC9sb29uZ2FyY2gvaW5jbHVkZS9h c20vY3Jhc2hfcmVzZXJ2ZS5oCj4gPiBAQCAtMSw2ICsxLDYgQEAKPiA+ICAvKiBTUERYLUxpY2Vu c2UtSWRlbnRpZmllcjogR1BMLTIuMC1vbmx5ICovCj4gPiAtI2lmbmRlZiBfTE9PTkdBUkNIX0NS QVNIX0NPUkVfSAo+ID4gLSNkZWZpbmUgX0xPT05HQVJDSF9DUkFTSF9DT1JFX0gKPiA+ICsjaWZu ZGVmIF9MT09OR0FSQ0hfQ1JBU0hfUkVTRVJWRV9ICj4gPiArI2RlZmluZSBfTE9PTkdBUkNIX0NS QVNIX1JFU0VSVkVfSAo+ID4KPiA+ICAjZGVmaW5lIENSQVNIX0FMSUdOICAgICAgICAgICAgICAg ICAgICBTWl8yTQo+ID4KPiA+IC0tCj4gPiAyLjQxLjAKPiA+Cj4gCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka2V4ZWMgbWFpbGluZyBsaXN0CmtleGVj QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9rZXhlYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90F8C1D540 for ; Sat, 30 Mar 2024 14:24:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711808659; cv=none; b=eZb75CjANSPydCB47zC7H8dA4yq+ahfrnvPlVqRaq16u/02ERK01DznoaFUmDlR63Nn15aCFAgPMm8AI/kTnc9Dbd6jV1F3ThDwmVgT8vi3YUwZE/tbSlLaldRmbfXkVn9ipdydUg4MO5MDTHfYBDw+f3EciHWiXfwnSDV5CiEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711808659; c=relaxed/simple; bh=RpXyyIUYJRFbE/drwS6Gi5Were0vXBmKDIXy6H9sZWg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=ROmi04TfGmHlOYDFfOoOFGSu+YirryoFOXD8xRshHTL9Qy/RnNWVSRHuMREGb1H2x6owXAvz28cgRuK43HL39BetkcBT0vD21uTy49uaZ9lOdtLeJ85Wh9KFpFHSlMFMfbag5t7HJtUxDvE9hY7jAGmxOp2MfqYAz78D2mFxLKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VhsZYwqk; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VhsZYwqk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711808656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8HbCGyy1GVrVUNL7zlMzVEy/UJRgHTJ0kZQntvsmDig=; b=VhsZYwqkzQsUZyo0OdPkV9zY3G4/tckLsctVOLe+11dbutSY+VEAGT1UCf/dPynUXEeFUs jTJr3mjQVrEQPofanNM+s2/8aJvCT7n9JJ/nY8sMqrZZkToUf3Fp8eBmbbdbqqWWbOqhP2 k/jDl/PBSfV5qpEXuZkAht/E9NLAWLI= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-658-oZ4t53_4MXydy8zt9jpAOA-1; Sat, 30 Mar 2024 10:24:12 -0400 X-MC-Unique: oZ4t53_4MXydy8zt9jpAOA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9EE4638000A5; Sat, 30 Mar 2024 14:24:11 +0000 (UTC) Received: from localhost (unknown [10.72.116.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 468433C20; Sat, 30 Mar 2024 14:24:09 +0000 (UTC) Date: Sat, 30 Mar 2024 22:23:47 +0800 From: Baoquan He To: Huacai Chen Cc: kexec@lists.infradead.org, akpm@linux-foundation.org, geert@linux-m68k.org, WANG Xuerui , loongarch@lists.linux.dev Subject: Re: [PATCH 1/2] arch/loongarch: clean up the left code and Kconfig item related to CRASH_CORE Message-ID: References: <20240329132825.1102459-1-bhe@redhat.com> <20240329132825.1102459-2-bhe@redhat.com> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On 03/30/24 at 09:59pm, Huacai Chen wrote: > Queued, thanks. Thanks, Huacai. While I noticed Andrew has queued this patchset in his mm-unstable branch. > > Huacai > > On Fri, Mar 29, 2024 at 9:28 PM Baoquan He wrote: > > > > In commit 85fcde402db1 ("kexec: split crashkernel reservation code > > out from crash_core.c"), crashkernel reservation code is split out from > > crash_core.c, and add CRASH_RESERVE to control it. And also rename each > > ARCH's to accordingly. > > > > But the relevant part in loongarch is missed. Do it now. > > > > Signed-off-by: Baoquan He > > Cc: Huacai Chen > > Cc: WANG Xuerui > > Cc: loongarch@lists.linux.dev > > --- > > arch/loongarch/Kconfig | 2 +- > > arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} | 4 ++-- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > rename arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} (75%) > > > > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig > > index a5f300ec6f28..54ad04dacdee 100644 > > --- a/arch/loongarch/Kconfig > > +++ b/arch/loongarch/Kconfig > > @@ -595,7 +595,7 @@ config ARCH_SELECTS_CRASH_DUMP > > select RELOCATABLE > > > > config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION > > - def_bool CRASH_CORE > > + def_bool CRASH_RESERVE > > > > config RELOCATABLE > > bool "Relocatable kernel" > > diff --git a/arch/loongarch/include/asm/crash_core.h b/arch/loongarch/include/asm/crash_reserve.h > > similarity index 75% > > rename from arch/loongarch/include/asm/crash_core.h > > rename to arch/loongarch/include/asm/crash_reserve.h > > index 218bdbfa527b..a1d9b84b1c7d 100644 > > --- a/arch/loongarch/include/asm/crash_core.h > > +++ b/arch/loongarch/include/asm/crash_reserve.h > > @@ -1,6 +1,6 @@ > > /* SPDX-License-Identifier: GPL-2.0-only */ > > -#ifndef _LOONGARCH_CRASH_CORE_H > > -#define _LOONGARCH_CRASH_CORE_H > > +#ifndef _LOONGARCH_CRASH_RESERVE_H > > +#define _LOONGARCH_CRASH_RESERVE_H > > > > #define CRASH_ALIGN SZ_2M > > > > -- > > 2.41.0 > > >