From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C76929AF for ; Mon, 1 Apr 2024 07:01:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711954877; cv=none; b=sCvCyKlSqSnrD/o3jmdBtD2ZInfxhDAqin90BR6q2gqSMAn2+/VrSLHYRwexbqG+MHlxitbVR+x24MzfpuVKKSikr9hPhsBEsh63/KnZjw5iA8c+WGi/Ns3BlBaxogQFpC2AMNbwDgl1NPUqnnHnIEhB+KO135SjrQGlcOO/IsE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711954877; c=relaxed/simple; bh=0UxXqbvneBknkvUjHFo+1LfyNPC9qRMw/RiQNbhnucc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P43xRmV8xPCyy/dTZ7SztQrYTMtTa7F+eGjKXX4Mqf5VpvgYP+WXy7i34Cq9NG+bo+flHgOZmN4gsiMNcFs5FixCqMIJcQhMbAbWyBwM08iN7WHqZdyDbZ7w0Cfhfc0oB42ZS8bC5zIxW3PaYSSr0MMryxKLn/A1RUSHsEvmow8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=ch0nKlP2; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="ch0nKlP2" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3bbd6ea06f5so1582829b6e.1 for ; Mon, 01 Apr 2024 00:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1711954873; x=1712559673; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CR3iwkHe4Np8Vng7wVF9RKBPosLNIp8pBnmcewjQ5aU=; b=ch0nKlP2KtJF1bXEHiQ1j4ZH5wVQU5UVNkPMB1GRvvvJ2ql7rXqReqSm5p8v3rAibl NTOwPgM4oENEmcGlorPrxU0uRgSzQWw4kLbZG993IXgRGBDquD5AlNA7myLRKUB+SjI6 lsL3b3ngt8Sp5/sK0E1yfyUFJZ2szfFomTnddyWGjPB9NNOf2oBB/bppYuisdQihxgXk f6Mh8y6A35tJu1Ssj/AHP3Z8n5Be8onu/jxOJgK9O7TJ0mT54GPB9e6FNfMiz6/sHm4T +k24KIigpQudCApo9r1LGVHbe+N7rj9QinsT6zcJs6k59dTe8C0iEES1Ly7ItYDxILTA vCFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711954873; x=1712559673; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CR3iwkHe4Np8Vng7wVF9RKBPosLNIp8pBnmcewjQ5aU=; b=KJ7OzyD3r89lIrALdktwzuj3JMB1Yh2KabFPTvbQq2ZGzLEMWqYXJsoNP0cS7OU23s 3Gsc6a58a2I1fY5SGnG+C62rM9i1JEurRgt8EWw+/Ktt+GlOjFpOwUvwW8MtDPBCW6DS CcpYFo89cIj9uRBY1ywMtMyTcApqDWjka4WEUnkaByqQTtWh+H5ieVL7SMYvJJtdtffU +5EBnIKWICqhF0JDNtgbC02kzyuMMqkMd/H+270eobo4p7eviHq7TTgteeHwS25Hz+6X WLvULCMj1XiiNh0y2Jfa5KRGcw7vqc8vxt6K5CN/ITkZxBwp0V7NZHTKMtz+8IsGfLii R4xw== X-Forwarded-Encrypted: i=1; AJvYcCXvnMg2kZKYrdodDhv0vru1TZSu96uuwmt537c186cqL/2sgKLiZA06uLE8SN6nNTZglJPzbe5hkK6oR/l5MQAJanNknGVqH0+U+bqp X-Gm-Message-State: AOJu0YyOThzEsPX8gXBrAVqW/ZXbFmcvIwN6eMpNsZwzfgH/3jrEGVt1 w2pibIbfUfol19QkwZ/z/r6qUWCdtUKT8Mmzxmc1fk9OXVPIOonZzQbVyEAV7tw= X-Google-Smtp-Source: AGHT+IHNVXbtf4nFi0CjQtWkGz+KO+8YX+Nli7rw8a7TjQYiIWVV4PVHNMdRC2/hIgsRYyvZbdhOXQ== X-Received: by 2002:a05:6808:309c:b0:3c3:c157:5dc7 with SMTP id bl28-20020a056808309c00b003c3c1575dc7mr3557976oib.13.1711954873346; Mon, 01 Apr 2024 00:01:13 -0700 (PDT) Received: from sunil-laptop ([106.51.187.230]) by smtp.gmail.com with ESMTPSA id l7-20020a056808020700b003c4dac3b55dsm1018840oie.3.2024.04.01.00.01.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 00:01:12 -0700 (PDT) Date: Mon, 1 Apr 2024 12:30:56 +0530 From: Sunil V L To: Haibo Xu Cc: xiaobo55x@gmail.com, ajones@ventanamicro.com, Paul Walmsley , Palmer Dabbelt , Albert Ou , "Rafael J. Wysocki" , Len Brown , Robert Moore , Conor Dooley , Guo Ren , Alexandre Ghiti , Greentime Hu , Anup Patel , Zong Li , Sami Tolvanen , Jisheng Zhang , Baoquan He , =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , Greg Kroah-Hartman , Chen Jiahao , Arnd Bergmann , James Morse , Evan Green , Samuel Holland , Tony Luck , Ard Biesheuvel , Yuntao Wang , Dan Williams , Alison Schofield , Dave Hansen , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev Subject: Re: [PATCH v2 4/6] ACPI: NUMA: Make some NUMA related parse functions common Message-ID: References: Precedence: bulk X-Mailing-List: acpica-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Mar 07, 2024 at 04:47:56PM +0800, Haibo Xu wrote: > The acpi_numa_slit_init(), acpi_numa_memory_affinity_init() > and acpi_parse_cfmws() functions are common enough to be used > on platforms that support ACPI_NUMA(x86/arm64/loongarch). > Remove the condition to avoid long defined(CONFIG_ARCH) check > when new platform(riscv) support was enabled. > > Suggested-by: Sunil V L > Signed-off-by: Haibo Xu > --- > drivers/acpi/numa/srat.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > index 1946431c0eef..938c4adb7ec4 100644 > --- a/drivers/acpi/numa/srat.c > +++ b/drivers/acpi/numa/srat.c > @@ -219,7 +219,6 @@ int __init srat_disabled(void) > return acpi_numa < 0; > } > > -#if defined(CONFIG_X86) || defined(CONFIG_ARM64) || defined(CONFIG_LOONGARCH) > /* > * Callback for SLIT parsing. pxm_to_node() returns NUMA_NO_NODE for > * I/O localities since SRAT does not list them. I/O localities are > @@ -351,13 +350,6 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > (*fake_pxm)++; > return 0; > } > -#else > -static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > - void *arg, const unsigned long table_end) > -{ > - return 0; > -} > -#endif /* defined(CONFIG_X86) || defined (CONFIG_ARM64) */ > > static int __init acpi_parse_slit(struct acpi_table_header *table) > { LGTM. Reviewed-by: Sunil V L From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FA91CD128A for ; Mon, 1 Apr 2024 07:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yevA1Z9Sa5D7kTRsDze89ywVeESLWBPce+BXl2tSPkM=; b=uzQgEmyR+W/+UR IiISvk/DCcBEerbYbBqL1yyPgiwiqUNeFNLGg71g4bVkjADNEu2aCaB2asV4FYPyjP8rgE/cBxywC C19OqFrSK582IfGbHmke2p5m5yxTudNZp5m15cM/LCtYo362kyDQodJLIKP4Jba9gzUBhh+0qYTNu C0LJ/RfYaUs0HVcftR2/F1pZwCfnkANSCSfC/dVb/A6VYCFXDL0Dsa68rAt67FWrdFsSVvDcxKBgi wLMDlHzUIq8GG3++ABSmWq9Wxl5NAyWlBOj4hdRvZjHkZLRdqGQEbrsgtRXRvlkqMUrO599XWukvO /zU39A/xx6gxUmDw+UaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrBfR-000000076MH-2T1L; Mon, 01 Apr 2024 07:01:17 +0000 Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrBfO-000000076Lg-3kI7 for linux-riscv@lists.infradead.org; Mon, 01 Apr 2024 07:01:16 +0000 Received: by mail-oi1-x22b.google.com with SMTP id 5614622812f47-3bbd6ea06f5so1582834b6e.1 for ; Mon, 01 Apr 2024 00:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1711954873; x=1712559673; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CR3iwkHe4Np8Vng7wVF9RKBPosLNIp8pBnmcewjQ5aU=; b=h0Q88reSWfhYddglUTXCtEa6/h+W1KUwhbCnU4ISU2OuhCuSUG6/e7ltcS3xbFMyi/ 3w4DXos+yJpq/AVX88PRru2s5knWV8atoaEQeOQ9Z6n8byE+P6+6NfN8hx99t9lHAe9G VIhcdwGWI4BCWxn0Achrt/Lcf+SxGafq7s6mir9eKT1t0zHAKZoEWeMCV+PZiKZVWAVp JUFDY0/5ff2bkixXh0SR0WwqbSmxeANv/ICBpPFahg4OvLWsquXe9RhizrxAEEEVysK0 kbhIApzILpyp7qIrNmCe5M0jG66sItzhfARj2ghiog6CGC4WSoMKd+jtDQ6n+yuM4u8N I+kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711954873; x=1712559673; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CR3iwkHe4Np8Vng7wVF9RKBPosLNIp8pBnmcewjQ5aU=; b=tpUgMJyd09BHImQhigpyykRDy9UpHIGbx2zTTqEKICsTTkKDZHTK+Kxvo0oGUY52Wb Fhe0P0UE7saxqonTIjGho/T8E+7Y+MtX+fXALWsI4wFnWmvhHazcExHTQf2ayNdz73Cg 0IpHai/u1bOy8FqjfK1PCweVwPSa3XsRB3YmLwNgcO1a97yEPCtMx6RThvw9OwKLkL2n xl1SkG6jF8TEFWe9MeV0Z3gkrAOlYhmJSD1zpAtie5/lAwgRI1oTTysiFDU51FD/SYCT HM81K+llt//whHmqC03R39drCGXE5km3UoX5+PCAd/4EIkjqzlUoHpUadVV7U+pdjzQE 9WaQ== X-Forwarded-Encrypted: i=1; AJvYcCVJ5gxM/1z3p4w9iQsq0kDVyPBJaIgcrKuNrllEAG/cKfxujHDl0m6DWAa2A5TFLDpRpSxv7kVrC73BcaF1zcDHbKK4kji8UWQyzh/tslsk X-Gm-Message-State: AOJu0Yz/AiLUP2W5tbtJtLP3LbqC9kOClteW+9B/Ppe7gq4QFsgN4ncL EUPdLRdVUE1NRJWLWAOM0HcQj1GWOTu4BMMUnz310D7/ehV+oF5hS6zpZkzMD+8= X-Google-Smtp-Source: AGHT+IHNVXbtf4nFi0CjQtWkGz+KO+8YX+Nli7rw8a7TjQYiIWVV4PVHNMdRC2/hIgsRYyvZbdhOXQ== X-Received: by 2002:a05:6808:309c:b0:3c3:c157:5dc7 with SMTP id bl28-20020a056808309c00b003c3c1575dc7mr3557976oib.13.1711954873346; Mon, 01 Apr 2024 00:01:13 -0700 (PDT) Received: from sunil-laptop ([106.51.187.230]) by smtp.gmail.com with ESMTPSA id l7-20020a056808020700b003c4dac3b55dsm1018840oie.3.2024.04.01.00.01.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 00:01:12 -0700 (PDT) Date: Mon, 1 Apr 2024 12:30:56 +0530 From: Sunil V L To: Haibo Xu Cc: xiaobo55x@gmail.com, ajones@ventanamicro.com, Paul Walmsley , Palmer Dabbelt , Albert Ou , "Rafael J. Wysocki" , Len Brown , Robert Moore , Conor Dooley , Guo Ren , Alexandre Ghiti , Greentime Hu , Anup Patel , Zong Li , Sami Tolvanen , Jisheng Zhang , Baoquan He , =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , Greg Kroah-Hartman , Chen Jiahao , Arnd Bergmann , James Morse , Evan Green , Samuel Holland , Tony Luck , Ard Biesheuvel , Yuntao Wang , Dan Williams , Alison Schofield , Dave Hansen , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev Subject: Re: [PATCH v2 4/6] ACPI: NUMA: Make some NUMA related parse functions common Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_000115_033689_A6BDDABA X-CRM114-Status: GOOD ( 16.21 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Mar 07, 2024 at 04:47:56PM +0800, Haibo Xu wrote: > The acpi_numa_slit_init(), acpi_numa_memory_affinity_init() > and acpi_parse_cfmws() functions are common enough to be used > on platforms that support ACPI_NUMA(x86/arm64/loongarch). > Remove the condition to avoid long defined(CONFIG_ARCH) check > when new platform(riscv) support was enabled. > > Suggested-by: Sunil V L > Signed-off-by: Haibo Xu > --- > drivers/acpi/numa/srat.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > index 1946431c0eef..938c4adb7ec4 100644 > --- a/drivers/acpi/numa/srat.c > +++ b/drivers/acpi/numa/srat.c > @@ -219,7 +219,6 @@ int __init srat_disabled(void) > return acpi_numa < 0; > } > > -#if defined(CONFIG_X86) || defined(CONFIG_ARM64) || defined(CONFIG_LOONGARCH) > /* > * Callback for SLIT parsing. pxm_to_node() returns NUMA_NO_NODE for > * I/O localities since SRAT does not list them. I/O localities are > @@ -351,13 +350,6 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > (*fake_pxm)++; > return 0; > } > -#else > -static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > - void *arg, const unsigned long table_end) > -{ > - return 0; > -} > -#endif /* defined(CONFIG_X86) || defined (CONFIG_ARM64) */ > > static int __init acpi_parse_slit(struct acpi_table_header *table) > { LGTM. Reviewed-by: Sunil V L _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv