From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6E75384039 for ; Tue, 2 Apr 2024 14:12:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712067131; cv=none; b=N0YIKZ8DghqKfwsmFfsafLdrveWTA497EuvQkcV5rLjLCqwtZCnmf1BKEaq4arQ1dGs+Z39OF3OeGX1tjwuw3I8w0swYwT0qDnK9x3cGTm4dm97fImz1RkSP11tRDRjnRK4MI+FTtXEYMjC26yS3RZvtE9AGteRgnH2Ch7u8RNg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712067131; c=relaxed/simple; bh=sBOdmheLZ2gGf5kKDBuAKPcg2oBCHcIwa/Kgod/gHsM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oB9iZ/Qmn1MBjFyOB5xPSAlc/nW5vPnwDntfsPpPp9EEUcJHfe9NaT3ViWJ/ibA71WClVfAsz9TMvF8CuyUeIMN+X/igl08pJxxf6ziNevovgqb6wiwDRu593yWAZfehDXKMQie+4nQF/20EPLKoyDkUy4F1LjCeIKP1IKChmI4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 75B9A2F4; Tue, 2 Apr 2024 07:12:40 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E93503F64C; Tue, 2 Apr 2024 07:12:06 -0700 (PDT) Date: Tue, 2 Apr 2024 15:12:04 +0100 From: Sudeep Holla To: "Mediouni, Mohamed" Cc: David Woodhouse , "linux-arm-kernel@lists.infradead.org" , Catalin Marinas , Sudeep Holla , Will Deacon , Robert Moore , "Rafael J. Wysocki" , Len Brown , "Saidi, Ali" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "acpica-devel@lists.linux.dev" , Saket Dumbre Subject: Re: [PATCH 2/2] arm64: acpi: Honour firmware_signature field of FACS, if it exists Message-ID: References: <20240312134148.727454-1-dwmw2@infradead.org> <20240312134148.727454-2-dwmw2@infradead.org> <70B4B352-08A5-4922-93A0-7F420374A831@amazon.de> Precedence: bulk X-Mailing-List: acpica-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <70B4B352-08A5-4922-93A0-7F420374A831@amazon.de> On Tue, Apr 02, 2024 at 12:17:22PM +0000, Mediouni, Mohamed wrote: > > > On 2. Apr 2024, at 12:29, Sudeep Holla wrote: > > > > I think it is OK as a temporary solution for now. But there was some > > investigation last year as part of some work in Linaro to enable > > "drivers/acpi/sleep.c" into the build cleaning up some x86-ness in there. > > acpi_sleep_hibernate_setup() already does this but enabling sleep.c need > > some careful investigation so that it doesn't break any existing arm64/x86 > > platforms and made need some wordings clarification in the ACPI spec. > > Today system suspend work via psci std path bypassing the ACPI paths which > > may not be ideal as none of the ACPI methods are honoured. Some arm64 > > platforms may implement them and expect to be executed in the future, > > maybe ? > Current Windows on Arm platforms (seen on SC8280XP) don’t have _GTS > or _PTS methods, and don’t have sleeping objects either. > IMO, SC8280XP is not a very good model platform for ACPI firmware reference. It uses PEP which Linux doesn't support for good reason and that make it hard to follow everything on that platform. > As such, I don’t expect any users for that potential functionality. I am not 100% sure > Am I missing something or hibernation signalling to firmware (on ARM64) > can be made PSCI only indefinitely? Also bypassing certain operation taken care in sleep.c might result in missing certain features. Few things IIRC(might be missing things myself or misunderstood as it has been a while since I looked at the code in detail): handing of GPE for wakeup, power resource handling during the resume, power button event to mention few. -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAAE9C6FD1F for ; Tue, 2 Apr 2024 14:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9pve3y2hMTCoQP7CFgJ5e4gyufXavM5PGe32BjIqw6M=; b=MglbgU6OyaJjvO 5qniYBpaX69+FpgrJX7PDoBD7gJU3XLaDb/XIcRYpjMYKts2FYWOIBrtOqXBR++uuLcnc5NxUDY4O 3r7ENLuF1JEf6DzKuRAqgQPYp/GcFGIMa6ssadsgRF6M7i9DL26QMAdWkV3FmXYI5LqPjetcOq0cd 2AcWyjtxXcws4NCIJ/pkzZEltTr+fB+yfA/KM/VgKS1UQds1GvZ8lQEYS0M3EIAynl3RlmcEt7V7N fMTfGX6x9wpeIajTbYWl9hAK3yb4GNllAuzAitryR6aXkFCRwOc/HFGgDnihqRnu1hU2aSz4wzMdc 18ZYwC0JBEq7Q0QHtF7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rres1-0000000BWlS-04yK; Tue, 02 Apr 2024 14:12:13 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrery-0000000BWkb-0FOV for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2024 14:12:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 75B9A2F4; Tue, 2 Apr 2024 07:12:40 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E93503F64C; Tue, 2 Apr 2024 07:12:06 -0700 (PDT) Date: Tue, 2 Apr 2024 15:12:04 +0100 From: Sudeep Holla To: "Mediouni, Mohamed" Cc: David Woodhouse , "linux-arm-kernel@lists.infradead.org" , Catalin Marinas , Sudeep Holla , Will Deacon , Robert Moore , "Rafael J. Wysocki" , Len Brown , "Saidi, Ali" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "acpica-devel@lists.linux.dev" , Saket Dumbre Subject: Re: [PATCH 2/2] arm64: acpi: Honour firmware_signature field of FACS, if it exists Message-ID: References: <20240312134148.727454-1-dwmw2@infradead.org> <20240312134148.727454-2-dwmw2@infradead.org> <70B4B352-08A5-4922-93A0-7F420374A831@amazon.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <70B4B352-08A5-4922-93A0-7F420374A831@amazon.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_071210_212169_549FE529 X-CRM114-Status: GOOD ( 20.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBcHIgMDIsIDIwMjQgYXQgMTI6MTc6MjJQTSArMDAwMCwgTWVkaW91bmksIE1vaGFt ZWQgd3JvdGU6Cj4gCj4gPiBPbiAyLiBBcHIgMjAyNCwgYXQgMTI6MjksIFN1ZGVlcCBIb2xsYSA8 c3VkZWVwLmhvbGxhQGFybS5jb20+IHdyb3RlOgo+ID4gCj4gPiBJIHRoaW5rIGl0IGlzIE9LIGFz IGEgdGVtcG9yYXJ5IHNvbHV0aW9uIGZvciBub3cuIEJ1dCB0aGVyZSB3YXMgc29tZQo+ID4gaW52 ZXN0aWdhdGlvbiBsYXN0IHllYXIgYXMgcGFydCBvZiBzb21lIHdvcmsgaW4gTGluYXJvIHRvIGVu YWJsZQo+ID4gImRyaXZlcnMvYWNwaS9zbGVlcC5jIiBpbnRvIHRoZSBidWlsZCBjbGVhbmluZyB1 cCBzb21lIHg4Ni1uZXNzIGluIHRoZXJlLgo+ID4gYWNwaV9zbGVlcF9oaWJlcm5hdGVfc2V0dXAo KSBhbHJlYWR5IGRvZXMgdGhpcyBidXQgZW5hYmxpbmcgc2xlZXAuYyBuZWVkCj4gPiBzb21lIGNh cmVmdWwgaW52ZXN0aWdhdGlvbiBzbyB0aGF0IGl0IGRvZXNuJ3QgYnJlYWsgYW55IGV4aXN0aW5n IGFybTY0L3g4Ngo+ID4gcGxhdGZvcm1zIGFuZCBtYWRlIG5lZWQgc29tZSB3b3JkaW5ncyBjbGFy aWZpY2F0aW9uIGluIHRoZSBBQ1BJIHNwZWMuCj4gPiBUb2RheSBzeXN0ZW0gc3VzcGVuZCB3b3Jr IHZpYSBwc2NpIHN0ZCBwYXRoIGJ5cGFzc2luZyB0aGUgQUNQSSBwYXRocyB3aGljaAo+ID4gbWF5 IG5vdCBiZSBpZGVhbCBhcyBub25lIG9mIHRoZSBBQ1BJIG1ldGhvZHMgYXJlIGhvbm91cmVkLiBT b21lIGFybTY0Cj4gPiBwbGF0Zm9ybXMgbWF5IGltcGxlbWVudCB0aGVtIGFuZCBleHBlY3QgdG8g YmUgZXhlY3V0ZWQgaW4gdGhlIGZ1dHVyZSwKPiA+IG1heWJlID8KPiBDdXJyZW50IFdpbmRvd3Mg b24gQXJtIHBsYXRmb3JtcyAoc2VlbiBvbiBTQzgyODBYUCkgZG9u4oCZdCBoYXZlIF9HVFMKPiBv ciBfUFRTIG1ldGhvZHMsIGFuZCBkb27igJl0IGhhdmUgc2xlZXBpbmcgb2JqZWN0cyBlaXRoZXIu Cj4KCklNTywgU0M4MjgwWFAgaXMgbm90IGEgdmVyeSBnb29kIG1vZGVsIHBsYXRmb3JtIGZvciBB Q1BJIGZpcm13YXJlIHJlZmVyZW5jZS4KSXQgdXNlcyBQRVAgd2hpY2ggTGludXggZG9lc24ndCBz dXBwb3J0IGZvciBnb29kIHJlYXNvbiBhbmQgdGhhdCBtYWtlIGl0CmhhcmQgdG8gZm9sbG93IGV2 ZXJ5dGhpbmcgb24gdGhhdCBwbGF0Zm9ybS4KCj4gQXMgc3VjaCwgSSBkb27igJl0IGV4cGVjdCBh bnkgdXNlcnMgZm9yIHRoYXQgcG90ZW50aWFsIGZ1bmN0aW9uYWxpdHkuCgpJIGFtIG5vdCAxMDAl IHN1cmUKCj4gQW0gSSBtaXNzaW5nIHNvbWV0aGluZyBvciBoaWJlcm5hdGlvbiBzaWduYWxsaW5n IHRvIGZpcm13YXJlIChvbiBBUk02NCkKPiBjYW4gYmUgbWFkZSBQU0NJIG9ubHkgaW5kZWZpbml0 ZWx5PwoKQWxzbyBieXBhc3NpbmcgY2VydGFpbiBvcGVyYXRpb24gdGFrZW4gY2FyZSBpbiBzbGVl cC5jIG1pZ2h0IHJlc3VsdCBpbgptaXNzaW5nIGNlcnRhaW4gZmVhdHVyZXMuIEZldyB0aGluZ3Mg SUlSQyhtaWdodCBiZSBtaXNzaW5nIHRoaW5ncyBteXNlbGYKb3IgbWlzdW5kZXJzdG9vZCBhcyBp dCBoYXMgYmVlbiBhIHdoaWxlIHNpbmNlIEkgbG9va2VkIGF0IHRoZSBjb2RlIGluCmRldGFpbCk6 IGhhbmRpbmcgb2YgR1BFIGZvciB3YWtldXAsIHBvd2VyIHJlc291cmNlIGhhbmRsaW5nIGR1cmlu ZyB0aGUKcmVzdW1lLCBwb3dlciBidXR0b24gZXZlbnQgdG8gbWVudGlvbiBmZXcuCgotLQpSZWdh cmRzLApTdWRlZXAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK