All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Guillaume William Brs <guillaume.bressaix@gmail.com>,
	Norbert Lange <nolange79@gmail.com>,
	Sen Hastings <sen@hastings.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/systemd: fix build with glibc 2.39
Date: Tue, 2 Apr 2024 23:28:26 +0200	[thread overview]
Message-ID: <Zgx4emXI7NgZPSBI@landeda> (raw)
In-Reply-To: <20240401234013.3570820-2-james.hilliard1@gmail.com>

James, All,

On 2024-04-01 17:40 -0600, James Hilliard spake thusly:
> When glibc was bumped to version 2.39 in commit
> b5680f53d60acf8ff6010082f873438a39bd5d97 it removed the deprecated
> libcrypt support.
> 
> As glibc's libcrypt was providing systemd's libcrypt dependency this
> broke any systemd build using glibc version 2.39.
> 
> To fix this add the libxcrypt dependency to systemd which is the
> preferred way of providing libcrypt support in systemd as the glibc
> variant is only used as a fallback due to being deprecated.
> 
> We should also have host-systemd depend on host-libxcrypt in case
> the host system does not provide glibc with libcrypt support.
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/36e/36efcfc76c015c9b4c955c13afa0f81a98b529f4
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/systemd/Config.in  | 1 +
>  package/systemd/systemd.mk | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/package/systemd/Config.in b/package/systemd/Config.in
> index aa5143d484..a94e9b73b8 100644
> --- a/package/systemd/Config.in
> +++ b/package/systemd/Config.in
> @@ -28,6 +28,7 @@ menuconfig BR2_PACKAGE_SYSTEMD
>  	select BR2_PACKAGE_HAS_UDEV
>  	select BR2_PACKAGE_DBUS if !BR2_PACKAGE_DBUS_BROKER # runtime
>  	select BR2_PACKAGE_LIBCAP
> +	select BR2_PACKAGE_LIBXCRYPT
>  	select BR2_PACKAGE_UTIL_LINUX
>  	select BR2_PACKAGE_UTIL_LINUX_LIBS
>  	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index c6b006d1fb..8987dc19a6 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -55,6 +55,7 @@ SYSTEMD_DEPENDENCIES = \
>  	host-python-jinja2 \
>  	kmod \
>  	libcap \
> +	libxcrypt \
>  	util-linux-libs \
>  	$(TARGET_NLS_DEPENDENCIES)
>  
> @@ -882,6 +883,7 @@ HOST_SYSTEMD_DEPENDENCIES = \
>  	host-util-linux \
>  	host-patchelf \
>  	host-libcap \
> +	host-libxcrypt \
>  	host-gperf \
>  	host-python-jinja2
>  
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-04-02 21:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-01 23:40 [Buildroot] [PATCH 1/2] package/libxcrypt: support host package build James Hilliard
2024-04-01 23:40 ` [Buildroot] [PATCH 2/2] package/systemd: fix build with glibc 2.39 James Hilliard
2024-04-02 21:28   ` Yann E. MORIN [this message]
2024-04-02 21:28 ` [Buildroot] [PATCH 1/2] package/libxcrypt: support host package build Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zgx4emXI7NgZPSBI@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=guillaume.bressaix@gmail.com \
    --cc=james.hilliard1@gmail.com \
    --cc=nolange79@gmail.com \
    --cc=sen@hastings.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.