From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D102ECD1284 for ; Tue, 2 Apr 2024 17:58:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2TLwnAftF/L+PYJku1Irzf/x6nrSzag0YPvML+Z5Adw=; b=cWPoe0SWxpJm5l +sJKlkxswrvkbdRnYvLHAQr/nHJaOIkZVe0Jy/e7VlwRzuwHIHq+/QUVCmwAdDgiI2PocugvqphhI nduycNIk8gtAg4gBysyP/mIU5pDTtbcpoek2ZW2LpI1X2ZcNzX8r0mDksCEXBy2heLaypLkZbzhT+ I6/iEvGsfB6wxxUlJo/2dUiV9gHGNfHBgVNS3IXd71tR/zlUwBk7SQALJGF6FukN5+eOv8ukapRMh QWXocaAAU02NY6lx5ZXtBFoWZCj9RIYjsJM81RwjNH+j/HfeHccY7etgpSP6WVqunc7vEJe+4D/r/ Rsx4jUC4xZWiAIKrwC4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rriP1-0000000CHLC-2U93; Tue, 02 Apr 2024 17:58:31 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rriOv-0000000CHIT-0fmz for linux-riscv@lists.infradead.org; Tue, 02 Apr 2024 17:58:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712080702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QbOtfO/Dg9m2AlUnDgJHatWmb8CbT3I2rXBSbFfhdJY=; b=UhTNg/XPtc7hgQsz8u4FV1NdMiuxMAnM/F9vzyvMFTahGOWlBYPy2RK1YiDt3E5/r5wvnx uU4FBhVU+oM39GSFc9thnjr/lEqz+8k4yBd1NE3QsNCPsH8/vBJJZG0dctaC/Vo6VdOKE9 8Okvzgp112eqIkOqRtmGjrOA+QgL/eA= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-260-7JmcFivYP9mFGsZlVfiU8g-1; Tue, 02 Apr 2024 13:58:18 -0400 X-MC-Unique: 7JmcFivYP9mFGsZlVfiU8g-1 Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-7e33b4df4ddso367777241.1 for ; Tue, 02 Apr 2024 10:58:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712080698; x=1712685498; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QbOtfO/Dg9m2AlUnDgJHatWmb8CbT3I2rXBSbFfhdJY=; b=JMrkOvfDuDRia2M/8irqczi8xQXf5ajdHPu3jfAe+dY4mDkjrLoOo5ptc8wpK4X8xR 9Ba+4xch0DYg+pDMR7ZQknwoI3hn7Cbcly234U72kp/XsA4ZzeDlyMqiIWX8aFrjdXbw Sz4btg/Nv11+HytOB58GnZKOpXC/apH7BllRtd0s3foyUTRIzmCEq92Khv7UrvY+Me2e Qg78K1QMVqm909YAwZfh7gupYa5bP/SmXsCvPY/euY6EFVyoX4/goGpVSTzjHZW8rkcR rR9hZdyW89C5Jq7oAGVBitQxRtVvaKeSq41P+mTmJjtJdAMGv37UE0yCxhUC7iMbfytw J3yQ== X-Forwarded-Encrypted: i=1; AJvYcCXVwLRQucpn9txCbBc/ytxT1F487kPFbUAvJsCeEbIDfAjro3jauxX8M1xNdl9v6pKasTSHyFT34r9uUxq5GWntx13XmAyRABKr1GRCrZJI X-Gm-Message-State: AOJu0Yz3PmNAdX8gjQmlVRkCcLrA2yXorUgFyWjEK3ZUhq17X4DZqVUm pTnSajpRH/bGjK8jxcC7/As8aO57TJQlN1KQXL0spajJkKXUvSyQi+O3azUxqfeWM05JshT61B9 4Fry+v4hj12nm7PnpNzzJU9lRKOJWXC5Rupl6ls9MvvxPk0SoQLr9rknxSNI1fXH8/A== X-Received: by 2002:a05:6102:93:b0:476:e72e:94ef with SMTP id t19-20020a056102009300b00476e72e94efmr9650810vsp.3.1712080697552; Tue, 02 Apr 2024 10:58:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8b3uQ69B5cqo+ud6RtEbqNi2TEDMHUU32VESs2Pw1E24CP/zf32LkrpOQk6Mcp1ToEoA3Uw== X-Received: by 2002:a05:6102:93:b0:476:e72e:94ef with SMTP id t19-20020a056102009300b00476e72e94efmr9650757vsp.3.1712080696946; Tue, 02 Apr 2024 10:58:16 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id kk15-20020a056214508f00b00696a78b9cc6sm5720428qvb.53.2024.04.02.10.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 10:58:16 -0700 (PDT) Date: Tue, 2 Apr 2024 13:58:12 -0400 From: Peter Xu To: Ryan Roberts Cc: David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi , "Kirill A . Shutemov" , Mike Kravetz , John Hubbard , Michael Ellerman , Andrew Jones , Muchun Song , linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox , Rik van Riel , linux-arm-kernel@lists.infradead.org, Andrea Arcangeli , "Aneesh Kumar K . V" , Vlastimil Babka , James Houghton , Jason Gunthorpe , Mike Rapoport , Axel Rasmussen Subject: Re: [PATCH v4 13/13] mm/gup: Handle hugetlb in the generic follow_page_mask code Message-ID: References: <20240327152332.950956-1-peterx@redhat.com> <20240327152332.950956-14-peterx@redhat.com> <5d9dd9a7-e544-4741-944c-469b79c2c649@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_105828_868726_D39DBBD8 X-CRM114-Status: GOOD ( 10.12 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Apr 02, 2024 at 05:46:57PM +0100, Ryan Roberts wrote: > I'll leave you to do the testing on this, if that's ok. Definitely. I'll test and send formal patches. > > Just to make my config explicit, I have this kernel command line, which reserves > hugetlbs of all sizes for the tests: > > "transparent_hugepage=madvise earlycon root=/dev/vda2 secretmem.enable > hugepagesz=1G hugepages=0:2,1:2 hugepagesz=32M hugepages=0:2,1:2 > default_hugepagesz=2M hugepages=0:64,1:64 hugepagesz=64K hugepages=0:2,1:2" This helps, thanks. -- Peter Xu _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2665CD1284 for ; Tue, 2 Apr 2024 17:59:10 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UhTNg/XP; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UhTNg/XP; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4V8Fxn4CQpz3vZn for ; Wed, 3 Apr 2024 04:59:09 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UhTNg/XP; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UhTNg/XP; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=peterx@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4V8Fwx0Tdrz3020 for ; Wed, 3 Apr 2024 04:58:24 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712080702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QbOtfO/Dg9m2AlUnDgJHatWmb8CbT3I2rXBSbFfhdJY=; b=UhTNg/XPtc7hgQsz8u4FV1NdMiuxMAnM/F9vzyvMFTahGOWlBYPy2RK1YiDt3E5/r5wvnx uU4FBhVU+oM39GSFc9thnjr/lEqz+8k4yBd1NE3QsNCPsH8/vBJJZG0dctaC/Vo6VdOKE9 8Okvzgp112eqIkOqRtmGjrOA+QgL/eA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712080702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QbOtfO/Dg9m2AlUnDgJHatWmb8CbT3I2rXBSbFfhdJY=; b=UhTNg/XPtc7hgQsz8u4FV1NdMiuxMAnM/F9vzyvMFTahGOWlBYPy2RK1YiDt3E5/r5wvnx uU4FBhVU+oM39GSFc9thnjr/lEqz+8k4yBd1NE3QsNCPsH8/vBJJZG0dctaC/Vo6VdOKE9 8Okvzgp112eqIkOqRtmGjrOA+QgL/eA= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-noXfWabtPrm0WYPjghiO5w-1; Tue, 02 Apr 2024 13:58:18 -0400 X-MC-Unique: noXfWabtPrm0WYPjghiO5w-1 Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-7e33b4df4ddso367781241.1 for ; Tue, 02 Apr 2024 10:58:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712080698; x=1712685498; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QbOtfO/Dg9m2AlUnDgJHatWmb8CbT3I2rXBSbFfhdJY=; b=Wbk9MJBCqftBWY67Q456ykrFFzoQVOHqDuwFRadMa8G+6riAYzTtUm9QZqlmWJBjnX bWTGpy/VtAz6jyu+RQFRYfHLLc5Pc/P+f7vJEF++oaFCTygsJIdsNbcpSwi+Rw8QRIdv pcXkmnZrUdv9kyTlGaxdbVrRp+9mM6DgOnoJbxn1KSG9P4gaA4d3IHca8mH7pgzjrBt6 Xblicgq+TfGV3TRvFuG/FLCPth+/PJRexsDigMogYTNIl9sWYNeBBYA0IEk2WFK4lQNo 70gpFWsIKrSTmsTD0x+THH81NY4h2woU/UKAJYZENmqY8KX844Y1hAUXa/wXFZ1RzyAQ /gdw== X-Forwarded-Encrypted: i=1; AJvYcCXzfIsk7oI/NW9woQwrLw3rWNFCxk0U2o/93ZDhcEnodvPteprzcj0WqHvJuPFnAZP6AG2cM4Ck7/1UvAfQEdE5eMmcMh0siVHbcdUFNA== X-Gm-Message-State: AOJu0YzgbzrZrUAUmtdM/Nn9e8MhklhKLHRhnXZkwxR1Vnqj7DgwfiJ0 VeCsmdqps1yWV4EM+pk705UER6Rk8Ko39dA7qQ8PGZT0Y3VujNsUtXy+EQgSTyuWmSJpDzoW9Ze xcklBAF0IY7IsZ7bhxaDdxnr1uJREzRyYbF8vj49cxcr8AAzgfDaPqSrDQbtzpGM= X-Received: by 2002:a05:6102:93:b0:476:e72e:94ef with SMTP id t19-20020a056102009300b00476e72e94efmr9650805vsp.3.1712080697551; Tue, 02 Apr 2024 10:58:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8b3uQ69B5cqo+ud6RtEbqNi2TEDMHUU32VESs2Pw1E24CP/zf32LkrpOQk6Mcp1ToEoA3Uw== X-Received: by 2002:a05:6102:93:b0:476:e72e:94ef with SMTP id t19-20020a056102009300b00476e72e94efmr9650757vsp.3.1712080696946; Tue, 02 Apr 2024 10:58:16 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id kk15-20020a056214508f00b00696a78b9cc6sm5720428qvb.53.2024.04.02.10.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 10:58:16 -0700 (PDT) Date: Tue, 2 Apr 2024 13:58:12 -0400 From: Peter Xu To: Ryan Roberts Subject: Re: [PATCH v4 13/13] mm/gup: Handle hugetlb in the generic follow_page_mask code Message-ID: References: <20240327152332.950956-1-peterx@redhat.com> <20240327152332.950956-14-peterx@redhat.com> <5d9dd9a7-e544-4741-944c-469b79c2c649@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Houghton , David Hildenbrand , Yang Shi , Andrew Jones , linux-mm@kvack.org, Matthew Wilcox , linux-riscv@lists.infradead.org, Andrea Arcangeli , "Aneesh Kumar K . V" , Christoph Hellwig , Vlastimil Babka , Jason Gunthorpe , Axel Rasmussen , Rik van Riel , John Hubbard , "Kirill A . Shutemov" , linux-arm-kernel@lists.infradead.org, Lorenzo Stoakes , Muchun Song , linux-kernel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, Mike Rapoport , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Apr 02, 2024 at 05:46:57PM +0100, Ryan Roberts wrote: > I'll leave you to do the testing on this, if that's ok. Definitely. I'll test and send formal patches. > > Just to make my config explicit, I have this kernel command line, which reserves > hugetlbs of all sizes for the tests: > > "transparent_hugepage=madvise earlycon root=/dev/vda2 secretmem.enable > hugepagesz=1G hugepages=0:2,1:2 hugepagesz=32M hugepages=0:2,1:2 > default_hugepagesz=2M hugepages=0:64,1:64 hugepagesz=64K hugepages=0:2,1:2" This helps, thanks. -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D79F0CD1284 for ; Tue, 2 Apr 2024 17:58:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VH7fo9J1LHzE94z3T25Lj/EYasReUlPut9nDCYT2iTk=; b=jzncL5tnkBFIiC cz/G3l1VoS4GgQiqKpnKmTCO77e+Oft/x34qYgZOk70r3YLeyYvqLt5unrrBDwBMbXmYebLOm56gN VM+nw/k9VRiAhrn49ExiPke5lNv/nKoMNYF4ljWWSFFGcpYhvP1sC6QzdOvxixVZzzx50u7laXqQL UzeIpLOqzXeyu1FYQLzFiJLqd/TK0pWP9Ysin+K39hg/KdjpsHDUM1vMFCxUUUoGBCGEblt6SfGGq PxP/8ZHwomTwJSnlEuWg3QGK8dcIsqfr7yV5l3N04gorFTDkQdgdLqum8ih576QqK8WpYlFj+ziR3 2uVNhR9juqdciVL0eYJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rriP3-0000000CHMH-1vc0; Tue, 02 Apr 2024 17:58:33 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rriOv-0000000CHIa-1iNa for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2024 17:58:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712080704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QbOtfO/Dg9m2AlUnDgJHatWmb8CbT3I2rXBSbFfhdJY=; b=QAPoLihPD9/A1sgXXexAFUvIAVz6QCP7r1ZoeSC/qU8O7T2bThUhoKGjOLnOe447qRII2F KM0XRp0DheBbww7JPR5NpO+/tz9pS+8LwvBuxEiTTM6vPxt1gMYjYdnG8ZskVElwJ98f1U XnuUgx1T7f/NK+WWG/thzxxd9HbDt1s= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-47coWHttO56ProjtQTB_vw-1; Tue, 02 Apr 2024 13:58:18 -0400 X-MC-Unique: 47coWHttO56ProjtQTB_vw-1 Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-7e3492f5c52so353759241.0 for ; Tue, 02 Apr 2024 10:58:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712080698; x=1712685498; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QbOtfO/Dg9m2AlUnDgJHatWmb8CbT3I2rXBSbFfhdJY=; b=T0vtW6JA2h28hqizcH7i1pj8kZBdArOLbE0dD95qbHvKEIhf1jpoDrfT9yRfY3DN0z nO737pTpJlJ7TnYSKqYygpOfrEszW7F8C2BWpdekv74JJYFrxhBe1iBN3mO0rfYWiPkW 8BlmBAeFzNmUkYfMFocm51fG0Ic2IoSUk5IkV0me/EaYw9deO6T9m3X/QECs0TBNowFS 86bJZMCLVixqcwTpzUvrEjDM4tAIt8fLxKOwux7aUt3ScaCh5KNJcc+O8TTp+Dtg7cJI n0EIs8B+ISslqNp76GqZECPfNLLB8KTdgTHTjg6S4Zgp7D2Og/2aLNI+95F8ngiro/kb uLKA== X-Forwarded-Encrypted: i=1; AJvYcCUiAcFg5b7RzIQFHaOENAivPZdSWcWOR9wg99HfA20U7rE2Ypq8uU7HaPeJVUpKSZJ79o/ogO+HLA6FoJDUxnsvPJWucTKXPUSTTbMnLPvfRWSCyAc= X-Gm-Message-State: AOJu0YxmRlThziXycSxMLqRP+5g6zjaet347M6s2VyIMheZ1q7kwaSQ0 LyuHHua5tjouYbwOIOigx37HW+PNJwHRa18WBreh5fJr5SLsHU/fDvTFzIMmt8o9d7SDswGHM7K VtntPLaW6eXpRvCZR8+nvJrMmPCDso43WiX0NG7mst3W4wjnvdNGQTknfmvmw/opZmT4ami6B X-Received: by 2002:a05:6102:93:b0:476:e72e:94ef with SMTP id t19-20020a056102009300b00476e72e94efmr9650796vsp.3.1712080697549; Tue, 02 Apr 2024 10:58:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8b3uQ69B5cqo+ud6RtEbqNi2TEDMHUU32VESs2Pw1E24CP/zf32LkrpOQk6Mcp1ToEoA3Uw== X-Received: by 2002:a05:6102:93:b0:476:e72e:94ef with SMTP id t19-20020a056102009300b00476e72e94efmr9650757vsp.3.1712080696946; Tue, 02 Apr 2024 10:58:16 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id kk15-20020a056214508f00b00696a78b9cc6sm5720428qvb.53.2024.04.02.10.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 10:58:16 -0700 (PDT) Date: Tue, 2 Apr 2024 13:58:12 -0400 From: Peter Xu To: Ryan Roberts Cc: David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi , "Kirill A . Shutemov" , Mike Kravetz , John Hubbard , Michael Ellerman , Andrew Jones , Muchun Song , linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox , Rik van Riel , linux-arm-kernel@lists.infradead.org, Andrea Arcangeli , "Aneesh Kumar K . V" , Vlastimil Babka , James Houghton , Jason Gunthorpe , Mike Rapoport , Axel Rasmussen Subject: Re: [PATCH v4 13/13] mm/gup: Handle hugetlb in the generic follow_page_mask code Message-ID: References: <20240327152332.950956-1-peterx@redhat.com> <20240327152332.950956-14-peterx@redhat.com> <5d9dd9a7-e544-4741-944c-469b79c2c649@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_105828_893275_490E5309 X-CRM114-Status: GOOD ( 11.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 02, 2024 at 05:46:57PM +0100, Ryan Roberts wrote: > I'll leave you to do the testing on this, if that's ok. Definitely. I'll test and send formal patches. > > Just to make my config explicit, I have this kernel command line, which reserves > hugetlbs of all sizes for the tests: > > "transparent_hugepage=madvise earlycon root=/dev/vda2 secretmem.enable > hugepagesz=1G hugepages=0:2,1:2 hugepagesz=32M hugepages=0:2,1:2 > default_hugepagesz=2M hugepages=0:64,1:64 hugepagesz=64K hugepages=0:2,1:2" This helps, thanks. -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EAEFCD1284 for ; Tue, 2 Apr 2024 17:58:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C52F76B0085; Tue, 2 Apr 2024 13:58:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDBC16B0088; Tue, 2 Apr 2024 13:58:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2EEF6B0089; Tue, 2 Apr 2024 13:58:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 829756B0085 for ; Tue, 2 Apr 2024 13:58:25 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 035514023A for ; Tue, 2 Apr 2024 17:58:24 +0000 (UTC) X-FDA: 81965351370.15.5874B55 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id DE8E61C000A for ; Tue, 2 Apr 2024 17:58:22 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="UhTNg/XP"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712080702; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QbOtfO/Dg9m2AlUnDgJHatWmb8CbT3I2rXBSbFfhdJY=; b=wbe/6Pu69xPsQopAE1FGNCnLMkONwgLuEtE7qCXRr1KGmdpkYPT+xNmJFM56dS+8k85AOF mfDq0PrFUBhbCJCtYwAlJU9b3bg/K4K5s+lb8EwPrqNUv6Nzbh4EEW5qa5KslmwRDycsOi 9cDG4jHfA3gT8JkoPP2QnDOzpPcwFoU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="UhTNg/XP"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712080702; a=rsa-sha256; cv=none; b=UZatemiPFoPOQ8qVjE4qpfrAcQVmzrdltaniE0fTU0kc6acupzAyGhvSThciuadC65jzkK haI6znpQEnkhNSMHHotNOGfuw3GSk1+BeYjI6a7KahrcrjUEFTkHt4rfCndoUJYhEKM0uw nH5CF97Q0B2CePtOVovFnf7fY26hDvA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712080702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QbOtfO/Dg9m2AlUnDgJHatWmb8CbT3I2rXBSbFfhdJY=; b=UhTNg/XPtc7hgQsz8u4FV1NdMiuxMAnM/F9vzyvMFTahGOWlBYPy2RK1YiDt3E5/r5wvnx uU4FBhVU+oM39GSFc9thnjr/lEqz+8k4yBd1NE3QsNCPsH8/vBJJZG0dctaC/Vo6VdOKE9 8Okvzgp112eqIkOqRtmGjrOA+QgL/eA= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-js-atlNjM1m_snDVivDkcg-1; Tue, 02 Apr 2024 13:58:18 -0400 X-MC-Unique: js-atlNjM1m_snDVivDkcg-1 Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-7e33b4df4ddso367783241.1 for ; Tue, 02 Apr 2024 10:58:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712080698; x=1712685498; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QbOtfO/Dg9m2AlUnDgJHatWmb8CbT3I2rXBSbFfhdJY=; b=YFvLvpmmzvmGJAbV/pf27oD4cXL1Oqk6cIk5fVbrUdx1AiZvHIeP6sEoWFBur1m2J5 zi2fwuvoxsDoClYWZyenuGxJPYZWoxxajGF3kV1DJvABH3ovw48uDtUOnEGIuUhhljgv PspZvFZEnQMPjbWxMUh4kIC0TQscRQZ7oVhTF0BtkyYQgmMYKyafSRNl4l3EuPQ70Qnb p+BSVddwTq7uoJ1trjRv/QugS3AoUPFh3dmtZt2MIkBNacG7HLNuvXBTJ75Yx3ixOcC7 3UWrtDyc3qisEriodDqTmwOqn4R63s+uJqOdCVVFwE9lgs2zFPE8aafNR9S9hcCRnfq+ 0zaw== X-Forwarded-Encrypted: i=1; AJvYcCXcEOE0XlF0TkhV/M3ndHbmv8Ncv6FL8LuS1attR7F+lIc5jYhltm1S2ZTo8H/HqlLo1wN4pm6W/GBJVxoiHPbfb2o= X-Gm-Message-State: AOJu0YxY2ZCO+49ZakkzpAhYP+wS8wZEtsyPiF7l3GTsTbYiULC3ajLf Qiqnemixi0w8JzdC8lWs2+kQaXLtNoPwsGoRolTBaQWZNAT4xbes5LqURtXSqf+D+dHFJzOzgVM SLr6PWtti0tEuPUYTF9EmR9P/GAs2rvhE9OcAyCX7Di6TxSe9 X-Received: by 2002:a05:6102:93:b0:476:e72e:94ef with SMTP id t19-20020a056102009300b00476e72e94efmr9650807vsp.3.1712080697552; Tue, 02 Apr 2024 10:58:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8b3uQ69B5cqo+ud6RtEbqNi2TEDMHUU32VESs2Pw1E24CP/zf32LkrpOQk6Mcp1ToEoA3Uw== X-Received: by 2002:a05:6102:93:b0:476:e72e:94ef with SMTP id t19-20020a056102009300b00476e72e94efmr9650757vsp.3.1712080696946; Tue, 02 Apr 2024 10:58:16 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id kk15-20020a056214508f00b00696a78b9cc6sm5720428qvb.53.2024.04.02.10.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 10:58:16 -0700 (PDT) Date: Tue, 2 Apr 2024 13:58:12 -0400 From: Peter Xu To: Ryan Roberts Cc: David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi , "Kirill A . Shutemov" , Mike Kravetz , John Hubbard , Michael Ellerman , Andrew Jones , Muchun Song , linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox , Rik van Riel , linux-arm-kernel@lists.infradead.org, Andrea Arcangeli , "Aneesh Kumar K . V" , Vlastimil Babka , James Houghton , Jason Gunthorpe , Mike Rapoport , Axel Rasmussen Subject: Re: [PATCH v4 13/13] mm/gup: Handle hugetlb in the generic follow_page_mask code Message-ID: References: <20240327152332.950956-1-peterx@redhat.com> <20240327152332.950956-14-peterx@redhat.com> <5d9dd9a7-e544-4741-944c-469b79c2c649@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DE8E61C000A X-Stat-Signature: rr7pc7or45q5rdinaf1e7wcq3xhqk9pa X-HE-Tag: 1712080702-592898 X-HE-Meta: U2FsdGVkX1/IAeSNekIqSlxZg4uZKAB58ZJQw5J+coVGlAZlX75Rrt/qepK5+Yn/iQNSMxrTZbNAOFeZ29H4oufLUeZJ6AWJilciYgcEN+B1umKwoI05z0iZBVUYoKFpsahygicgJY1vylwuBLqB8ixsVheJUBCNAISHM5E8LZgKH12tx6GgsBRokwQZPtWhkNm82hLtiRe9zltGmfsDDB7SU8GfJTECcbeKq0t8ck8k+LAM7o0t/Kr/n1bvvC2R6KG2Z3zrWI7nNtJ9iTdWifI6xOF9dx2ifaI3CYAj28t0+unsZmdvymdzuTzki7NgDRJZgrprteukOvYORi4NqfaULA7uHKGkHRcseVXThEIvflYL6lZSCBXPRS/Qtw0jEbfkKVZuuLRrEvhsSZushnA2izN5zxRbHmACfrtlbJhS1kNhblUtoIZ9P67BspBI8XxOTRXYLtUyLdsZxTndyit9oZGpaaMRF91buNMMq/2sSt2O/U5c+LdF0xqDC8kR98aoWWeufzOCoirq2400JjM0t2WVdO13H0kgjfwlaAxPrD/UBvgTywiidaVlSG+mi+i8xvRosfcx5oruLpT9QPtpjwR/erK/vjebKijcb28MnoR0a2pdK0elPq57Guj/JCxSbnotIwJENte+6EZae+Oo+Fl7OzAS/LkK/EiI8LJJGYJKAXHOKMgIfmz4SMIKg51+ez++CH0jFcjACigkyKyghvgZocizi3tN9Hn6h2PlRpD/f2TrPPeLtkp0seLb8u042TtQ1vMb885eIfRWZcr+SH0qqrdkI3M8+1CK9yUgePmpu+nKUobPK1TGaEBzWv8YFEt/eG9J63h3oCPGrfOA8A6NiTLLfhAd/6j+My5DoL6r4U2+yrX6e3ZOnLR9Y4bTr1dXnhenUXL+DalfGZQn2Lb7L3xBqEIm+Csrd+qkjvSHDAEZhIOlsqdLmX9i7oN8r5B0T5br1AlzQM2 jq70rlLl rr5CRVmjxHuo4u6a03ftONgE4OkJotDyKKeI7fg+IQ2u1ld/cErRKrjyWuTfiEH0VvHfNQKaCdNc3AM2+5O5h3Sfh6wsXt81FvYU+L+ZfnUGvUcecJKZ4KJenfxAfAzPF1QtYCX0TVij/BurLL85rDW5brlqE2RB7LF/I0vW35jE2ZRb0uMRtO7n7w6xeCG2M26YXud0UwSyvJ0eEnEBUjNrU8wFUlALD7TgUZ4nedRRyKCJluMAgvlbVCXhNXq6si8w+Lw2RVfsQh1u7jTKjPGH4wWYVQJsDUN2ClxKy90AdiELj/LIlktGXr9ISabed4uHyxU3rtQUVyaAUsWnJXVWjmB65rfzcUbY4VvRXIRBoFaxSLXB9IpDZIzlcevKmn84O1mQbtgYaOLnXXLTTtRy7eRw01qduWDat X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 02, 2024 at 05:46:57PM +0100, Ryan Roberts wrote: > I'll leave you to do the testing on this, if that's ok. Definitely. I'll test and send formal patches. > > Just to make my config explicit, I have this kernel command line, which reserves > hugetlbs of all sizes for the tests: > > "transparent_hugepage=madvise earlycon root=/dev/vda2 secretmem.enable > hugepagesz=1G hugepages=0:2,1:2 hugepagesz=32M hugepages=0:2,1:2 > default_hugepagesz=2M hugepages=0:64,1:64 hugepagesz=64K hugepages=0:2,1:2" This helps, thanks. -- Peter Xu