From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-177132.yeah.net (mail-177132.yeah.net [123.58.177.132]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 338BB2AE8E; Wed, 3 Apr 2024 04:45:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=123.58.177.132 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712119546; cv=none; b=jkXXzxfJT1a2W1u43e0mIPqq5OXaDbcb7iAlkdwtp7dCGNU46TDBogm4ch4bRT43+FeRLx/UGoTo4NhX6F3uPEnpukCNvWRQR/ufK65EYFD0PuNcfIhYTPMDSdRioPf4+/FORWge4eAqV8S5HDl7WqXonqoJhkilnmTVxpHAAcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712119546; c=relaxed/simple; bh=RKRjGazQgi9/wy1ZAhmHmX3W2MvlUVydC1Fm+Jjp4lg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EBsjXgydKw4s6rN5DLYGBYve5cED4UoDJbhHCmeFYNM0hfIjA8c3RnM24tIx3N7KkAvSqna6vt52hfdutFJK7vZtDvG/d1ITnzWzAI1oVFchPB3MlmYdH+5Uby0tMuE+PSWRwtIicxdcm5YB44tmibqOPxFGAYW1wfNMBJvUsTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yeah.net; spf=pass smtp.mailfrom=yeah.net; dkim=pass (1024-bit key) header.d=yeah.net header.i=@yeah.net header.b=Cn68qSYi; arc=none smtp.client-ip=123.58.177.132 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yeah.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yeah.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=yeah.net header.i=@yeah.net header.b="Cn68qSYi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version: Content-Type; bh=uqX62Bf+JcrmBQv01/Vx3mbSrOugBLWbo5yWq5zhEF0=; b=Cn68qSYiu/cNf66cDzMKChseMZEtIq+6n/0ljmod+U1HDeD/QZo0TYcSi/xUvT /GkgzXYtXAzlJumWi1KSd5uQXdkTO1ibihOj4bp+JXJQmZR12YkuV41qb/2fnlGU At/deTB46fkinM5OX5MH6DDalYzfmNzY2muIVT/BQ/wwY= Received: from dragon (unknown [223.68.79.243]) by smtp2 (Coremail) with SMTP id C1UQrACH7xjG3gxmxeC1Ag--.47054S3; Wed, 03 Apr 2024 12:44:55 +0800 (CST) Date: Wed, 3 Apr 2024 12:44:54 +0800 From: Shawn Guo To: Frank Li Cc: Fabio Estevam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/7] arm64: dts: imx8-ss-lsio: fix pwm lpcg indices Message-ID: References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> <20240401-dts_fix-v1-1-8c51ce52d411@nxp.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CM-TRANSID:C1UQrACH7xjG3gxmxeC1Ag--.47054S3 X-Coremail-Antispam: 1Uf129KBjvdXoWruF18tw45AF1xAw4kJF1DKFg_yoWktFbEga 1kZrs2yr1Du3ZrJan5Ar4rJ3yDJa4qkr15Xr95Wr17XasxJ34UJF1UKry8ZrW7GFZxtrn8 JFnxJFWYq3ySvjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0CJmUUUUUU== X-CM-SenderInfo: pvkd40hjxrjqh1hdxhhqhw/1tbiBR+1ZVsVCbh9qgABsj On Tue, Apr 02, 2024 at 11:10:07PM -0400, Frank Li wrote: > On Wed, Apr 03, 2024 at 09:41:26AM +0800, Shawn Guo wrote: > > On Tue, Apr 02, 2024 at 11:09:17AM -0400, Frank Li wrote: > > > On Mon, Apr 01, 2024 at 08:04:56PM -0300, Fabio Estevam wrote: > > > > On Mon, Apr 1, 2024 at 7:25 PM Frank Li wrote: > > > > > > > > > > lpcg's arg0 should use clock indices instead of index. > > > > > > > > > > pwm0_lpcg: clock-controller@5d400000 { > > > > > ... // Col1 Col2 > > > > > clocks = <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>, // 0 0 > > > > > <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>, // 1 1 > > > > > <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>, // 2 4 > > > > > <&lsio_bus_clk>, // 3 5 > > > > > <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>; // 4 6 > > > > > clock-indices = , , > > > > > , , > > > > > ; > > > > > }; > > > > > > > > > > Col1: index, which exited dts try to get. > > > > > > > > I cannot understand this sentence, sorry. > > > > > > This base on downstream dts code. Downstream code use index in 'Col1' to > > > get clock. > > > > So s/exited/existing you meant? > > Yes, sorry for typo. I fixed the typo and applied the series, thanks! Shawn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B1A3CD1288 for ; Wed, 3 Apr 2024 04:45:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DUEaaATDHL0couPsDuWbUpJCocxUv0C3W+4HHd9pp3M=; b=D1deY3647kSfHF 3uZZyUUFKmHnZ59HYXhl68z1hAITSOuDeaaxMv9tDfHdIDNooRJ/J22l1SNjXCVDRLREJ0t1FSpKG GFGf70iKaSbd3xVG52woQrkSKq9tFvIupGGCPYVFx2w1CDdSuEgx2u13GQ7I8V6hAaFJRyN3pmP+d KjxjnmE3NomqED9ZuTR860hquDcrg31lelSKTUoI/k3EuKKYQJ1cNazElg83e/G82hCneTWWZqnZb /kVGpLgRUXR4Ku7/gVni7rOj98g20BcDjcShXtKxVPiiK98jb+xb871W/hojdWrHspocs7io/teCp l1wG40tSwsVYbUmb7hqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrsV2-0000000DzXI-0OOg; Wed, 03 Apr 2024 04:45:24 +0000 Received: from mail-177132.yeah.net ([123.58.177.132]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrsUy-0000000DzVp-20QB for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 04:45:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version: Content-Type; bh=uqX62Bf+JcrmBQv01/Vx3mbSrOugBLWbo5yWq5zhEF0=; b=Cn68qSYiu/cNf66cDzMKChseMZEtIq+6n/0ljmod+U1HDeD/QZo0TYcSi/xUvT /GkgzXYtXAzlJumWi1KSd5uQXdkTO1ibihOj4bp+JXJQmZR12YkuV41qb/2fnlGU At/deTB46fkinM5OX5MH6DDalYzfmNzY2muIVT/BQ/wwY= Received: from dragon (unknown [223.68.79.243]) by smtp2 (Coremail) with SMTP id C1UQrACH7xjG3gxmxeC1Ag--.47054S3; Wed, 03 Apr 2024 12:44:55 +0800 (CST) Date: Wed, 3 Apr 2024 12:44:54 +0800 From: Shawn Guo To: Frank Li Cc: Fabio Estevam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/7] arm64: dts: imx8-ss-lsio: fix pwm lpcg indices Message-ID: References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> <20240401-dts_fix-v1-1-8c51ce52d411@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CM-TRANSID: C1UQrACH7xjG3gxmxeC1Ag--.47054S3 X-Coremail-Antispam: 1Uf129KBjvdXoWruF18tw45AF1xAw4kJF1DKFg_yoWktFbEga 1kZrs2yr1Du3ZrJan5Ar4rJ3yDJa4qkr15Xr95Wr17XasxJ34UJF1UKry8ZrW7GFZxtrn8 JFnxJFWYq3ySvjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0CJmUUUUUU== X-Originating-IP: [223.68.79.243] X-CM-SenderInfo: pvkd40hjxrjqh1hdxhhqhw/1tbiBR+1ZVsVCbh9qgABsj X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_214521_070435_108DFCDA X-CRM114-Status: GOOD ( 12.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBcHIgMDIsIDIwMjQgYXQgMTE6MTA6MDdQTSAtMDQwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gT24gV2VkLCBBcHIgMDMsIDIwMjQgYXQgMDk6NDE6MjZBTSArMDgwMCwgU2hhd24gR3VvIHdy b3RlOgo+ID4gT24gVHVlLCBBcHIgMDIsIDIwMjQgYXQgMTE6MDk6MTdBTSAtMDQwMCwgRnJhbmsg TGkgd3JvdGU6Cj4gPiA+IE9uIE1vbiwgQXByIDAxLCAyMDI0IGF0IDA4OjA0OjU2UE0gLTAzMDAs IEZhYmlvIEVzdGV2YW0gd3JvdGU6Cj4gPiA+ID4gT24gTW9uLCBBcHIgMSwgMjAyNCBhdCA3OjI1 4oCvUE0gRnJhbmsgTGkgPEZyYW5rLkxpQG54cC5jb20+IHdyb3RlOgo+ID4gPiA+ID4KPiA+ID4g PiA+IGxwY2cncyBhcmcwIHNob3VsZCB1c2UgY2xvY2sgaW5kaWNlcyBpbnN0ZWFkIG9mIGluZGV4 Lgo+ID4gPiA+ID4KPiA+ID4gPiA+IHB3bTBfbHBjZzogY2xvY2stY29udHJvbGxlckA1ZDQwMDAw MCB7Cj4gPiA+ID4gPiAgICAgICAgIC4uLiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIC8vIENvbDEgIENvbDIKPiA+ID4gPiA+ICAgICAgICAgY2xvY2tzID0g PCZjbGsgSU1YX1NDX1JfUFdNXzAgSU1YX1NDX1BNX0NMS19QRVI+LCAgLy8gMCAgICAgMAo+ID4g PiA+ID4gICAgICAgICAgICAgICAgICA8JmNsayBJTVhfU0NfUl9QV01fMCBJTVhfU0NfUE1fQ0xL X1BFUj4sICAvLyAxICAgICAxCj4gPiA+ID4gPiAgICAgICAgICAgICAgICAgIDwmY2xrIElNWF9T Q19SX1BXTV8wIElNWF9TQ19QTV9DTEtfUEVSPiwgIC8vIDIgICAgIDQKPiA+ID4gPiA+ICAgICAg ICAgICAgICAgICAgPCZsc2lvX2J1c19jbGs+LCAgICAgICAgICAgICAgICAgICAgICAgICAgLy8g MyAgICAgNQo+ID4gPiA+ID4gICAgICAgICAgICAgICAgICA8JmNsayBJTVhfU0NfUl9QV01fMCBJ TVhfU0NfUE1fQ0xLX1BFUj47ICAvLyA0ICAgICA2Cj4gPiA+ID4gPiAgICAgICAgIGNsb2NrLWlu ZGljZXMgPSA8SU1YX0xQQ0dfQ0xLXzA+LCA8SU1YX0xQQ0dfQ0xLXzE+LAo+ID4gPiA+ID4gICAg ICAgICAgICAgICAgICAgICAgICAgPElNWF9MUENHX0NMS180PiwgPElNWF9MUENHX0NMS181PiwK PiA+ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIDxJTVhfTFBDR19DTEtfNj47Cj4gPiA+ ID4gPiB9Owo+ID4gPiA+ID4KPiA+ID4gPiA+IENvbDE6IGluZGV4LCB3aGljaCBleGl0ZWQgZHRz IHRyeSB0byBnZXQuCj4gPiA+ID4gCj4gPiA+ID4gSSBjYW5ub3QgdW5kZXJzdGFuZCB0aGlzIHNl bnRlbmNlLCBzb3JyeS4KPiA+ID4gCj4gPiA+IFRoaXMgYmFzZSBvbiBkb3duc3RyZWFtIGR0cyBj b2RlLiAgRG93bnN0cmVhbSBjb2RlIHVzZSBpbmRleCBpbiAnQ29sMScgdG8KPiA+ID4gZ2V0IGNs b2NrLgo+ID4gCj4gPiBTbyBzL2V4aXRlZC9leGlzdGluZyB5b3UgbWVhbnQ/Cj4gCj4gWWVzLCBz b3JyeSBmb3IgdHlwby4gCgpJIGZpeGVkIHRoZSB0eXBvIGFuZCBhcHBsaWVkIHRoZSBzZXJpZXMs IHRoYW5rcyEKClNoYXduCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=