From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B5EBE126F36; Mon, 15 Apr 2024 13:22:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713187326; cv=none; b=B0ug4cmZiBlZMHo3wM69IDbxzSt9+S7+eCuCws/CCtCpUH4tu2wT4xiX6L6kPmAZlztWF3+FlFoyqbZGLFYrY22Eo1jX6wb3orxmRWDOIPQx7XdDa0EudqmpC1PkYimYjv+KXyD9pe7nSmDVRQd8d5ugcBUizgVofNAqvG9Fb/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713187326; c=relaxed/simple; bh=c9S4lDBsYHRr2v3kQQwGMcvUDoMDtV1vjj4QujV7SMU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gbB6RTPf3hshSUZc9Jm9dm0W5TTzkAiGL2a6eEQk0vsDuEk6Zuulnpg4e8A5Wp9pujD6S2bY9+Gt1+3ixevBJXuLuAylwbwaoHba19MnbAONHMfE3UOZz2lPpwuhVKcaufDQ3sREhRWa/VosmRZNKpb6H/w3Fox20merAwAfpg4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E47FCDA7; Mon, 15 Apr 2024 06:22:27 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4D2AF3F7CE; Mon, 15 Apr 2024 06:21:57 -0700 (PDT) Date: Mon, 15 Apr 2024 14:21:54 +0100 From: Sudeep Holla To: yunhui cui Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, Sudeep Holla , linux-kernel@vger.kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, bhelgaas@google.com, james.morse@arm.com, jhugo@codeaurora.org, jeremy.linton@arm.com, john.garry@huawei.com, Jonathan.Cameron@huawei.com, pierre.gondois@arm.com, tiantao6@huawei.com Subject: Re: [External] Re: [PATCH v2 2/3] riscv: cacheinfo: initialize cacheinfo's level and type from ACPI PPTT Message-ID: References: <20240414025826.64025-1-cuiyunhui@bytedance.com> <20240414025826.64025-2-cuiyunhui@bytedance.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Apr 15, 2024 at 08:03:38PM +0800, yunhui cui wrote: > Hi Sudeep, > > On Mon, Apr 15, 2024 at 4:45 PM Sudeep Holla wrote: > > > > On Sun, Apr 14, 2024 at 10:58:25AM +0800, Yunhui Cui wrote: > > > Before cacheinfo can be built correctly, we need to initialize level > > > and type. Since RSIC-V currently does not have a register group that > > > describes cache-related attributes like ARM64, we cannot obtain them > > > directly, so now we obtain cache leaves from the ACPI PPTT table > > > (acpi_get_cache_info()) and set the cache type through split_levels. > > > > > > Suggested-by: Jeremy Linton > > > Suggested-by: Sudeep Holla > > > Signed-off-by: Yunhui Cui > > > --- > > > arch/riscv/kernel/cacheinfo.c | 23 +++++++++++++++++++++++ > > > 1 file changed, 23 insertions(+) > > > > > > diff --git a/arch/riscv/kernel/cacheinfo.c b/arch/riscv/kernel/cacheinfo.c > > > index 30a6878287ad..ece92aa404e3 100644 > > > --- a/arch/riscv/kernel/cacheinfo.c > > > +++ b/arch/riscv/kernel/cacheinfo.c > > > @@ -6,6 +6,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > > > > static struct riscv_cacheinfo_ops *rv_cache_ops; > > > > > > @@ -78,6 +79,28 @@ int populate_cache_leaves(unsigned int cpu) > > > struct device_node *prev = NULL; > > > int levels = 1, level = 1; > > > > > > + if (!acpi_disabled) { > > > + int ret, idx, fw_levels, split_levels; > > > + > > > + ret = acpi_get_cache_info(cpu, &fw_levels, &split_levels); > > > + if (ret) > > > + return ret; > > > + > > > + /* must be set, so we can drop num_leaves assignment below */ > > > > I intentionally added this above comment to check and drop the below statement > > if it is already set. Please check if the value is already set when we call > > into this function(which I think is the case). > > > > > + this_cpu_ci->num_leaves = fw_levels + split_levels; > > Uh,got it. I understand that there is no need to add this line: > "this_cpu_ci->num_leaves = fw_levels + split_levels; " , because in > the Master core first it will: > smp_prepare_cpus > ->init_cpu_topology > ->for_each_possible_cpu(cpu) { > fetch_cache_info(cpu); //num_leaves and num_levels will be set > Then store_cpu_topology->update_siblings_masks->detect_cache_attributes->populate_cache_leaves(). > > Slave core will follow the logic of smp_callin->store_cpu_topology(). > It's the same after I tested it, so I plan to remove that line and > update V3, what do you think? > Correct, just drop the statement updating "this_cpu_ci->num_leaves". -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6931C04FF8 for ; Mon, 15 Apr 2024 13:22:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P51hIez6nKZPppVqfVHhTNZLS2+siRfmlI7qpTI2ztk=; b=fpNVolzdcLQeF1 W2NiC6ttSk1ERlVEypgUux5DTaySrrplRRwIGNCer1CoBHJZtmaKhuRvytTgFxj06awhJu5E/F+yZ In7XSPNYSOne4DJ7qkuPBum5R5MaX3I91rL6xfCS3pcPkNJHkkA13hJ2fSNgpu7iMYeK5BrgxT3U7 Ssql2og5hK6ZfQFyyjyUt0NwNY/g1Z6SjqlZ+RP54SvnM6zFbWrUE2d78YEjmHk/DSvZkNm9uQJY7 PfGIGS/p9BoihhzZVq5Y32vxGwJR1U1i47rtVlK4cQ7sdtAvc7rFb4IqUfxp1lQxbcJhWgUdoO7Qm n7WApSbAbO/5SwJ1k8rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwMHe-00000008Rau-1MCB; Mon, 15 Apr 2024 13:22:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwMHa-00000008RYU-3gHf for linux-riscv@lists.infradead.org; Mon, 15 Apr 2024 13:22:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E47FCDA7; Mon, 15 Apr 2024 06:22:27 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4D2AF3F7CE; Mon, 15 Apr 2024 06:21:57 -0700 (PDT) Date: Mon, 15 Apr 2024 14:21:54 +0100 From: Sudeep Holla To: yunhui cui Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, Sudeep Holla , linux-kernel@vger.kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, bhelgaas@google.com, james.morse@arm.com, jhugo@codeaurora.org, jeremy.linton@arm.com, john.garry@huawei.com, Jonathan.Cameron@huawei.com, pierre.gondois@arm.com, tiantao6@huawei.com Subject: Re: [External] Re: [PATCH v2 2/3] riscv: cacheinfo: initialize cacheinfo's level and type from ACPI PPTT Message-ID: References: <20240414025826.64025-1-cuiyunhui@bytedance.com> <20240414025826.64025-2-cuiyunhui@bytedance.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_062203_039873_01D8DF00 X-CRM114-Status: GOOD ( 28.49 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBcHIgMTUsIDIwMjQgYXQgMDg6MDM6MzhQTSArMDgwMCwgeXVuaHVpIGN1aSB3cm90 ZToKPiBIaSBTdWRlZXAsCj4gCj4gT24gTW9uLCBBcHIgMTUsIDIwMjQgYXQgNDo0NeKAr1BNIFN1 ZGVlcCBIb2xsYSA8c3VkZWVwLmhvbGxhQGFybS5jb20+IHdyb3RlOgo+ID4KPiA+IE9uIFN1biwg QXByIDE0LCAyMDI0IGF0IDEwOjU4OjI1QU0gKzA4MDAsIFl1bmh1aSBDdWkgd3JvdGU6Cj4gPiA+ IEJlZm9yZSBjYWNoZWluZm8gY2FuIGJlIGJ1aWx0IGNvcnJlY3RseSwgd2UgbmVlZCB0byBpbml0 aWFsaXplIGxldmVsCj4gPiA+IGFuZCB0eXBlLiBTaW5jZSBSU0lDLVYgY3VycmVudGx5IGRvZXMg bm90IGhhdmUgYSByZWdpc3RlciBncm91cCB0aGF0Cj4gPiA+IGRlc2NyaWJlcyBjYWNoZS1yZWxh dGVkIGF0dHJpYnV0ZXMgbGlrZSBBUk02NCwgd2UgY2Fubm90IG9idGFpbiB0aGVtCj4gPiA+IGRp cmVjdGx5LCBzbyBub3cgd2Ugb2J0YWluIGNhY2hlIGxlYXZlcyBmcm9tIHRoZSBBQ1BJIFBQVFQg dGFibGUKPiA+ID4gKGFjcGlfZ2V0X2NhY2hlX2luZm8oKSkgYW5kIHNldCB0aGUgY2FjaGUgdHlw ZSB0aHJvdWdoIHNwbGl0X2xldmVscy4KPiA+ID4KPiA+ID4gU3VnZ2VzdGVkLWJ5OiBKZXJlbXkg TGludG9uIDxqZXJlbXkubGludG9uQGFybS5jb20+Cj4gPiA+IFN1Z2dlc3RlZC1ieTogU3VkZWVw IEhvbGxhIDxzdWRlZXAuaG9sbGFAYXJtLmNvbT4KPiA+ID4gU2lnbmVkLW9mZi1ieTogWXVuaHVp IEN1aSA8Y3VpeXVuaHVpQGJ5dGVkYW5jZS5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgYXJjaC9yaXNj di9rZXJuZWwvY2FjaGVpbmZvLmMgfCAyMyArKysrKysrKysrKysrKysrKysrKysrKwo+ID4gPiAg MSBmaWxlIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKykKPiA+ID4KPiA+ID4gZGlmZiAtLWdpdCBh L2FyY2gvcmlzY3Yva2VybmVsL2NhY2hlaW5mby5jIGIvYXJjaC9yaXNjdi9rZXJuZWwvY2FjaGVp bmZvLmMKPiA+ID4gaW5kZXggMzBhNjg3ODI4N2FkLi5lY2U5MmFhNDA0ZTMgMTAwNjQ0Cj4gPiA+ IC0tLSBhL2FyY2gvcmlzY3Yva2VybmVsL2NhY2hlaW5mby5jCj4gPiA+ICsrKyBiL2FyY2gvcmlz Y3Yva2VybmVsL2NhY2hlaW5mby5jCj4gPiA+IEBAIC02LDYgKzYsNyBAQAo+ID4gPiAgI2luY2x1 ZGUgPGxpbnV4L2NwdS5oPgo+ID4gPiAgI2luY2x1ZGUgPGxpbnV4L29mLmg+Cj4gPiA+ICAjaW5j bHVkZSA8YXNtL2NhY2hlaW5mby5oPgo+ID4gPiArI2luY2x1ZGUgPGxpbnV4L2FjcGkuaD4KPiA+ ID4KPiA+ID4gIHN0YXRpYyBzdHJ1Y3QgcmlzY3ZfY2FjaGVpbmZvX29wcyAqcnZfY2FjaGVfb3Bz Owo+ID4gPgo+ID4gPiBAQCAtNzgsNiArNzksMjggQEAgaW50IHBvcHVsYXRlX2NhY2hlX2xlYXZl cyh1bnNpZ25lZCBpbnQgY3B1KQo+ID4gPiAgICAgICBzdHJ1Y3QgZGV2aWNlX25vZGUgKnByZXYg PSBOVUxMOwo+ID4gPiAgICAgICBpbnQgbGV2ZWxzID0gMSwgbGV2ZWwgPSAxOwo+ID4gPgo+ID4g PiArICAgICBpZiAoIWFjcGlfZGlzYWJsZWQpIHsKPiA+ID4gKyAgICAgICAgICAgICBpbnQgcmV0 LCBpZHgsIGZ3X2xldmVscywgc3BsaXRfbGV2ZWxzOwo+ID4gPiArCj4gPiA+ICsgICAgICAgICAg ICAgcmV0ID0gYWNwaV9nZXRfY2FjaGVfaW5mbyhjcHUsICZmd19sZXZlbHMsICZzcGxpdF9sZXZl bHMpOwo+ID4gPiArICAgICAgICAgICAgIGlmIChyZXQpCj4gPiA+ICsgICAgICAgICAgICAgICAg ICAgICByZXR1cm4gcmV0Owo+ID4gPiArCj4gPiA+ICsgICAgICAgICAgICAgLyogbXVzdCBiZSBz ZXQsIHNvIHdlIGNhbiBkcm9wIG51bV9sZWF2ZXMgYXNzaWdubWVudCBiZWxvdyAqLwo+ID4KPiA+ IEkgaW50ZW50aW9uYWxseSBhZGRlZCB0aGlzIGFib3ZlIGNvbW1lbnQgdG8gY2hlY2sgYW5kIGRy b3AgdGhlIGJlbG93IHN0YXRlbWVudAo+ID4gaWYgaXQgaXMgYWxyZWFkeSBzZXQuIFBsZWFzZSBj aGVjayBpZiB0aGUgdmFsdWUgaXMgYWxyZWFkeSBzZXQgd2hlbiB3ZSBjYWxsCj4gPiBpbnRvIHRo aXMgZnVuY3Rpb24od2hpY2ggSSB0aGluayBpcyB0aGUgY2FzZSkuCj4gPgo+ID4gPiArICAgICAg ICAgICAgIHRoaXNfY3B1X2NpLT5udW1fbGVhdmVzID0gZndfbGV2ZWxzICsgc3BsaXRfbGV2ZWxz Owo+IAo+IFVoLGdvdCBpdC4gSSB1bmRlcnN0YW5kIHRoYXQgdGhlcmUgaXMgbm8gbmVlZCB0byBh ZGQgdGhpcyBsaW5lOgo+ICJ0aGlzX2NwdV9jaS0+bnVtX2xlYXZlcyA9IGZ3X2xldmVscyArIHNw bGl0X2xldmVsczsgIiAsIGJlY2F1c2UgaW4KPiB0aGUgTWFzdGVyIGNvcmUgZmlyc3QgaXQgd2ls bDoKPiBzbXBfcHJlcGFyZV9jcHVzCj4gICAgICAtPmluaXRfY3B1X3RvcG9sb2d5Cj4gICAgICAg ICAgIC0+Zm9yX2VhY2hfcG9zc2libGVfY3B1KGNwdSkgewo+ICAgICAgICAgICAgICAgICAgZmV0 Y2hfY2FjaGVfaW5mbyhjcHUpOyAvL251bV9sZWF2ZXMgYW5kIG51bV9sZXZlbHMgd2lsbCBiZSBz ZXQKPiBUaGVuIHN0b3JlX2NwdV90b3BvbG9neS0+dXBkYXRlX3NpYmxpbmdzX21hc2tzLT5kZXRl Y3RfY2FjaGVfYXR0cmlidXRlcy0+cG9wdWxhdGVfY2FjaGVfbGVhdmVzKCkuCj4gCj4gU2xhdmUg Y29yZSB3aWxsIGZvbGxvdyB0aGUgbG9naWMgb2Ygc21wX2NhbGxpbi0+c3RvcmVfY3B1X3RvcG9s b2d5KCkuCj4gSXQncyB0aGUgc2FtZSBhZnRlciBJIHRlc3RlZCBpdCwgc28gSSBwbGFuIHRvIHJl bW92ZSB0aGF0IGxpbmUgYW5kCj4gdXBkYXRlIFYzLCB3aGF0IGRvIHlvdSB0aGluaz8KPgoKQ29y cmVjdCwganVzdCBkcm9wIHRoZSBzdGF0ZW1lbnQgdXBkYXRpbmcgInRoaXNfY3B1X2NpLT5udW1f bGVhdmVzIi4KCi0tIApSZWdhcmRzLApTdWRlZXAKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNj dkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtcmlzY3YK