From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCDB1C4345F for ; Mon, 15 Apr 2024 13:54:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 755E140119; Mon, 15 Apr 2024 13:54:16 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id bCWCsmkfhzf2; Mon, 15 Apr 2024 13:54:15 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 99477401D5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1713189255; bh=7/WZq/8bAV2ty7aVrpMWCn0oCl0hHcOFIFP+E3T3NoA=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=wyIVwTFeayQb0rPcovOKHFtCbp2+HpWhL5YjyjplTnAWg4sEPbgi31Of7HGiQyK2s Esk/xup2m7s/FxU6pozY3Zl/PqpU5rkEbg1fpsB6EZosgV/m5MD1IJMriiHp0tcLjP dfO1XWojkDLEH5vUAfYCMHZJE4lMMeIlq2yeuXBO7jAFcCcXatzG4/Gj+s0YFv1MXy /oY2Y+jxcyRP4onQ08dOmQwWiDpU/EDIbBE8QvK49tCbYFVX437SxoacI+msr0NXau 8GSdWeNMOM1GUoC4e5NRqlBEwiTTTk8xZ46MrpTF3+z3lZU9cgHn6wpo14fVKqcUM7 kxKPr1cPJEdxQ== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 99477401D5; Mon, 15 Apr 2024 13:54:15 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 461AC1BF285 for ; Mon, 15 Apr 2024 13:54:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2F95480ED9 for ; Mon, 15 Apr 2024 13:54:14 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id XRUhGRU595-x for ; Mon, 15 Apr 2024 13:54:12 +0000 (UTC) Received-SPF: Pass (sender SPF authorized) identity=helo; client-ip=2a01:37:1000::53df:5f64:0; helo=bmailout1.hostsharing.net; envelope-from=foo00@h08.hostsharing.net; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 6310980EAD DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 6310980EAD Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [IPv6:2a01:37:1000::53df:5f64:0]) by smtp1.osuosl.org (Postfix) with ESMTPS id 6310980EAD for ; Mon, 15 Apr 2024 13:54:12 +0000 (UTC) Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id 5801A300037E5; Mon, 15 Apr 2024 15:54:10 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 32D6E1BD9B; Mon, 15 Apr 2024 15:54:10 +0200 (CEST) Date: Mon, 15 Apr 2024 15:54:10 +0200 From: Lukas Wunner To: Kurt Kanzenbach Message-ID: References: <20240411-igc_led_deadlock-v1-1-0da98a3c68c5@linutronix.de> <877ch0b901.fsf@kurt.kurt.home> <87zftukhxl.fsf@kurt.kurt.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zftukhxl.fsf@kurt.kurt.home> X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=none (p=none dis=none) header.from=wunner.de Subject: Re: [Intel-wired-lan] [PATCH iwl-net] igc: Fix deadlock on module removal X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Sasha Neftin , Roman Lozko , Eric Dumazet , netdev@vger.kernel.org, Tony Nguyen , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Apr 15, 2024 at 01:02:14PM +0200, Kurt Kanzenbach wrote: > > > I would have been happy to submit a patch myself, I was waiting > > > for a Tested-by from Roman or you. > > > > Perfect. I was wondering why you are not submitting the patch > > yourself. Then, please go ahead and submit the patch. Feel free to add > > my Tested-by. > > Scratch that. I've sent v2 with your SoB. PTAL, because your original > code snippet didn't have a SoB. > > https://lore.kernel.org/netdev/20240411-igc_led_deadlock-v2-1-b758c0c88b2b@linutronix.de/ I created a patch yesterday, as you've requested, then waited for 0-day to crunch through it and report success. Which it just did, so here's my proposal and I guess maintainers now have more than enough options to choose from: https://lore.kernel.org/netdev/2f1be6b1cf2b3346929b0049f2ac7d7d79acb5c9.1713188539.git.lukas@wunner.de/ Thanks, Lukas From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [83.223.95.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18D215F54D for ; Mon, 15 Apr 2024 13:54:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.223.95.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713189254; cv=none; b=pDIkL+09huKTAxZe71x7veFK+BjxP7rg2IaWJeCkUQfoYCTLxbfIezngSdqxsI0VotVYqld7bieiCnAXdhpGZI5Fjz+yJI+mxIFCsGK76qt+AoFm8PT6Bkq6m4Oi0+jU/Ojgi7SpBThzhmvZbsVSNEO0GBjUA+ECAB3NI0pkPR8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713189254; c=relaxed/simple; bh=s64tPzEuAURs1JoCSR9aaBZd5lR6ij2bp/d83+dXio0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MWXn/40/1ftNdzIQhXnz2GECp2RCQLksU0IYUIkDyG/QM4KBv1bvMR0pbWsrhiwsoRJzXpaqN56dwAs2G7wR2T4rlFxcEkxDNwRP3euV1fjz96X0/co5pZ/lEhGPzJFdLQxzV39M/3AsSwFBAKPvWwVHD0UJ41vRXHR42CGenQI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=none smtp.mailfrom=h08.hostsharing.net; arc=none smtp.client-ip=83.223.95.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=h08.hostsharing.net Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id 5801A300037E5; Mon, 15 Apr 2024 15:54:10 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 32D6E1BD9B; Mon, 15 Apr 2024 15:54:10 +0200 (CEST) Date: Mon, 15 Apr 2024 15:54:10 +0200 From: Lukas Wunner To: Kurt Kanzenbach Cc: Roman Lozko , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Sasha Neftin , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: Re: [PATCH iwl-net] igc: Fix deadlock on module removal Message-ID: References: <20240411-igc_led_deadlock-v1-1-0da98a3c68c5@linutronix.de> <877ch0b901.fsf@kurt.kurt.home> <87zftukhxl.fsf@kurt.kurt.home> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zftukhxl.fsf@kurt.kurt.home> On Mon, Apr 15, 2024 at 01:02:14PM +0200, Kurt Kanzenbach wrote: > > > I would have been happy to submit a patch myself, I was waiting > > > for a Tested-by from Roman or you. > > > > Perfect. I was wondering why you are not submitting the patch > > yourself. Then, please go ahead and submit the patch. Feel free to add > > my Tested-by. > > Scratch that. I've sent v2 with your SoB. PTAL, because your original > code snippet didn't have a SoB. > > https://lore.kernel.org/netdev/20240411-igc_led_deadlock-v2-1-b758c0c88b2b@linutronix.de/ I created a patch yesterday, as you've requested, then waited for 0-day to crunch through it and report success. Which it just did, so here's my proposal and I guess maintainers now have more than enough options to choose from: https://lore.kernel.org/netdev/2f1be6b1cf2b3346929b0049f2ac7d7d79acb5c9.1713188539.git.lukas@wunner.de/ Thanks, Lukas