From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: quic_fenglinw@quicinc.com, kernel@quicinc.com,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v10 1/4] input: pm8xxx-vibrator: correct VIB_MAX_LEVELS calculation
Date: Mon, 15 Apr 2024 16:30:00 -0700 [thread overview]
Message-ID: <Zh24eN9ZMZ6QhzeZ@google.com> (raw)
In-Reply-To: <CAA8EJpp-awdTyfngeYyJaOObOWz=UCSK9U08TfFPA0v=8Naz=A@mail.gmail.com>
On Fri, Apr 12, 2024 at 07:21:16PM +0300, Dmitry Baryshkov wrote:
> On Fri, 12 Apr 2024 at 15:36, Fenglin Wu via B4 Relay
> <devnull+quic_fenglinw.quicinc.com@kernel.org> wrote:
> >
> > From: Fenglin Wu <quic_fenglinw@quicinc.com>
> >
> > The output voltage is inclusive hence the max level calculation is
> > off-by-one-step. Correct it.
>
> ... while we are at it also add a define for the step size instead of
> using the magic value.
I adjusted the patch description as Dmitry suggested, and applied this
patch. Please address Konrad's feedback on the other 2 and I will apply
the rest.
Thank you.
--
Dmitry
next prev parent reply other threads:[~2024-04-15 23:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 12:36 [PATCH v10 0/4] Add support for vibrator in multiple PMICs Fenglin Wu
2024-04-12 12:36 ` Fenglin Wu via B4 Relay
2024-04-12 12:36 ` [PATCH v10 1/4] input: pm8xxx-vibrator: correct VIB_MAX_LEVELS calculation Fenglin Wu
2024-04-12 12:36 ` Fenglin Wu via B4 Relay
2024-04-12 16:21 ` Dmitry Baryshkov
2024-04-15 23:30 ` Dmitry Torokhov [this message]
2024-04-12 12:36 ` [PATCH v10 2/4] input: pm8xxx-vibrator: refactor to support new SPMI vibrator Fenglin Wu
2024-04-12 12:36 ` Fenglin Wu via B4 Relay
2024-04-15 19:47 ` Konrad Dybcio
2024-04-12 12:36 ` [PATCH v10 3/4] dt-bindings: input: qcom,pm8xxx-vib: add new SPMI vibrator module Fenglin Wu
2024-04-12 12:36 ` Fenglin Wu via B4 Relay
2024-04-12 12:36 ` [PATCH v10 4/4] input: pm8xxx-vibrator: add new SPMI vibrator support Fenglin Wu
2024-04-12 12:36 ` Fenglin Wu via B4 Relay
2024-04-15 19:52 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh24eN9ZMZ6QhzeZ@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_fenglinw@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.