All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@intel.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Dave Hello <hsu@peterdavehello.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] Add zh_TW Traditional Chinese translation
Date: Wed, 17 Apr 2024 00:41:16 +0800	[thread overview]
Message-ID: <Zh6qLCvyiSk6YkVy@intel.com> (raw)
In-Reply-To: <CAFEAcA_D1+BUk01mXNwRehxYqyXQU+Zu98sWBujauk5L2tHh3w@mail.gmail.com>

Hi Peter,

On Tue, Apr 16, 2024 at 02:27:45PM +0100, Peter Maydell wrote:
> Date: Tue, 16 Apr 2024 14:27:45 +0100
> From: Peter Maydell <peter.maydell@linaro.org>
> Subject: Re: [PATCH] Add zh_TW Traditional Chinese translation
> 
> On Tue, 16 Apr 2024 at 14:00, Peter Dave Hello <hsu@peterdavehello.org> wrote:
> >
> > From: Peter Dave Hello <hsu@peterdavehello.org>
> > Date: Tue, 16 Apr 2024 00:43:29 +0800
> > Subject: [PATCH] Add a simple zh_TW Traditional Chinese translation
> >
> > This patch adds a basic zh_TW translation file for Taiwan Traditional
> > Chinese users.
> >
> > Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
> 
> This name in your Signed-off-by line doesn't match the
> name you use in the .po file...
> 
> > ---
> >  po/LINGUAS  |  1 +
> >  po/zh_TW.po | 93 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 94 insertions(+)
> >  create mode 100644 po/zh_TW.po
> >
> > diff --git a/po/LINGUAS b/po/LINGUAS
> > index 9b33a36..08163e8 100644
> > --- a/po/LINGUAS
> > +++ b/po/LINGUAS
> > @@ -7,3 +7,4 @@ sv
> >  tr
> >  uk
> >  zh_CN
> > +zh_TW
> > diff --git a/po/zh_TW.po b/po/zh_TW.po
> > new file mode 100644
> > index 0000000..d25557e
> > --- /dev/null
> > +++ b/po/zh_TW.po
> > @@ -0,0 +1,93 @@
> > +# Chinese translations for PACKAGE package.
> > +# Copyright (C) 2024 THE PACKAGE'S COPYRIGHT HOLDER
> > +# This file is distributed under the same license as the PACKAGE package.
> 
> Can you replace all these placeholder ALLCAPS items
> with the right values, please?
> 
> > +# Peter Hsu <hsu@peterdavehello.org>, 2024.
> > +#

Open source license is missing here.

And I checked the other .po files and found that none of them declare
the open source license, are they missing it? Or does this case default
to "GPL-2.0-or-later"?

Thanks,
Zhao



  reply	other threads:[~2024-04-16 16:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16 11:31 [PATCH] Add zh_TW Traditional Chinese translation Peter Dave Hello
2024-04-16 13:27 ` Peter Maydell
2024-04-16 16:41   ` Zhao Liu [this message]
2024-04-16 16:32     ` Daniel P. Berrangé
2024-04-17 13:07       ` Peter Dave Hello
2024-04-18  2:22         ` Zhao Liu
2024-04-23 18:20           ` Peter Dave Hello
2024-06-21 12:50             ` Peter Dave Hello
2024-06-21 13:07               ` Peter Maydell
2024-06-24 17:06                 ` Daniel P. Berrangé
2025-01-14 13:45                   ` Peter Dave Hello via
2025-01-14 14:34                     ` Daniel P. Berrangé
2024-04-16 16:34 ` Zhao Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zh6qLCvyiSk6YkVy@intel.com \
    --to=zhao1.liu@intel.com \
    --cc=hsu@peterdavehello.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.