[Regression] USB ethernet AX88179 broken usb ethernet names

[Salvatore Bonaccorso <carnil@debian.org>]

Hi,

Roland Rosenfeld reported in Debian a regression after the update to
the 6.1.85 based kernel, with his USB ethernet device not anymore
able to use the usb ethernet names.

https://bugs.debian.org/1069082

it is somehow linked to the already reported regression
https://lore.kernel.org/regressions/ZhFl6xueHnuVHKdp@nuc/ but has
another aspect. I'm quoting his original report:

> Dear Maintainer,
> 
> when upgrading from 6.1.76-1 to 6.1.85-1 my USB ethernet device
>  ID 0b95:1790 ASIX Electronics Corp. AX88179 Gigabit Ethernet
> is no longer named enx00249bXXXXXX but eth0.
> 
> I see the following in dmsg:
> 
> [    1.484345] usb 4-5: Manufacturer: ASIX Elec. Corp.
> [    1.484661] usb 4-5: SerialNumber: 0000249BXXXXXX
> [    1.496312] ax88179_178a 4-5:1.0 eth0: register 'ax88179_178a' at usb-0000:00:14.0-5, ASIX AX88179 USB 3.0 Gigabit Ethernet, d2:60:4c:YY:YY:YY
> [    1.497746] usbcore: registered new interface driver ax88179_178a
> 
> Unplugging and plugging again does not solve the issue, but the
> interface still is named eth0.
> 
> Maybe it has to do with the following commit from
> https://cdn.kernel.org/pub/linux/kernel/v6.x/ChangeLog-6.1.85
> 
> commit fc77240f6316d17fc58a8881927c3732b1d75d51
> Author: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
> Date:   Wed Apr 3 15:21:58 2024 +0200
> 
>     net: usb: ax88179_178a: avoid the interface always configured as random address
> 
>     commit 2e91bb99b9d4f756e92e83c4453f894dda220f09 upstream.
> 
>     After the commit d2689b6a86b9 ("net: usb: ax88179_178a: avoid two
>     consecutive device resets"), reset is not executed from bind operation and
>     mac address is not read from the device registers or the devicetree at that
>     moment. Since the check to configure if the assigned mac address is random
>     or not for the interface, happens after the bind operation from
>     usbnet_probe, the interface keeps configured as random address, although the
>     address is correctly read and set during open operation (the only reset
>     now).
> 
>     In order to keep only one reset for the device and to avoid the interface
>     always configured as random address, after reset, configure correctly the
>     suitable field from the driver, if the mac address is read successfully from
>     the device registers or the devicetree. Take into account if a locally
>     administered address (random) was previously stored.
> 
>     cc: stable@vger.kernel.org # 6.6+
>     Fixes: d2689b6a86b9 ("net: usb: ax88179_178a: avoid two consecutive device resets")
>     Reported-by: Dave Stevenson  <dave.stevenson@raspberrypi.com>
>     Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
>     Reviewed-by: Simon Horman <horms@kernel.org>
>     Link: https://lore.kernel.org/r/20240403132158.344838-1-jtornosm@redhat.com
>     Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Seems, that I'm not alone with this issue, there are also reports in
> https://www.reddit.com/r/debian/comments/1c304xn/linuximageamd64_61851_usb_link_interface_names/
> and https://infosec.space/@topher/112276500329020316
> 
> 
> All other (pci based) network interfaces still use there static names
> (enp0s25, enp2s0, enp3s0), only the usb ethernet name is broken with
> the new kernel.
> 
> Greetings
> Roland

Roland confirmed that reverting both fc77240f6316 ("net: usb:
ax88179_178a: avoid the interface always configured as random
address") and 5c4cbec5106d ("net: usb: ax88179_178a: avoid two
consecutive device resets") fixes the problem.

Confirmation: https://bugs.debian.org/1069082#27

Regards,
Salvatore