From: Stafford Horne <shorne@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
GLIBC patches <libc-alpha@sourceware.org>,
Linux OpenRISC <linux-openrisc@vger.kernel.org>
Subject: Re: [PATCH 1/2] or1k: Add hard float support
Date: Tue, 16 Apr 2024 21:37:06 +0100 [thread overview]
Message-ID: <Zh7hcqSWKc9qrnP3@antec> (raw)
In-Reply-To: <1cd9db5c-fd3a-45d8-96d5-227ea720dab3@linaro.org>
On Tue, Apr 16, 2024 at 12:56:11PM -0700, Richard Henderson wrote:
> On 4/16/24 09:20, Adhemerval Zanella Netto wrote:
> > Right, it was not clear from patch without dig into the ABI documen
> > itself. So the only thing I am not sure is the mcontext_t change.
> > Other ABIs added a symbol version to proper handle it, so maybe
> > OpenRISC would need something similar.
>
> Yes, I think some compat symbols are needed for getcontext et al, since the
> size of ucontext_t changes.
Just to re-iterate, the size of ucontext_t provided by the kernel never changed.
But the change of ucontext_t in glibc changing causes issues.
With the glibc ucontext_t size change there will be a problem with running
old compiled applications on new versions of glibc if this hard-float series is
added as is. I will see if we can add some versioning to ensure binaries will
not break when running on new glibc versions after this series.
> I think softfloat glibc should populate the same field (with zero, since
> neither exceptions nor rounding are supported).
Let me double check this is the case.
-Stafford
next prev parent reply other threads:[~2024-04-16 20:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 7:40 [PATCH 0/2] OpenRISC glibc hard float support Stafford Horne
2024-03-29 7:40 ` [PATCH 1/2] or1k: Add " Stafford Horne
2024-04-16 14:04 ` Adhemerval Zanella Netto
2024-04-16 14:53 ` Richard Henderson
2024-04-16 16:20 ` Adhemerval Zanella Netto
2024-04-16 19:56 ` Richard Henderson
2024-04-16 20:37 ` Stafford Horne [this message]
2024-03-29 7:40 ` [PATCH 2/2] build-many-glibcs.py: Add openrisc hard float glibc variant Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh7hcqSWKc9qrnP3@antec \
--to=shorne@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.