From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8CFDC4345F for ; Tue, 16 Apr 2024 20:55:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 8C5FE8151E; Tue, 16 Apr 2024 20:55:29 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id oUEwQvqRxO5t; Tue, 16 Apr 2024 20:55:28 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 584E3814B7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1713300928; bh=SOBrduNq6abzzMV93b1/GhKvT61LbgDaVIzoPQPGROQ=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=MP4tLIFq57BW37wkVNw++ynetuTWvwXlj5Hk7Dx6HYd456Y96Atyv+sumo73dl5q4 2pdB0fLKKdptW5duIhX9trJoeUZNdTzqhFk9oY3SquS0Hldq+JqAlHBcLQzJ88R1Ra brRlWCbJzHs7RtH63iZvqWiiDGrX9V7/UP2xOfOF9kHFh08B1FV2udYgJCJt9nO1f9 5Of92FR44a/4vxgdALWrC5vQvu+cKe4gHmbBSr04z5xStwRupOVjv7JAOkwLaNoNxV SMSADXu0J9lhzQttMvjgtDGX5MD15H/mGgWdE5tHV4r1I9gS6Z7eorZrmgX0v7vu+r ckTTDHHBeELsA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 584E3814B7; Tue, 16 Apr 2024 20:55:28 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id DECCD1BF279 for ; Tue, 16 Apr 2024 20:55:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id C9B7940A45 for ; Tue, 16 Apr 2024 20:55:26 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id nWs4UoJo5tBL for ; Tue, 16 Apr 2024 20:55:25 +0000 (UTC) Received-SPF: Pass (sender SPF authorized) identity=helo; client-ip=83.223.95.100; helo=bmailout1.hostsharing.net; envelope-from=foo00@h08.hostsharing.net; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org B13374018E DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org B13374018E Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [83.223.95.100]) by smtp2.osuosl.org (Postfix) with ESMTPS id B13374018E for ; Tue, 16 Apr 2024 20:55:23 +0000 (UTC) Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id CAC463000D5BB; Tue, 16 Apr 2024 22:55:19 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 9D1131E063; Tue, 16 Apr 2024 22:55:19 +0200 (CEST) Date: Tue, 16 Apr 2024 22:55:19 +0200 From: Lukas Wunner To: Kurt Kanzenbach Message-ID: References: <2f1be6b1cf2b3346929b0049f2ac7d7d79acb5c9.1713188539.git.lukas@wunner.de> <87plupe70m.fsf@kurt.kurt.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87plupe70m.fsf@kurt.kurt.home> X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=none (p=none dis=none) header.from=wunner.de Subject: Re: [Intel-wired-lan] [PATCH net] igc: Fix LED-related deadlock on driver unbind X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Sasha Neftin , Roman Lozko , intel-wired-lan@lists.osuosl.org, Eric Dumazet , Tony Nguyen , netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" , Heiner Kallweit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Apr 16, 2024 at 04:06:49PM +0200, Kurt Kanzenbach wrote: > On Mon Apr 15 2024, Lukas Wunner wrote: > > Fixes: ea578703b03d ("igc: Add support for LEDs on i225/i226") > > Reported-by: Roman Lozko > > Closes: https://lore.kernel.org/r/CAEhC_B=ksywxCG_+aQqXUrGEgKq+4mqnSV8EBHOKbC3-Obj9+Q@mail.gmail.com/ > > Signed-off-by: Kurt Kanzenbach > > I think, the first SoB has to be yours, because you are the patch > author. In fact, my SoB is not required at all. My understanding is that the commit author must be identical to the last Signed-off-by, so I put mine last. I've seen Stephen Rothwell send complaints whenever he spotted commits in linux-next violating that. I carried over the variable and function renaming you did to match the driver's (or your) preferred style, hence the inclusion of your Signed-off-by. Thanks! Lukas From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [83.223.95.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E968C2375B for ; Tue, 16 Apr 2024 20:55:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.223.95.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713300931; cv=none; b=VM7OOubazdSvyu+uUG9hYvDM9N7C7zz3vWHywVNjnjJFloIhRDL7ohOJ2tIipvdXOHR21AbAo0uIiJQUMP7uSC5tOmE0orn4O3145nNZU5f1LkQkxk1JAqi8GqyQFv/MWTTtrrcx7z79j/yKDMt3qFn+hQO/Zejd3FJVHeRy5XY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713300931; c=relaxed/simple; bh=wGwJzpcMh6WJgwflNIZwew7EYrOklHa755izNe2Rfw8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fZpphPRuwGz6lupgl5UjPNe1HN2t36QzBj4cVowQ5ea2Drthm5jRq6WieHzI4CdMT4SnXbLRg8dz3XLvHidzFk+03PZiA6c1/0PORq3e/hc8+Fm01NUfJrJtHqwJVucmmCo4z8mOMKv0+IhaRnMtMby941tnnra/O/sZ/McBAvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=none smtp.mailfrom=h08.hostsharing.net; arc=none smtp.client-ip=83.223.95.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=h08.hostsharing.net Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id CAC463000D5BB; Tue, 16 Apr 2024 22:55:19 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 9D1131E063; Tue, 16 Apr 2024 22:55:19 +0200 (CEST) Date: Tue, 16 Apr 2024 22:55:19 +0200 From: Lukas Wunner To: Kurt Kanzenbach Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jesse Brandeburg , Tony Nguyen , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Roman Lozko , Heiner Kallweit , Andrew Lunn , Sasha Neftin Subject: Re: [PATCH net] igc: Fix LED-related deadlock on driver unbind Message-ID: References: <2f1be6b1cf2b3346929b0049f2ac7d7d79acb5c9.1713188539.git.lukas@wunner.de> <87plupe70m.fsf@kurt.kurt.home> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87plupe70m.fsf@kurt.kurt.home> On Tue, Apr 16, 2024 at 04:06:49PM +0200, Kurt Kanzenbach wrote: > On Mon Apr 15 2024, Lukas Wunner wrote: > > Fixes: ea578703b03d ("igc: Add support for LEDs on i225/i226") > > Reported-by: Roman Lozko > > Closes: https://lore.kernel.org/r/CAEhC_B=ksywxCG_+aQqXUrGEgKq+4mqnSV8EBHOKbC3-Obj9+Q@mail.gmail.com/ > > Signed-off-by: Kurt Kanzenbach > > I think, the first SoB has to be yours, because you are the patch > author. In fact, my SoB is not required at all. My understanding is that the commit author must be identical to the last Signed-off-by, so I put mine last. I've seen Stephen Rothwell send complaints whenever he spotted commits in linux-next violating that. I carried over the variable and function renaming you did to match the driver's (or your) preferred style, hence the inclusion of your Signed-off-by. Thanks! Lukas