Re: [PATCH v6 1/3] perf, capstone: Support 32bit code under 64bit OS

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Thu, Apr 04, 2024 at 09:22:11AM +0300, Adrian Hunter wrote:
> On 2/04/24 00:08, Andi Kleen wrote:
> > Use the DSO to resolve whether an IP is 32bit or 64bit and use that to
> > configure capstone to the correct mode. This allows to correctly
> > disassemble 32bit code under a 64bit OS.
> > 
> > % cat > loop.c
> > volatile int var;
> > int main(void)
> > {
> > 	int i;
> > 	for (i = 0; i < 100000; i++)
> > 		var++;
> > }
> > % gcc -m32 -o loop loop.c
> > % perf record -e cycles:u ./loop
> > % perf script -F +disasm
> >             loop   82665 1833176.618023:          1 cycles:u:          f7eed500 _start+0x0 (/usr/lib/ld-linux.so.2)             movl %esp, %eax
> >             loop   82665 1833176.618029:          1 cycles:u:          f7eed500 _start+0x0 (/usr/lib/ld-linux.so.2)             movl %esp, %eax
> >             loop   82665 1833176.618031:          7 cycles:u:          f7eed500 _start+0x0 (/usr/lib/ld-linux.so.2)             movl %esp, %eax
> >             loop   82665 1833176.618034:         91 cycles:u:          f7eed500 _start+0x0 (/usr/lib/ld-linux.so.2)             movl %esp, %eax
> >             loop   82665 1833176.618036:       1242 cycles:u:          f7eed500 _start+0x0 (/usr/lib/ld-linux.so.2)             movl %esp, %eax
> > 
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
> 
> As with V4, comma in subject is slightly odd, otherwise:
> 
> Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
> 
> Also note V4 Ack from Thomas Richter:
> 
> 	https://lore.kernel.org/all/5399c3b2-a1f0-41c6-ba91-a6a6692629dd@linux.ibm.com/

Collected Thomas for 1/3 and standardized the summary lines, thanks:

⬢[acme@toolbox perf-tools-next]$ git log --oneline -3
0209991d98e483af (HEAD -> perf-tools-next) perf script: Consolidate capstone print functions
d812044688dfe73e perf script: Add capstone support for '-F +brstackdisasm'
38ab60132b0d477e perf script: Support 32bit code under 64bit OS with capstone
⬢[acme@toolbox perf-tools-next]$

- Arnaldo