From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from luna.linkmauve.fr (luna.linkmauve.fr [82.65.109.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BFF116F85A for ; Fri, 5 Apr 2024 14:30:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.65.109.163 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712327453; cv=none; b=S+F/FzL3xoEeErcZzhvkKPPuBUKvj6SkrtY4w2S4pmflLvq2vllVj5gw0IfWPlNuBk/L2IRqJjjT9DrkwtuaZEyAJzKLKz+/QqDXRCBHNYbNIrZ30qvCoh7RfQlOWKeToC4Ti/aGHwXx+dnq0VsTDbzx6hzMwDkMglUJpxljyDs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712327453; c=relaxed/simple; bh=OAIDc5kctipri1hRyW8oc3G7ind5HlKJOPmKLgo/ZtE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L7YDRKzmZn0eaGWoqRomB68i8KwWjYUQ1g54whtA3rs1FVsNkmbeRf03SCEgG56gdzKPSbKt7LBiplDv0b/Hw2gR9Y9ys1pMRHo3NP7gTKNOsi8yXKlK7C32OinRKaShC8W9kYM7A17j7oq/H0U0jiuCmvRjmsH0s3tQSshwjjE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linkmauve.fr; spf=pass smtp.mailfrom=linkmauve.fr; arc=none smtp.client-ip=82.65.109.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linkmauve.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linkmauve.fr Received: by luna.linkmauve.fr (Postfix, from userid 1000) id BA81A106966F; Fri, 5 Apr 2024 16:21:30 +0200 (CEST) Date: Fri, 5 Apr 2024 16:21:30 +0200 From: Link Mauve To: Nicolas Dufresne Cc: Emmanuel Gil Peyrot , linux-kernel@vger.kernel.org, Ezequiel Garcia , Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Joerg Roedel , Will Deacon , Robin Murphy , Sebastian Reichel , Cristian Ciocaltea , Dragan Simic , Shreeya Patel , Chris Morgan , Andy Yan , Nicolas Frattaroli , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev Subject: Re: [PATCH v2 0/2] Enable JPEG encoding on rk3588 Message-ID: References: <20240327134115.424846-1-linkmauve@linkmauve.fr> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Jabber-ID: linkmauve@linkmauve.fr On Thu, Apr 04, 2024 at 01:41:15PM -0400, Nicolas Dufresne wrote: > Hi, Hi, > > Le mercredi 27 mars 2024 à 14:41 +0100, Emmanuel Gil Peyrot a écrit : > > Only the JPEG encoder is available for now, although there are patches > > for the undocumented VP8 encoder floating around[0]. > > [0] seems like a broken link. The VP8 encoder RFC is for RK3399 (and Hantro H1 > posted by ST more recently). The TRM says "VEPU121(JPEG encoder only)", which > suggest that the H.264 and VP8 encoders usually found on the VEPU121 are > removed. As Rockchip have remove the synthesize register while modifying the H1 > IP, it is difficult to verify. Confusingly the H.264 specific registers are > documented in the TRM around VEPU121. Ah, the link became, and was indeed ST’s series: https://patchwork.kernel.org/project/linux-rockchip/list/?series=789885&archive=both But the TRM part 1 says the VEPU121 supports H.264 encoding (page 367), and it’s likely they didn’t remove just VP8 support since the codec features are pretty close to H.264’s. > > > > > This has been tested on a rock-5b, resulting in four /dev/video* > > encoders. The userspace program I’ve been using to test them is > > Onix[1], using the jpeg-encoder example, it will pick one of these four > > at random (but displays the one it picked): > > % ffmpeg -i -pix_fmt yuvj420p temp.yuv > > % jpeg-encoder temp.yuv NV12 output.jpeg > > I don't like that we exposing each identical cores a separate video nodes. I > think we should aim for 1 device, and then multi-plex and schedule de cores from > inside the Linux kernel. I agree, but this should be handled in the driver not in the device tree, and it can be done later. > > Not doing this now means we'll never have an optimal hardware usage > distribution. Just consider two userspace software wanting to do jpeg encoding. > If they both take a guess, they may endup using a single core. Where with proper > scheduling in V4L2, the kernel will be able to properly distribute the load. I > insist on this, since if we merge you changes it becomes an ABI and we can't > change it anymore. Will it really become ABI just like that? Userspace should always discover the video nodes and their capabilities and not hardcode e.g. a specific /dev/videoN file for a specific codec. I would argue that this series would let userspace do JPEG encoding right away, even if in a less optimal way than if the driver would round-robin them through a single video node, but that can always be added in a future version. > > I understand that this impose a rework of the mem2mem framework so that we can > run multiple jobs, but this will be needed anyway on RK3588, since the rkvdec2, > which we don't have a driver yet is also multi-core, but you need to use 2 cores > when the resolution is close to 8K. I think the mediatek JPEG driver already supports that, would it be ok to do it the same way? > > Nicolas > > > > > [0] https://patchwork.kernel.org/project/linux-rockchip/list/?series=789885 > > [1] https://crates.io/crates/onix > > > > Changes since v1: > > - Dropped patches 1 and 4. > > - Use the proper compatible form, since this device should be fully > > compatible with the VEPU of rk356x. > > - Describe where the VEPU121 name comes from, and list other encoders > > and decoders present in this SoC. > > - Properly test the device tree changes, I previously couldn’t since I > > was using a too recent version of python-jsonschema… > > > > Emmanuel Gil Peyrot (2): > > media: dt-binding: media: Document rk3588’s VEPU121 > > arm64: dts: rockchip: Add VEPU121 to rk3588 > > > > .../bindings/media/rockchip,rk3568-vepu.yaml | 8 +- > > arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 80 +++++++++++++++++++ > > 2 files changed, 86 insertions(+), 2 deletions(-) > > > -- Link Mauve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C64B1CD11C2 for ; Fri, 5 Apr 2024 14:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cd3wL3tnxHx5L7arh/pUr3XliUlyJpxTHID7AN80sv8=; b=2mIuVLMz2hwDWc W9ZYT2g4+uZwjptO7NtrVeIbB8P9AFV8ojKzEpu+rx3A72mrCbHq08QW8KcmLtWfkEqBIecNf52cD XHT8deCYSIBtlmduAnrOTeNgxoGjySYruJaOXxV+XOwe+Mc/Ej6N54hDQKfec5gCARVNBGbUjGFJq PqlMDJii2NodnRTqKhO5wupw7BIelaPplqYc9w2Kh0EilY+EyfHUf2M9ipRTQzSzRa/JITk/NU/e5 TwXJP+IHXZ7tuXE+fckumRk/V0pCBrz23E9vrx0eZNeF62Kbhy5nrnXpQulh61LKfVO5cQKLkSylW edFeE/GskhMZKDUzBL+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rskRq-00000007Qvg-1ZJB; Fri, 05 Apr 2024 14:21:42 +0000 Received: from luna.linkmauve.fr ([82.65.109.163]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rskRl-00000007Qtp-3Ge9; Fri, 05 Apr 2024 14:21:39 +0000 Received: by luna.linkmauve.fr (Postfix, from userid 1000) id BA81A106966F; Fri, 5 Apr 2024 16:21:30 +0200 (CEST) Date: Fri, 5 Apr 2024 16:21:30 +0200 From: Link Mauve To: Nicolas Dufresne Cc: Emmanuel Gil Peyrot , linux-kernel@vger.kernel.org, Ezequiel Garcia , Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Joerg Roedel , Will Deacon , Robin Murphy , Sebastian Reichel , Cristian Ciocaltea , Dragan Simic , Shreeya Patel , Chris Morgan , Andy Yan , Nicolas Frattaroli , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev Subject: Re: [PATCH v2 0/2] Enable JPEG encoding on rk3588 Message-ID: References: <20240327134115.424846-1-linkmauve@linkmauve.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Jabber-ID: linkmauve@linkmauve.fr X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_072138_070154_18E1E012 X-CRM114-Status: GOOD ( 38.23 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMDQsIDIwMjQgYXQgMDE6NDE6MTVQTSAtMDQwMCwgTmljb2xhcyBEdWZyZXNu ZSB3cm90ZToKPiBIaSwKCkhpLAoKPiAKPiBMZSBtZXJjcmVkaSAyNyBtYXJzIDIwMjQgw6AgMTQ6 NDEgKzAxMDAsIEVtbWFudWVsIEdpbCBQZXlyb3QgYSDDqWNyaXTCoDoKPiA+IE9ubHkgdGhlIEpQ RUcgZW5jb2RlciBpcyBhdmFpbGFibGUgZm9yIG5vdywgYWx0aG91Z2ggdGhlcmUgYXJlIHBhdGNo ZXMKPiA+IGZvciB0aGUgdW5kb2N1bWVudGVkIFZQOCBlbmNvZGVyIGZsb2F0aW5nIGFyb3VuZFsw XS4KPiAKPiBbMF0gc2VlbXMgbGlrZSBhIGJyb2tlbiBsaW5rLiBUaGUgVlA4IGVuY29kZXIgUkZD IGlzIGZvciBSSzMzOTkgKGFuZCBIYW50cm8gSDEKPiBwb3N0ZWQgYnkgU1QgbW9yZSByZWNlbnRs eSkuIFRoZSBUUk0gc2F5cyAiVkVQVTEyMShKUEVHIGVuY29kZXIgb25seSkiLCB3aGljaAo+IHN1 Z2dlc3QgdGhhdCB0aGUgSC4yNjQgYW5kIFZQOCBlbmNvZGVycyB1c3VhbGx5IGZvdW5kIG9uIHRo ZSBWRVBVMTIxIGFyZQo+IHJlbW92ZWQuIEFzIFJvY2tjaGlwIGhhdmUgcmVtb3ZlIHRoZSBzeW50 aGVzaXplIHJlZ2lzdGVyIHdoaWxlIG1vZGlmeWluZyB0aGUgSDEKPiBJUCwgaXQgaXMgZGlmZmlj dWx0IHRvIHZlcmlmeS4gQ29uZnVzaW5nbHkgdGhlIEguMjY0IHNwZWNpZmljIHJlZ2lzdGVycyBh cmUKPiBkb2N1bWVudGVkIGluIHRoZSBUUk0gYXJvdW5kIFZFUFUxMjEuCgpBaCwgdGhlIGxpbmsg YmVjYW1lLCBhbmQgd2FzIGluZGVlZCBTVOKAmXMgc2VyaWVzOgpodHRwczovL3BhdGNod29yay5r ZXJuZWwub3JnL3Byb2plY3QvbGludXgtcm9ja2NoaXAvbGlzdC8/c2VyaWVzPTc4OTg4NSZhcmNo aXZlPWJvdGgKCkJ1dCB0aGUgVFJNIHBhcnQgMSBzYXlzIHRoZSBWRVBVMTIxIHN1cHBvcnRzIEgu MjY0IGVuY29kaW5nIChwYWdlIDM2NyksCmFuZCBpdOKAmXMgbGlrZWx5IHRoZXkgZGlkbuKAmXQg cmVtb3ZlIGp1c3QgVlA4IHN1cHBvcnQgc2luY2UgdGhlIGNvZGVjCmZlYXR1cmVzIGFyZSBwcmV0 dHkgY2xvc2UgdG8gSC4yNjTigJlzLgoKPiAKPiA+IAo+ID4gVGhpcyBoYXMgYmVlbiB0ZXN0ZWQg b24gYSByb2NrLTViLCByZXN1bHRpbmcgaW4gZm91ciAvZGV2L3ZpZGVvKgo+ID4gZW5jb2RlcnMu ICBUaGUgdXNlcnNwYWNlIHByb2dyYW0gSeKAmXZlIGJlZW4gdXNpbmcgdG8gdGVzdCB0aGVtIGlz Cj4gPiBPbml4WzFdLCB1c2luZyB0aGUganBlZy1lbmNvZGVyIGV4YW1wbGUsIGl0IHdpbGwgcGlj ayBvbmUgb2YgdGhlc2UgZm91cgo+ID4gYXQgcmFuZG9tIChidXQgZGlzcGxheXMgdGhlIG9uZSBp dCBwaWNrZWQpOgo+ID4gJSBmZm1wZWcgLWkgPGlucHV0IGltYWdlPiAtcGl4X2ZtdCB5dXZqNDIw cCB0ZW1wLnl1dgo+ID4gJSBqcGVnLWVuY29kZXIgdGVtcC55dXYgPHdpZHRoPiA8aGVpZ2h0PiBO VjEyIDxxdWFsaXR5PiBvdXRwdXQuanBlZwo+IAo+IEkgZG9uJ3QgbGlrZSB0aGF0IHdlIGV4cG9z aW5nIGVhY2ggaWRlbnRpY2FsIGNvcmVzIGEgc2VwYXJhdGUgdmlkZW8gbm9kZXMuIEkKPiB0aGlu ayB3ZSBzaG91bGQgYWltIGZvciAxIGRldmljZSwgYW5kIHRoZW4gbXVsdGktcGxleCBhbmQgc2No ZWR1bGUgZGUgY29yZXMgZnJvbQo+IGluc2lkZSB0aGUgTGludXgga2VybmVsLgoKSSBhZ3JlZSwg YnV0IHRoaXMgc2hvdWxkIGJlIGhhbmRsZWQgaW4gdGhlIGRyaXZlciBub3QgaW4gdGhlIGRldmlj ZQp0cmVlLCBhbmQgaXQgY2FuIGJlIGRvbmUgbGF0ZXIuCgo+IAo+IE5vdCBkb2luZyB0aGlzIG5v dyBtZWFucyB3ZSdsbCBuZXZlciBoYXZlIGFuIG9wdGltYWwgaGFyZHdhcmUgdXNhZ2UKPiBkaXN0 cmlidXRpb24uIEp1c3QgY29uc2lkZXIgdHdvIHVzZXJzcGFjZSBzb2Z0d2FyZSB3YW50aW5nIHRv IGRvIGpwZWcgZW5jb2RpbmcuCj4gSWYgdGhleSBib3RoIHRha2UgYSBndWVzcywgdGhleSBtYXkg ZW5kdXAgdXNpbmcgYSBzaW5nbGUgY29yZS4gV2hlcmUgd2l0aCBwcm9wZXIKPiBzY2hlZHVsaW5n IGluIFY0TDIsIHRoZSBrZXJuZWwgd2lsbCBiZSBhYmxlIHRvIHByb3Blcmx5IGRpc3RyaWJ1dGUg dGhlIGxvYWQuIEkKPiBpbnNpc3Qgb24gdGhpcywgc2luY2UgaWYgd2UgbWVyZ2UgeW91IGNoYW5n ZXMgaXQgYmVjb21lcyBhbiBBQkkgYW5kIHdlIGNhbid0Cj4gY2hhbmdlIGl0IGFueW1vcmUuCgpX aWxsIGl0IHJlYWxseSBiZWNvbWUgQUJJIGp1c3QgbGlrZSB0aGF0PyAgVXNlcnNwYWNlIHNob3Vs ZCBhbHdheXMKZGlzY292ZXIgdGhlIHZpZGVvIG5vZGVzIGFuZCB0aGVpciBjYXBhYmlsaXRpZXMg YW5kIG5vdCBoYXJkY29kZSBlLmcuIGEKc3BlY2lmaWMgL2Rldi92aWRlb04gZmlsZSBmb3IgYSBz cGVjaWZpYyBjb2RlYy4gIEkgd291bGQgYXJndWUgdGhhdCB0aGlzCnNlcmllcyB3b3VsZCBsZXQg dXNlcnNwYWNlIGRvIEpQRUcgZW5jb2RpbmcgcmlnaHQgYXdheSwgZXZlbiBpZiBpbiBhCmxlc3Mg b3B0aW1hbCB3YXkgdGhhbiBpZiB0aGUgZHJpdmVyIHdvdWxkIHJvdW5kLXJvYmluIHRoZW0gdGhy b3VnaCBhCnNpbmdsZSB2aWRlbyBub2RlLCBidXQgdGhhdCBjYW4gYWx3YXlzIGJlIGFkZGVkIGlu IGEgZnV0dXJlIHZlcnNpb24uCgo+IAo+IEkgdW5kZXJzdGFuZCB0aGF0IHRoaXMgaW1wb3NlIGEg cmV3b3JrIG9mIHRoZSBtZW0ybWVtIGZyYW1ld29yayBzbyB0aGF0IHdlIGNhbgo+IHJ1biBtdWx0 aXBsZSBqb2JzLCBidXQgdGhpcyB3aWxsIGJlIG5lZWRlZCBhbnl3YXkgb24gUkszNTg4LCBzaW5j ZSB0aGUgcmt2ZGVjMiwKPiB3aGljaCB3ZSBkb24ndCBoYXZlIGEgZHJpdmVyIHlldCBpcyBhbHNv IG11bHRpLWNvcmUsIGJ1dCB5b3UgbmVlZCB0byB1c2UgMiBjb3Jlcwo+IHdoZW4gdGhlIHJlc29s dXRpb24gaXMgY2xvc2UgdG8gOEsuCgpJIHRoaW5rIHRoZSBtZWRpYXRlayBKUEVHIGRyaXZlciBh bHJlYWR5IHN1cHBvcnRzIHRoYXQsIHdvdWxkIGl0IGJlIG9rCnRvIGRvIGl0IHRoZSBzYW1lIHdh eT8KCj4gCj4gTmljb2xhcwo+IAo+ID4gCj4gPiBbMF0gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVs Lm9yZy9wcm9qZWN0L2xpbnV4LXJvY2tjaGlwL2xpc3QvP3Nlcmllcz03ODk4ODUKPiA+IFsxXSBo dHRwczovL2NyYXRlcy5pby9jcmF0ZXMvb25peAo+ID4gCj4gPiBDaGFuZ2VzIHNpbmNlIHYxOgo+ ID4gLSBEcm9wcGVkIHBhdGNoZXMgMSBhbmQgNC4KPiA+IC0gVXNlIHRoZSBwcm9wZXIgY29tcGF0 aWJsZSBmb3JtLCBzaW5jZSB0aGlzIGRldmljZSBzaG91bGQgYmUgZnVsbHkKPiA+ICAgY29tcGF0 aWJsZSB3aXRoIHRoZSBWRVBVIG9mIHJrMzU2eC4KPiA+IC0gRGVzY3JpYmUgd2hlcmUgdGhlIFZF UFUxMjEgbmFtZSBjb21lcyBmcm9tLCBhbmQgbGlzdCBvdGhlciBlbmNvZGVycwo+ID4gICBhbmQg ZGVjb2RlcnMgcHJlc2VudCBpbiB0aGlzIFNvQy4KPiA+IC0gUHJvcGVybHkgdGVzdCB0aGUgZGV2 aWNlIHRyZWUgY2hhbmdlcywgSSBwcmV2aW91c2x5IGNvdWxkbuKAmXQgc2luY2UgSQo+ID4gICB3 YXMgdXNpbmcgYSB0b28gcmVjZW50IHZlcnNpb24gb2YgcHl0aG9uLWpzb25zY2hlbWHigKYKPiA+ IAo+ID4gRW1tYW51ZWwgR2lsIFBleXJvdCAoMik6Cj4gPiAgIG1lZGlhOiBkdC1iaW5kaW5nOiBt ZWRpYTogRG9jdW1lbnQgcmszNTg44oCZcyBWRVBVMTIxCj4gPiAgIGFybTY0OiBkdHM6IHJvY2tj aGlwOiBBZGQgVkVQVTEyMSB0byByazM1ODgKPiA+IAo+ID4gIC4uLi9iaW5kaW5ncy9tZWRpYS9y b2NrY2hpcCxyazM1NjgtdmVwdS55YW1sICB8ICA4ICstCj4gPiAgYXJjaC9hcm02NC9ib290L2R0 cy9yb2NrY2hpcC9yazM1ODhzLmR0c2kgICAgIHwgODAgKysrKysrKysrKysrKysrKysrKwo+ID4g IDIgZmlsZXMgY2hhbmdlZCwgODYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+IAo+ IAoKLS0gCkxpbmsgTWF1dmUKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFB02C67861 for ; Fri, 5 Apr 2024 14:21:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9MYKlNA4nIiqnt5atRkSIXmGjG3AldW65c9hVqhcnFg=; b=sh3rw71iUQMboG djctJ9sCNZZByywqBgWSNzJv1Na/xPpvCfmp+XwDtQeLTDvd9rKsTpMQdkzQEOigz6ghxV12pJhUS 8wleFgEXMhtg+++Lbxd7ZyAys7l5BknTH7EcJCMUXLfg4QN5G639qwQAOE6NYmz625wCEFvel6HvU sRdK0PhA3lLE9w/B876FGKL4Q4ZH5XMw6kxWnHGOycdftmU6eCArs+s/dt4XYjcr4ZOjkcElh135r qTK5dvPaxC15oZ8sU4z23WsX00sogW2p+tBd4cAVQmOQ5s6A6cUCw+4ZtnnNBd5sL9xL7QwLqytAc 1Nz8eXg31y4c092jnyyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rskRp-00000007QvH-1oqV; Fri, 05 Apr 2024 14:21:41 +0000 Received: from luna.linkmauve.fr ([82.65.109.163]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rskRl-00000007Qtp-3Ge9; Fri, 05 Apr 2024 14:21:39 +0000 Received: by luna.linkmauve.fr (Postfix, from userid 1000) id BA81A106966F; Fri, 5 Apr 2024 16:21:30 +0200 (CEST) Date: Fri, 5 Apr 2024 16:21:30 +0200 From: Link Mauve To: Nicolas Dufresne Cc: Emmanuel Gil Peyrot , linux-kernel@vger.kernel.org, Ezequiel Garcia , Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Joerg Roedel , Will Deacon , Robin Murphy , Sebastian Reichel , Cristian Ciocaltea , Dragan Simic , Shreeya Patel , Chris Morgan , Andy Yan , Nicolas Frattaroli , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev Subject: Re: [PATCH v2 0/2] Enable JPEG encoding on rk3588 Message-ID: References: <20240327134115.424846-1-linkmauve@linkmauve.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Jabber-ID: linkmauve@linkmauve.fr X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_072138_070154_18E1E012 X-CRM114-Status: GOOD ( 38.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMDQsIDIwMjQgYXQgMDE6NDE6MTVQTSAtMDQwMCwgTmljb2xhcyBEdWZyZXNu ZSB3cm90ZToKPiBIaSwKCkhpLAoKPiAKPiBMZSBtZXJjcmVkaSAyNyBtYXJzIDIwMjQgw6AgMTQ6 NDEgKzAxMDAsIEVtbWFudWVsIEdpbCBQZXlyb3QgYSDDqWNyaXTCoDoKPiA+IE9ubHkgdGhlIEpQ RUcgZW5jb2RlciBpcyBhdmFpbGFibGUgZm9yIG5vdywgYWx0aG91Z2ggdGhlcmUgYXJlIHBhdGNo ZXMKPiA+IGZvciB0aGUgdW5kb2N1bWVudGVkIFZQOCBlbmNvZGVyIGZsb2F0aW5nIGFyb3VuZFsw XS4KPiAKPiBbMF0gc2VlbXMgbGlrZSBhIGJyb2tlbiBsaW5rLiBUaGUgVlA4IGVuY29kZXIgUkZD IGlzIGZvciBSSzMzOTkgKGFuZCBIYW50cm8gSDEKPiBwb3N0ZWQgYnkgU1QgbW9yZSByZWNlbnRs eSkuIFRoZSBUUk0gc2F5cyAiVkVQVTEyMShKUEVHIGVuY29kZXIgb25seSkiLCB3aGljaAo+IHN1 Z2dlc3QgdGhhdCB0aGUgSC4yNjQgYW5kIFZQOCBlbmNvZGVycyB1c3VhbGx5IGZvdW5kIG9uIHRo ZSBWRVBVMTIxIGFyZQo+IHJlbW92ZWQuIEFzIFJvY2tjaGlwIGhhdmUgcmVtb3ZlIHRoZSBzeW50 aGVzaXplIHJlZ2lzdGVyIHdoaWxlIG1vZGlmeWluZyB0aGUgSDEKPiBJUCwgaXQgaXMgZGlmZmlj dWx0IHRvIHZlcmlmeS4gQ29uZnVzaW5nbHkgdGhlIEguMjY0IHNwZWNpZmljIHJlZ2lzdGVycyBh cmUKPiBkb2N1bWVudGVkIGluIHRoZSBUUk0gYXJvdW5kIFZFUFUxMjEuCgpBaCwgdGhlIGxpbmsg YmVjYW1lLCBhbmQgd2FzIGluZGVlZCBTVOKAmXMgc2VyaWVzOgpodHRwczovL3BhdGNod29yay5r ZXJuZWwub3JnL3Byb2plY3QvbGludXgtcm9ja2NoaXAvbGlzdC8/c2VyaWVzPTc4OTg4NSZhcmNo aXZlPWJvdGgKCkJ1dCB0aGUgVFJNIHBhcnQgMSBzYXlzIHRoZSBWRVBVMTIxIHN1cHBvcnRzIEgu MjY0IGVuY29kaW5nIChwYWdlIDM2NyksCmFuZCBpdOKAmXMgbGlrZWx5IHRoZXkgZGlkbuKAmXQg cmVtb3ZlIGp1c3QgVlA4IHN1cHBvcnQgc2luY2UgdGhlIGNvZGVjCmZlYXR1cmVzIGFyZSBwcmV0 dHkgY2xvc2UgdG8gSC4yNjTigJlzLgoKPiAKPiA+IAo+ID4gVGhpcyBoYXMgYmVlbiB0ZXN0ZWQg b24gYSByb2NrLTViLCByZXN1bHRpbmcgaW4gZm91ciAvZGV2L3ZpZGVvKgo+ID4gZW5jb2RlcnMu ICBUaGUgdXNlcnNwYWNlIHByb2dyYW0gSeKAmXZlIGJlZW4gdXNpbmcgdG8gdGVzdCB0aGVtIGlz Cj4gPiBPbml4WzFdLCB1c2luZyB0aGUganBlZy1lbmNvZGVyIGV4YW1wbGUsIGl0IHdpbGwgcGlj ayBvbmUgb2YgdGhlc2UgZm91cgo+ID4gYXQgcmFuZG9tIChidXQgZGlzcGxheXMgdGhlIG9uZSBp dCBwaWNrZWQpOgo+ID4gJSBmZm1wZWcgLWkgPGlucHV0IGltYWdlPiAtcGl4X2ZtdCB5dXZqNDIw cCB0ZW1wLnl1dgo+ID4gJSBqcGVnLWVuY29kZXIgdGVtcC55dXYgPHdpZHRoPiA8aGVpZ2h0PiBO VjEyIDxxdWFsaXR5PiBvdXRwdXQuanBlZwo+IAo+IEkgZG9uJ3QgbGlrZSB0aGF0IHdlIGV4cG9z aW5nIGVhY2ggaWRlbnRpY2FsIGNvcmVzIGEgc2VwYXJhdGUgdmlkZW8gbm9kZXMuIEkKPiB0aGlu ayB3ZSBzaG91bGQgYWltIGZvciAxIGRldmljZSwgYW5kIHRoZW4gbXVsdGktcGxleCBhbmQgc2No ZWR1bGUgZGUgY29yZXMgZnJvbQo+IGluc2lkZSB0aGUgTGludXgga2VybmVsLgoKSSBhZ3JlZSwg YnV0IHRoaXMgc2hvdWxkIGJlIGhhbmRsZWQgaW4gdGhlIGRyaXZlciBub3QgaW4gdGhlIGRldmlj ZQp0cmVlLCBhbmQgaXQgY2FuIGJlIGRvbmUgbGF0ZXIuCgo+IAo+IE5vdCBkb2luZyB0aGlzIG5v dyBtZWFucyB3ZSdsbCBuZXZlciBoYXZlIGFuIG9wdGltYWwgaGFyZHdhcmUgdXNhZ2UKPiBkaXN0 cmlidXRpb24uIEp1c3QgY29uc2lkZXIgdHdvIHVzZXJzcGFjZSBzb2Z0d2FyZSB3YW50aW5nIHRv IGRvIGpwZWcgZW5jb2RpbmcuCj4gSWYgdGhleSBib3RoIHRha2UgYSBndWVzcywgdGhleSBtYXkg ZW5kdXAgdXNpbmcgYSBzaW5nbGUgY29yZS4gV2hlcmUgd2l0aCBwcm9wZXIKPiBzY2hlZHVsaW5n IGluIFY0TDIsIHRoZSBrZXJuZWwgd2lsbCBiZSBhYmxlIHRvIHByb3Blcmx5IGRpc3RyaWJ1dGUg dGhlIGxvYWQuIEkKPiBpbnNpc3Qgb24gdGhpcywgc2luY2UgaWYgd2UgbWVyZ2UgeW91IGNoYW5n ZXMgaXQgYmVjb21lcyBhbiBBQkkgYW5kIHdlIGNhbid0Cj4gY2hhbmdlIGl0IGFueW1vcmUuCgpX aWxsIGl0IHJlYWxseSBiZWNvbWUgQUJJIGp1c3QgbGlrZSB0aGF0PyAgVXNlcnNwYWNlIHNob3Vs ZCBhbHdheXMKZGlzY292ZXIgdGhlIHZpZGVvIG5vZGVzIGFuZCB0aGVpciBjYXBhYmlsaXRpZXMg YW5kIG5vdCBoYXJkY29kZSBlLmcuIGEKc3BlY2lmaWMgL2Rldi92aWRlb04gZmlsZSBmb3IgYSBz cGVjaWZpYyBjb2RlYy4gIEkgd291bGQgYXJndWUgdGhhdCB0aGlzCnNlcmllcyB3b3VsZCBsZXQg dXNlcnNwYWNlIGRvIEpQRUcgZW5jb2RpbmcgcmlnaHQgYXdheSwgZXZlbiBpZiBpbiBhCmxlc3Mg b3B0aW1hbCB3YXkgdGhhbiBpZiB0aGUgZHJpdmVyIHdvdWxkIHJvdW5kLXJvYmluIHRoZW0gdGhy b3VnaCBhCnNpbmdsZSB2aWRlbyBub2RlLCBidXQgdGhhdCBjYW4gYWx3YXlzIGJlIGFkZGVkIGlu IGEgZnV0dXJlIHZlcnNpb24uCgo+IAo+IEkgdW5kZXJzdGFuZCB0aGF0IHRoaXMgaW1wb3NlIGEg cmV3b3JrIG9mIHRoZSBtZW0ybWVtIGZyYW1ld29yayBzbyB0aGF0IHdlIGNhbgo+IHJ1biBtdWx0 aXBsZSBqb2JzLCBidXQgdGhpcyB3aWxsIGJlIG5lZWRlZCBhbnl3YXkgb24gUkszNTg4LCBzaW5j ZSB0aGUgcmt2ZGVjMiwKPiB3aGljaCB3ZSBkb24ndCBoYXZlIGEgZHJpdmVyIHlldCBpcyBhbHNv IG11bHRpLWNvcmUsIGJ1dCB5b3UgbmVlZCB0byB1c2UgMiBjb3Jlcwo+IHdoZW4gdGhlIHJlc29s dXRpb24gaXMgY2xvc2UgdG8gOEsuCgpJIHRoaW5rIHRoZSBtZWRpYXRlayBKUEVHIGRyaXZlciBh bHJlYWR5IHN1cHBvcnRzIHRoYXQsIHdvdWxkIGl0IGJlIG9rCnRvIGRvIGl0IHRoZSBzYW1lIHdh eT8KCj4gCj4gTmljb2xhcwo+IAo+ID4gCj4gPiBbMF0gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVs Lm9yZy9wcm9qZWN0L2xpbnV4LXJvY2tjaGlwL2xpc3QvP3Nlcmllcz03ODk4ODUKPiA+IFsxXSBo dHRwczovL2NyYXRlcy5pby9jcmF0ZXMvb25peAo+ID4gCj4gPiBDaGFuZ2VzIHNpbmNlIHYxOgo+ ID4gLSBEcm9wcGVkIHBhdGNoZXMgMSBhbmQgNC4KPiA+IC0gVXNlIHRoZSBwcm9wZXIgY29tcGF0 aWJsZSBmb3JtLCBzaW5jZSB0aGlzIGRldmljZSBzaG91bGQgYmUgZnVsbHkKPiA+ICAgY29tcGF0 aWJsZSB3aXRoIHRoZSBWRVBVIG9mIHJrMzU2eC4KPiA+IC0gRGVzY3JpYmUgd2hlcmUgdGhlIFZF UFUxMjEgbmFtZSBjb21lcyBmcm9tLCBhbmQgbGlzdCBvdGhlciBlbmNvZGVycwo+ID4gICBhbmQg ZGVjb2RlcnMgcHJlc2VudCBpbiB0aGlzIFNvQy4KPiA+IC0gUHJvcGVybHkgdGVzdCB0aGUgZGV2 aWNlIHRyZWUgY2hhbmdlcywgSSBwcmV2aW91c2x5IGNvdWxkbuKAmXQgc2luY2UgSQo+ID4gICB3 YXMgdXNpbmcgYSB0b28gcmVjZW50IHZlcnNpb24gb2YgcHl0aG9uLWpzb25zY2hlbWHigKYKPiA+ IAo+ID4gRW1tYW51ZWwgR2lsIFBleXJvdCAoMik6Cj4gPiAgIG1lZGlhOiBkdC1iaW5kaW5nOiBt ZWRpYTogRG9jdW1lbnQgcmszNTg44oCZcyBWRVBVMTIxCj4gPiAgIGFybTY0OiBkdHM6IHJvY2tj aGlwOiBBZGQgVkVQVTEyMSB0byByazM1ODgKPiA+IAo+ID4gIC4uLi9iaW5kaW5ncy9tZWRpYS9y b2NrY2hpcCxyazM1NjgtdmVwdS55YW1sICB8ICA4ICstCj4gPiAgYXJjaC9hcm02NC9ib290L2R0 cy9yb2NrY2hpcC9yazM1ODhzLmR0c2kgICAgIHwgODAgKysrKysrKysrKysrKysrKysrKwo+ID4g IDIgZmlsZXMgY2hhbmdlZCwgODYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+IAo+ IAoKLS0gCkxpbmsgTWF1dmUKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK