From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94D426AB6; Fri, 5 Apr 2024 16:44:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712335453; cv=none; b=pCpgvIaBeYY5yEFOdUFFQwk7Q8iOF+WBSpFRMvJi5g/jJ9l0P/dTSmvIQ+LhqfFUsT5tmUeXS7DIPlE6Wq5y3YIQI+LVUxIsTCj/xl3w35U+xlEyHzjD4/Hsc6ltLAqf5VW9wvNcd/ilDQY+baZX8KMXlauWFU/CMKC6Fqu2FOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712335453; c=relaxed/simple; bh=ViaSMrZIPCzmKnR3iMx+cq3XI+FjdW5BQMMi7XeiIVU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LCwfxF/Qjbe/IxAixnDy8K6wbLIjykxBAYUK06MnnOSuVnnPlbiDodAZAKYStPAvzRIBflIovGFsUAcy37yRfrKbD4z4R61ROPQRaUxlPR/oZgiqMwFuYXHRXg+xc6hGK+Va7FszeTrd5EZ+iF8/hhVK41GP5nLMi3+xMsG/T+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Hd8ozYRU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Hd8ozYRU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31107C433F1; Fri, 5 Apr 2024 16:44:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712335453; bh=ViaSMrZIPCzmKnR3iMx+cq3XI+FjdW5BQMMi7XeiIVU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hd8ozYRUncFrTzLH+SmJ/vF3tOrvsD6NvHIFf9fb2ANT6bBktVoawIFjRGqjL2JOL 69l3TrB0IA0gzVGKKqdPSjG09Fd23/P14KhVr9CmEL7i81CiiwvJKNYsDpQ5x4O57h 4stJUsyJ3THA0LbFLhqY3dkVTatUGzD5FQoQ0yCRQABMI3rgIvmmnO8JHfU51XiNdJ sFEPtTEZfT6hWD0v/Q4bFOXWV2VNWwEID21JBshgiyEtBsSxe2o8Kl3mpPv21yqVto ep9zzo0HvKAzvVWTGAfnbaUJmnDoVhOUyPmeYHw0iS/av7Pswk6cOC54mUx5KUyI2R 3QIyTyTQ8ucGw== Date: Fri, 5 Apr 2024 22:14:09 +0530 From: Vinod Koul To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Kishon Vijay Abraham I , Philipp Zabel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH v4 08/18] phy: ti: phy-j721e-wiz: add resume support Message-ID: References: <20240102-j7200-pcie-s2r-v4-0-6f1f53390c85@bootlin.com> <20240102-j7200-pcie-s2r-v4-8-6f1f53390c85@bootlin.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240102-j7200-pcie-s2r-v4-8-6f1f53390c85@bootlin.com> On 04-03-24, 16:35, Thomas Richard wrote: > Add resume support. > It has been tested on J7200 SR1.0 and SR2.0. > > Co-developed-by: Théo Lebrun > Signed-off-by: Théo Lebrun > Signed-off-by: Thomas Richard > --- > drivers/phy/ti/phy-j721e-wiz.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c > index 0e3cb1ed5a52..b2320f2efb72 100644 > --- a/drivers/phy/ti/phy-j721e-wiz.c > +++ b/drivers/phy/ti/phy-j721e-wiz.c > @@ -1660,12 +1660,41 @@ static void wiz_remove(struct platform_device *pdev) > pm_runtime_disable(dev); > } > > +static int wiz_resume_noirq(struct device *dev) I think this should be annotated with __maybe_unused > +{ > + struct device_node *node = dev->of_node; > + struct wiz *wiz = dev_get_drvdata(dev); > + int ret; > + > + /* Enable supplemental Control override if available */ > + if (wiz->sup_legacy_clk_override) > + regmap_field_write(wiz->sup_legacy_clk_override, 1); > + > + wiz_clock_init(wiz); > + > + ret = wiz_init(wiz); > + if (ret) { > + dev_err(dev, "WIZ initialization failed\n"); > + goto err_wiz_init; > + } > + > + return 0; > + > +err_wiz_init: > + wiz_clock_cleanup(wiz, node); > + > + return ret; > +} > + > +static DEFINE_NOIRQ_DEV_PM_OPS(wiz_pm_ops, NULL, wiz_resume_noirq); > + > static struct platform_driver wiz_driver = { > .probe = wiz_probe, > .remove_new = wiz_remove, > .driver = { > .name = "wiz", > .of_match_table = wiz_id_table, > + .pm = pm_sleep_ptr(&wiz_pm_ops), > }, > }; > module_platform_driver(wiz_driver); > > -- > 2.39.2 -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D80FEC67861 for ; Fri, 5 Apr 2024 16:44:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=brXSFtDiMnSeEhI8oumnaxfX7w16aAB0DdTxCA6wvLA=; b=Jg34Bpnp1ZRIJC O6bE5wpd6cAR0WsffAv2y8mo/FX5dOJai+wvex6azKyAER2djuvjJAKfnKwesRVIhxAhHxUyZ/a9w OhhgVxvtyis0Ws91al74Svz+Trq/twEw/Iless7MzJnzNSoSGQ74ty1iGbqet3AZRWME+4wHMHjYs tr1293f1Mg8hUdMImVuT27YvACl8fC0Xt4eKQSAvoAnFu7CFuKLeYwiKV0m8m8IW8rNW8u4JIaRPZ ZCj9DoGpsKwYmAxrcqpYmQ+dq3dnjR3U8B8de3viM8i2281zk8U8y6p1ZrfU98FfH6jAaA2QfaIHf EOTGQT0R8e657LuwOb3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsmfr-000000083P3-1nNc; Fri, 05 Apr 2024 16:44:19 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsmfm-000000083NX-0ZmA; Fri, 05 Apr 2024 16:44:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 57A6B61788; Fri, 5 Apr 2024 16:44:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31107C433F1; Fri, 5 Apr 2024 16:44:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712335453; bh=ViaSMrZIPCzmKnR3iMx+cq3XI+FjdW5BQMMi7XeiIVU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hd8ozYRUncFrTzLH+SmJ/vF3tOrvsD6NvHIFf9fb2ANT6bBktVoawIFjRGqjL2JOL 69l3TrB0IA0gzVGKKqdPSjG09Fd23/P14KhVr9CmEL7i81CiiwvJKNYsDpQ5x4O57h 4stJUsyJ3THA0LbFLhqY3dkVTatUGzD5FQoQ0yCRQABMI3rgIvmmnO8JHfU51XiNdJ sFEPtTEZfT6hWD0v/Q4bFOXWV2VNWwEID21JBshgiyEtBsSxe2o8Kl3mpPv21yqVto ep9zzo0HvKAzvVWTGAfnbaUJmnDoVhOUyPmeYHw0iS/av7Pswk6cOC54mUx5KUyI2R 3QIyTyTQ8ucGw== Date: Fri, 5 Apr 2024 22:14:09 +0530 From: Vinod Koul To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Kishon Vijay Abraham I , Philipp Zabel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH v4 08/18] phy: ti: phy-j721e-wiz: add resume support Message-ID: References: <20240102-j7200-pcie-s2r-v4-0-6f1f53390c85@bootlin.com> <20240102-j7200-pcie-s2r-v4-8-6f1f53390c85@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240102-j7200-pcie-s2r-v4-8-6f1f53390c85@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_094414_307934_D709053E X-CRM114-Status: GOOD ( 20.96 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 04-03-24, 16:35, Thomas Richard wrote: > Add resume support. > It has been tested on J7200 SR1.0 and SR2.0. > = > Co-developed-by: Th=E9o Lebrun > Signed-off-by: Th=E9o Lebrun > Signed-off-by: Thomas Richard > --- > drivers/phy/ti/phy-j721e-wiz.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > = > diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wi= z.c > index 0e3cb1ed5a52..b2320f2efb72 100644 > --- a/drivers/phy/ti/phy-j721e-wiz.c > +++ b/drivers/phy/ti/phy-j721e-wiz.c > @@ -1660,12 +1660,41 @@ static void wiz_remove(struct platform_device *pd= ev) > pm_runtime_disable(dev); > } > = > +static int wiz_resume_noirq(struct device *dev) I think this should be annotated with __maybe_unused > +{ > + struct device_node *node =3D dev->of_node; > + struct wiz *wiz =3D dev_get_drvdata(dev); > + int ret; > + > + /* Enable supplemental Control override if available */ > + if (wiz->sup_legacy_clk_override) > + regmap_field_write(wiz->sup_legacy_clk_override, 1); > + > + wiz_clock_init(wiz); > + > + ret =3D wiz_init(wiz); > + if (ret) { > + dev_err(dev, "WIZ initialization failed\n"); > + goto err_wiz_init; > + } > + > + return 0; > + > +err_wiz_init: > + wiz_clock_cleanup(wiz, node); > + > + return ret; > +} > + > +static DEFINE_NOIRQ_DEV_PM_OPS(wiz_pm_ops, NULL, wiz_resume_noirq); > + > static struct platform_driver wiz_driver =3D { > .probe =3D wiz_probe, > .remove_new =3D wiz_remove, > .driver =3D { > .name =3D "wiz", > .of_match_table =3D wiz_id_table, > + .pm =3D pm_sleep_ptr(&wiz_pm_ops), > }, > }; > module_platform_driver(wiz_driver); > = > -- = > 2.39.2 -- = ~Vinod -- = linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 707AEC67861 for ; Fri, 5 Apr 2024 16:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U1EBo6kuDXWyjaymqB5AfsT0C/iM+bJwW5GZuf1uetI=; b=EZEHCmZUF9QEgo A1OCtwIXwz09Msrm4ulSL5RaJuUhtr3LHtMnWDFPpNno4lrikMIkG9mJ972lN0hPh3MRNhShGNfVz X9/vHpoItPvvrrjFsJmHZphN0BfGDiX+D0D2rZv40zCwfDEPidtzG8NG0dYQe4xA0giunaTtLlLWf e6+xD6FJAtzs16VY8rjMT64klVmQ7MNi0zkCh6cTKXjIvdp8jOC336jyE1EeJ3c99WnqSahvWPOqH Zubxa9st+vy/w7yyxAE6CAZSdMh5tQOIjkcZcdzsPOuRfeNXbMx+ge7J+jcU4F5YuZ31Jz5SZUTJ2 aiYJUKljX/JY1CnsLKsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsmfp-000000083OI-3RMM; Fri, 05 Apr 2024 16:44:17 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsmfm-000000083NX-0ZmA; Fri, 05 Apr 2024 16:44:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 57A6B61788; Fri, 5 Apr 2024 16:44:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31107C433F1; Fri, 5 Apr 2024 16:44:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712335453; bh=ViaSMrZIPCzmKnR3iMx+cq3XI+FjdW5BQMMi7XeiIVU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hd8ozYRUncFrTzLH+SmJ/vF3tOrvsD6NvHIFf9fb2ANT6bBktVoawIFjRGqjL2JOL 69l3TrB0IA0gzVGKKqdPSjG09Fd23/P14KhVr9CmEL7i81CiiwvJKNYsDpQ5x4O57h 4stJUsyJ3THA0LbFLhqY3dkVTatUGzD5FQoQ0yCRQABMI3rgIvmmnO8JHfU51XiNdJ sFEPtTEZfT6hWD0v/Q4bFOXWV2VNWwEID21JBshgiyEtBsSxe2o8Kl3mpPv21yqVto ep9zzo0HvKAzvVWTGAfnbaUJmnDoVhOUyPmeYHw0iS/av7Pswk6cOC54mUx5KUyI2R 3QIyTyTQ8ucGw== Date: Fri, 5 Apr 2024 22:14:09 +0530 From: Vinod Koul To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Kishon Vijay Abraham I , Philipp Zabel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH v4 08/18] phy: ti: phy-j721e-wiz: add resume support Message-ID: References: <20240102-j7200-pcie-s2r-v4-0-6f1f53390c85@bootlin.com> <20240102-j7200-pcie-s2r-v4-8-6f1f53390c85@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240102-j7200-pcie-s2r-v4-8-6f1f53390c85@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_094414_307934_D709053E X-CRM114-Status: GOOD ( 20.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04-03-24, 16:35, Thomas Richard wrote: > Add resume support. > It has been tested on J7200 SR1.0 and SR2.0. > = > Co-developed-by: Th=E9o Lebrun > Signed-off-by: Th=E9o Lebrun > Signed-off-by: Thomas Richard > --- > drivers/phy/ti/phy-j721e-wiz.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > = > diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wi= z.c > index 0e3cb1ed5a52..b2320f2efb72 100644 > --- a/drivers/phy/ti/phy-j721e-wiz.c > +++ b/drivers/phy/ti/phy-j721e-wiz.c > @@ -1660,12 +1660,41 @@ static void wiz_remove(struct platform_device *pd= ev) > pm_runtime_disable(dev); > } > = > +static int wiz_resume_noirq(struct device *dev) I think this should be annotated with __maybe_unused > +{ > + struct device_node *node =3D dev->of_node; > + struct wiz *wiz =3D dev_get_drvdata(dev); > + int ret; > + > + /* Enable supplemental Control override if available */ > + if (wiz->sup_legacy_clk_override) > + regmap_field_write(wiz->sup_legacy_clk_override, 1); > + > + wiz_clock_init(wiz); > + > + ret =3D wiz_init(wiz); > + if (ret) { > + dev_err(dev, "WIZ initialization failed\n"); > + goto err_wiz_init; > + } > + > + return 0; > + > +err_wiz_init: > + wiz_clock_cleanup(wiz, node); > + > + return ret; > +} > + > +static DEFINE_NOIRQ_DEV_PM_OPS(wiz_pm_ops, NULL, wiz_resume_noirq); > + > static struct platform_driver wiz_driver =3D { > .probe =3D wiz_probe, > .remove_new =3D wiz_remove, > .driver =3D { > .name =3D "wiz", > .of_match_table =3D wiz_id_table, > + .pm =3D pm_sleep_ptr(&wiz_pm_ops), > }, > }; > module_platform_driver(wiz_driver); > = > -- = > 2.39.2 -- = ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel