All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/util-linux: add libxcrypt optional dependency
Date: Sun, 7 Apr 2024 10:51:02 +0200	[thread overview]
Message-ID: <ZhJedrcE8P6DpRjg@landeda> (raw)
In-Reply-To: <20240404210640.1926462-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2024-04-04 23:06 +0200, Fabrice Fontaine spake thusly:
> Fix the following build failures raised since bump of glibc to version
> 2.39 in commit b5680f53d60acf8ff6010082f873438a39bd5d97:
> 
> configure: error: newgrp selected, but required crypt function not available
> 
> [...]
> 
> configure: error: sulogin selected, but required crypt function not available
> 
> Fixes: b5680f53d60acf8ff6010082f873438a39bd5d97
>  - http://autobuild.buildroot.org/results/961cd1221adf9ef8bfaff25b212351d10769c369
>  - http://autobuild.buildroot.org/results/875a8d9ad76e844149d9a1c0c1983696e7313eff
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/util-linux/Config.in                          | 2 ++
>  package/util-linux/util-linux-libs/util-linux-libs.mk | 1 +
>  package/util-linux/util-linux.mk                      | 1 +
>  3 files changed, 4 insertions(+)
> 
> diff --git a/package/util-linux/Config.in b/package/util-linux/Config.in
> index 73fa11380e..1f5dacec2f 100644
> --- a/package/util-linux/Config.in
> +++ b/package/util-linux/Config.in
> @@ -280,6 +280,7 @@ config BR2_PACKAGE_UTIL_LINUX_MOUNTPOINT
>  
>  config BR2_PACKAGE_UTIL_LINUX_NEWGRP
>  	bool "newgrp"
> +	select BR2_PACKAGE_LIBXCRYPT if BR2_TOOLCHAIN_USES_GLIBC
>  	help
>  	  Log in to a new group
>  
> @@ -402,6 +403,7 @@ comment "su needs a uClibc or glibc toolchain w/ wchar, locale, dynamic library,
>  config BR2_PACKAGE_UTIL_LINUX_SULOGIN
>  	bool "sulogin"
>  	depends on BR2_USE_MMU # fork()
> +	select BR2_PACKAGE_LIBXCRYPT if BR2_TOOLCHAIN_USES_GLIBC
>  	help
>  	  Single-user login
>  
> diff --git a/package/util-linux/util-linux-libs/util-linux-libs.mk b/package/util-linux/util-linux-libs/util-linux-libs.mk
> index e1fe1ec191..0337e7e13a 100644
> --- a/package/util-linux/util-linux-libs/util-linux-libs.mk
> +++ b/package/util-linux/util-linux-libs/util-linux-libs.mk
> @@ -24,6 +24,7 @@ UTIL_LINUX_LIBS_LICENSE_FILES = README.licensing \
>  UTIL_LINUX_LIBS_INSTALL_STAGING = YES
>  UTIL_LINUX_LIBS_DEPENDENCIES = \
>  	host-pkgconf \
> +	$(if $(BR2_PACKAGE_LIBXCRYPT),libxcrypt) \
>  	$(TARGET_NLS_DEPENDENCIES)
>  UTIL_LINUX_LIBS_CONF_OPTS += \
>  	--disable-rpath \
> diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
> index a9e5b0bf68..f2821978c5 100644
> --- a/package/util-linux/util-linux.mk
> +++ b/package/util-linux/util-linux.mk
> @@ -37,6 +37,7 @@ UTIL_LINUX_AUTORECONF = YES
>  UTIL_LINUX_INSTALL_STAGING = YES
>  UTIL_LINUX_DEPENDENCIES = \
>  	host-pkgconf \
> +	$(if $(BR2_PACKAGE_LIBXCRYPT),libxcrypt) \
>  	$(if $(BR2_PACKAGE_UTIL_LINUX_LIBS),util-linux-libs) \
>  	$(TARGET_NLS_DEPENDENCIES)
>  UTIL_LINUX_CONF_OPTS += \
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-04-07  8:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04 21:06 [Buildroot] [PATCH 1/1] package/util-linux: add libxcrypt optional dependency Fabrice Fontaine
2024-04-07  8:51 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZhJedrcE8P6DpRjg@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.