All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dominique Martinet <asmadeus@codewreck.org>
To: Ian Rogers <irogers@google.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] perf parse: Allow names to start with digits
Date: Mon, 8 Apr 2024 21:49:20 +0900	[thread overview]
Message-ID: <ZhPn0EwXf_bPBj-p@codewreck.org> (raw)
In-Reply-To: <CAP-5=fWT4=yT9rxKmR4ing9i-EffRQnjTP355wU-fFN1Mfnezg@mail.gmail.com>

Ian Rogers wrote on Sun, Apr 07, 2024 at 11:32:31AM -0700:
> Try adding PARSER_DEBUG=1 to your command line, I need to do the following:
> ```
> $ make EXTRA_CFLAGS="-Wno-error=redundant-decls" PARSER_DEBUG=1
> ```

Thanks for this hint!
I tried with that earlier and couldn't reproduce either (e.g. it works
with this patch as you observed), looking at my shell history it turns
out I was just sleep-deprived and I had forgotten the '-e' preceding the
probe and didn't grok the error message...

So this patch is ok.

> I think Jiri's e-mail should be jolsa@kernel.org.

Ah, right -- I used the mail he actually sent the diff with a couple of
years back, but the address in maintainers is jolsa@kernel.org so you're
probably correct that it should be prefered.

I can send a v2 with just this address changed, or whoever picks the
patches up can fix the commit messages for patches 1 & 2, just tell me.
-- 
Dominique Martinet | Asmadeus

      reply	other threads:[~2024-04-08 12:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-07 12:18 [PATCH 0/3] perf probe: Allow names to start with digits Dominique Martinet
2024-04-07 12:18 ` [PATCH 1/3] perf parse-events: pass parse_state to add_tracepoint Dominique Martinet
2024-04-07 12:18 ` [PATCH 2/3] perf parse-events: Add new 'fake_tp' parameter for tests Dominique Martinet
2024-04-07 12:18 ` [PATCH 3/3] perf parse: Allow names to start with digits Dominique Martinet
2024-04-07 12:38   ` Dominique Martinet
2024-04-07 18:32     ` Ian Rogers
2024-04-08 12:49       ` Dominique Martinet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZhPn0EwXf_bPBj-p@codewreck.org \
    --to=asmadeus@codewreck.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.