From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Pavan Holla <pholla@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH v3 2/2] usb: typec: ucsi: Implement ChromeOS UCSI driver
Date: Tue, 9 Apr 2024 18:39:51 +0800 [thread overview]
Message-ID: <ZhUa91g0B9-oj0po@google.com> (raw)
In-Reply-To: <CAB2FV=4_TYP=uBHjJLDwKOdnyfdurX5k5LqqtOPpX4er1fKiZg@mail.gmail.com>
On Mon, Apr 08, 2024 at 07:47:35PM -0700, Pavan Holla wrote:
> On Mon, Apr 8, 2024 at 1:13 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
> >
> > How this driver get probed? From drivers/mfd/cros_ec_dev.c? If so, there is
> > no "cros-ec-ucsi" in the MFD driver yet.
>
> Yes, this should get probed from drivers/mfd/cros_ec_dev.c. However, the
> corresponding change in the EC is still under review. I was planning to send
> it out once the EC change lands. Please let me know if you think that this
> review should wait until then.
I see. The mfd patch is independent and can be sent later.
I was asking because the patch (and the series) don't reflect the message:
"This driver will be loaded if the ChromeOS EC implements a PPM."
However, include/linux/platform_data/cros_ec_commands.h (the previous patch in
the series) usually follows include/ec_commands.h[1]. We should wait until
the corresponding EC patches land.
[1]: https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/main/include/ec_commands.h
prev parent reply other threads:[~2024-04-09 10:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 18:05 [PATCH v3 0/2] usb: typec: Implement UCSI driver for ChromeOS Pavan Holla
2024-04-03 18:05 ` [PATCH v3 1/2] platform/chrome: Update ChromeOS EC header for UCSI Pavan Holla
2024-04-08 8:13 ` Tzung-Bi Shih
2024-04-03 18:05 ` [PATCH v3 2/2] usb: typec: ucsi: Implement ChromeOS UCSI driver Pavan Holla
2024-04-03 18:58 ` Dmitry Baryshkov
2024-04-04 13:07 ` Greg Kroah-Hartman
2024-04-04 13:20 ` Dmitry Baryshkov
2024-04-04 13:30 ` Greg Kroah-Hartman
2024-04-08 13:04 ` Guenter Roeck
2024-04-08 14:51 ` Greg Kroah-Hartman
2024-04-08 17:12 ` Dmitry Baryshkov
2024-04-04 20:44 ` Pavan Holla
2024-04-08 8:13 ` Tzung-Bi Shih
2024-04-09 2:47 ` Pavan Holla
2024-04-09 10:39 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhUa91g0B9-oj0po@google.com \
--to=tzungbi@kernel.org \
--cc=abhishekpandit@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pholla@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.