From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 246B3C67861 for ; Tue, 9 Apr 2024 11:15:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8yEKoQfgcPnLIIapfTR6obwekjWNOUfLhyk8dEcFFcQ=; b=Qy18jc7x26yY+c M8zSraho7xxBgfg5EZUimIuMtqZOKiXox+GAAprcxUBhrmHNjsFF8gdJn/bLX0Zl9WX6Qx0AFYkTG UwTWvA1MZIkUachbAdWHEErKU5JPbf27sm5deTnB2zX7zSeB0TDDYrqGEcKL+M5Igzjng9fcy21xW g9WtLfdF4Df/m5XN4dr2FCSmywSg0jkRWtf5v7jN2Bl18kOeflU0LfbRaJAtto7sSQ+BvVzW1lFc2 ZYSxyQzSQ1fe3AMuv6/jCVrakrb1nTJOH9r4JyI9ppj/yVtR8vhdzyZk9EHlrXgFQK/qzoTDA8bun ZbPA9Ftol3Li2vhaJdrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru9RE-00000001bm4-11yu; Tue, 09 Apr 2024 11:14:52 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru9RA-00000001bk5-16iO; Tue, 09 Apr 2024 11:14:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C4F12CE1DAF; Tue, 9 Apr 2024 11:14:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35FC7C433F1; Tue, 9 Apr 2024 11:14:41 +0000 (UTC) Date: Tue, 9 Apr 2024 12:14:38 +0100 From: Catalin Marinas To: Kefeng Wang Cc: akpm@linux-foundation.org, Russell King , Will Deacon , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, surenb@google.com, linux-mm@kvack.org Subject: Re: [PATCH v2 1/7] arm64: mm: cleanup __do_page_fault() Message-ID: References: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> <20240403083805.1818160-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240403083805.1818160-2-wangkefeng.wang@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_041448_570072_CE9074F9 X-CRM114-Status: UNSURE ( 8.15 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Apr 03, 2024 at 04:37:59PM +0800, Kefeng Wang wrote: > The __do_page_fault() only calls handle_mm_fault() after vm_flags > checked, and it is only called by do_page_fault(), let's squash > it into do_page_fault() to cleanup code. > > Reviewed-by: Suren Baghdasaryan > Signed-off-by: Kefeng Wang As I reviewed v1 and the changes are minimal: Reviewed-by: Catalin Marinas _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9313D84D02 for ; Tue, 9 Apr 2024 11:14:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712661285; cv=none; b=Fr3R0V6aK5j09nTQIAn7ZxiRxKiZvP3djaAOE6H3F3L4k8Y10CCymburYTU7g5kdm6iMmMrW0WkispZ7giiH1pyUwqzVSsJn2gVnABJgZ9egdGLayP75ZrOKYV8kdMX2GhHRyLBGxsX5THiuu6EYqewHNtDDFhlO1QLo7LSOEDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712661285; c=relaxed/simple; bh=g5WDgYmd1tGygYxCeeHhAYcVKdvhkUte9n/R9xJVUZE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BVhZtNDmzmj+8cJREtQ/87YO3T3yjw2E6sBRVUJuC7XV235Pm8Z7LdTF+wALGQEtDlC4p/CSEfNnnkiIGi+uSrE4uaxvFtILDvqK2BJz0ZgqAEmas5DBcBDdMfLnS/m4lMoUnlnVxOAQNGE5ZGJmVzP0lOOZbCnAHU9334rB8WA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35FC7C433F1; Tue, 9 Apr 2024 11:14:41 +0000 (UTC) Date: Tue, 9 Apr 2024 12:14:38 +0100 From: Catalin Marinas To: Kefeng Wang Cc: akpm@linux-foundation.org, Russell King , Will Deacon , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, surenb@google.com, linux-mm@kvack.org Subject: Re: [PATCH v2 1/7] arm64: mm: cleanup __do_page_fault() Message-ID: References: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> <20240403083805.1818160-2-wangkefeng.wang@huawei.com> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403083805.1818160-2-wangkefeng.wang@huawei.com> On Wed, Apr 03, 2024 at 04:37:59PM +0800, Kefeng Wang wrote: > The __do_page_fault() only calls handle_mm_fault() after vm_flags > checked, and it is only called by do_page_fault(), let's squash > it into do_page_fault() to cleanup code. > > Reviewed-by: Suren Baghdasaryan > Signed-off-by: Kefeng Wang As I reviewed v1 and the changes are minimal: Reviewed-by: Catalin Marinas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B771CD1284 for ; Tue, 9 Apr 2024 11:15:15 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VDNfT6Wj2z3vYF for ; Tue, 9 Apr 2024 21:15:13 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=cmarinas@kernel.org; receiver=lists.ozlabs.org) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VDNf12kLlz3d2W for ; Tue, 9 Apr 2024 21:14:49 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C4F12CE1DAF; Tue, 9 Apr 2024 11:14:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35FC7C433F1; Tue, 9 Apr 2024 11:14:41 +0000 (UTC) Date: Tue, 9 Apr 2024 12:14:38 +0100 From: Catalin Marinas To: Kefeng Wang Subject: Re: [PATCH v2 1/7] arm64: mm: cleanup __do_page_fault() Message-ID: References: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> <20240403083805.1818160-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403083805.1818160-2-wangkefeng.wang@huawei.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, Albert Ou , linux-s390@vger.kernel.org, Peter Zijlstra , Dave Hansen , Russell King , surenb@google.com, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, Palmer Dabbelt , Nicholas Piggin , Andy Lutomirski , Paul Walmsley , akpm@linux-foundation.org, Gerald Schaefer , Will Deacon , Alexander Gordeev , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Apr 03, 2024 at 04:37:59PM +0800, Kefeng Wang wrote: > The __do_page_fault() only calls handle_mm_fault() after vm_flags > checked, and it is only called by do_page_fault(), let's squash > it into do_page_fault() to cleanup code. > > Reviewed-by: Suren Baghdasaryan > Signed-off-by: Kefeng Wang As I reviewed v1 and the changes are minimal: Reviewed-by: Catalin Marinas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1D11CD1284 for ; Tue, 9 Apr 2024 11:15:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3+BiStDTBShpOynnPTxSJZn9dP/pOiDy3IMFyKkQV90=; b=S3q0b5h40cs/6J BCp5kr6NaQdP5MmjRrSwja8T15R/bwE9pjsfsN0xluFIxUYME6F8CHgZUZUjUVIOVEIFhpE7YJy4V BV7DA9rPEzqt/XWclS7NSv8Q84BVGKbjFEjFp2lMZSu2FUiVW9Af2TFmadkGSPYl52S7EEE58x6E+ e1Hv69QtWJPplgoCC4hCf5+0ZXBYQ89NONqhY6qcd8Ks9D2yg+emVUUvgVEPRIVCXIYaLeudg3hL6 RTu9cH8tXLooEq+1E4pcRjUgpeSYQGZXu46I/uFX05JVflrl7qlwmrsDU9giA8aj84AHGRLvxhUwz xdKm+xy74kzXDJduR6vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru9RD-00000001blm-1Q4E; Tue, 09 Apr 2024 11:14:51 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru9RA-00000001bk5-16iO; Tue, 09 Apr 2024 11:14:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C4F12CE1DAF; Tue, 9 Apr 2024 11:14:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35FC7C433F1; Tue, 9 Apr 2024 11:14:41 +0000 (UTC) Date: Tue, 9 Apr 2024 12:14:38 +0100 From: Catalin Marinas To: Kefeng Wang Cc: akpm@linux-foundation.org, Russell King , Will Deacon , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, surenb@google.com, linux-mm@kvack.org Subject: Re: [PATCH v2 1/7] arm64: mm: cleanup __do_page_fault() Message-ID: References: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> <20240403083805.1818160-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240403083805.1818160-2-wangkefeng.wang@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_041448_570072_CE9074F9 X-CRM114-Status: UNSURE ( 8.15 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 03, 2024 at 04:37:59PM +0800, Kefeng Wang wrote: > The __do_page_fault() only calls handle_mm_fault() after vm_flags > checked, and it is only called by do_page_fault(), let's squash > it into do_page_fault() to cleanup code. > > Reviewed-by: Suren Baghdasaryan > Signed-off-by: Kefeng Wang As I reviewed v1 and the changes are minimal: Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel