From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Peter Hutterer <peter.hutterer@redhat.com>
Cc: Mark Pearson <mpearson-lenovo@squebb.ca>,
hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com,
hmh@hmh.eng.br, ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, njoshi1@lenovo.com,
vsankar@lenovo.com
Subject: Re: [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes
Date: Tue, 9 Apr 2024 18:20:37 -0700 [thread overview]
Message-ID: <ZhXpZe1Gm5e4xP6r@google.com> (raw)
In-Reply-To: <ZhW3Wbn4YSGFBgfS@google.com>
On Tue, Apr 09, 2024 at 02:47:05PM -0700, Dmitry Torokhov wrote:
> On Tue, Apr 09, 2024 at 03:23:52PM +1000, Peter Hutterer wrote:
> > On 09/04/2024 09:31, Dmitry Torokhov wrote:
> > > Hi Mark,
> > >
> > > On Sun, Mar 24, 2024 at 05:07:58PM -0400, Mark Pearson wrote:
> > > > Add support for new input events on Lenovo laptops that need exporting to
> > > > user space.
> > > >
> > > > Lenovo trackpoints are adding the ability to generate a doubletap event.
> > > > Add a new keycode to allow this to be used by userspace.
> > >
> > > What is the intended meaning of this keycode? How does it differ from
> > > the driver sending BTN_LEFT press/release twice?
> > > >
> > > > Lenovo support is using FN+N with Windows to collect needed details for
> > > > support cases. Add a keycode so that we'll be able to provide similar
> > > > support on Linux.
> > >
> > > Is there a userspace consumer for this?
> >
> > Funnily enough XKB has had a keysym for this for decades but it's not
> > hooked up anywhere due to the way it's pointer keys accessibility
> > feature was implemented. Theory is that most of userspace just needs
> > to patch the various pieces together for the new evdev code + keysym,
> > it's not really any different to handling a volume key (except this
> > one needs to be assignable).
>
> What is the keysym? If we can make them relatable to each other that
> would be good. Or maybe we could find a matching usage from HID usage
> tables...
I was looking through the existing codes and I see:
#define KEY_INFO 0x166 /* AL OEM Features/Tips/Tutorial */
We also have KEY_VENDOR used in a few drivers/plafrom/x86, including
thinkkpad_acpi.c and I wonder if it would be suitable for this vendor
specific debug info collection application (which I honestly doubt will
materialize).
Thanks.
--
Dmitry
next prev parent reply other threads:[~2024-04-10 1:20 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 21:07 [PATCH 0/4] platform/x86,input: Support for new events on Mark Pearson
2024-03-24 21:07 ` [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes Mark Pearson
2024-04-08 12:45 ` Hans de Goede
2024-04-08 23:31 ` Dmitry Torokhov
2024-04-09 0:00 ` Mark Pearson
2024-04-09 10:16 ` Hans de Goede
2024-04-09 21:54 ` Dmitry Torokhov
2024-04-09 5:23 ` Peter Hutterer
2024-04-09 21:47 ` Dmitry Torokhov
2024-04-10 1:20 ` Dmitry Torokhov [this message]
2024-04-10 2:17 ` Mark Pearson
2024-04-11 0:02 ` Dmitry Torokhov
2024-04-11 2:48 ` Mark Pearson
2024-04-15 19:40 ` Dmitry Torokhov
2024-04-15 19:50 ` Hans de Goede
2024-04-15 19:58 ` Dmitry Torokhov
2024-04-15 20:28 ` Mark Pearson
2024-04-15 22:54 ` Dmitry Torokhov
2024-04-15 23:57 ` Mark Pearson
2024-04-16 8:33 ` Hans de Goede
2024-04-16 12:48 ` Mark Pearson
2024-04-16 13:03 ` Hans de Goede
2024-04-16 8:35 ` Hans de Goede
2024-04-11 12:30 ` Hans de Goede
2024-04-15 19:35 ` Dmitry Torokhov
2024-04-15 19:47 ` Hans de Goede
2024-04-15 19:55 ` Dmitry Torokhov
2024-04-10 4:32 ` Peter Hutterer
2024-04-15 19:32 ` Dmitry Torokhov
2024-03-24 21:07 ` [PATCH 2/4] platform/x86: thinkpad_acpi: Support for trackpoint doubletap Mark Pearson
2024-04-08 13:04 ` Hans de Goede
2024-04-08 14:56 ` [ibm-acpi-devel] " Mark Pearson
2024-03-24 21:08 ` [PATCH 3/4] platform/x86: thinkpad_acpi: Support for system debug info hotkey Mark Pearson
2024-04-08 13:11 ` Hans de Goede
2024-04-08 14:56 ` Mark Pearson
2024-03-24 21:08 ` [PATCH 4/4] platform/x86: thinkpad_acpi: Support hotkey to disable trackpoint doubletap Mark Pearson
2024-04-08 13:13 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhXpZe1Gm5e4xP6r@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=njoshi1@lenovo.com \
--cc=peter.hutterer@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vsankar@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.