From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 041782206C; Wed, 10 Apr 2024 04:35:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712723737; cv=none; b=iMNOEeZLVEsOjQ/ivcGEn5MVZOCOmlJPwJsYDIr1iUJXtsgz2e/3ybnSs50Trt51fXoF2XH+v5bSCCMk8hywOaDwV2z0/s3ZKu4N3DyBQfukFDq5PaXZXiGy4Hj5v6KYjrj/xUN4vlwtUjQtqWDe7IR5dTFOKgIkBR1lAY3jWPM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712723737; c=relaxed/simple; bh=A5ocNCfCC13JQEwgLffXyCcRlMXUemMEj+WDWXuLyYo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CJEl6iAXGdpiNQN0YJ1sM0sVNNBkDuWMkbuywjKZonMOFnzyK6lK1844E8aZYTZ4Zt5NPbe2iRAlyrsN9jyIu8HA4G7v5RXMJgPsG9zo1dQ9Zw0AThXYASAHylv1pizgPmrkUynMjBYxo8UTaDXE1VkkiZpui9wdLfxWA4/YTsk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SjhUV3rF; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SjhUV3rF" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a5200202c1bso134338366b.0; Tue, 09 Apr 2024 21:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712723734; x=1713328534; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=/jBy/6Q3rVBWhWCAM1R1P2AD92VuX8BxxvAdftUWY5s=; b=SjhUV3rFSb08/0JK7sa0OpEUrZuQ0vMpGmBka3TOk5Fw6Af6I4YWq/xPYoLN+PyWZJ dzJv0nOFVVMFXg4Uo6SV7Y98cfqxptalSMIiuXyK9/rhkvAooQ0nj/wJj/oLkELlNxCV Bsgb5SPwhRhkKnzFTLUKD9wzYP3Fv5rY5X6gq5AsATZkLUv24s2lZ9DW7F4aS4S6LL+g tfUBIp1gDlYuvJDThNvWcWeqCf0w/r5sUh2m8kIqgTzxw98Ia8OWJkgky5Vbxb1z5SpY Mnwn5kX1XMvx/2x3eQSC6BgxM7OeXwUdh0bzjCeAS/TCx1PMeztdQzDvn+BJwsg3eVWG fCBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712723734; x=1713328534; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/jBy/6Q3rVBWhWCAM1R1P2AD92VuX8BxxvAdftUWY5s=; b=Dhjiwf9msJ+I11I/slKAYs6GUp6/WKc5lszmWscfqD8bq1sDocNDKLArV8YvTBEPCF 31M6g4RrlJ8H/5QtQCLyYXjA0BNHMHYYiBXxB16nQx4igtSdcwjV5hqpMLPkz6HfDE8/ 3seYLcPH7+tmUkz+TV5YCIARJwtRdAW2XSAoP2g5z7nhahfyVQ3V6SzuhurSSD8+TMoX tntZ9GnLnXFyIQOwvrOhtPc/IynDOMbkSgVZ6TgHN1izADoFwmcNgA9nq7djVlRuHAtR gpNDEjzBUndrY3ViIv3pnmIUjZ9UB3/NjELz4LcdDQfcOXEgbD2DWEEjQMvOG+8bul/K lHBg== X-Forwarded-Encrypted: i=1; AJvYcCUEo4fm6r/McWlfGvRQ1nFJZ1RS4YliCQ0gzjSor/6BxIrRMz3igb8w2iFnSBkqmeaI8XNkoDnTUy3B+gxACuK99a70D7ZVGRfeDkHaS+oK+7WCMZh4VHH08Pq3QKUaJjYYUHLjIZ2y6krkClhwCELaJmUVQACTUCX1ZUZwaw5KRNEypw== X-Gm-Message-State: AOJu0YxJKbK7w3n9cEX/QA82P258YafF6dfOUQ6SJhbRomA9RJn16bSD ZTbyxB73TM70yOwkYOpm9n4fkpR6nGeZThfWPnCWxvkXX8ejaLuRB7VCDwIeqM51Sg== X-Google-Smtp-Source: AGHT+IGw3pGdJNDGc36x5yeSbeGn3X2Wfz1ITzkM/g7HGnBIi9qtAcipDvdlkr1wPsLlzku3Rvcclg== X-Received: by 2002:a17:906:e288:b0:a52:a3a:3959 with SMTP id gg8-20020a170906e28800b00a520a3a3959mr662263ejb.23.1712723733985; Tue, 09 Apr 2024 21:35:33 -0700 (PDT) Received: from gmail.com (1F2EF1A5.nat.pool.telekom.hu. [31.46.241.165]) by smtp.gmail.com with ESMTPSA id an3-20020a17090656c300b00a51cfd5c6ddsm3893091ejc.9.2024.04.09.21.35.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 21:35:33 -0700 (PDT) Sender: Ingo Molnar Date: Wed, 10 Apr 2024 06:35:31 +0200 From: Ingo Molnar To: Kyle Huey Cc: Kyle Huey , linux-kernel@vger.kernel.org, Andrii Nakryiko , Jiri Olsa , Namhyung Kim , Marco Elver , Yonghong Song , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Robert O'Callahan , Will Deacon , Song Liu , Mark Rutland , Russell King , Catalin Marinas , Alexander Shishkin , Ian Rogers , Adrian Hunter , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [RESEND PATCH v5 2/4] perf/bpf: Remove unneeded uses_default_overflow_handler. Message-ID: References: <20240214173950.18570-1-khuey@kylehuey.com> <20240214173950.18570-3-khuey@kylehuey.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240214173950.18570-3-khuey@kylehuey.com> * Kyle Huey wrote: > Now that struct perf_event's orig_overflow_handler is gone, there's no need > for the functions and macros to support looking past overflow_handler to > orig_overflow_handler. > > This patch is solely a refactoring and results in no behavior change. > > Signed-off-by: Kyle Huey > Acked-by: Will Deacon > Acked-by: Song Liu > Acked-by: Jiri Olsa > --- > arch/arm/kernel/hw_breakpoint.c | 8 ++++---- > arch/arm64/kernel/hw_breakpoint.c | 4 ++-- > include/linux/perf_event.h | 16 ++-------------- > 3 files changed, 8 insertions(+), 20 deletions(-) > > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index c7f54fd74d89..c8bd5bb6610c 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -1341,8 +1341,9 @@ extern int perf_event_output(struct perf_event *event, > struct pt_regs *regs); > > static inline bool > -__is_default_overflow_handler(perf_overflow_handler_t overflow_handler) > +is_default_overflow_handler(struct perf_event *event) > { > + perf_overflow_handler_t overflow_handler = event->overflow_handler; > if (likely(overflow_handler == perf_event_output_forward)) Please read the CodingStyle section about variable definition blocks and newlines... Also note the stray period in the title ... How did this patch get to v5 and get acked by 3 people with such trivial problems still present? ... Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1321CD11C2 for ; Wed, 10 Apr 2024 04:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7tGMrw3CMok0PI/d6SR4bKb3h9F1pp73ivLmcQ0PI+g=; b=0zrR4d02G1zWon /Em+wVUQo8gwBTCf5N+ItH6GUUktqCeKpdaNuB50LPeH2nHMuM8k0VKAfjlrFX9Hwo9J3CFz9FRLC 9ahbkijNpgvQu/0T/6nTE1I7vagc9ZUE08nXh1xj6jiV+jjzedrJ4PP9lTLrErYLUMFaf9B0s2Tsm 51p84tEq+sHtMp4EreayBK3lIffHYZplDV8anO2v3KOnt8WCvGbPafmEOMyKeHQIa7+Sp5Qi9I54a pct8Tw0cECLLWXsnrOhF0anzVbwS6T+lyWAzk8BevQ5BeB1eTt3NBpz57ob7xyBvLsa7rO7Vh+zAn L/nFh5Y4Gx6Jfv56D8xQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruPgS-000000052CJ-06NC; Wed, 10 Apr 2024 04:35:40 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruPgP-000000052AK-0J6o for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 04:35:39 +0000 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a51fea60c0bso140253966b.3 for ; Tue, 09 Apr 2024 21:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712723734; x=1713328534; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=/jBy/6Q3rVBWhWCAM1R1P2AD92VuX8BxxvAdftUWY5s=; b=mmFxhzc3ckr/gNbu4JqMcS/7KVinNXiyZdj8w3FKATFGURcZamUaRsAzwFd6rLY40j QUSo8II68pxrCAg1KWGZ7rWT6ZuCx+LKaex6462FIA8ZeXkoFT86y8CaXypldttgRXtQ FglIKxKd/hRqq6DsKJjhsp+Cd/PzgZ8fraZSnSTM/RTSx1nMsuz32WRulZ5sdDTy7Ip/ DOAjl4jraWeoN1yI7aIHcBDifvAfhuH4d+fZ5gtyIUO8BwiHoVysLRXJvm2bKD4TgyQN np5v86DD7ignpZ/SCxQU9nu4kKY6Rl5XxYru/SfUvNOLm3kuXRn/+eehMGoZjT2zKhyM jI7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712723734; x=1713328534; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/jBy/6Q3rVBWhWCAM1R1P2AD92VuX8BxxvAdftUWY5s=; b=R+a5B4/cAxwzsMlwSBXqC0DGORxN9qOIJKaIbwxdK22SGF30mrl7S+K3d1nQ/uDFyr 7pGVOJEC6nqnQiPDK0qbop8KNfQ8c2D1DJ/aJarbCaMRM3OoGoEzOlbdc0C8RAJ+UPB3 1BWQr8RUnyDJ2KQWkq/4ysFQW1jwZzEnoFTajYIVH75Vntn4v/ODQIZkjAPgpPnHfEUL hmyis2KpIPQ6zrt0FIhfkgDBSdMB6spHOF6lK+yaCw1HCuGpZpV1h+IGWyA3F/R8t6zf PB81xblDHNYJmkV86kt4pKiaH3cGrd2HigmddPmN3QWjvWMACFBEpvSLPPo0m/ELvJAW yNrg== X-Forwarded-Encrypted: i=1; AJvYcCXLpb9iE425NpwTsYhKxzvGHGPFPnJANAfm1URKKpFu0OBnf9favQlujN1S/2QDKBTVojqQ/86Rlg9Q/H265Ef68523nKu4Wl7/bjiHnGjMKM5TyVg= X-Gm-Message-State: AOJu0YyvhuOrzr5b52l4kCmLeYXyBjk9McSWOqzaUe8THJP7jvQfvftN onNrVWsmoX7rFuffCuRlSUxn+wWBiA51k077IekijuTBNWz5oAK0 X-Google-Smtp-Source: AGHT+IGw3pGdJNDGc36x5yeSbeGn3X2Wfz1ITzkM/g7HGnBIi9qtAcipDvdlkr1wPsLlzku3Rvcclg== X-Received: by 2002:a17:906:e288:b0:a52:a3a:3959 with SMTP id gg8-20020a170906e28800b00a520a3a3959mr662263ejb.23.1712723733985; Tue, 09 Apr 2024 21:35:33 -0700 (PDT) Received: from gmail.com (1F2EF1A5.nat.pool.telekom.hu. [31.46.241.165]) by smtp.gmail.com with ESMTPSA id an3-20020a17090656c300b00a51cfd5c6ddsm3893091ejc.9.2024.04.09.21.35.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 21:35:33 -0700 (PDT) Date: Wed, 10 Apr 2024 06:35:31 +0200 From: Ingo Molnar To: Kyle Huey Cc: Kyle Huey , linux-kernel@vger.kernel.org, Andrii Nakryiko , Jiri Olsa , Namhyung Kim , Marco Elver , Yonghong Song , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Robert O'Callahan , Will Deacon , Song Liu , Mark Rutland , Russell King , Catalin Marinas , Alexander Shishkin , Ian Rogers , Adrian Hunter , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [RESEND PATCH v5 2/4] perf/bpf: Remove unneeded uses_default_overflow_handler. Message-ID: References: <20240214173950.18570-1-khuey@kylehuey.com> <20240214173950.18570-3-khuey@kylehuey.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240214173950.18570-3-khuey@kylehuey.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_213537_150399_69B34DEE X-CRM114-Status: GOOD ( 20.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Kyle Huey wrote: > Now that struct perf_event's orig_overflow_handler is gone, there's no need > for the functions and macros to support looking past overflow_handler to > orig_overflow_handler. > > This patch is solely a refactoring and results in no behavior change. > > Signed-off-by: Kyle Huey > Acked-by: Will Deacon > Acked-by: Song Liu > Acked-by: Jiri Olsa > --- > arch/arm/kernel/hw_breakpoint.c | 8 ++++---- > arch/arm64/kernel/hw_breakpoint.c | 4 ++-- > include/linux/perf_event.h | 16 ++-------------- > 3 files changed, 8 insertions(+), 20 deletions(-) > > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index c7f54fd74d89..c8bd5bb6610c 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -1341,8 +1341,9 @@ extern int perf_event_output(struct perf_event *event, > struct pt_regs *regs); > > static inline bool > -__is_default_overflow_handler(perf_overflow_handler_t overflow_handler) > +is_default_overflow_handler(struct perf_event *event) > { > + perf_overflow_handler_t overflow_handler = event->overflow_handler; > if (likely(overflow_handler == perf_event_output_forward)) Please read the CodingStyle section about variable definition blocks and newlines... Also note the stray period in the title ... How did this patch get to v5 and get acked by 3 people with such trivial problems still present? ... Thanks, Ingo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel