From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CEBECD11C2 for ; Wed, 10 Apr 2024 10:09:31 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 71B6A3CF760 for ; Wed, 10 Apr 2024 12:09:30 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id E30613C7832 for ; Wed, 10 Apr 2024 12:09:15 +0200 (CEST) Authentication-Results: in-3.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=2a07:de40:b251:101:10:150:64:2; helo=smtp-out2.suse.de; envelope-from=chrubis@suse.cz; receiver=lists.linux.it) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 7FF711B601D3 for ; Wed, 10 Apr 2024 12:09:13 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8BF115CA37; Wed, 10 Apr 2024 10:09:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712743751; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=So3f40EDc9m3Y+DQF1h31D7pa/IdbLqJ5Yhd6JW4fBs=; b=QW5sZPvyb+jYlOG27RCGZ0xUPz1xaf0fhQ1m8vHLIdbf1OpS6K2CZPn9UQ40C0WiCP0jfh GESMG+sCYohy6XB3xVU98KcMrafeEt50/JGTUTss6FhUoZxuFoiOZmNXHYq7M7vWJj1l/A FqB44jMZ/MHOAbWmGbippCfEru7veGU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712743751; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=So3f40EDc9m3Y+DQF1h31D7pa/IdbLqJ5Yhd6JW4fBs=; b=WwmTDcSatTa70M/b6kaJzp+a4nZ51np9/loaIyRLOCAjZKHw0vGfVEaKvCPIpzuRzQoqiF a9U/d9XwGh1Gp2Bw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712743750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=So3f40EDc9m3Y+DQF1h31D7pa/IdbLqJ5Yhd6JW4fBs=; b=KEMlw6KgZzbfRMI+AGb4ay5gMzIUodrX9Kx7Liam1oyM1e4itNu0KIvhw6xO4X4P+Mz6rP I36U/J3TOF75IpfS5Odif2H/DjkCaeWO2K+DnWP7nocnNr8yn938nNbmmdIE/mTGc5TRUT z636R7Hr+C9Q7JJ4DV8iGcv+leXpaSs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712743750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=So3f40EDc9m3Y+DQF1h31D7pa/IdbLqJ5Yhd6JW4fBs=; b=MGG5XkP7XXXXJBkJ3TfuSvlCHU0O5gqhZ8kMVFp5K/Ry0u4XevJRc6XMD4M5PFAoTp+6o2 tQuaIWK00jGuHEAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7BF4A13942; Wed, 10 Apr 2024 10:09:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 5gFIHUZlFmZdVgAAD6G6ig (envelope-from ); Wed, 10 Apr 2024 10:09:10 +0000 Date: Wed, 10 Apr 2024 12:08:19 +0200 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20240401150015.301640-1-samasth.norway.ananda@oracle.com> <20240409101753.GA107959@pevik> <20240410094621.GA184706@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240410094621.GA184706@pevik> X-Spamd-Result: default: False [-7.80 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCPT_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Virus-Scanned: clamav-milter 1.0.3 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] mremap06: fallocate is not supported on nfsv3 X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: calum.mackay@oracle.com, ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > The solution would be to at least check for tst_fs_type(".") == TST_NFS_MAGIC. I would go for this at the moment, that is the easiest fix at the moment. > Perfect solution would IMHO be to check for NFS version (e.g. in /proc/mounts) > and TCONF only on NFSv3. And is nfsv4 enough, wasn't it added in nfsv4.2? Do we need to parse /proc/net/rpc/nfs to figure out if nfs fallocate() is supported? -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp