From: Andy Shevchenko <andy@kernel.org>
To: Ivan Orlov <ivan.orlov0322@gmail.com>
Cc: keescook@chromium.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH] string: Implement KUnit test for str*cmp functions
Date: Wed, 17 Apr 2024 17:28:18 +0300 [thread overview]
Message-ID: <Zh_cgnMOFHuP-lKu@smile.fi.intel.com> (raw)
In-Reply-To: <20240417135415.614284-1-ivan.orlov0322@gmail.com>
On Wed, Apr 17, 2024 at 02:54:15PM +0100, Ivan Orlov wrote:
> Currently, str*cmp functions (strcmp, strncmp, strcasecmp and
> strncasecmp) are not covered with tests. Implement the test which
> covers them all.
>
> The strcmp test suite consist of 8 test cases:
>
> 1) strcmp test
> 2) strcmp test on long strings (2048 chars)
> 3) strncmp test
> 4) strncmp test on long strings (2048 chars)
> 5) strcasecmp test
> 6) strcasecmp test on long strings
> 7) strncasecmp test
> 8) strncasecmp test on long strings
>
> The test aims at covering as many edge cases as possible, including
> the tests on empty strings, situations when the different symbol is
> placed at the end of one of the strings, etc.
...
> lib/strcmp_kunit.c | 170 +++++++++++++++++++++++++++++++++++++++++++++
Why is not part of the existing string_kunit.c?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-17 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 13:54 [PATCH] string: Implement KUnit test for str*cmp functions Ivan Orlov
2024-04-17 14:28 ` Andy Shevchenko [this message]
2024-04-17 14:46 ` Ivan Orlov
2024-04-17 14:53 ` Andy Shevchenko
2024-04-17 15:12 ` Ivan Orlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh_cgnMOFHuP-lKu@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ivan.orlov0322@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.