From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v1 1/1] serial: core: Extract uart_alloc_xmit_buf() and uart_free_xmit_buf()
Date: Wed, 10 Apr 2024 16:45:29 +0300 [thread overview]
Message-ID: <ZhaX-R2UV8B9xMXL@smile.fi.intel.com> (raw)
In-Reply-To: <52a83cb5-ef4f-46f5-ad90-1f64b4d588e2@kernel.org>
On Wed, Apr 10, 2024 at 11:04:35AM +0200, Jiri Slaby wrote:
> On 09. 04. 24, 19:40, Andy Shevchenko wrote:
...
> I see very much of tty_port_alloc_xmit_buf() and tty_port_free_xmit_buf() in
> here :).
A-ha!
> Currently, different locks are used, so the patch is, I think, good for now.
> For future, we should switch to the tty port helpers.
Sure, but I'm not familiar with TTY.
> Actually have you looked if the different locking is an issue at all? IOW,
> isn't the tty_port's (and its xmit buf) lifetime enough w/o uart port locks?
Nope. I only looked at spin lock differences (irq/irqsave) and decided that
irqsave variant is good for both cases.
...
So, do I need to do anything or is it good to go as-is?
Thanks for review.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-04-10 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 17:40 [PATCH v1 1/1] serial: core: Extract uart_alloc_xmit_buf() and uart_free_xmit_buf() Andy Shevchenko
2024-04-10 9:04 ` Jiri Slaby
2024-04-10 13:45 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhaX-R2UV8B9xMXL@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.