From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FDAECD11C2 for ; Wed, 10 Apr 2024 18:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u04ty4XeC+ToVpbCTU/qMTm1yQRrPUKOYomefkfVDGA=; b=BPzNRQWMOVnkGXDcn7SBn4AigY JJNXd/uxSbhvdfyfiUdK1v9yesWJ1gTqNMf+l4rx+uJFVOQUlUIAcGhm671OBTdn3ShnEhccmCguu eTQ4fYW/GAXjOoAHdzF9OWXqBJ60svRyz9KyTAwx6v4Vu2tFhD83q6FXQP2E+OeiD2j7jRu24GyoI thcRajPVdQ96y/1dNQg++/tVSXH8fxv9lXI/i1v67Hk7nt4DyU5omskShvtPLo+84pXSBjVm730lB EIFpvMmsfPVEQQwTg8eDNhs4PTVq4xKp60xFAdvn58vZyiEWATkQV7FJlIkezBXcxgfE5xcr5cGcF VzkabNtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rud4D-00000008YgT-3tBw; Wed, 10 Apr 2024 18:53:05 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rud4A-00000008Yde-0qrE; Wed, 10 Apr 2024 18:53:03 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rud3c-0001D4-1U; Wed, 10 Apr 2024 18:52:28 +0000 Date: Wed, 10 Apr 2024 19:52:24 +0100 From: Daniel Golle To: Paolo Abeni Cc: arinc.unal@arinc9.com, DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Matthias Brugger , AngeloGioacchino Del Regno , =?iso-8859-1?Q?Ren=E9?= van Dorst , Russell King , SkyLake Huang , Heiner Kallweit , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Florian Fainelli Subject: Re: [PATCH net v3] net: dsa: mt7530: fix enabling EEE on MT7531 switch on all boards Message-ID: References: <20240408-for-net-mt7530-fix-eee-for-mt7531-mt7988-v3-1-84fdef1f008b@arinc9.com> <1f2bc5416a0a73756cc1f45f3300619eb201b0a4.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1f2bc5416a0a73756cc1f45f3300619eb201b0a4.camel@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_115302_340516_B7CE49F2 X-CRM114-Status: GOOD ( 33.82 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Apr 09, 2024 at 01:58:56PM +0200, Paolo Abeni wrote: > On Mon, 2024-04-08 at 10:08 +0300, Arınç ÜNAL via B4 Relay wrote: > > From: Arınç ÜNAL > > > > The commit 40b5d2f15c09 ("net: dsa: mt7530: Add support for EEE features") > > brought EEE support but did not enable EEE on MT7531 MACs. EEE is > > enabled on MT7531 switch MACs by pulling the LAN2LED0 pin low on the board > > (bootstrapping), unsetting the EEE_DIS bit on the trap register, or setting > > the internal EEE switch bit on the CORE_PLL_GROUP4 register. Thanks to > > SkyLake Huang (黃啟澤) from MediaTek for providing information on the > > internal EEE switch bit. > > > > There are existing boards that were not designed to pull the pin low. > > Because of that, the EEE status currently depends on the board design. > > > > The EEE_DIS bit on the trap pertains to the LAN2LED0 pin which is usually > > used to control an LED. Once the bit is unset, the pin will be low. That > > will make the active low LED turn on. The pin is controlled by the switch > > PHY. It seems that the PHY controls the pin in the way that it inverts the > > pin state. That means depending on the wiring of the LED connected to > > LAN2LED0 on the board, the LED may be on without an active link. > > > > To not cause this unwanted behaviour whilst enabling EEE on all boards, set > > the internal EEE switch bit on the CORE_PLL_GROUP4 register. > > > > My testing on MT7531 shows a certain amount of traffic loss when EEE is > > enabled. That said, I haven't come across a board that enables EEE. So > > enable EEE on the switch MACs but disable EEE advertisement on the switch > > PHYs. This way, we don't change the behaviour of the majority of the boards > > that have this switch. The mediatek-ge PHY driver already disables EEE > > advertisement on the switch PHYs but my testing shows that it is somehow > > enabled afterwards. Disabling EEE advertisement before the PHY driver > > initialises keeps it off. > > > > With this change, EEE can now be enabled using ethtool. > > > > Fixes: 40b5d2f15c09 ("net: dsa: mt7530: Add support for EEE features") > > Reviewed-by: Florian Fainelli > > Signed-off-by: Arınç ÜNAL > > --- > > Here's some information for the record. EEE could not be enabled on MT7531 > > on most boards using ethtool before this. On MT7988 SoC switch, EEE is > > disabled by default but can be turned on normally using ethtool. EEE is > > enabled by default on MT7530 and there's no need to make changes on the DSA > > subdriver for it. > > --- > > Changes in v3: > > - Remove patch 2, it was revealed that it doesn't fix a bug. > > - Patch 1 > > - Use the internal EEE switch bit provided by SkyLake Huang (黃啟澤). It > > is a better method compared to unsetting the EEE_DIS bit of the trap as > > the latter method causes unwanted behaviour on the LED connected to the > > pin that pertains to the EEE_DIS bit. > > Since this leverages something relatively obscure, it would be great if > someone in the CC list could independently test it. Let's wait a bit > more. I've excessively tested this patch on MT7531 today, and reviewed it today and yesterday. I've also picked it as downstream patch[1] to OpenWrt, so an even wider audience will have the pleasure of working EEE on those switch ICs and in-SoC switches. Tested-by: Daniel Golle Reviewed-by: Daniel Golle [1]: https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=98f9154316fe8371c709bd11ae8f263e22075ec6 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6702BCD128A for ; Wed, 10 Apr 2024 18:53:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oEH1vWizon6GDwOZ4YEL3kvxCiNvOnfqx4nFLckclJA=; b=13wpM4+FDkJoQW xkjK+qHbYUiXoV9ELwon6WPetWyjlff71EhRwhdaEM9k9LelE2GWwy9LXmmMB4/3QdFsIgWNfn+3x MRA33vHEFPfhr5/g9mkMqCRj51aU7w2nmAOnK29poIswAIFsrQFMEo4x3MhYWPkOCUWUOUETRss3r nvnGXd+0iNY2gYYRj0vV2j6hsM/2Mrut2sgTmUKhhZwzenFsGPesGqaecfWAcQCQNlwKgnZ7xzpUl ryiTtP4I57S+PDZ2HUOBLgWWg5g40e8HbgHHhNp2arF+mJeu1c95I+SGgS5aY2MLs8pAM0ZqRV32e LPsOv5yz+W54jFFqZu7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rud4D-00000008YgH-15WS; Wed, 10 Apr 2024 18:53:05 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rud4A-00000008Yde-0qrE; Wed, 10 Apr 2024 18:53:03 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rud3c-0001D4-1U; Wed, 10 Apr 2024 18:52:28 +0000 Date: Wed, 10 Apr 2024 19:52:24 +0100 From: Daniel Golle To: Paolo Abeni Cc: arinc.unal@arinc9.com, DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Matthias Brugger , AngeloGioacchino Del Regno , =?iso-8859-1?Q?Ren=E9?= van Dorst , Russell King , SkyLake Huang , Heiner Kallweit , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Florian Fainelli Subject: Re: [PATCH net v3] net: dsa: mt7530: fix enabling EEE on MT7531 switch on all boards Message-ID: References: <20240408-for-net-mt7530-fix-eee-for-mt7531-mt7988-v3-1-84fdef1f008b@arinc9.com> <1f2bc5416a0a73756cc1f45f3300619eb201b0a4.camel@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1f2bc5416a0a73756cc1f45f3300619eb201b0a4.camel@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_115302_340516_B7CE49F2 X-CRM114-Status: GOOD ( 33.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBcHIgMDksIDIwMjQgYXQgMDE6NTg6NTZQTSArMDIwMCwgUGFvbG8gQWJlbmkgd3Jv dGU6Cj4gT24gTW9uLCAyMDI0LTA0LTA4IGF0IDEwOjA4ICswMzAwLCBBcsSxbsOnIMOcTkFMIHZp YSBCNCBSZWxheSB3cm90ZToKPiA+IEZyb206IEFyxLFuw6cgw5xOQUwgPGFyaW5jLnVuYWxAYXJp bmM5LmNvbT4KPiA+IAo+ID4gVGhlIGNvbW1pdCA0MGI1ZDJmMTVjMDkgKCJuZXQ6IGRzYTogbXQ3 NTMwOiBBZGQgc3VwcG9ydCBmb3IgRUVFIGZlYXR1cmVzIikKPiA+IGJyb3VnaHQgRUVFIHN1cHBv cnQgYnV0IGRpZCBub3QgZW5hYmxlIEVFRSBvbiBNVDc1MzEgIE1BQ3MuIEVFRSBpcwo+ID4gZW5h YmxlZCBvbiBNVDc1MzEgc3dpdGNoIE1BQ3MgYnkgcHVsbGluZyB0aGUgTEFOMkxFRDAgcGluIGxv dyBvbiB0aGUgYm9hcmQKPiA+IChib290c3RyYXBwaW5nKSwgdW5zZXR0aW5nIHRoZSBFRUVfRElT IGJpdCBvbiB0aGUgdHJhcCByZWdpc3Rlciwgb3Igc2V0dGluZwo+ID4gdGhlIGludGVybmFsIEVF RSBzd2l0Y2ggYml0IG9uIHRoZSBDT1JFX1BMTF9HUk9VUDQgcmVnaXN0ZXIuIFRoYW5rcyB0bwo+ ID4gU2t5TGFrZSBIdWFuZyAo6buD5ZWf5r6kKSBmcm9tIE1lZGlhVGVrIGZvciBwcm92aWRpbmcg aW5mb3JtYXRpb24gb24gdGhlCj4gPiBpbnRlcm5hbCBFRUUgc3dpdGNoIGJpdC4KPiA+IAo+ID4g VGhlcmUgYXJlIGV4aXN0aW5nIGJvYXJkcyB0aGF0IHdlcmUgbm90IGRlc2lnbmVkIHRvIHB1bGwg dGhlIHBpbiBsb3cuCj4gPiBCZWNhdXNlIG9mIHRoYXQsIHRoZSBFRUUgc3RhdHVzIGN1cnJlbnRs eSBkZXBlbmRzIG9uIHRoZSBib2FyZCBkZXNpZ24uCj4gPiAKPiA+IFRoZSBFRUVfRElTIGJpdCBv biB0aGUgdHJhcCBwZXJ0YWlucyB0byB0aGUgTEFOMkxFRDAgcGluIHdoaWNoIGlzIHVzdWFsbHkK PiA+IHVzZWQgdG8gY29udHJvbCBhbiBMRUQuIE9uY2UgdGhlIGJpdCBpcyB1bnNldCwgdGhlIHBp biB3aWxsIGJlIGxvdy4gVGhhdAo+ID4gd2lsbCBtYWtlIHRoZSBhY3RpdmUgbG93IExFRCB0dXJu IG9uLiBUaGUgcGluIGlzIGNvbnRyb2xsZWQgYnkgdGhlIHN3aXRjaAo+ID4gUEhZLiBJdCBzZWVt cyB0aGF0IHRoZSBQSFkgY29udHJvbHMgdGhlIHBpbiBpbiB0aGUgd2F5IHRoYXQgaXQgaW52ZXJ0 cyB0aGUKPiA+IHBpbiBzdGF0ZS4gVGhhdCBtZWFucyBkZXBlbmRpbmcgb24gdGhlIHdpcmluZyBv ZiB0aGUgTEVEIGNvbm5lY3RlZCB0bwo+ID4gTEFOMkxFRDAgb24gdGhlIGJvYXJkLCB0aGUgTEVE IG1heSBiZSBvbiB3aXRob3V0IGFuIGFjdGl2ZSBsaW5rLgo+ID4gCj4gPiBUbyBub3QgY2F1c2Ug dGhpcyB1bndhbnRlZCBiZWhhdmlvdXIgd2hpbHN0IGVuYWJsaW5nIEVFRSBvbiBhbGwgYm9hcmRz LCBzZXQKPiA+IHRoZSBpbnRlcm5hbCBFRUUgc3dpdGNoIGJpdCBvbiB0aGUgQ09SRV9QTExfR1JP VVA0IHJlZ2lzdGVyLgo+ID4gCj4gPiBNeSB0ZXN0aW5nIG9uIE1UNzUzMSBzaG93cyBhIGNlcnRh aW4gYW1vdW50IG9mIHRyYWZmaWMgbG9zcyB3aGVuIEVFRSBpcwo+ID4gZW5hYmxlZC4gVGhhdCBz YWlkLCBJIGhhdmVuJ3QgY29tZSBhY3Jvc3MgYSBib2FyZCB0aGF0IGVuYWJsZXMgRUVFLiBTbwo+ ID4gZW5hYmxlIEVFRSBvbiB0aGUgc3dpdGNoIE1BQ3MgYnV0IGRpc2FibGUgRUVFIGFkdmVydGlz ZW1lbnQgb24gdGhlIHN3aXRjaAo+ID4gUEhZcy4gVGhpcyB3YXksIHdlIGRvbid0IGNoYW5nZSB0 aGUgYmVoYXZpb3VyIG9mIHRoZSBtYWpvcml0eSBvZiB0aGUgYm9hcmRzCj4gPiB0aGF0IGhhdmUg dGhpcyBzd2l0Y2guIFRoZSBtZWRpYXRlay1nZSBQSFkgZHJpdmVyIGFscmVhZHkgZGlzYWJsZXMg RUVFCj4gPiBhZHZlcnRpc2VtZW50IG9uIHRoZSBzd2l0Y2ggUEhZcyBidXQgbXkgdGVzdGluZyBz aG93cyB0aGF0IGl0IGlzIHNvbWVob3cKPiA+IGVuYWJsZWQgYWZ0ZXJ3YXJkcy4gRGlzYWJsaW5n IEVFRSBhZHZlcnRpc2VtZW50IGJlZm9yZSB0aGUgUEhZIGRyaXZlcgo+ID4gaW5pdGlhbGlzZXMg a2VlcHMgaXQgb2ZmLgo+ID4gCj4gPiBXaXRoIHRoaXMgY2hhbmdlLCBFRUUgY2FuIG5vdyBiZSBl bmFibGVkIHVzaW5nIGV0aHRvb2wuCj4gPiAKPiA+IEZpeGVzOiA0MGI1ZDJmMTVjMDkgKCJuZXQ6 IGRzYTogbXQ3NTMwOiBBZGQgc3VwcG9ydCBmb3IgRUVFIGZlYXR1cmVzIikKPiA+IFJldmlld2Vk LWJ5OiBGbG9yaWFuIEZhaW5lbGxpIDxmbG9yaWFuLmZhaW5lbGxpQGJyb2FkY29tLmNvbT4KPiA+ IFNpZ25lZC1vZmYtYnk6IEFyxLFuw6cgw5xOQUwgPGFyaW5jLnVuYWxAYXJpbmM5LmNvbT4KPiA+ IC0tLQo+ID4gSGVyZSdzIHNvbWUgaW5mb3JtYXRpb24gZm9yIHRoZSByZWNvcmQuIEVFRSBjb3Vs ZCBub3QgYmUgZW5hYmxlZCBvbiBNVDc1MzEKPiA+IG9uIG1vc3QgYm9hcmRzIHVzaW5nIGV0aHRv b2wgYmVmb3JlIHRoaXMuIE9uIE1UNzk4OCBTb0Mgc3dpdGNoLCBFRUUgaXMKPiA+IGRpc2FibGVk IGJ5IGRlZmF1bHQgYnV0IGNhbiBiZSB0dXJuZWQgb24gbm9ybWFsbHkgdXNpbmcgZXRodG9vbC4g RUVFIGlzCj4gPiBlbmFibGVkIGJ5IGRlZmF1bHQgb24gTVQ3NTMwIGFuZCB0aGVyZSdzIG5vIG5l ZWQgdG8gbWFrZSBjaGFuZ2VzIG9uIHRoZSBEU0EKPiA+IHN1YmRyaXZlciBmb3IgaXQuCj4gPiAt LS0KPiA+IENoYW5nZXMgaW4gdjM6Cj4gPiAtIFJlbW92ZSBwYXRjaCAyLCBpdCB3YXMgcmV2ZWFs ZWQgdGhhdCBpdCBkb2Vzbid0IGZpeCBhIGJ1Zy4KPiA+IC0gUGF0Y2ggMQo+ID4gICAtIFVzZSB0 aGUgaW50ZXJuYWwgRUVFIHN3aXRjaCBiaXQgcHJvdmlkZWQgYnkgU2t5TGFrZSBIdWFuZyAo6buD 5ZWf5r6kKS4gSXQKPiA+ICAgICBpcyBhIGJldHRlciBtZXRob2QgY29tcGFyZWQgdG8gdW5zZXR0 aW5nIHRoZSBFRUVfRElTIGJpdCBvZiB0aGUgdHJhcCBhcwo+ID4gICAgIHRoZSBsYXR0ZXIgbWV0 aG9kIGNhdXNlcyB1bndhbnRlZCBiZWhhdmlvdXIgb24gdGhlIExFRCBjb25uZWN0ZWQgdG8gdGhl Cj4gPiAgICAgcGluIHRoYXQgcGVydGFpbnMgdG8gdGhlIEVFRV9ESVMgYml0Lgo+IAo+IFNpbmNl IHRoaXMgbGV2ZXJhZ2VzIHNvbWV0aGluZyByZWxhdGl2ZWx5IG9ic2N1cmUsIGl0IHdvdWxkIGJl IGdyZWF0IGlmCj4gc29tZW9uZSBpbiB0aGUgQ0MgbGlzdCBjb3VsZCBpbmRlcGVuZGVudGx5IHRl c3QgaXQuIExldCdzIHdhaXQgYSBiaXQKPiBtb3JlLgoKSSd2ZSBleGNlc3NpdmVseSB0ZXN0ZWQg dGhpcyBwYXRjaCBvbiBNVDc1MzEgdG9kYXksIGFuZCByZXZpZXdlZCBpdAp0b2RheSBhbmQgeWVz dGVyZGF5LiBJJ3ZlIGFsc28gcGlja2VkIGl0IGFzIGRvd25zdHJlYW0gcGF0Y2hbMV0gdG8KT3Bl bldydCwgc28gYW4gZXZlbiB3aWRlciBhdWRpZW5jZSB3aWxsIGhhdmUgdGhlIHBsZWFzdXJlIG9m IHdvcmtpbmcKRUVFIG9uIHRob3NlIHN3aXRjaCBJQ3MgYW5kIGluLVNvQyBzd2l0Y2hlcy4KClRl c3RlZC1ieTogRGFuaWVsIEdvbGxlIDxkYW5pZWxAbWFrcm90b3BpYS5vcmc+ClJldmlld2VkLWJ5 OiBEYW5pZWwgR29sbGUgPGRhbmllbEBtYWtyb3RvcGlhLm9yZz4KClsxXTogaHR0cHM6Ly9naXQu b3BlbndydC5vcmcvP3A9b3BlbndydC9vcGVud3J0LmdpdDthPWNvbW1pdDtoPTk4ZjkxNTQzMTZm ZTgzNzFjNzA5YmQxMWFlOGYyNjNlMjIwNzVlYzYKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK