From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ziyang Xuan <william.xuanziyang@huawei.com>
Cc: kadlec@netfilter.org, netfilter-devel@vger.kernel.org, fw@strlen.de
Subject: Re: [PATCH nft 1/2] netfilter: nf_tables: Fix potential data-race in __nft_expr_type_get()
Date: Thu, 11 Apr 2024 12:04:28 +0200 [thread overview]
Message-ID: <Zhe1rNYaJ2ehkFOt@calendula> (raw)
In-Reply-To: <15ed198f9be877a704af51b906cf2fd655d8590b.1712472595.git.william.xuanziyang@huawei.com>
On Sun, Apr 07, 2024 at 02:56:04PM +0800, Ziyang Xuan wrote:
> nft_unregister_expr() can concurrent with __nft_expr_type_get(),
> and there is not any protection when iterate over nf_tables_expressions
> list in __nft_expr_type_get(). Therefore, there is pertential
> data-race of nf_tables_expressions list entry.
>
> Use list_for_each_entry_rcu() to iterate over nf_tables_expressions
> list in __nft_expr_type_get(), and use rcu_read_lock() in the caller
> nft_expr_type_get() to protect the entire type query process.
Applied to nf, thanks
next prev parent reply other threads:[~2024-04-11 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-07 6:56 [PATCH nft 0/2] netfilter: nf_tables: Use rcu lock to enhance protection of the lists Ziyang Xuan
2024-04-07 6:56 ` [PATCH nft 1/2] netfilter: nf_tables: Fix potential data-race in __nft_expr_type_get() Ziyang Xuan
2024-04-11 10:04 ` Pablo Neira Ayuso [this message]
2024-04-07 6:56 ` [PATCH nft 2/2] netfilter: nf_tables: Fix potential data-race in __nft_obj_type_get() Ziyang Xuan
2024-04-11 10:05 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zhe1rNYaJ2ehkFOt@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=william.xuanziyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.