All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Nikita Kiryushin <kiryushin@ancud.ru>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ashok Raj <ashok.raj@intel.com>,
	David Woodhouse <dwmw@amazon.co.uk>,
	linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] x86/smpboot: Add map vars allocation check in smp_prepare_cpus_common
Date: Thu, 11 Apr 2024 10:43:12 +0200	[thread overview]
Message-ID: <ZheioNCrbeT+0UHR@gmail.com> (raw)
In-Reply-To: <75c2b85a-da67-4037-b2b5-6a1dec838fa9@ancud.ru>


* Nikita Kiryushin <kiryushin@ancud.ru> wrote:

> But I have some questions considering __GFP_NOFAIL. It clearly shows, 
> that allocation will not fail/is not expected to fail, does it not try 
> making allocation until it succeeds? Would not it make the system hang in 
> a problematic case?

Yes, which is better than undefined behavior. This case should only happen 
on hopelessly buggy kernels or hopelessly buggy hardware - which will very 
likely crash way sooner before they get into this part of the init 
sequence.

This whole problem is a non-issue.

Thanks,

	Ingo

      reply	other threads:[~2024-04-11  8:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-09 18:29 [PATCH] x86/smpboot: Add map vars allocation check in smp_prepare_cpus_common Nikita Kiryushin
2024-04-10 13:30 ` Ingo Molnar
2024-04-10 18:00   ` Nikita Kiryushin
2024-04-11  8:43     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZheioNCrbeT+0UHR@gmail.com \
    --to=mingo@kernel.org \
    --cc=ashok.raj@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=dwmw@amazon.co.uk \
    --cc=hpa@zytor.com \
    --cc=kiryushin@ancud.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.