Re: [PATCH ipsec-next v9] xfrm: Add Direction to the SA in or out

[Steffen Klassert <steffen.klassert@secunet.com>]

On Thu, Apr 11, 2024 at 11:05:02AM +0200, Nicolas Dichtel wrote:
> Le 11/04/2024 à 09:22, Steffen Klassert a écrit :
> > On Wed, Apr 10, 2024 at 10:37:27AM +0200, Nicolas Dichtel wrote:
> >> Le 10/04/2024 à 10:17, Sabrina Dubroca a écrit :
> >> [snip]
> >>>> Why isn't it possible to restrict the use of an input SA to the input path and
> >>>> output SA to xmit path?
> >>>
> >>> Because nobody has written a patch for it yet :)
> >>>
> >> For me, it should be done in this patch/series ;-)
> > 
> > I tend to disagree here. Adding the direction as a lookup key
> > is IMO beyond the scope of this patch. That's complicated and
> > would defer this series by months. Given that the upcomming IPTFS
> > implementation has a lot of direction specific config options,
> > it makes sense to take that this patch now. Otherwise we have the
> > direction specific options in input and output states forever.
> I don't understand why the direction could not be mandatory and checked for new
> options only (offload, iptfs, etc.) and reject for legacy use cases.

Because every state has a direction and it should be marked explictly.
As said, IMO it should have been like that from the beginning.