From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Date: Thu, 11 Apr 2024 14:47:56 -0400 Subject: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback In-Reply-To: References: <20240405115815.3226315-1-pbonzini@redhat.com> <20240405115815.3226315-2-pbonzini@redhat.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Apr 11, 2024 at 06:55:44PM +0200, Paolo Bonzini wrote: > On Mon, Apr 8, 2024 at 3:56?PM Peter Xu wrote: > > Paolo, > > > > I may miss a bunch of details here (as I still remember some change_pte > > patches previously on the list..), however not sure whether we considered > > enable it? Asked because I remember Andrea used to have a custom tree > > maintaining that part: > > > > https://github.com/aagit/aa/commit/c761078df7a77d13ddfaeebe56a0f4bc128b1968 > > The patch enables it only for KSM, so it would still require a bunch > of cleanups, for example I also would still use set_pte_at() in all > the places that are not KSM. This would at least fix the issue with > the poor documentation of where to use set_pte_at_notify() vs > set_pte_at(). > > With regard to the implementation, I like the idea of disabling the > invalidation on the MMU notifier side, but I would rather have > MMU_NOTIFIER_CHANGE_PTE as a separate field in the range instead of > overloading the event field. > > > Maybe it can't be enabled for some reason that I overlooked in the current > > tree, or we just decided to not to? > > I have just learnt about the patch, nobody had ever mentioned it even > though it's almost 2 years old... It's a lot of code though and no one > has ever reported an issue for over 10 years, so I think it's easiest > to just rip the code out. Right, it was pretty old and I have no idea if that was discussed or published before.. It would be better to have discussed this earlier. As long as we have a decision with that being aware and in mind, then it looks fine to me to take either way to go, and I also agree either way is better than keep the status quo. I also have Andrea copied anyway when I replied, so I guess he should be aware of this and he can chim in anytime. Thanks! -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF5FBDF5C for ; Thu, 11 Apr 2024 18:48:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712861284; cv=none; b=TChThonFE6xyuR9mcTe5ru3zoZg9oKf3sVf7q9gD1AM+uaVbdWCfYPexj+xmQW7uN4dPxSVyufKvw0oZGW+d/VU19i808fJrXumI0bL8GIjqK442djfcsMR/NXahvyyDOyu1VoHvU6xnthmwcaw/CLrduFA8331Wus7/jolBAiY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712861284; c=relaxed/simple; bh=HfoacRHaPwwnTCmXDkoKk1PJpiX4sznxb7ZH8+YFYQA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=JdxOV7sWkRH5wx7kQ988m1UzQAyAukn2IGAa8oLki7bISU5Ldm8U/1J4u0jJ6jUQ7RrXqyoFTxKZhJOHWwFemZ1nD/du0+wWhqvWEfUC3tyBWZD5mYmKq65ggZDS+lxZvsf+mOJSY/TO6f5xPVhIN7n04dcBf7o3N+IanvVR5ns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=imMqXDly; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="imMqXDly" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712861282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KZYsCvW//u/CQQXOA7VquWR1RJVn5i/6cYVGpW0idNY=; b=imMqXDlyYRB3gASRX7MzCg2dE5VCfCb3OpbDsrjxtY6cIb/uw9+y3HiKQ5YQqCyD2oX5/1 vAw8UKke3EXmDQXiW/G5/dj8WLnBoyFPEwW1vevz900eSgZSN3aP/izEvxGx6JbHuyvLlO +lF1ize9TRw+1dYEl+MIu5zqu+24ylk= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-fFZ5r3dyOn-NmuwGR-wH9Q-1; Thu, 11 Apr 2024 14:48:00 -0400 X-MC-Unique: fFZ5r3dyOn-NmuwGR-wH9Q-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-69b147e856aso665796d6.1 for ; Thu, 11 Apr 2024 11:48:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712861280; x=1713466080; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KZYsCvW//u/CQQXOA7VquWR1RJVn5i/6cYVGpW0idNY=; b=KIQTNVc2mHj8y0h3VQH4kVY6yaVfqZYMQbwAuc7isT/lOftptyicIL1p46n68P0Onl 7DTnDe7Q/dl39EmRyk9jLWMHndXfs3WkEbcwWNwUE7iz8Qs7HkaVZ4/l3YL+gzkfXUtJ ffubHgJofLMlHKpF3mlqsMPzTcvFlvRZErDBW7Ew8xvGsTuN0q9cPuZ1sjhP5M1HeVz5 NeJX7AlGmfNAW50KIL8ROG/WVhx+4CxPE2KRgY8s5QtIG/9uWK3RpjN3C4J9JGOa3st5 fHqNXpGVgXvpME7hTVpd2MTxRNrzJZg+4Pi5BTE48X/SI0iSwaOre3jSVL7K9oRD6zcB RCzA== X-Forwarded-Encrypted: i=1; AJvYcCXOlrZJdhBmNb4KoafgAni2Jaxrnw5flkjZcBTfiNZud7JqUqA/4eUwzlcnJPVDW9Pl68UQHsW4CdewmAle+hRWjvDIgCU3 X-Gm-Message-State: AOJu0YzzGFKCqC7KKh5F+JGEwxa7gs1LWYaVoBG7D3Qq8/4nMyXYOspQ FzIQqCEESx1Diubn9/Vmabl9BTt4RkrK4KcO2/1ebR9QH7MSDOsAklARsMwbtWSZSGyb20fSOck lF5kJ8vJaVrrSW0QwK6A+k3IRKgCOGVU2vvttLfWUGeuonBZLSCrt7g== X-Received: by 2002:a05:6214:5299:b0:69b:1c5c:28fb with SMTP id kj25-20020a056214529900b0069b1c5c28fbmr648134qvb.0.1712861279771; Thu, 11 Apr 2024 11:47:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE7S/NCpZfvRlaXUMSJjHCJMO0BUAFkMZwp6uvumqLHKeYZXzRRk2gozszNqWEk8Im7F5OglA== X-Received: by 2002:a05:6214:5299:b0:69b:1c5c:28fb with SMTP id kj25-20020a056214529900b0069b1c5c28fbmr648100qvb.0.1712861279132; Thu, 11 Apr 2024 11:47:59 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id ej6-20020ad45a46000000b00696b1050be8sm1276159qvb.133.2024.04.11.11.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 11:47:58 -0700 (PDT) Date: Thu, 11 Apr 2024 14:47:56 -0400 From: Peter Xu To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Thomas Bogendoerfer , Nicholas Piggin , Anup Patel , Atish Patra , Sean Christopherson , Andrew Morton , David Hildenbrand , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrea Arcangeli Subject: Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback Message-ID: References: <20240405115815.3226315-1-pbonzini@redhat.com> <20240405115815.3226315-2-pbonzini@redhat.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Apr 11, 2024 at 06:55:44PM +0200, Paolo Bonzini wrote: > On Mon, Apr 8, 2024 at 3:56 PM Peter Xu wrote: > > Paolo, > > > > I may miss a bunch of details here (as I still remember some change_pte > > patches previously on the list..), however not sure whether we considered > > enable it? Asked because I remember Andrea used to have a custom tree > > maintaining that part: > > > > https://github.com/aagit/aa/commit/c761078df7a77d13ddfaeebe56a0f4bc128b1968 > > The patch enables it only for KSM, so it would still require a bunch > of cleanups, for example I also would still use set_pte_at() in all > the places that are not KSM. This would at least fix the issue with > the poor documentation of where to use set_pte_at_notify() vs > set_pte_at(). > > With regard to the implementation, I like the idea of disabling the > invalidation on the MMU notifier side, but I would rather have > MMU_NOTIFIER_CHANGE_PTE as a separate field in the range instead of > overloading the event field. > > > Maybe it can't be enabled for some reason that I overlooked in the current > > tree, or we just decided to not to? > > I have just learnt about the patch, nobody had ever mentioned it even > though it's almost 2 years old... It's a lot of code though and no one > has ever reported an issue for over 10 years, so I think it's easiest > to just rip the code out. Right, it was pretty old and I have no idea if that was discussed or published before.. It would be better to have discussed this earlier. As long as we have a decision with that being aware and in mind, then it looks fine to me to take either way to go, and I also agree either way is better than keep the status quo. I also have Andrea copied anyway when I replied, so I guess he should be aware of this and he can chim in anytime. Thanks! -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28F03C4345F for ; Thu, 11 Apr 2024 18:48:51 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Pk5ljdD0; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=imMqXDly; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VFpcx5hBvz3vcX for ; Fri, 12 Apr 2024 04:48:49 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Pk5ljdD0; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=imMqXDly; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=peterx@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VFpc56N1hz3dh2 for ; Fri, 12 Apr 2024 04:48:04 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712861281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KZYsCvW//u/CQQXOA7VquWR1RJVn5i/6cYVGpW0idNY=; b=Pk5ljdD0oUnRW7iDww4rX/ryDsWMssYKEBjKNDWG0I1v1F+zHYUkdxQPphS+2poSu45fzn Fef4Lw9JtRd/hcKF1Y8vT5CM5UMLzDufWU/GZt9VbKq2m8CDiwAqCrbE5xEm25d9XaesOx zrgyrv2V0iqSb98Pz8Blpc9aLNI8YsM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712861282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KZYsCvW//u/CQQXOA7VquWR1RJVn5i/6cYVGpW0idNY=; b=imMqXDlyYRB3gASRX7MzCg2dE5VCfCb3OpbDsrjxtY6cIb/uw9+y3HiKQ5YQqCyD2oX5/1 vAw8UKke3EXmDQXiW/G5/dj8WLnBoyFPEwW1vevz900eSgZSN3aP/izEvxGx6JbHuyvLlO +lF1ize9TRw+1dYEl+MIu5zqu+24ylk= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-658-gHjaQA7IOpi29HLxarAC_w-1; Thu, 11 Apr 2024 14:48:00 -0400 X-MC-Unique: gHjaQA7IOpi29HLxarAC_w-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-69a01201ca0so696856d6.0 for ; Thu, 11 Apr 2024 11:48:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712861280; x=1713466080; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KZYsCvW//u/CQQXOA7VquWR1RJVn5i/6cYVGpW0idNY=; b=r5eaUqx9s53Iu+TA442aqiIDRxNKuIyMG9ZujVg6AdUF31OQ6jzAzpRD/8ORi0owpJ 2S8LcEtZMQhKBFbBw4/MrIqLixlciTezwpGqQ/fx5TJEpv6Am1GsDb0B4loYbVxNCx3v BirPAQKDDKMLnmSLGWJqeDeY5lTzXxfV1IpJcLa/WcnKlwtP4qBCrgq7WtBMkmO1UqGC FqaErfVeAEkVQoZpIA8kbpjeMS+mVh7ebkn3oyAvPT3B/T1NOmeHIo3CJDfAXb4pai0s Lnw8th8DetK7CPcxr+wb/D1wPla/6VL0sFzik9vwVcACG8/XaF/rFo2c6hEm4Z1e1FuX NEeA== X-Forwarded-Encrypted: i=1; AJvYcCVa3NZAVD8A7Rjtbza/f74G++T/pXm5kU2Z/k4yRQCveBvOqu4DYifgakTh9aLLxsi5FBBl962hp0YN1mHIPsq1gsb5Tv7iaBFlgbd4/Q== X-Gm-Message-State: AOJu0Yya+YId9BBLoxCgzIvOEnqhQVLgzTQ0rR4qRciypKUsmc1DOYQV qixO9wPWSxHIc/1yD+Kgw5eSkyp8z67uI1MpB4sY4gw+iBK6Yjo+sIBt+oqvD+FZI+OJsBayrw2 XlYpFyBA6D5417jgRiptS0Y7t3JrE9hMPpx4MZZG4ZFOWLxGW0Vem6D4x2VoncXE= X-Received: by 2002:a05:6214:5299:b0:69b:1c5c:28fb with SMTP id kj25-20020a056214529900b0069b1c5c28fbmr648128qvb.0.1712861279769; Thu, 11 Apr 2024 11:47:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE7S/NCpZfvRlaXUMSJjHCJMO0BUAFkMZwp6uvumqLHKeYZXzRRk2gozszNqWEk8Im7F5OglA== X-Received: by 2002:a05:6214:5299:b0:69b:1c5c:28fb with SMTP id kj25-20020a056214529900b0069b1c5c28fbmr648100qvb.0.1712861279132; Thu, 11 Apr 2024 11:47:59 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id ej6-20020ad45a46000000b00696b1050be8sm1276159qvb.133.2024.04.11.11.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 11:47:58 -0700 (PDT) Date: Thu, 11 Apr 2024 14:47:56 -0400 From: Peter Xu To: Paolo Bonzini Subject: Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback Message-ID: References: <20240405115815.3226315-1-pbonzini@redhat.com> <20240405115815.3226315-2-pbonzini@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, David Hildenbrand , linux-mips@vger.kernel.org, linux-mm@kvack.org, Andrea Arcangeli , Marc Zyngier , linux-trace-kernel@vger.kernel.org, Nicholas Piggin , Bibo Mao , loongarch@lists.linux.dev, Atish Patra , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Sean Christopherson , linux-kernel@vger.kernel.org, Oliver Upton , linux-perf-users@vger.kernel.org, kvm-riscv@lists.infradead.org, Anup Patel , Andrew Morton , Tianrui Zhao , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Apr 11, 2024 at 06:55:44PM +0200, Paolo Bonzini wrote: > On Mon, Apr 8, 2024 at 3:56 PM Peter Xu wrote: > > Paolo, > > > > I may miss a bunch of details here (as I still remember some change_pte > > patches previously on the list..), however not sure whether we considered > > enable it? Asked because I remember Andrea used to have a custom tree > > maintaining that part: > > > > https://github.com/aagit/aa/commit/c761078df7a77d13ddfaeebe56a0f4bc128b1968 > > The patch enables it only for KSM, so it would still require a bunch > of cleanups, for example I also would still use set_pte_at() in all > the places that are not KSM. This would at least fix the issue with > the poor documentation of where to use set_pte_at_notify() vs > set_pte_at(). > > With regard to the implementation, I like the idea of disabling the > invalidation on the MMU notifier side, but I would rather have > MMU_NOTIFIER_CHANGE_PTE as a separate field in the range instead of > overloading the event field. > > > Maybe it can't be enabled for some reason that I overlooked in the current > > tree, or we just decided to not to? > > I have just learnt about the patch, nobody had ever mentioned it even > though it's almost 2 years old... It's a lot of code though and no one > has ever reported an issue for over 10 years, so I think it's easiest > to just rip the code out. Right, it was pretty old and I have no idea if that was discussed or published before.. It would be better to have discussed this earlier. As long as we have a decision with that being aware and in mind, then it looks fine to me to take either way to go, and I also agree either way is better than keep the status quo. I also have Andrea copied anyway when I replied, so I guess he should be aware of this and he can chim in anytime. Thanks! -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46E07C4345F for ; Thu, 11 Apr 2024 18:48:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=avj4Avfdwqufka04qAhkSG3vdNwNCO0EYdNNOfBvJwQ=; b=vpbHyOqs1TP1sT k92lTVF34OGqg9T/eaJyia9wxYp/3s+AV6M/VSkrqrE7cmXIsqY3paD3sZlbMkCSAZlWbecjRBI/V UnZj7cCZzQv940yGkFst2jBudqvtm6nG2YN4NXRY1x0hWMKw28370H1SBZdHDHYdyMpuB3Ffcvfa0 Ot2g7NGhVv2GTzGoJqcGdN0d0HdFL+Bk+GpTe9SCzF/kOsvTBOL6/TF27T4nRtHZXHELdca1W/Sk5 pp3COwMsa1EBBXlZeaf+F1kkQeLc4JmMODzCHqe0TOv5Ymx18rXS+0RZYLYkoURJD1fHLdRy+//rZ QDvJQoD7DlOnE8ywhDnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruzSx-0000000Dlbp-2jHK; Thu, 11 Apr 2024 18:48:07 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruzSu-0000000Dlb4-3wQK for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2024 18:48:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712861283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KZYsCvW//u/CQQXOA7VquWR1RJVn5i/6cYVGpW0idNY=; b=aFKWrQW60TAAZ+MkH5r/5SNShUtcUiIJYSw4jX2gF1HpRBjnLp4z9CZoK3UGv7Dri1SUus SqQ09ZIGKXQxC0gLW4Dzxcm50/87nZrhiHjxvrYU8QaktEdfOjO1OeTn9GnKNfVmSM2Tsj qV4S3konwmjLG0ZBbgN5ZXzaEdgItzM= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-_Kl6I9cuNwCjM5dr6VwuTQ-1; Thu, 11 Apr 2024 14:48:00 -0400 X-MC-Unique: _Kl6I9cuNwCjM5dr6VwuTQ-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-69b147e856aso665726d6.1 for ; Thu, 11 Apr 2024 11:48:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712861280; x=1713466080; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KZYsCvW//u/CQQXOA7VquWR1RJVn5i/6cYVGpW0idNY=; b=nPlUpinH8dQbwQhcAS8UbRr+VRt/HGskdd2gqTtJDCIehnXJXHNi1chrizBYuqwWqx WpM61Dbx/+1LAhps97qoGwwoeH59II9qswU6m31W3iMP21VjW3SSNQmVx2N6NcYrgV1T rpkVhpqwbK+EZdNAQmQN3u8UMsUAS60pQRhIGCV/hONbW+DXvfn3bk9Dfn4luN1P8WHn efe29gBjjENl4YIQMeH+8kwEN1ccpzfIfG3JjffcUKCmYKn+oK69hs1DVK4mNMVb0lLk /n0EgaiZTnmozZO7uPcYSV8KfaRMPhbrcEaSaQnxC9c6IU1CakBYjWMiq7EjV9GpBtDz LBCA== X-Forwarded-Encrypted: i=1; AJvYcCURkbNplxgfDj9jhAtczOxYExlteWjDisyRabtJjFtXgsncTQ35V0rOXIIu5OsxI/kwCvb6C6t1el6YnfPHLEOiamPZ4HZB9XNIUGaeYwE6gnuvs14= X-Gm-Message-State: AOJu0YwL1jvzH8juxEMZL5EhiTJKxJPxIdLKBtYwPSzcE2SWcVodx3Rt oSLymQdBV3PR17zFojyQmw6sB0L56JtryQTWVrFeLgs78QZ4xvhzipKv1/B7tm1CQeOvLIk0/GA soMkzQ08sjRP3pihv7iAjdntk8dtXAkTyo3PPNic4EyctlpPeY+9NqA/XRAiIJ0u92FS11k6P X-Received: by 2002:a05:6214:5299:b0:69b:1c5c:28fb with SMTP id kj25-20020a056214529900b0069b1c5c28fbmr648126qvb.0.1712861279769; Thu, 11 Apr 2024 11:47:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE7S/NCpZfvRlaXUMSJjHCJMO0BUAFkMZwp6uvumqLHKeYZXzRRk2gozszNqWEk8Im7F5OglA== X-Received: by 2002:a05:6214:5299:b0:69b:1c5c:28fb with SMTP id kj25-20020a056214529900b0069b1c5c28fbmr648100qvb.0.1712861279132; Thu, 11 Apr 2024 11:47:59 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id ej6-20020ad45a46000000b00696b1050be8sm1276159qvb.133.2024.04.11.11.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 11:47:58 -0700 (PDT) Date: Thu, 11 Apr 2024 14:47:56 -0400 From: Peter Xu To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Thomas Bogendoerfer , Nicholas Piggin , Anup Patel , Atish Patra , Sean Christopherson , Andrew Morton , David Hildenbrand , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrea Arcangeli Subject: Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback Message-ID: References: <20240405115815.3226315-1-pbonzini@redhat.com> <20240405115815.3226315-2-pbonzini@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240411_114805_133504_9B0004F0 X-CRM114-Status: GOOD ( 25.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMTEsIDIwMjQgYXQgMDY6NTU6NDRQTSArMDIwMCwgUGFvbG8gQm9uemluaSB3 cm90ZToKPiBPbiBNb24sIEFwciA4LCAyMDI0IGF0IDM6NTbigK9QTSBQZXRlciBYdSA8cGV0ZXJ4 QHJlZGhhdC5jb20+IHdyb3RlOgo+ID4gUGFvbG8sCj4gPgo+ID4gSSBtYXkgbWlzcyBhIGJ1bmNo IG9mIGRldGFpbHMgaGVyZSAoYXMgSSBzdGlsbCByZW1lbWJlciBzb21lIGNoYW5nZV9wdGUKPiA+ IHBhdGNoZXMgcHJldmlvdXNseSBvbiB0aGUgbGlzdC4uKSwgaG93ZXZlciBub3Qgc3VyZSB3aGV0 aGVyIHdlIGNvbnNpZGVyZWQKPiA+IGVuYWJsZSBpdD8gIEFza2VkIGJlY2F1c2UgSSByZW1lbWJl ciBBbmRyZWEgdXNlZCB0byBoYXZlIGEgY3VzdG9tIHRyZWUKPiA+IG1haW50YWluaW5nIHRoYXQg cGFydDoKPiA+Cj4gPiBodHRwczovL2dpdGh1Yi5jb20vYWFnaXQvYWEvY29tbWl0L2M3NjEwNzhk ZjdhNzdkMTNkZGZhZWViZTU2YTBmNGJjMTI4YjE5NjgKPiAKPiBUaGUgcGF0Y2ggZW5hYmxlcyBp dCBvbmx5IGZvciBLU00sIHNvIGl0IHdvdWxkIHN0aWxsIHJlcXVpcmUgYSBidW5jaAo+IG9mIGNs ZWFudXBzLCBmb3IgZXhhbXBsZSBJIGFsc28gd291bGQgc3RpbGwgdXNlIHNldF9wdGVfYXQoKSBp biBhbGwKPiB0aGUgcGxhY2VzIHRoYXQgYXJlIG5vdCBLU00uIFRoaXMgd291bGQgYXQgbGVhc3Qg Zml4IHRoZSBpc3N1ZSB3aXRoCj4gdGhlIHBvb3IgZG9jdW1lbnRhdGlvbiBvZiB3aGVyZSB0byB1 c2Ugc2V0X3B0ZV9hdF9ub3RpZnkoKSB2cwo+IHNldF9wdGVfYXQoKS4KPiAKPiBXaXRoIHJlZ2Fy ZCB0byB0aGUgaW1wbGVtZW50YXRpb24sIEkgbGlrZSB0aGUgaWRlYSBvZiBkaXNhYmxpbmcgdGhl Cj4gaW52YWxpZGF0aW9uIG9uIHRoZSBNTVUgbm90aWZpZXIgc2lkZSwgYnV0IEkgd291bGQgcmF0 aGVyIGhhdmUKPiBNTVVfTk9USUZJRVJfQ0hBTkdFX1BURSBhcyBhIHNlcGFyYXRlIGZpZWxkIGlu IHRoZSByYW5nZSBpbnN0ZWFkIG9mCj4gb3ZlcmxvYWRpbmcgdGhlIGV2ZW50IGZpZWxkLgo+IAo+ ID4gTWF5YmUgaXQgY2FuJ3QgYmUgZW5hYmxlZCBmb3Igc29tZSByZWFzb24gdGhhdCBJIG92ZXJs b29rZWQgaW4gdGhlIGN1cnJlbnQKPiA+IHRyZWUsIG9yIHdlIGp1c3QgZGVjaWRlZCB0byBub3Qg dG8/Cj4gCj4gSSBoYXZlIGp1c3QgbGVhcm50IGFib3V0IHRoZSBwYXRjaCwgbm9ib2R5IGhhZCBl dmVyIG1lbnRpb25lZCBpdCBldmVuCj4gdGhvdWdoIGl0J3MgYWxtb3N0IDIgeWVhcnMgb2xkLi4u IEl0J3MgYSBsb3Qgb2YgY29kZSB0aG91Z2ggYW5kIG5vIG9uZQo+IGhhcyBldmVyIHJlcG9ydGVk IGFuIGlzc3VlIGZvciBvdmVyIDEwIHllYXJzLCBzbyBJIHRoaW5rIGl0J3MgZWFzaWVzdAo+IHRv IGp1c3QgcmlwIHRoZSBjb2RlIG91dC4KClJpZ2h0LCBpdCB3YXMgcHJldHR5IG9sZCBhbmQgSSBo YXZlIG5vIGlkZWEgaWYgdGhhdCB3YXMgZGlzY3Vzc2VkIG9yCnB1Ymxpc2hlZCBiZWZvcmUuLiAg SXQgd291bGQgYmUgYmV0dGVyIHRvIGhhdmUgZGlzY3Vzc2VkIHRoaXMgZWFybGllci4KCkFzIGxv bmcgYXMgd2UgaGF2ZSBhIGRlY2lzaW9uIHdpdGggdGhhdCBiZWluZyBhd2FyZSBhbmQgaW4gbWlu ZCwgdGhlbiBpdApsb29rcyBmaW5lIHRvIG1lIHRvIHRha2UgZWl0aGVyIHdheSB0byBnbywgYW5k IEkgYWxzbyBhZ3JlZSBlaXRoZXIgd2F5IGlzCmJldHRlciB0aGFuIGtlZXAgdGhlIHN0YXR1cyBx dW8uCgpJIGFsc28gaGF2ZSBBbmRyZWEgY29waWVkIGFueXdheSB3aGVuIEkgcmVwbGllZCwgc28g SSBndWVzcyBoZSBzaG91bGQgYmUKYXdhcmUgb2YgdGhpcyBhbmQgaGUgY2FuIGNoaW0gaW4gYW55 dGltZS4KClRoYW5rcyEKCi0tIApQZXRlciBYdQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK