From: Peter Xu <peterx@redhat.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Suren Baghdasaryan <surenb@google.com>,
Lokesh Gidra <lokeshgidra@google.com>,
Alistair Popple <apopple@nvidia.com>
Subject: Re: [PATCH] mm: Always sanity check anon_vma first for per-vma locks
Date: Thu, 11 Apr 2024 17:46:45 -0400 [thread overview]
Message-ID: <ZhhaRXHKk7w_hKgi@x1n> (raw)
In-Reply-To: <ZhhV3PKgEX9d7_vA@casper.infradead.org>
On Thu, Apr 11, 2024 at 10:27:56PM +0100, Matthew Wilcox wrote:
> On Thu, Apr 11, 2024 at 05:12:02PM -0400, Peter Xu wrote:
> > The question is whether that's intended to make it as complicated. For
> > example, why don't we check anon_vma for anonymous too later when prepare
> > anon_vma, however we do it late for file memory. AFAICT there's nothing
> > special with file memory in this case.
>
> Yes, it's absolutely intended. If anything, anon memory is the special
> case that checks up-front.
>
> Congratulations on adding additional instructions to the common case.
> I don't understand why you persist with your nonsense. Please stop.
How many instructions it takes for a late RETRY for WRITEs to private file
mappings, fallback to mmap_sem?
Did you even finish reading the patch at all?
--
Peter Xu
next prev parent reply other threads:[~2024-04-11 21:46 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 17:06 [PATCH] mm: Always sanity check anon_vma first for per-vma locks Peter Xu
2024-04-10 20:26 ` Matthew Wilcox
2024-04-10 20:43 ` Peter Xu
2024-04-10 21:10 ` Matthew Wilcox
2024-04-10 21:23 ` Peter Xu
2024-04-10 23:59 ` Matthew Wilcox
2024-04-11 0:20 ` Peter Xu
2024-04-11 14:50 ` Matthew Wilcox
2024-04-11 15:34 ` Peter Xu
2024-04-11 17:14 ` Matthew Wilcox
2024-04-11 15:42 ` Suren Baghdasaryan
2024-04-11 17:13 ` Liam R. Howlett
2024-04-11 21:12 ` Peter Xu
2024-04-11 21:27 ` Matthew Wilcox
2024-04-11 21:46 ` Peter Xu [this message]
2024-04-11 22:02 ` Matthew Wilcox
2024-04-12 3:14 ` Matthew Wilcox
2024-04-12 12:38 ` Peter Xu
2024-04-12 13:06 ` Suren Baghdasaryan
2024-04-12 14:16 ` Matthew Wilcox
2024-04-12 14:53 ` Suren Baghdasaryan
2024-04-12 15:19 ` Matthew Wilcox
2024-04-12 15:31 ` Matthew Wilcox
2024-04-13 21:46 ` Suren Baghdasaryan
2024-04-13 22:52 ` Matthew Wilcox
2024-04-13 23:11 ` Suren Baghdasaryan
2024-04-13 21:41 ` Suren Baghdasaryan
2024-04-13 22:46 ` Matthew Wilcox
2024-04-15 15:58 ` Suren Baghdasaryan
2024-04-15 16:13 ` Matthew Wilcox
2024-04-15 16:19 ` Suren Baghdasaryan
2024-04-15 16:26 ` Matthew Wilcox
2024-04-12 12:46 ` Suren Baghdasaryan
2024-04-12 13:32 ` Matthew Wilcox
2024-04-12 13:46 ` Suren Baghdasaryan
2024-04-26 14:00 ` Matthew Wilcox
2024-04-26 15:07 ` Suren Baghdasaryan
2024-04-26 15:28 ` Matthew Wilcox
2024-04-26 15:32 ` Suren Baghdasaryan
2024-04-26 15:50 ` Matthew Wilcox
2024-04-26 15:32 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhhaRXHKk7w_hKgi@x1n \
--to=peterx@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lokeshgidra@google.com \
--cc=surenb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.