From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8477114EC49 for ; Fri, 12 Apr 2024 18:22:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712946142; cv=none; b=MRpqnCo2ioFC6JD5bqVnly+FIc+aZZr+qoqPhRafZyzPKiFKsNvwN/96d5ATz36F5i91zv5uXXdZjGK7PvulYLOOaS4i73amxA9MBBtZY8SpdpZ4DXl9YGH1YgQuD7AFF8scHPB33tLhh4ivt+Jy3yAltSsK3L8mQX5sO2v+leY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712946142; c=relaxed/simple; bh=3GwZHEj4k5rWl1wxWnzlMV8+5rajQDaKeZirl4b7xhM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hEjHsTXCZXqbe9E7MIcEr1VIFMc0ubSdTLl687P6A9Fz6EYEmyz89roezA9goFc2iEITImHLM03l/F3aOAXd8qAbAGBuo4H9TtqJRCsbWKLF7qIydUDzj1fSjzKl+LhlZ3VysMYm2pIMKjSmEgOfw0iGZmPhcMdFwEroEDdCdfQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=O/zY5m5F; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="O/zY5m5F" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6ed32341906so1242941b3a.1 for ; Fri, 12 Apr 2024 11:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1712946140; x=1713550940; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=wCHPnhyTcC9ocJWJcXngwPv4ks2H4M0UEeE7J2w7Lsc=; b=O/zY5m5FP2CbA5DKvp1DxqyQU5vjyJIfhmYRAMR1srJ03P9LX+Cik8eWvtXS8cBXcg j9SIKdGSk0waJ9EqWN9rkAish3Hzr8bYwlXGUpEM1Xy36eEcD7XEjv1n03jzXmzNLmsR Xg9rHKeyWNqjVXFIwBCq0UdiroJYK9JioKBY64S/rKqPdTDcxLY7h7SQZZ+hogqfuFFr c/epbC++2jkJbPVmhk05GyhF5PxkH0ksfIx1SEVnCQP2qDWxfdFzQa3Kh7n2yp9GZJtc cDStlAGmtm/cYpOn0b08RUINTly1lpoKokjSWdkhjv0rcE0ZlpHsmjvx0OoArQWPXywW FyZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712946140; x=1713550940; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wCHPnhyTcC9ocJWJcXngwPv4ks2H4M0UEeE7J2w7Lsc=; b=aR2hTu5atWKujWjE6c+8sG9HQXYYGRN84ZH7qcjh11N+2KS0ft2c2KDjXaEwIPOgMq veR5PFEX3N6Qbd8TOZotj/tnjxw5by/sGb3nbeHEHo06ZzaCDzOPIO3G35u2MqD/Rg4y miCfsEvFOXCCcVSQgK9cnxSJWDa+S4RY5ioX7LHC4BkFzM6PkqwCppemSiRh+2FxqoBh 13Kpms8QujtHrwdZroEU4fTZYaLt2pWr9LQuE9v5EcbkVmY4vfE2U0fqgTnQrjLDncq5 JXjepDbASzOeHAGuBZw7JOn+RIKFlyVo/RytO3kFS3fMcz5PR6BfzdJQJmsnPore3xMR ysxA== X-Forwarded-Encrypted: i=1; AJvYcCWbkMckkP0wwZu2hJJKBJRDhdfGVzi35ONa1GQ5EGVUVYT2ZkzSXMG1WWTrkCuwwuPXOarbAcj8sQIFQvnXFTbRIT8+jrSunZtB X-Gm-Message-State: AOJu0Yxum8dVuFJrXTZJs+OL+bZKIFfeOmGEczexb1qRW2zfh+KqAQd5 KNyxFO6Uun5rNSDoEmzTSUimdxVqzI/2/Imv7idSdOI/7F/QSYuKb53uw+qiIMo= X-Google-Smtp-Source: AGHT+IH3pC+f8pzqqXv0EovOv3q0ogIpnNxixUGOjWjSEXDo/maroqpNMt/5YXZL0hJP+QvlDJt4Ag== X-Received: by 2002:a05:6a20:3244:b0:1a7:59b5:4276 with SMTP id hm4-20020a056a20324400b001a759b54276mr3112304pzc.54.1712946139775; Fri, 12 Apr 2024 11:22:19 -0700 (PDT) Received: from ghost (mobile-166-137-160-039.mycingular.net. [166.137.160.39]) by smtp.gmail.com with ESMTPSA id t21-20020aa78f95000000b006ed4aa9d48esm3179455pfs.212.2024.04.12.11.22.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 11:22:19 -0700 (PDT) Date: Fri, 12 Apr 2024 11:22:15 -0700 From: Charlie Jenkins To: Evan Green Cc: Conor Dooley , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Jonathan Corbet , Shuah Khan , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 14/19] riscv: hwprobe: Disambiguate vector and xtheadvector in hwprobe Message-ID: References: <20240411-dev-charlie-support_thead_vector_6_9-v1-0-4af9815ec746@rivosinc.com> <20240411-dev-charlie-support_thead_vector_6_9-v1-14-4af9815ec746@rivosinc.com> <20240412-moonshine-acting-0df1a90b86d2@wendy> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Apr 12, 2024 at 10:04:42AM -0700, Evan Green wrote: > On Fri, Apr 12, 2024 at 4:35 AM Conor Dooley wrote: > > > > On Thu, Apr 11, 2024 at 09:11:20PM -0700, Charlie Jenkins wrote: > > > Ensure that hwprobe does not flag "v" when xtheadvector is present. > > > > > > Signed-off-by: Charlie Jenkins > > > --- > > > arch/riscv/kernel/sys_hwprobe.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/riscv/kernel/sys_hwprobe.c b/arch/riscv/kernel/sys_hwprobe.c > > > index 8cae41a502dd..e0a42c851511 100644 > > > --- a/arch/riscv/kernel/sys_hwprobe.c > > > +++ b/arch/riscv/kernel/sys_hwprobe.c > > > @@ -69,7 +69,7 @@ static void hwprobe_isa_ext0(struct riscv_hwprobe *pair, > > > if (riscv_isa_extension_available(NULL, c)) > > > pair->value |= RISCV_HWPROBE_IMA_C; > > > > > > - if (has_vector()) > > > + if (has_vector() && !riscv_has_vendor_extension_unlikely(RISCV_ISA_VENDOR_EXT_XTHEADVECTOR)) > > > > Hmm, I think this is "dangerous". has_vector() is used across the kernel > > now in several places for the in-kernel vector. I don't think that > > has_vector() should return true for the T-Head stuff given that & > > has_vector() should represent the ratified spec. I'll have to think > > about this one and how nasty this makes any of the save/restore code > > etc. > > Yeah, my nose crinkled here as well. If you're having to do a > vendorish thing in this generic spot, then others may too, suggesting > perhaps this isn't the cleanest way to go about it. Ideally extensions > are all additive, rather than subtractive, I guess? This was the "easiest" way to support this but I agree this is not ideal. The vector code is naturally coupled with having support for "v" and I wanted to leverage that. The other concern is all of the ifdefs for having V enabled. I can make all of those V or XTHEADVECTOR; that will increase the surface area of xtheadvector but it is probably the right(?) way to go. - Charlie > > > > > > > pair->value |= RISCV_HWPROBE_IMA_V; > > > > > > /* > > > @@ -112,7 +112,7 @@ static void hwprobe_isa_ext0(struct riscv_hwprobe *pair, > > > EXT_KEY(ZACAS); > > > EXT_KEY(ZICOND); > > > > > > - if (has_vector()) { > > > + if (has_vector() && !riscv_has_vendor_extension_unlikely(RISCV_ISA_VENDOR_EXT_XTHEADVECTOR)) { > > > EXT_KEY(ZVBB); > > > EXT_KEY(ZVBC); > > > EXT_KEY(ZVKB); > > > > > > -- > > > 2.44.0 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E984EC4345F for ; Fri, 12 Apr 2024 18:22:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A5VE2GrAkCB6eUkgeN0gmnnZKKQdhSi3Ke3vFFXsZT8=; b=3BBhRKoXfh2pBA IbIko77Yam/Z6FmT1fo5wmMucKm3nWUF4n2AaC1afxifPhbONm7WkZZnPmaomMTDBXHgxPwMYe9AO ytKWy+A4tUAr7Ww3jkQPs06gHTfdjIfY/11wxscak7vUN8tWBw/C1NwHODWDTCcVofCpuaHypTh96 Zl+sdkQ2RVHp6/oSmALejM6HHvm5JFdhDtIKZzqjBpcU0lExEKiDnSh20A/QpNsVkAM3sQUCpps8u qrub/jTdpKlKnkDRoS9SIVqC9cGpJix98EK24POgXLspeWa3snj3/8OqGv5IDTIfyH7aqvwF+6Lqe ThWDQX1DICJdTDRcvsGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvLXd-00000000q3i-2VpR; Fri, 12 Apr 2024 18:22:25 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvLXa-00000000q1v-0ETk for linux-riscv@lists.infradead.org; Fri, 12 Apr 2024 18:22:23 +0000 Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-6e46dcd8feaso701264b3a.2 for ; Fri, 12 Apr 2024 11:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1712946140; x=1713550940; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=wCHPnhyTcC9ocJWJcXngwPv4ks2H4M0UEeE7J2w7Lsc=; b=kfu0L+OxOSRZdD0jiwwJ0axUcfqlNQ1ItKjFA1ytfQaAt93Kl0gtRL4Zac1q0JVZ0z czoDQD0+PBsGLeU3oVGrBXpoVsjM/imWY3chrUGSKjwdFTWcZuGjbkGPFTYU4WLiwTyY hEVCkSFFvEPALU5fji7uDG3XCyDWU/QcGRPS7BTYw2OxTN2yqDYJ7eFbO49/CMusFySr bt/38dE/Kcvxfvq3C9vg7UK4j/sNS3C37l3aJd2OHmMP9JTvE6V9jiFDGyFE36v/hMvR PwCkemxWjdhsbzJxQQw32RTDCGKoajTMKqNLB7TC1Ebr99CTTMxMR3cT/rwAV7hO6LTB t8TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712946140; x=1713550940; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wCHPnhyTcC9ocJWJcXngwPv4ks2H4M0UEeE7J2w7Lsc=; b=c77wNPyMuMmT40ZOYpvTCrrUG8bU0HXvyNz7sxKXsshdnMepHgIR6cadQ703NivzKV GkDKTOorUuuGxz4bKQrTQCw5NLM0Xq9udeNySMEPXWl+osRA5b12NEOFImZbyNYUFEAI NPRWKwWmm+/yqZPxqtoiZNUsxvW8NakEt/I2303Wz0LQz3pffhunNdjGdkFYfoo8mW+b DbL78w1PxmOLwUGjoY0LxRhMcmTGjzq9W+yvaafE6j5bM/Pj0XBpM5aI61Qf0YjFvH0J +XOfKhKV4jI+QWg7BUwVM5Q+gQq/oahpJjoY+1VSKtsdhS+LcZ8dhWnRZVY9RqAvNJ+n i3qQ== X-Forwarded-Encrypted: i=1; AJvYcCV7OCGALuu5NAkL9a0p38NWNGbb2uDzZkQ9a6BnRtY7wQVXoldv6W/VVSnl4hB6/XLD31fOpykIhr33jVpf2F1V9oeSOYpTo5bCxFS4Smaf X-Gm-Message-State: AOJu0YyTvnQsYSsXvO8EU6ta2zPf8nOJ/vIw40whGIFcg3BWbFyHVT2+ J1qtO1002ZQOkCLFNWu4zzEH5pAmK+NZo0GZFh8etr1l7jfhU79ALx1dyEdpWkk= X-Google-Smtp-Source: AGHT+IH3pC+f8pzqqXv0EovOv3q0ogIpnNxixUGOjWjSEXDo/maroqpNMt/5YXZL0hJP+QvlDJt4Ag== X-Received: by 2002:a05:6a20:3244:b0:1a7:59b5:4276 with SMTP id hm4-20020a056a20324400b001a759b54276mr3112304pzc.54.1712946139775; Fri, 12 Apr 2024 11:22:19 -0700 (PDT) Received: from ghost (mobile-166-137-160-039.mycingular.net. [166.137.160.39]) by smtp.gmail.com with ESMTPSA id t21-20020aa78f95000000b006ed4aa9d48esm3179455pfs.212.2024.04.12.11.22.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 11:22:19 -0700 (PDT) Date: Fri, 12 Apr 2024 11:22:15 -0700 From: Charlie Jenkins To: Evan Green Cc: Conor Dooley , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Jonathan Corbet , Shuah Khan , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 14/19] riscv: hwprobe: Disambiguate vector and xtheadvector in hwprobe Message-ID: References: <20240411-dev-charlie-support_thead_vector_6_9-v1-0-4af9815ec746@rivosinc.com> <20240411-dev-charlie-support_thead_vector_6_9-v1-14-4af9815ec746@rivosinc.com> <20240412-moonshine-acting-0df1a90b86d2@wendy> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_112222_124990_0BFCCC8F X-CRM114-Status: GOOD ( 26.25 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBcHIgMTIsIDIwMjQgYXQgMTA6MDQ6NDJBTSAtMDcwMCwgRXZhbiBHcmVlbiB3cm90 ZToKPiBPbiBGcmksIEFwciAxMiwgMjAyNCBhdCA0OjM14oCvQU0gQ29ub3IgRG9vbGV5IDxjb25v ci5kb29sZXlAbWljcm9jaGlwLmNvbT4gd3JvdGU6Cj4gPgo+ID4gT24gVGh1LCBBcHIgMTEsIDIw MjQgYXQgMDk6MTE6MjBQTSAtMDcwMCwgQ2hhcmxpZSBKZW5raW5zIHdyb3RlOgo+ID4gPiBFbnN1 cmUgdGhhdCBod3Byb2JlIGRvZXMgbm90IGZsYWcgInYiIHdoZW4geHRoZWFkdmVjdG9yIGlzIHBy ZXNlbnQuCj4gPiA+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IENoYXJsaWUgSmVua2lucyA8Y2hhcmxp ZUByaXZvc2luYy5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgYXJjaC9yaXNjdi9rZXJuZWwvc3lzX2h3 cHJvYmUuYyB8IDQgKystLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkKPiA+ID4KPiA+ID4gZGlmZiAtLWdpdCBhL2FyY2gvcmlzY3Yva2VybmVs L3N5c19od3Byb2JlLmMgYi9hcmNoL3Jpc2N2L2tlcm5lbC9zeXNfaHdwcm9iZS5jCj4gPiA+IGlu ZGV4IDhjYWU0MWE1MDJkZC4uZTBhNDJjODUxNTExIDEwMDY0NAo+ID4gPiAtLS0gYS9hcmNoL3Jp c2N2L2tlcm5lbC9zeXNfaHdwcm9iZS5jCj4gPiA+ICsrKyBiL2FyY2gvcmlzY3Yva2VybmVsL3N5 c19od3Byb2JlLmMKPiA+ID4gQEAgLTY5LDcgKzY5LDcgQEAgc3RhdGljIHZvaWQgaHdwcm9iZV9p c2FfZXh0MChzdHJ1Y3QgcmlzY3ZfaHdwcm9iZSAqcGFpciwKPiA+ID4gICAgICAgaWYgKHJpc2N2 X2lzYV9leHRlbnNpb25fYXZhaWxhYmxlKE5VTEwsIGMpKQo+ID4gPiAgICAgICAgICAgICAgIHBh aXItPnZhbHVlIHw9IFJJU0NWX0hXUFJPQkVfSU1BX0M7Cj4gPiA+Cj4gPiA+IC0gICAgIGlmICho YXNfdmVjdG9yKCkpCj4gPiA+ICsgICAgIGlmIChoYXNfdmVjdG9yKCkgJiYgIXJpc2N2X2hhc192 ZW5kb3JfZXh0ZW5zaW9uX3VubGlrZWx5KFJJU0NWX0lTQV9WRU5ET1JfRVhUX1hUSEVBRFZFQ1RP UikpCj4gPgo+ID4gSG1tLCBJIHRoaW5rIHRoaXMgaXMgImRhbmdlcm91cyIuIGhhc192ZWN0b3Io KSBpcyB1c2VkIGFjcm9zcyB0aGUga2VybmVsCj4gPiBub3cgaW4gc2V2ZXJhbCBwbGFjZXMgZm9y IHRoZSBpbi1rZXJuZWwgdmVjdG9yLiBJIGRvbid0IHRoaW5rIHRoYXQKPiA+IGhhc192ZWN0b3Io KSBzaG91bGQgcmV0dXJuIHRydWUgZm9yIHRoZSBULUhlYWQgc3R1ZmYgZ2l2ZW4gdGhhdCAmCj4g PiBoYXNfdmVjdG9yKCkgc2hvdWxkIHJlcHJlc2VudCB0aGUgcmF0aWZpZWQgc3BlYy4gSSdsbCBo YXZlIHRvIHRoaW5rCj4gPiBhYm91dCB0aGlzIG9uZSBhbmQgaG93IG5hc3R5IHRoaXMgbWFrZXMg YW55IG9mIHRoZSBzYXZlL3Jlc3RvcmUgY29kZQo+ID4gZXRjLgo+IAo+IFllYWgsIG15IG5vc2Ug Y3JpbmtsZWQgaGVyZSBhcyB3ZWxsLiBJZiB5b3UncmUgaGF2aW5nIHRvIGRvIGEKPiB2ZW5kb3Jp c2ggdGhpbmcgaW4gdGhpcyBnZW5lcmljIHNwb3QsIHRoZW4gb3RoZXJzIG1heSB0b28sIHN1Z2dl c3RpbmcKPiBwZXJoYXBzIHRoaXMgaXNuJ3QgdGhlIGNsZWFuZXN0IHdheSB0byBnbyBhYm91dCBp dC4gSWRlYWxseSBleHRlbnNpb25zCj4gYXJlIGFsbCBhZGRpdGl2ZSwgcmF0aGVyIHRoYW4gc3Vi dHJhY3RpdmUsIEkgZ3Vlc3M/CgpUaGlzIHdhcyB0aGUgImVhc2llc3QiIHdheSB0byBzdXBwb3J0 IHRoaXMgYnV0IEkgYWdyZWUgdGhpcyBpcyBub3QKaWRlYWwuIFRoZSB2ZWN0b3IgY29kZSBpcyBu YXR1cmFsbHkgY291cGxlZCB3aXRoIGhhdmluZyBzdXBwb3J0IGZvcgoidiIgYW5kIEkgd2FudGVk IHRvIGxldmVyYWdlIHRoYXQuIFRoZSBvdGhlciBjb25jZXJuIGlzIGFsbCBvZiB0aGUKaWZkZWZz IGZvciBoYXZpbmcgViBlbmFibGVkLiBJIGNhbiBtYWtlIGFsbCBvZiB0aG9zZSBWIG9yIFhUSEVB RFZFQ1RPUjsKdGhhdCB3aWxsIGluY3JlYXNlIHRoZSBzdXJmYWNlIGFyZWEgb2YgeHRoZWFkdmVj dG9yIGJ1dCBpdCBpcyBwcm9iYWJseQp0aGUgcmlnaHQoPykgd2F5IHRvIGdvLgoKLSBDaGFybGll Cgo+IAo+IAo+ID4KPiA+ID4gICAgICAgICAgICAgICBwYWlyLT52YWx1ZSB8PSBSSVNDVl9IV1BS T0JFX0lNQV9WOwo+ID4gPgo+ID4gPiAgICAgICAvKgo+ID4gPiBAQCAtMTEyLDcgKzExMiw3IEBA IHN0YXRpYyB2b2lkIGh3cHJvYmVfaXNhX2V4dDAoc3RydWN0IHJpc2N2X2h3cHJvYmUgKnBhaXIs Cj4gPiA+ICAgICAgICAgICAgICAgRVhUX0tFWShaQUNBUyk7Cj4gPiA+ICAgICAgICAgICAgICAg RVhUX0tFWShaSUNPTkQpOwo+ID4gPgo+ID4gPiAtICAgICAgICAgICAgIGlmIChoYXNfdmVjdG9y KCkpIHsKPiA+ID4gKyAgICAgICAgICAgICBpZiAoaGFzX3ZlY3RvcigpICYmICFyaXNjdl9oYXNf dmVuZG9yX2V4dGVuc2lvbl91bmxpa2VseShSSVNDVl9JU0FfVkVORE9SX0VYVF9YVEhFQURWRUNU T1IpKSB7Cj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICBFWFRfS0VZKFpWQkIpOwo+ID4gPiAg ICAgICAgICAgICAgICAgICAgICAgRVhUX0tFWShaVkJDKTsKPiA+ID4gICAgICAgICAgICAgICAg ICAgICAgIEVYVF9LRVkoWlZLQik7Cj4gPiA+Cj4gPiA+IC0tCj4gPiA+IDIuNDQuMAo+ID4gPgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlz Y3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7E3DC4345F for ; Fri, 12 Apr 2024 18:22:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dn1GLIM3VyJY0SHOltKKJHfj41UW8Q22SC6H6xngj64=; b=KpVd26tV6PXZ8w CAv+pB9uNuryvmKOBarod+EL4medIUiUqFZHHISyJoCtk6EdP5c503lsvjf7PzaobQ7hdfaX26uLA 8LvWrlrLwhDG/uSYuKb4l/oVlHAM6tSTW4rI10lzSnDg5eQ8beTweDTetyNvwn9Uhz4IByCGJK4WB FIHuXP0TJXEtCBJ70S5qdkBtUtJSoLHNNvpry3p6qJw1YA0UBH3hb6iliUaGPx3Dad6ZlNF5A7nSR hEep07yFir491NdPl7pAvJ7fVvTO7Afc04DkhDJz1cZNLQKk011dptg5v607WFKLAcIN7UyeXJj6P eZCtWOvm/pp5Bjkwc0rA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvLXc-00000000q3W-359E; Fri, 12 Apr 2024 18:22:24 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvLXa-00000000q1u-0EDi for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2024 18:22:23 +0000 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-6ead4093f85so1055158b3a.3 for ; Fri, 12 Apr 2024 11:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1712946140; x=1713550940; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=wCHPnhyTcC9ocJWJcXngwPv4ks2H4M0UEeE7J2w7Lsc=; b=kfu0L+OxOSRZdD0jiwwJ0axUcfqlNQ1ItKjFA1ytfQaAt93Kl0gtRL4Zac1q0JVZ0z czoDQD0+PBsGLeU3oVGrBXpoVsjM/imWY3chrUGSKjwdFTWcZuGjbkGPFTYU4WLiwTyY hEVCkSFFvEPALU5fji7uDG3XCyDWU/QcGRPS7BTYw2OxTN2yqDYJ7eFbO49/CMusFySr bt/38dE/Kcvxfvq3C9vg7UK4j/sNS3C37l3aJd2OHmMP9JTvE6V9jiFDGyFE36v/hMvR PwCkemxWjdhsbzJxQQw32RTDCGKoajTMKqNLB7TC1Ebr99CTTMxMR3cT/rwAV7hO6LTB t8TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712946140; x=1713550940; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wCHPnhyTcC9ocJWJcXngwPv4ks2H4M0UEeE7J2w7Lsc=; b=P0LDmicVcjg45aiIcAT4/vM8K8kZEuQXrCy7D6Tgqk+QfHxkhU0P3NlNnQz9Yq8b/n /eAkmL/SNvcscogBqZ0YzmMDGp3sQkyGDuE9bZqD7KBjUvEGfvbcQVLYWCe1En6UCQSc vms/S3FO0YoHEcQwskvE9g9Rlc7a8P/qJhB4lry+nK+7dTHcjFqQXpCFAGS+hOSBRoLS vPxQ39nC2c8j14CF2JJ0iuoKK3clHv1g6IfZgMdTE3OAGSRca+0pIvCV6yrUjYBz+p6V ZhOkdeFYWgxzaAg/0U702foRCR9npXrzyD/0MYtFR8Y4hBABLagP+CS0yyMcSrCqz9aT 7E/A== X-Forwarded-Encrypted: i=1; AJvYcCUSMiE5bwJGbicpz2bO/tycOKxNeNjwNyoD3GgFLczEcbBXmDnx/2jPuuLovnyjsDsmtZkgL1nT7Gcw0TV42YUezeukpIk5YBEIpHyseez6QXPE5wk= X-Gm-Message-State: AOJu0YxjZnsOl6nddqw1QXe8CkmKL2b+HurtN7mPaYURVMJ+nJSqnCbx rscS1ZbSaAfZ4LK2f7raz/UgYJs+kTA4x0Pk38iJiyh1/sdZyGDYwbO4z7X8Ky8= X-Google-Smtp-Source: AGHT+IH3pC+f8pzqqXv0EovOv3q0ogIpnNxixUGOjWjSEXDo/maroqpNMt/5YXZL0hJP+QvlDJt4Ag== X-Received: by 2002:a05:6a20:3244:b0:1a7:59b5:4276 with SMTP id hm4-20020a056a20324400b001a759b54276mr3112304pzc.54.1712946139775; Fri, 12 Apr 2024 11:22:19 -0700 (PDT) Received: from ghost (mobile-166-137-160-039.mycingular.net. [166.137.160.39]) by smtp.gmail.com with ESMTPSA id t21-20020aa78f95000000b006ed4aa9d48esm3179455pfs.212.2024.04.12.11.22.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 11:22:19 -0700 (PDT) Date: Fri, 12 Apr 2024 11:22:15 -0700 From: Charlie Jenkins To: Evan Green Cc: Conor Dooley , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Jonathan Corbet , Shuah Khan , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 14/19] riscv: hwprobe: Disambiguate vector and xtheadvector in hwprobe Message-ID: References: <20240411-dev-charlie-support_thead_vector_6_9-v1-0-4af9815ec746@rivosinc.com> <20240411-dev-charlie-support_thead_vector_6_9-v1-14-4af9815ec746@rivosinc.com> <20240412-moonshine-acting-0df1a90b86d2@wendy> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_112222_125160_0C9007E0 X-CRM114-Status: GOOD ( 27.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBcHIgMTIsIDIwMjQgYXQgMTA6MDQ6NDJBTSAtMDcwMCwgRXZhbiBHcmVlbiB3cm90 ZToKPiBPbiBGcmksIEFwciAxMiwgMjAyNCBhdCA0OjM14oCvQU0gQ29ub3IgRG9vbGV5IDxjb25v ci5kb29sZXlAbWljcm9jaGlwLmNvbT4gd3JvdGU6Cj4gPgo+ID4gT24gVGh1LCBBcHIgMTEsIDIw MjQgYXQgMDk6MTE6MjBQTSAtMDcwMCwgQ2hhcmxpZSBKZW5raW5zIHdyb3RlOgo+ID4gPiBFbnN1 cmUgdGhhdCBod3Byb2JlIGRvZXMgbm90IGZsYWcgInYiIHdoZW4geHRoZWFkdmVjdG9yIGlzIHBy ZXNlbnQuCj4gPiA+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IENoYXJsaWUgSmVua2lucyA8Y2hhcmxp ZUByaXZvc2luYy5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgYXJjaC9yaXNjdi9rZXJuZWwvc3lzX2h3 cHJvYmUuYyB8IDQgKystLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkKPiA+ID4KPiA+ID4gZGlmZiAtLWdpdCBhL2FyY2gvcmlzY3Yva2VybmVs L3N5c19od3Byb2JlLmMgYi9hcmNoL3Jpc2N2L2tlcm5lbC9zeXNfaHdwcm9iZS5jCj4gPiA+IGlu ZGV4IDhjYWU0MWE1MDJkZC4uZTBhNDJjODUxNTExIDEwMDY0NAo+ID4gPiAtLS0gYS9hcmNoL3Jp c2N2L2tlcm5lbC9zeXNfaHdwcm9iZS5jCj4gPiA+ICsrKyBiL2FyY2gvcmlzY3Yva2VybmVsL3N5 c19od3Byb2JlLmMKPiA+ID4gQEAgLTY5LDcgKzY5LDcgQEAgc3RhdGljIHZvaWQgaHdwcm9iZV9p c2FfZXh0MChzdHJ1Y3QgcmlzY3ZfaHdwcm9iZSAqcGFpciwKPiA+ID4gICAgICAgaWYgKHJpc2N2 X2lzYV9leHRlbnNpb25fYXZhaWxhYmxlKE5VTEwsIGMpKQo+ID4gPiAgICAgICAgICAgICAgIHBh aXItPnZhbHVlIHw9IFJJU0NWX0hXUFJPQkVfSU1BX0M7Cj4gPiA+Cj4gPiA+IC0gICAgIGlmICho YXNfdmVjdG9yKCkpCj4gPiA+ICsgICAgIGlmIChoYXNfdmVjdG9yKCkgJiYgIXJpc2N2X2hhc192 ZW5kb3JfZXh0ZW5zaW9uX3VubGlrZWx5KFJJU0NWX0lTQV9WRU5ET1JfRVhUX1hUSEVBRFZFQ1RP UikpCj4gPgo+ID4gSG1tLCBJIHRoaW5rIHRoaXMgaXMgImRhbmdlcm91cyIuIGhhc192ZWN0b3Io KSBpcyB1c2VkIGFjcm9zcyB0aGUga2VybmVsCj4gPiBub3cgaW4gc2V2ZXJhbCBwbGFjZXMgZm9y IHRoZSBpbi1rZXJuZWwgdmVjdG9yLiBJIGRvbid0IHRoaW5rIHRoYXQKPiA+IGhhc192ZWN0b3Io KSBzaG91bGQgcmV0dXJuIHRydWUgZm9yIHRoZSBULUhlYWQgc3R1ZmYgZ2l2ZW4gdGhhdCAmCj4g PiBoYXNfdmVjdG9yKCkgc2hvdWxkIHJlcHJlc2VudCB0aGUgcmF0aWZpZWQgc3BlYy4gSSdsbCBo YXZlIHRvIHRoaW5rCj4gPiBhYm91dCB0aGlzIG9uZSBhbmQgaG93IG5hc3R5IHRoaXMgbWFrZXMg YW55IG9mIHRoZSBzYXZlL3Jlc3RvcmUgY29kZQo+ID4gZXRjLgo+IAo+IFllYWgsIG15IG5vc2Ug Y3JpbmtsZWQgaGVyZSBhcyB3ZWxsLiBJZiB5b3UncmUgaGF2aW5nIHRvIGRvIGEKPiB2ZW5kb3Jp c2ggdGhpbmcgaW4gdGhpcyBnZW5lcmljIHNwb3QsIHRoZW4gb3RoZXJzIG1heSB0b28sIHN1Z2dl c3RpbmcKPiBwZXJoYXBzIHRoaXMgaXNuJ3QgdGhlIGNsZWFuZXN0IHdheSB0byBnbyBhYm91dCBp dC4gSWRlYWxseSBleHRlbnNpb25zCj4gYXJlIGFsbCBhZGRpdGl2ZSwgcmF0aGVyIHRoYW4gc3Vi dHJhY3RpdmUsIEkgZ3Vlc3M/CgpUaGlzIHdhcyB0aGUgImVhc2llc3QiIHdheSB0byBzdXBwb3J0 IHRoaXMgYnV0IEkgYWdyZWUgdGhpcyBpcyBub3QKaWRlYWwuIFRoZSB2ZWN0b3IgY29kZSBpcyBu YXR1cmFsbHkgY291cGxlZCB3aXRoIGhhdmluZyBzdXBwb3J0IGZvcgoidiIgYW5kIEkgd2FudGVk IHRvIGxldmVyYWdlIHRoYXQuIFRoZSBvdGhlciBjb25jZXJuIGlzIGFsbCBvZiB0aGUKaWZkZWZz IGZvciBoYXZpbmcgViBlbmFibGVkLiBJIGNhbiBtYWtlIGFsbCBvZiB0aG9zZSBWIG9yIFhUSEVB RFZFQ1RPUjsKdGhhdCB3aWxsIGluY3JlYXNlIHRoZSBzdXJmYWNlIGFyZWEgb2YgeHRoZWFkdmVj dG9yIGJ1dCBpdCBpcyBwcm9iYWJseQp0aGUgcmlnaHQoPykgd2F5IHRvIGdvLgoKLSBDaGFybGll Cgo+IAo+IAo+ID4KPiA+ID4gICAgICAgICAgICAgICBwYWlyLT52YWx1ZSB8PSBSSVNDVl9IV1BS T0JFX0lNQV9WOwo+ID4gPgo+ID4gPiAgICAgICAvKgo+ID4gPiBAQCAtMTEyLDcgKzExMiw3IEBA IHN0YXRpYyB2b2lkIGh3cHJvYmVfaXNhX2V4dDAoc3RydWN0IHJpc2N2X2h3cHJvYmUgKnBhaXIs Cj4gPiA+ICAgICAgICAgICAgICAgRVhUX0tFWShaQUNBUyk7Cj4gPiA+ICAgICAgICAgICAgICAg RVhUX0tFWShaSUNPTkQpOwo+ID4gPgo+ID4gPiAtICAgICAgICAgICAgIGlmIChoYXNfdmVjdG9y KCkpIHsKPiA+ID4gKyAgICAgICAgICAgICBpZiAoaGFzX3ZlY3RvcigpICYmICFyaXNjdl9oYXNf dmVuZG9yX2V4dGVuc2lvbl91bmxpa2VseShSSVNDVl9JU0FfVkVORE9SX0VYVF9YVEhFQURWRUNU T1IpKSB7Cj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICBFWFRfS0VZKFpWQkIpOwo+ID4gPiAg ICAgICAgICAgICAgICAgICAgICAgRVhUX0tFWShaVkJDKTsKPiA+ID4gICAgICAgICAgICAgICAg ICAgICAgIEVYVF9LRVkoWlZLQik7Cj4gPiA+Cj4gPiA+IC0tCj4gPiA+IDIuNDQuMAo+ID4gPgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo=