From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from luna.linkmauve.fr (luna.linkmauve.fr [82.65.109.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF71584DE1 for ; Fri, 12 Apr 2024 15:07:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.65.109.163 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712934449; cv=none; b=ApxkWRAqKwfOg5I1tQXQMHlhKuVeYi+oefgbWFt3kiVuhYIjeCIawXuTec8ozUT/ChtIvoOMW0I6zHNFRFAyIL6BJLQ87JJUL7PAia60qIrnSRYBuP4MMCE5IHQKJ8jSSvOhZphaeDHQN/4CtXS8c9ssUJP3OeTYaddGodIdYqg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712934449; c=relaxed/simple; bh=voCHpxixn5k41RDfN/siqd8KEKEYBlLi9myAWQrB8c4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e7F4Pn3Yi2EsaF6+XMhwfg4S/6W0XpO51tWeV16tF/aAGx9kP6YV3SEDbJdk8Z23K0bs10qBQsSF/b85KsPKlGkMq9tM1uPVnbPn5prQUNkuHNqb4kqgzHow33Elc4qtvK+3ordMCi3tDpAhzGbLNWlzrpk3zCXDrYFaWI2GGgA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linkmauve.fr; spf=pass smtp.mailfrom=linkmauve.fr; arc=none smtp.client-ip=82.65.109.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linkmauve.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linkmauve.fr Received: by luna.linkmauve.fr (Postfix, from userid 1000) id 4EDA110A25E8; Fri, 12 Apr 2024 17:07:19 +0200 (CEST) Date: Fri, 12 Apr 2024 17:07:19 +0200 From: Link Mauve To: Nicolas Dufresne Cc: Link Mauve , linux-kernel@vger.kernel.org, Ezequiel Garcia , Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Joerg Roedel , Will Deacon , Robin Murphy , Sebastian Reichel , Cristian Ciocaltea , Dragan Simic , Shreeya Patel , Chris Morgan , Andy Yan , Nicolas Frattaroli , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev Subject: Re: [PATCH v2 0/2] Enable JPEG encoding on rk3588 Message-ID: References: <20240327134115.424846-1-linkmauve@linkmauve.fr> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Jabber-ID: linkmauve@linkmauve.fr On Sun, Apr 07, 2024 at 10:08:58AM +0200, Nicolas Dufresne wrote: > Le vendredi 05 avril 2024 à 16:21 +0200, Link Mauve a écrit : > > On Thu, Apr 04, 2024 at 01:41:15PM -0400, Nicolas Dufresne wrote: > > > Hi, > > > > Hi, > > > > > > > > Le mercredi 27 mars 2024 à 14:41 +0100, Emmanuel Gil Peyrot a écrit : > > > > Only the JPEG encoder is available for now, although there are patches > > > > for the undocumented VP8 encoder floating around[0]. > > > > > > [0] seems like a broken link. The VP8 encoder RFC is for RK3399 (and Hantro H1 > > > posted by ST more recently). The TRM says "VEPU121(JPEG encoder only)", which > > > suggest that the H.264 and VP8 encoders usually found on the VEPU121 are > > > removed. As Rockchip have remove the synthesize register while modifying the H1 > > > IP, it is difficult to verify. Confusingly the H.264 specific registers are > > > documented in the TRM around VEPU121. > > > > Ah, the link became, and was indeed ST’s series: > > https://patchwork.kernel.org/project/linux-rockchip/list/?series=789885&archive=both > > > > But the TRM part 1 says the VEPU121 supports H.264 encoding (page 367), > > and it’s likely they didn’t remove just VP8 support since the codec > > features are pretty close to H.264’s. > > > > > > > > > > > > > This has been tested on a rock-5b, resulting in four /dev/video* > > > > encoders. The userspace program I’ve been using to test them is > > > > Onix[1], using the jpeg-encoder example, it will pick one of these four > > > > at random (but displays the one it picked): > > > > % ffmpeg -i -pix_fmt yuvj420p temp.yuv > > > > % jpeg-encoder temp.yuv NV12 output.jpeg > > > > > > I don't like that we exposing each identical cores a separate video nodes. I > > > think we should aim for 1 device, and then multi-plex and schedule de cores from > > > inside the Linux kernel. > > > > I agree, but this should be handled in the driver not in the device > > tree, and it can be done later. > > As the behaviour we want is that these cores becomes a group and get schedule > together, its certainly a good time to slow down and evaluate if that part needs > to be improve in the DT too. > > Hantro G1/H1 and VEPU/VDPU121 combos originally shared the same sram region. Its > not clear if any of these cores have this limitation and if this should be > expressed in the DT / driver. The TRM on page 369 mentions that: > Please note that VDPU121 and VDPU381 and VDPU720 and AV1 and VEPU121 and VEPU580 > is different IP cores, so these processing core can be work together. I understand that as them not sharing any memory and being able to work independently. > > > > > > > > > Not doing this now means we'll never have an optimal hardware usage > > > distribution. Just consider two userspace software wanting to do jpeg encoding. > > > If they both take a guess, they may endup using a single core. Where with proper > > > scheduling in V4L2, the kernel will be able to properly distribute the load. I > > > insist on this, since if we merge you changes it becomes an ABI and we can't > > > change it anymore. > > > > Will it really become ABI just like that? Userspace should always > > discover the video nodes and their capabilities and not hardcode e.g. a > > specific /dev/videoN file for a specific codec. I would argue that this > > series would let userspace do JPEG encoding right away, even if in a > > less optimal way than if the driver would round-robin them through a > > single video node, but that can always be added in a future version. > > Might be on the gray side, but there is good chances software written for your > specific board can stop working after te grouping is done. I will send a new series shortly which enables only one of these four cores, the functionality should be the same, it will just expose only one video node which can get a four times throughput upgrade later once we implement multi-core support in the driver. > > > > > > > > > I understand that this impose a rework of the mem2mem framework so that we can > > > run multiple jobs, but this will be needed anyway on RK3588, since the rkvdec2, > > > which we don't have a driver yet is also multi-core, but you need to use 2 cores > > > when the resolution is close to 8K. > > > > I think the mediatek JPEG driver already supports that, would it be ok > > to do it the same way? > > I don't know for JPEG, the MTK vcoder do support cascading cores. This is > different from concurrent cores. In MTK architecture, for some of the codec, > there is LAT (entropy decoder) and CORE (the reconstruction block) that are > split. Ah, that’s different then, I only had a cursory look at them back when I implemented the JPEG decoder for sunxi. > > Nicolas -- Link Mauve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1102C4345F for ; Fri, 12 Apr 2024 15:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kmA0oEUWWd7vUVl6IsPUd7pw/1hjU74kKjewnhXX39Y=; b=h0iS0o5d32Ilf7 ffioCz+ULykgQluSyiBHlihH6tNlXys84PemHR/sHvnDP4lkFZVxWBXhJtj/E9kxyXssQAQ0FOzYf 1hLHGW28TgGamF0WOM4gjeMJWFIM//nAw7dPGXq2EX3UaNG9CDDpNQ67IPUozhU4AHfnuzGggv4TH LaDFBgJZ1x0CUKHwCLKS3T0u/V6ncSzQ3Q9f3o+FYH1BMnHKsd4HacdqY5dKNdS0yacC6+38+Ree5 B4jQmQ1XH5Q17fERKWOGS+KHXmC4gbmhgj9NGOdPO6VEZp+2Yvr1tnEufxQIx9v4jEjsqq18Kwe9o WpVsZLDFx3Nh10YHY8yA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvIV2-000000008xj-2OVU; Fri, 12 Apr 2024 15:07:32 +0000 Received: from luna.linkmauve.fr ([82.65.109.163]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvIUx-000000008w0-1MdQ; Fri, 12 Apr 2024 15:07:29 +0000 Received: by luna.linkmauve.fr (Postfix, from userid 1000) id 4EDA110A25E8; Fri, 12 Apr 2024 17:07:19 +0200 (CEST) Date: Fri, 12 Apr 2024 17:07:19 +0200 From: Link Mauve To: Nicolas Dufresne Cc: Link Mauve , linux-kernel@vger.kernel.org, Ezequiel Garcia , Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Joerg Roedel , Will Deacon , Robin Murphy , Sebastian Reichel , Cristian Ciocaltea , Dragan Simic , Shreeya Patel , Chris Morgan , Andy Yan , Nicolas Frattaroli , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev Subject: Re: [PATCH v2 0/2] Enable JPEG encoding on rk3588 Message-ID: References: <20240327134115.424846-1-linkmauve@linkmauve.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Jabber-ID: linkmauve@linkmauve.fr X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_080727_634832_30864B57 X-CRM114-Status: GOOD ( 48.94 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gU3VuLCBBcHIgMDcsIDIwMjQgYXQgMTA6MDg6NThBTSArMDIwMCwgTmljb2xhcyBEdWZyZXNu ZSB3cm90ZToKPiBMZSB2ZW5kcmVkaSAwNSBhdnJpbCAyMDI0IMOgIDE2OjIxICswMjAwLCBMaW5r IE1hdXZlIGEgw6ljcml0wqA6Cj4gPiBPbiBUaHUsIEFwciAwNCwgMjAyNCBhdCAwMTo0MToxNVBN IC0wNDAwLCBOaWNvbGFzIER1ZnJlc25lIHdyb3RlOgo+ID4gPiBIaSwKPiA+IAo+ID4gSGksCj4g PiAKPiA+ID4gCj4gPiA+IExlIG1lcmNyZWRpIDI3IG1hcnMgMjAyNCDDoCAxNDo0MSArMDEwMCwg RW1tYW51ZWwgR2lsIFBleXJvdCBhIMOpY3JpdMKgOgo+ID4gPiA+IE9ubHkgdGhlIEpQRUcgZW5j b2RlciBpcyBhdmFpbGFibGUgZm9yIG5vdywgYWx0aG91Z2ggdGhlcmUgYXJlIHBhdGNoZXMKPiA+ ID4gPiBmb3IgdGhlIHVuZG9jdW1lbnRlZCBWUDggZW5jb2RlciBmbG9hdGluZyBhcm91bmRbMF0u Cj4gPiA+IAo+ID4gPiBbMF0gc2VlbXMgbGlrZSBhIGJyb2tlbiBsaW5rLiBUaGUgVlA4IGVuY29k ZXIgUkZDIGlzIGZvciBSSzMzOTkgKGFuZCBIYW50cm8gSDEKPiA+ID4gcG9zdGVkIGJ5IFNUIG1v cmUgcmVjZW50bHkpLiBUaGUgVFJNIHNheXMgIlZFUFUxMjEoSlBFRyBlbmNvZGVyIG9ubHkpIiwg d2hpY2gKPiA+ID4gc3VnZ2VzdCB0aGF0IHRoZSBILjI2NCBhbmQgVlA4IGVuY29kZXJzIHVzdWFs bHkgZm91bmQgb24gdGhlIFZFUFUxMjEgYXJlCj4gPiA+IHJlbW92ZWQuIEFzIFJvY2tjaGlwIGhh dmUgcmVtb3ZlIHRoZSBzeW50aGVzaXplIHJlZ2lzdGVyIHdoaWxlIG1vZGlmeWluZyB0aGUgSDEK PiA+ID4gSVAsIGl0IGlzIGRpZmZpY3VsdCB0byB2ZXJpZnkuIENvbmZ1c2luZ2x5IHRoZSBILjI2 NCBzcGVjaWZpYyByZWdpc3RlcnMgYXJlCj4gPiA+IGRvY3VtZW50ZWQgaW4gdGhlIFRSTSBhcm91 bmQgVkVQVTEyMS4KPiA+IAo+ID4gQWgsIHRoZSBsaW5rIGJlY2FtZSwgYW5kIHdhcyBpbmRlZWQg U1TigJlzIHNlcmllczoKPiA+IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcHJvamVjdC9s aW51eC1yb2NrY2hpcC9saXN0Lz9zZXJpZXM9Nzg5ODg1JmFyY2hpdmU9Ym90aAo+ID4gCj4gPiBC dXQgdGhlIFRSTSBwYXJ0IDEgc2F5cyB0aGUgVkVQVTEyMSBzdXBwb3J0cyBILjI2NCBlbmNvZGlu ZyAocGFnZSAzNjcpLAo+ID4gYW5kIGl04oCZcyBsaWtlbHkgdGhleSBkaWRu4oCZdCByZW1vdmUg anVzdCBWUDggc3VwcG9ydCBzaW5jZSB0aGUgY29kZWMKPiA+IGZlYXR1cmVzIGFyZSBwcmV0dHkg Y2xvc2UgdG8gSC4yNjTigJlzLgo+ID4gCj4gPiA+IAo+ID4gPiA+IAo+ID4gPiA+IFRoaXMgaGFz IGJlZW4gdGVzdGVkIG9uIGEgcm9jay01YiwgcmVzdWx0aW5nIGluIGZvdXIgL2Rldi92aWRlbyoK PiA+ID4gPiBlbmNvZGVycy4gIFRoZSB1c2Vyc3BhY2UgcHJvZ3JhbSBJ4oCZdmUgYmVlbiB1c2lu ZyB0byB0ZXN0IHRoZW0gaXMKPiA+ID4gPiBPbml4WzFdLCB1c2luZyB0aGUganBlZy1lbmNvZGVy IGV4YW1wbGUsIGl0IHdpbGwgcGljayBvbmUgb2YgdGhlc2UgZm91cgo+ID4gPiA+IGF0IHJhbmRv bSAoYnV0IGRpc3BsYXlzIHRoZSBvbmUgaXQgcGlja2VkKToKPiA+ID4gPiAlIGZmbXBlZyAtaSA8 aW5wdXQgaW1hZ2U+IC1waXhfZm10IHl1dmo0MjBwIHRlbXAueXV2Cj4gPiA+ID4gJSBqcGVnLWVu Y29kZXIgdGVtcC55dXYgPHdpZHRoPiA8aGVpZ2h0PiBOVjEyIDxxdWFsaXR5PiBvdXRwdXQuanBl Zwo+ID4gPiAKPiA+ID4gSSBkb24ndCBsaWtlIHRoYXQgd2UgZXhwb3NpbmcgZWFjaCBpZGVudGlj YWwgY29yZXMgYSBzZXBhcmF0ZSB2aWRlbyBub2Rlcy4gSQo+ID4gPiB0aGluayB3ZSBzaG91bGQg YWltIGZvciAxIGRldmljZSwgYW5kIHRoZW4gbXVsdGktcGxleCBhbmQgc2NoZWR1bGUgZGUgY29y ZXMgZnJvbQo+ID4gPiBpbnNpZGUgdGhlIExpbnV4IGtlcm5lbC4KPiA+IAo+ID4gSSBhZ3JlZSwg YnV0IHRoaXMgc2hvdWxkIGJlIGhhbmRsZWQgaW4gdGhlIGRyaXZlciBub3QgaW4gdGhlIGRldmlj ZQo+ID4gdHJlZSwgYW5kIGl0IGNhbiBiZSBkb25lIGxhdGVyLgo+IAo+IEFzIHRoZSBiZWhhdmlv dXIgd2Ugd2FudCBpcyB0aGF0IHRoZXNlIGNvcmVzIGJlY29tZXMgYSBncm91cCBhbmQgZ2V0IHNj aGVkdWxlCj4gdG9nZXRoZXIsIGl0cyBjZXJ0YWlubHkgYSBnb29kIHRpbWUgdG8gc2xvdyBkb3du IGFuZCBldmFsdWF0ZSBpZiB0aGF0IHBhcnQgbmVlZHMKPiB0byBiZSBpbXByb3ZlIGluIHRoZSBE VCB0b28uCj4gCj4gSGFudHJvIEcxL0gxIGFuZCBWRVBVL1ZEUFUxMjEgY29tYm9zIG9yaWdpbmFs bHkgc2hhcmVkIHRoZSBzYW1lIHNyYW0gcmVnaW9uLiBJdHMKPiBub3QgY2xlYXIgaWYgYW55IG9m IHRoZXNlIGNvcmVzIGhhdmUgdGhpcyBsaW1pdGF0aW9uIGFuZCBpZiB0aGlzIHNob3VsZCBiZQo+ IGV4cHJlc3NlZCBpbiB0aGUgRFQgLyBkcml2ZXIuCgpUaGUgVFJNIG9uIHBhZ2UgMzY5IG1lbnRp b25zIHRoYXQ6Cj4gUGxlYXNlIG5vdGUgdGhhdCBWRFBVMTIxIGFuZCBWRFBVMzgxIGFuZCBWRFBV NzIwIGFuZCBBVjEgYW5kIFZFUFUxMjEgYW5kIFZFUFU1ODAKPiBpcyBkaWZmZXJlbnQgSVAgY29y ZXMsIHNvIHRoZXNlIHByb2Nlc3NpbmcgY29yZSBjYW4gYmUgd29yayB0b2dldGhlci4KCkkgdW5k ZXJzdGFuZCB0aGF0IGFzIHRoZW0gbm90IHNoYXJpbmcgYW55IG1lbW9yeSBhbmQgYmVpbmcgYWJs ZSB0byB3b3JrCmluZGVwZW5kZW50bHkuCgo+IAo+ID4gCj4gPiA+IAo+ID4gPiBOb3QgZG9pbmcg dGhpcyBub3cgbWVhbnMgd2UnbGwgbmV2ZXIgaGF2ZSBhbiBvcHRpbWFsIGhhcmR3YXJlIHVzYWdl Cj4gPiA+IGRpc3RyaWJ1dGlvbi4gSnVzdCBjb25zaWRlciB0d28gdXNlcnNwYWNlIHNvZnR3YXJl IHdhbnRpbmcgdG8gZG8ganBlZyBlbmNvZGluZy4KPiA+ID4gSWYgdGhleSBib3RoIHRha2UgYSBn dWVzcywgdGhleSBtYXkgZW5kdXAgdXNpbmcgYSBzaW5nbGUgY29yZS4gV2hlcmUgd2l0aCBwcm9w ZXIKPiA+ID4gc2NoZWR1bGluZyBpbiBWNEwyLCB0aGUga2VybmVsIHdpbGwgYmUgYWJsZSB0byBw cm9wZXJseSBkaXN0cmlidXRlIHRoZSBsb2FkLiBJCj4gPiA+IGluc2lzdCBvbiB0aGlzLCBzaW5j ZSBpZiB3ZSBtZXJnZSB5b3UgY2hhbmdlcyBpdCBiZWNvbWVzIGFuIEFCSSBhbmQgd2UgY2FuJ3QK PiA+ID4gY2hhbmdlIGl0IGFueW1vcmUuCj4gPiAKPiA+IFdpbGwgaXQgcmVhbGx5IGJlY29tZSBB QkkganVzdCBsaWtlIHRoYXQ/ICBVc2Vyc3BhY2Ugc2hvdWxkIGFsd2F5cwo+ID4gZGlzY292ZXIg dGhlIHZpZGVvIG5vZGVzIGFuZCB0aGVpciBjYXBhYmlsaXRpZXMgYW5kIG5vdCBoYXJkY29kZSBl LmcuIGEKPiA+IHNwZWNpZmljIC9kZXYvdmlkZW9OIGZpbGUgZm9yIGEgc3BlY2lmaWMgY29kZWMu ICBJIHdvdWxkIGFyZ3VlIHRoYXQgdGhpcwo+ID4gc2VyaWVzIHdvdWxkIGxldCB1c2Vyc3BhY2Ug ZG8gSlBFRyBlbmNvZGluZyByaWdodCBhd2F5LCBldmVuIGlmIGluIGEKPiA+IGxlc3Mgb3B0aW1h bCB3YXkgdGhhbiBpZiB0aGUgZHJpdmVyIHdvdWxkIHJvdW5kLXJvYmluIHRoZW0gdGhyb3VnaCBh Cj4gPiBzaW5nbGUgdmlkZW8gbm9kZSwgYnV0IHRoYXQgY2FuIGFsd2F5cyBiZSBhZGRlZCBpbiBh IGZ1dHVyZSB2ZXJzaW9uLgo+IAo+IE1pZ2h0IGJlIG9uIHRoZSBncmF5IHNpZGUsIGJ1dCB0aGVy ZSBpcyBnb29kIGNoYW5jZXMgc29mdHdhcmUgd3JpdHRlbiBmb3IgeW91cgo+IHNwZWNpZmljIGJv YXJkIGNhbiBzdG9wIHdvcmtpbmcgYWZ0ZXIgdGUgZ3JvdXBpbmcgaXMgZG9uZS4KCkkgd2lsbCBz ZW5kIGEgbmV3IHNlcmllcyBzaG9ydGx5IHdoaWNoIGVuYWJsZXMgb25seSBvbmUgb2YgdGhlc2Ug Zm91cgpjb3JlcywgdGhlIGZ1bmN0aW9uYWxpdHkgc2hvdWxkIGJlIHRoZSBzYW1lLCBpdCB3aWxs IGp1c3QgZXhwb3NlIG9ubHkKb25lIHZpZGVvIG5vZGUgd2hpY2ggY2FuIGdldCBhIGZvdXIgdGlt ZXMgdGhyb3VnaHB1dCB1cGdyYWRlIGxhdGVyIG9uY2UKd2UgaW1wbGVtZW50IG11bHRpLWNvcmUg c3VwcG9ydCBpbiB0aGUgZHJpdmVyLgoKPiAKPiA+IAo+ID4gPiAKPiA+ID4gSSB1bmRlcnN0YW5k IHRoYXQgdGhpcyBpbXBvc2UgYSByZXdvcmsgb2YgdGhlIG1lbTJtZW0gZnJhbWV3b3JrIHNvIHRo YXQgd2UgY2FuCj4gPiA+IHJ1biBtdWx0aXBsZSBqb2JzLCBidXQgdGhpcyB3aWxsIGJlIG5lZWRl ZCBhbnl3YXkgb24gUkszNTg4LCBzaW5jZSB0aGUgcmt2ZGVjMiwKPiA+ID4gd2hpY2ggd2UgZG9u J3QgaGF2ZSBhIGRyaXZlciB5ZXQgaXMgYWxzbyBtdWx0aS1jb3JlLCBidXQgeW91IG5lZWQgdG8g dXNlIDIgY29yZXMKPiA+ID4gd2hlbiB0aGUgcmVzb2x1dGlvbiBpcyBjbG9zZSB0byA4Sy4KPiA+ IAo+ID4gSSB0aGluayB0aGUgbWVkaWF0ZWsgSlBFRyBkcml2ZXIgYWxyZWFkeSBzdXBwb3J0cyB0 aGF0LCB3b3VsZCBpdCBiZSBvawo+ID4gdG8gZG8gaXQgdGhlIHNhbWUgd2F5Pwo+IAo+IEkgZG9u J3Qga25vdyBmb3IgSlBFRywgdGhlIE1USyB2Y29kZXIgZG8gc3VwcG9ydCBjYXNjYWRpbmcgY29y ZXMuIFRoaXMgaXMKPiBkaWZmZXJlbnQgZnJvbSBjb25jdXJyZW50IGNvcmVzLiBJbiBNVEsgYXJj aGl0ZWN0dXJlLCBmb3Igc29tZSBvZiB0aGUgY29kZWMsCj4gdGhlcmUgaXMgTEFUIChlbnRyb3B5 IGRlY29kZXIpIGFuZCBDT1JFICh0aGUgcmVjb25zdHJ1Y3Rpb24gYmxvY2spIHRoYXQgYXJlCj4g c3BsaXQuCgpBaCwgdGhhdOKAmXMgZGlmZmVyZW50IHRoZW4sIEkgb25seSBoYWQgYSBjdXJzb3J5 IGxvb2sgYXQgdGhlbSBiYWNrIHdoZW4gSQppbXBsZW1lbnRlZCB0aGUgSlBFRyBkZWNvZGVyIGZv ciBzdW54aS4KCj4gCj4gTmljb2xhcwoKLS0gCkxpbmsgTWF1dmUKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlz dApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBAEFC00A94 for ; Fri, 12 Apr 2024 15:07:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Sdn2/UnyTNd2XJbL5SOo4mz2+jfzHhdKXbwQyEypj6k=; b=VBsXAwJnQqeV5G Csw6nO4Sbt1YgsDjceHcAOW8zLSd0bVAqnNhrJxpGjWiGGc2Cg8PrpbB3DMwx1IUsX1BcjrczJCei N09t5uFOR0dPCglj5YH5d3Dt5lcboGtNSw9kr32vKafVFbyGi+a2cwhysjZO4zc9RfGGLs/bStqFu Tkf6Eo7IxElnpTCxRZYA4dcmOlygzZiJqKo4Oi3EjOsQvhQuhnfUCi1JkrjfUn0cW+xDC8eu9NdKh BSl/r98ezVl+gDBxbw7q7/L8LNWUKuGTv3zjHP8ijJ8DVfxEfawqExS2AloqRJsRoRaz0jtHkFLHs 34xekeN/2hJQpIde7n7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvIV1-000000008xE-2sh3; Fri, 12 Apr 2024 15:07:31 +0000 Received: from luna.linkmauve.fr ([82.65.109.163]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvIUx-000000008w0-1MdQ; Fri, 12 Apr 2024 15:07:29 +0000 Received: by luna.linkmauve.fr (Postfix, from userid 1000) id 4EDA110A25E8; Fri, 12 Apr 2024 17:07:19 +0200 (CEST) Date: Fri, 12 Apr 2024 17:07:19 +0200 From: Link Mauve To: Nicolas Dufresne Cc: Link Mauve , linux-kernel@vger.kernel.org, Ezequiel Garcia , Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Joerg Roedel , Will Deacon , Robin Murphy , Sebastian Reichel , Cristian Ciocaltea , Dragan Simic , Shreeya Patel , Chris Morgan , Andy Yan , Nicolas Frattaroli , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev Subject: Re: [PATCH v2 0/2] Enable JPEG encoding on rk3588 Message-ID: References: <20240327134115.424846-1-linkmauve@linkmauve.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Jabber-ID: linkmauve@linkmauve.fr X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_080727_634832_30864B57 X-CRM114-Status: GOOD ( 48.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCBBcHIgMDcsIDIwMjQgYXQgMTA6MDg6NThBTSArMDIwMCwgTmljb2xhcyBEdWZyZXNu ZSB3cm90ZToKPiBMZSB2ZW5kcmVkaSAwNSBhdnJpbCAyMDI0IMOgIDE2OjIxICswMjAwLCBMaW5r IE1hdXZlIGEgw6ljcml0wqA6Cj4gPiBPbiBUaHUsIEFwciAwNCwgMjAyNCBhdCAwMTo0MToxNVBN IC0wNDAwLCBOaWNvbGFzIER1ZnJlc25lIHdyb3RlOgo+ID4gPiBIaSwKPiA+IAo+ID4gSGksCj4g PiAKPiA+ID4gCj4gPiA+IExlIG1lcmNyZWRpIDI3IG1hcnMgMjAyNCDDoCAxNDo0MSArMDEwMCwg RW1tYW51ZWwgR2lsIFBleXJvdCBhIMOpY3JpdMKgOgo+ID4gPiA+IE9ubHkgdGhlIEpQRUcgZW5j b2RlciBpcyBhdmFpbGFibGUgZm9yIG5vdywgYWx0aG91Z2ggdGhlcmUgYXJlIHBhdGNoZXMKPiA+ ID4gPiBmb3IgdGhlIHVuZG9jdW1lbnRlZCBWUDggZW5jb2RlciBmbG9hdGluZyBhcm91bmRbMF0u Cj4gPiA+IAo+ID4gPiBbMF0gc2VlbXMgbGlrZSBhIGJyb2tlbiBsaW5rLiBUaGUgVlA4IGVuY29k ZXIgUkZDIGlzIGZvciBSSzMzOTkgKGFuZCBIYW50cm8gSDEKPiA+ID4gcG9zdGVkIGJ5IFNUIG1v cmUgcmVjZW50bHkpLiBUaGUgVFJNIHNheXMgIlZFUFUxMjEoSlBFRyBlbmNvZGVyIG9ubHkpIiwg d2hpY2gKPiA+ID4gc3VnZ2VzdCB0aGF0IHRoZSBILjI2NCBhbmQgVlA4IGVuY29kZXJzIHVzdWFs bHkgZm91bmQgb24gdGhlIFZFUFUxMjEgYXJlCj4gPiA+IHJlbW92ZWQuIEFzIFJvY2tjaGlwIGhh dmUgcmVtb3ZlIHRoZSBzeW50aGVzaXplIHJlZ2lzdGVyIHdoaWxlIG1vZGlmeWluZyB0aGUgSDEK PiA+ID4gSVAsIGl0IGlzIGRpZmZpY3VsdCB0byB2ZXJpZnkuIENvbmZ1c2luZ2x5IHRoZSBILjI2 NCBzcGVjaWZpYyByZWdpc3RlcnMgYXJlCj4gPiA+IGRvY3VtZW50ZWQgaW4gdGhlIFRSTSBhcm91 bmQgVkVQVTEyMS4KPiA+IAo+ID4gQWgsIHRoZSBsaW5rIGJlY2FtZSwgYW5kIHdhcyBpbmRlZWQg U1TigJlzIHNlcmllczoKPiA+IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcHJvamVjdC9s aW51eC1yb2NrY2hpcC9saXN0Lz9zZXJpZXM9Nzg5ODg1JmFyY2hpdmU9Ym90aAo+ID4gCj4gPiBC dXQgdGhlIFRSTSBwYXJ0IDEgc2F5cyB0aGUgVkVQVTEyMSBzdXBwb3J0cyBILjI2NCBlbmNvZGlu ZyAocGFnZSAzNjcpLAo+ID4gYW5kIGl04oCZcyBsaWtlbHkgdGhleSBkaWRu4oCZdCByZW1vdmUg anVzdCBWUDggc3VwcG9ydCBzaW5jZSB0aGUgY29kZWMKPiA+IGZlYXR1cmVzIGFyZSBwcmV0dHkg Y2xvc2UgdG8gSC4yNjTigJlzLgo+ID4gCj4gPiA+IAo+ID4gPiA+IAo+ID4gPiA+IFRoaXMgaGFz IGJlZW4gdGVzdGVkIG9uIGEgcm9jay01YiwgcmVzdWx0aW5nIGluIGZvdXIgL2Rldi92aWRlbyoK PiA+ID4gPiBlbmNvZGVycy4gIFRoZSB1c2Vyc3BhY2UgcHJvZ3JhbSBJ4oCZdmUgYmVlbiB1c2lu ZyB0byB0ZXN0IHRoZW0gaXMKPiA+ID4gPiBPbml4WzFdLCB1c2luZyB0aGUganBlZy1lbmNvZGVy IGV4YW1wbGUsIGl0IHdpbGwgcGljayBvbmUgb2YgdGhlc2UgZm91cgo+ID4gPiA+IGF0IHJhbmRv bSAoYnV0IGRpc3BsYXlzIHRoZSBvbmUgaXQgcGlja2VkKToKPiA+ID4gPiAlIGZmbXBlZyAtaSA8 aW5wdXQgaW1hZ2U+IC1waXhfZm10IHl1dmo0MjBwIHRlbXAueXV2Cj4gPiA+ID4gJSBqcGVnLWVu Y29kZXIgdGVtcC55dXYgPHdpZHRoPiA8aGVpZ2h0PiBOVjEyIDxxdWFsaXR5PiBvdXRwdXQuanBl Zwo+ID4gPiAKPiA+ID4gSSBkb24ndCBsaWtlIHRoYXQgd2UgZXhwb3NpbmcgZWFjaCBpZGVudGlj YWwgY29yZXMgYSBzZXBhcmF0ZSB2aWRlbyBub2Rlcy4gSQo+ID4gPiB0aGluayB3ZSBzaG91bGQg YWltIGZvciAxIGRldmljZSwgYW5kIHRoZW4gbXVsdGktcGxleCBhbmQgc2NoZWR1bGUgZGUgY29y ZXMgZnJvbQo+ID4gPiBpbnNpZGUgdGhlIExpbnV4IGtlcm5lbC4KPiA+IAo+ID4gSSBhZ3JlZSwg YnV0IHRoaXMgc2hvdWxkIGJlIGhhbmRsZWQgaW4gdGhlIGRyaXZlciBub3QgaW4gdGhlIGRldmlj ZQo+ID4gdHJlZSwgYW5kIGl0IGNhbiBiZSBkb25lIGxhdGVyLgo+IAo+IEFzIHRoZSBiZWhhdmlv dXIgd2Ugd2FudCBpcyB0aGF0IHRoZXNlIGNvcmVzIGJlY29tZXMgYSBncm91cCBhbmQgZ2V0IHNj aGVkdWxlCj4gdG9nZXRoZXIsIGl0cyBjZXJ0YWlubHkgYSBnb29kIHRpbWUgdG8gc2xvdyBkb3du IGFuZCBldmFsdWF0ZSBpZiB0aGF0IHBhcnQgbmVlZHMKPiB0byBiZSBpbXByb3ZlIGluIHRoZSBE VCB0b28uCj4gCj4gSGFudHJvIEcxL0gxIGFuZCBWRVBVL1ZEUFUxMjEgY29tYm9zIG9yaWdpbmFs bHkgc2hhcmVkIHRoZSBzYW1lIHNyYW0gcmVnaW9uLiBJdHMKPiBub3QgY2xlYXIgaWYgYW55IG9m IHRoZXNlIGNvcmVzIGhhdmUgdGhpcyBsaW1pdGF0aW9uIGFuZCBpZiB0aGlzIHNob3VsZCBiZQo+ IGV4cHJlc3NlZCBpbiB0aGUgRFQgLyBkcml2ZXIuCgpUaGUgVFJNIG9uIHBhZ2UgMzY5IG1lbnRp b25zIHRoYXQ6Cj4gUGxlYXNlIG5vdGUgdGhhdCBWRFBVMTIxIGFuZCBWRFBVMzgxIGFuZCBWRFBV NzIwIGFuZCBBVjEgYW5kIFZFUFUxMjEgYW5kIFZFUFU1ODAKPiBpcyBkaWZmZXJlbnQgSVAgY29y ZXMsIHNvIHRoZXNlIHByb2Nlc3NpbmcgY29yZSBjYW4gYmUgd29yayB0b2dldGhlci4KCkkgdW5k ZXJzdGFuZCB0aGF0IGFzIHRoZW0gbm90IHNoYXJpbmcgYW55IG1lbW9yeSBhbmQgYmVpbmcgYWJs ZSB0byB3b3JrCmluZGVwZW5kZW50bHkuCgo+IAo+ID4gCj4gPiA+IAo+ID4gPiBOb3QgZG9pbmcg dGhpcyBub3cgbWVhbnMgd2UnbGwgbmV2ZXIgaGF2ZSBhbiBvcHRpbWFsIGhhcmR3YXJlIHVzYWdl Cj4gPiA+IGRpc3RyaWJ1dGlvbi4gSnVzdCBjb25zaWRlciB0d28gdXNlcnNwYWNlIHNvZnR3YXJl IHdhbnRpbmcgdG8gZG8ganBlZyBlbmNvZGluZy4KPiA+ID4gSWYgdGhleSBib3RoIHRha2UgYSBn dWVzcywgdGhleSBtYXkgZW5kdXAgdXNpbmcgYSBzaW5nbGUgY29yZS4gV2hlcmUgd2l0aCBwcm9w ZXIKPiA+ID4gc2NoZWR1bGluZyBpbiBWNEwyLCB0aGUga2VybmVsIHdpbGwgYmUgYWJsZSB0byBw cm9wZXJseSBkaXN0cmlidXRlIHRoZSBsb2FkLiBJCj4gPiA+IGluc2lzdCBvbiB0aGlzLCBzaW5j ZSBpZiB3ZSBtZXJnZSB5b3UgY2hhbmdlcyBpdCBiZWNvbWVzIGFuIEFCSSBhbmQgd2UgY2FuJ3QK PiA+ID4gY2hhbmdlIGl0IGFueW1vcmUuCj4gPiAKPiA+IFdpbGwgaXQgcmVhbGx5IGJlY29tZSBB QkkganVzdCBsaWtlIHRoYXQ/ICBVc2Vyc3BhY2Ugc2hvdWxkIGFsd2F5cwo+ID4gZGlzY292ZXIg dGhlIHZpZGVvIG5vZGVzIGFuZCB0aGVpciBjYXBhYmlsaXRpZXMgYW5kIG5vdCBoYXJkY29kZSBl LmcuIGEKPiA+IHNwZWNpZmljIC9kZXYvdmlkZW9OIGZpbGUgZm9yIGEgc3BlY2lmaWMgY29kZWMu ICBJIHdvdWxkIGFyZ3VlIHRoYXQgdGhpcwo+ID4gc2VyaWVzIHdvdWxkIGxldCB1c2Vyc3BhY2Ug ZG8gSlBFRyBlbmNvZGluZyByaWdodCBhd2F5LCBldmVuIGlmIGluIGEKPiA+IGxlc3Mgb3B0aW1h bCB3YXkgdGhhbiBpZiB0aGUgZHJpdmVyIHdvdWxkIHJvdW5kLXJvYmluIHRoZW0gdGhyb3VnaCBh Cj4gPiBzaW5nbGUgdmlkZW8gbm9kZSwgYnV0IHRoYXQgY2FuIGFsd2F5cyBiZSBhZGRlZCBpbiBh IGZ1dHVyZSB2ZXJzaW9uLgo+IAo+IE1pZ2h0IGJlIG9uIHRoZSBncmF5IHNpZGUsIGJ1dCB0aGVy ZSBpcyBnb29kIGNoYW5jZXMgc29mdHdhcmUgd3JpdHRlbiBmb3IgeW91cgo+IHNwZWNpZmljIGJv YXJkIGNhbiBzdG9wIHdvcmtpbmcgYWZ0ZXIgdGUgZ3JvdXBpbmcgaXMgZG9uZS4KCkkgd2lsbCBz ZW5kIGEgbmV3IHNlcmllcyBzaG9ydGx5IHdoaWNoIGVuYWJsZXMgb25seSBvbmUgb2YgdGhlc2Ug Zm91cgpjb3JlcywgdGhlIGZ1bmN0aW9uYWxpdHkgc2hvdWxkIGJlIHRoZSBzYW1lLCBpdCB3aWxs IGp1c3QgZXhwb3NlIG9ubHkKb25lIHZpZGVvIG5vZGUgd2hpY2ggY2FuIGdldCBhIGZvdXIgdGlt ZXMgdGhyb3VnaHB1dCB1cGdyYWRlIGxhdGVyIG9uY2UKd2UgaW1wbGVtZW50IG11bHRpLWNvcmUg c3VwcG9ydCBpbiB0aGUgZHJpdmVyLgoKPiAKPiA+IAo+ID4gPiAKPiA+ID4gSSB1bmRlcnN0YW5k IHRoYXQgdGhpcyBpbXBvc2UgYSByZXdvcmsgb2YgdGhlIG1lbTJtZW0gZnJhbWV3b3JrIHNvIHRo YXQgd2UgY2FuCj4gPiA+IHJ1biBtdWx0aXBsZSBqb2JzLCBidXQgdGhpcyB3aWxsIGJlIG5lZWRl ZCBhbnl3YXkgb24gUkszNTg4LCBzaW5jZSB0aGUgcmt2ZGVjMiwKPiA+ID4gd2hpY2ggd2UgZG9u J3QgaGF2ZSBhIGRyaXZlciB5ZXQgaXMgYWxzbyBtdWx0aS1jb3JlLCBidXQgeW91IG5lZWQgdG8g dXNlIDIgY29yZXMKPiA+ID4gd2hlbiB0aGUgcmVzb2x1dGlvbiBpcyBjbG9zZSB0byA4Sy4KPiA+ IAo+ID4gSSB0aGluayB0aGUgbWVkaWF0ZWsgSlBFRyBkcml2ZXIgYWxyZWFkeSBzdXBwb3J0cyB0 aGF0LCB3b3VsZCBpdCBiZSBvawo+ID4gdG8gZG8gaXQgdGhlIHNhbWUgd2F5Pwo+IAo+IEkgZG9u J3Qga25vdyBmb3IgSlBFRywgdGhlIE1USyB2Y29kZXIgZG8gc3VwcG9ydCBjYXNjYWRpbmcgY29y ZXMuIFRoaXMgaXMKPiBkaWZmZXJlbnQgZnJvbSBjb25jdXJyZW50IGNvcmVzLiBJbiBNVEsgYXJj aGl0ZWN0dXJlLCBmb3Igc29tZSBvZiB0aGUgY29kZWMsCj4gdGhlcmUgaXMgTEFUIChlbnRyb3B5 IGRlY29kZXIpIGFuZCBDT1JFICh0aGUgcmVjb25zdHJ1Y3Rpb24gYmxvY2spIHRoYXQgYXJlCj4g c3BsaXQuCgpBaCwgdGhhdOKAmXMgZGlmZmVyZW50IHRoZW4sIEkgb25seSBoYWQgYSBjdXJzb3J5 IGxvb2sgYXQgdGhlbSBiYWNrIHdoZW4gSQppbXBsZW1lbnRlZCB0aGUgSlBFRyBkZWNvZGVyIGZv ciBzdW54aS4KCj4gCj4gTmljb2xhcwoKLS0gCkxpbmsgTWF1dmUKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK