From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2459C4345F for ; Fri, 12 Apr 2024 17:01:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I3ko+m8ft9wBMPEvDfAawAk492+f74LOemTVd7hed0w=; b=diLDDUf/tDQqmN bc7eshviicSyBJVkULsdbKsahk21T07PS9Gln0YlAGmhIVEEmloXPYnPWFJwEyyfBdiAGob/6xQ/R ee/10NwAB05i6eq5q+ujuVqh3nGbpGbALeMtGK7s7E5XC74cIAfd8HAijIuKKH4OPZa4ULTl31xcs maFCLX9BgwIzDggsW6OKALCJLL00ltF8C+eZ/RRMGca+lIesoO2xsRK3E94xu4YeEbWJrb0ZaEzR+ 3lWHMU76YXUtOtQf9u6S6EF9FUtixuSjZVuLxU8m8JuglaaCzmwfWmWFJF4Y23N1fZ2sDBKLiE945 yLIXBJ3G8Q0QiEr4BlDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvKH3-00000000aAl-2D98; Fri, 12 Apr 2024 17:01:13 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvKH0-00000000a9W-0or2 for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2024 17:01:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6D8D5339; Fri, 12 Apr 2024 10:01:35 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 193413F64C; Fri, 12 Apr 2024 10:01:04 -0700 (PDT) Date: Fri, 12 Apr 2024 18:01:02 +0100 From: Cristian Marussi To: Jassi Brar Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, sudeep.holla@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Subject: Re: [PATCH v3 2/2] mailbox: arm_mhuv3: Add driver Message-ID: References: <20240404062347.3219795-1-cristian.marussi@arm.com> <20240404062347.3219795-3-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_100110_311632_464974D2 X-CRM114-Status: GOOD ( 19.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBcHIgMDgsIDIwMjQgYXQgMTE6NDA6MjRBTSArMDEwMCwgQ3Jpc3RpYW4gTWFydXNz aSB3cm90ZToKPiBPbiBTdW4sIEFwciAwNywgMjAyNCBhdCAwODoxNDoyM1BNIC0wNTAwLCBKYXNz aSBCcmFyIHdyb3RlOgo+ID4gT24gVGh1LCBBcHIgNCwgMjAyNCBhdCAxOjI14oCvQU0gQ3Jpc3Rp YW4gTWFydXNzaQo+ID4gPGNyaXN0aWFuLm1hcnVzc2lAYXJtLmNvbT4gd3JvdGU6Cj4gPiA+Cj4g PiA+IEFkZCBzdXBwb3J0IGZvciBBUk0gTUhVdjMgbWFpbGJveCBjb250cm9sbGVyLgo+ID4gPgo+ ID4gPiBTdXBwb3J0IGlzIGxpbWl0ZWQgdG8gdGhlIE1IVXYzIERvb3JiZWxsIGV4dGVuc2lvbiB1 c2luZyBvbmx5IHRoZSBQQlgvTUJYCj4gPiA+IGNvbWJpbmVkIGludGVycnVwdHMuCj4gPiA+Cj4g Cj4gSGkgSmFzc2ksCj4gCj4gdGhhbmtzIGZvciBoYXZpbmcgYSBsb29rIGF0IHRoaXMgIQo+IAoK W3NuaXBdCgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBDcmlzdGlhbiBNYXJ1c3NpIDxjcmlzdGlhbi5t YXJ1c3NpQGFybS5jb20+Cj4gPiA+IC0tLQo+ID4gPiArc3RydWN0IGFpZHIgewo+ID4gPiArICAg ICAgIHUzMiBhcmNoX21pbm9yX3JldiA6IDQ7Cj4gPiA+ICsgICAgICAgdTMyIGFyY2hfbWFqb3Jf cmV2IDogNDsKPiA+ID4gKyAgICAgICB1MzIgcGFkIDogMjQ7Cj4gPiA+ICt9IF9fcGFja2VkOwo+ ID4gPiArCj4gPiBJIGFtIG5vdCBzdXJlIGFib3V0IHVzaW5nIGJpdGZpZWxkcyBvbiByZWdpc3Rl ciB2YWx1ZXMuIEkga25vdyB2Mgo+ID4gZHJpdmVyIGFsc28gdXNlcyBiaXRmaWVsZHMgYnV0IHRo aXMgc3RpbGwgaXMgbm90IHZlcnkgcG9ydGFibGUgYW5kIGlzCj4gPiBkZXBlbmRlbnQgb24gY29t cGlsZXIgYmVoYXZpb3VyLiBXZSBtYXkgYWN0dWFsbHkgc2F2ZSBzb21lIGxvYyBieSBub3QKPiA+ IGhhdmluZyB1bnVzZWQgZmllbGRzIGlmIHdlIHVzZSBzaGlmdHMgYW5kIG1hc2tzLiBUaG91Z2gg SSBkb24ndAo+ID4gc3Ryb25nbHkgZmVlbCBlaXRoZXIgd2F5Lgo+ID4gCj4gCj4gWWVzLCBpbmRl ZWQgc2VlbWVkIGEgYml0IG9kZCB3YXkgb2YgaGFuZGxpbmcgcmVncyB3aGVuIEkgc2F3IGl0IGlu IG1odXYyLAo+IEJVVCBpdCBzZWVtZWQgaXQgaGFkIGl0cyBhZHZhbnRhZ2VzIGluIHRlcm1zIG9m IGNsYXJpdHkgb2YgdXNhZ2UuLi4uZGlkCj4gbm90IGtub3cgYWJvdXQgcG9zc2libGUgZHJhd2Jh Y2tzLCB0aG91Z2guIEknbGwgcmUtdGhpbmsgYWJvdXQgdGhlIHByb3MKPiBhbmQgY29ucyBvZiB0 aGlzIGFwcHJvYWNoLgo+CgouLnJlcGx5aW5nIHRvIG15c2VsZiBoZXJlLi4uSSBhbSBkcm9wcGlu ZyBiaXRmaWVsZHMgdG9vIGluIGZhdm91ciBvZgpiaXRtYXNrcy4uLkkndmUgcmVhZCB0b28gbWFu eSBob3Jyb3Igc3RvcmllcyB0aGlzIGFmdGVybm9vbiBhYm91dCBiaXRmaWVsZHMKYW5kIGNvbXBp bGVycyBpbnRlcmFjdGlvbnMgYW5kIHRoZWlyIGZsYWt5IHVzYWdlIHdoaWxlIGhhbmRsaW5nIHJl ZyBtYXBzIHRvCnN0aWxsIGZlZWwgY29tZm9ydGFibGUgdXNpbmcgdGhlbS4uLgoKVGhhbmtzLApD cmlzdGlhbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E5FAF14BF8B; Fri, 12 Apr 2024 17:01:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712941268; cv=none; b=CxPDSSjNSGO7R0UkN7VO3wYtY0ZLzvx7AMvfT/SRbHKLQpLQ/wrKo2Sg8kjDVHhTADlroB5lHCYazvK1mJz9UUyaUm2ON2mW8/KzJaI1WHXuwJKXUEhHAtxUW0IAqrdifSanmCO9tyKjrn88joKmHCH5/quukvWCyFDUv0UJwA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712941268; c=relaxed/simple; bh=59anHmEmeL1dZlS9Wp5VDXxPg2tCJdny8Tcylbay9uM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mZi0Sz+kMSoXTNFlDKzuaMqXRfstfmpGyIF3+nKr6iBHXTKuNU+uHmTbNVWjdI5N+Z09TJrlG5VRzYhewucRcFV+7V+r1DuqP/bM8uGLloJmXXZMRfOXnKQ+hPJ85zbstTIy5uAyYjgyPElpyRi4Rl+kS0n7pQokKxOdw0g0o5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6D8D5339; Fri, 12 Apr 2024 10:01:35 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 193413F64C; Fri, 12 Apr 2024 10:01:04 -0700 (PDT) Date: Fri, 12 Apr 2024 18:01:02 +0100 From: Cristian Marussi To: Jassi Brar Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, sudeep.holla@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Subject: Re: [PATCH v3 2/2] mailbox: arm_mhuv3: Add driver Message-ID: References: <20240404062347.3219795-1-cristian.marussi@arm.com> <20240404062347.3219795-3-cristian.marussi@arm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Apr 08, 2024 at 11:40:24AM +0100, Cristian Marussi wrote: > On Sun, Apr 07, 2024 at 08:14:23PM -0500, Jassi Brar wrote: > > On Thu, Apr 4, 2024 at 1:25 AM Cristian Marussi > > wrote: > > > > > > Add support for ARM MHUv3 mailbox controller. > > > > > > Support is limited to the MHUv3 Doorbell extension using only the PBX/MBX > > > combined interrupts. > > > > > Hi Jassi, > > thanks for having a look at this ! > [snip] > > > Signed-off-by: Cristian Marussi > > > --- > > > +struct aidr { > > > + u32 arch_minor_rev : 4; > > > + u32 arch_major_rev : 4; > > > + u32 pad : 24; > > > +} __packed; > > > + > > I am not sure about using bitfields on register values. I know v2 > > driver also uses bitfields but this still is not very portable and is > > dependent on compiler behaviour. We may actually save some loc by not > > having unused fields if we use shifts and masks. Though I don't > > strongly feel either way. > > > > Yes, indeed seemed a bit odd way of handling regs when I saw it in mhuv2, > BUT it seemed it had its advantages in terms of clarity of usage....did > not know about possible drawbacks, though. I'll re-think about the pros > and cons of this approach. > ..replying to myself here...I am dropping bitfields too in favour of bitmasks...I've read too many horror stories this afternoon about bitfields and compilers interactions and their flaky usage while handling reg maps to still feel comfortable using them... Thanks, Cristian