From: Matthew Wilcox <willy@infradead.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
akpm@linux-foundation.org, linux-modules@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz
Subject: Re: [PATCH] module: ban '.', '..' as module names, ban '/' in module names
Date: Mon, 15 Apr 2024 01:35:09 +0100 [thread overview]
Message-ID: <Zhx2PfHjjTmjBZY8@casper.infradead.org> (raw)
In-Reply-To: <ee371cf7-69fa-4f9c-99b9-59bab86f25e4@p183>
On Sun, Apr 14, 2024 at 10:05:05PM +0300, Alexey Dobriyan wrote:
> Any other subsystem should use nice helper function aptly named
>
> string_is_vfs_ready()
>
> and apply additional restrictions if necessary.
>
> /proc/modules hints that newlines should be banned too,
> and \x1f, and whitespace, and similar looking characters
> from different languages and emojis (except 🐧obviously).
I don't see the purpose of allowing any character in 0x01-0x1f.
How annoying to have BEL in there. And, really, what's the value in
allowing characters after 0x7e?
next prev parent reply other threads:[~2024-04-15 0:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 19:05 [PATCH] module: ban '.', '..' as module names, ban '/' in module names Alexey Dobriyan
2024-04-14 20:58 ` Luis Chamberlain
2024-04-15 17:23 ` Alexey Dobriyan
2024-04-15 17:40 ` Dr. David Alan Gilbert
2024-04-15 0:35 ` Matthew Wilcox [this message]
2024-04-15 8:08 ` Christoph Hellwig
2025-02-19 20:35 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zhx2PfHjjTmjBZY8@casper.infradead.org \
--to=willy@infradead.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.