All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <xiang@kernel.org>
To: Li RongQing <lirongqing@baidu.com>
Cc: huyue2@coolpad.com, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs: Consider NUMA affinity when allocating memory for per-CPU pcpubuf
Date: Mon, 15 Apr 2024 15:58:26 +0800	[thread overview]
Message-ID: <ZhzeIgG6Xu46hrF/@debian> (raw)
In-Reply-To: <20240415061940.56864-1-lirongqing@baidu.com>

Hi RongQing,

On Mon, Apr 15, 2024 at 02:19:40PM +0800, Li RongQing wrote:
> per-CPU pcpubufs are dominantly accessed from their own local CPUs,
> so allocate them node-local to improve performance.
> 
> Signed-off-by: Li RongQing <lirongqing@baidu.com>

Thanks for your patch!  Yeah, NUMA-aware is important to
NUMA bare metal server scenarios.

In the next cycle, we also reduce the total number of buffers
since we don't such many per-CPU buffers if there are too many
CPUs: we called "global buffers" and maintain CPU->global
buffer mappings.  Also erofs_allocpage() won't be used to
allocate too.

For more details, see my for-next branch:
https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git/log/?h=dev

So could you make some difference to make the new global
buffers NUMA-aware? (both for allocation and mapping, maybe
the allocation is still a priority stuff if per-CPU is needed
anyway.)

Thanks,
Gao Xiang

      reply	other threads:[~2024-04-15  7:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15  6:19 [PATCH] erofs: Consider NUMA affinity when allocating memory for per-CPU pcpubuf Li RongQing via Linux-erofs
2024-04-15  7:58 ` Gao Xiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZhzeIgG6Xu46hrF/@debian \
    --to=xiang@kernel.org \
    --cc=huyue2@coolpad.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=lirongqing@baidu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.