From: Hangbin Liu <liuhangbin@gmail.com>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Ido Schimmel <idosch@nvidia.com>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, mlxsw@nvidia.com,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net-next 08/10] selftests: forwarding: router_mpath_nh: Add a diagram
Date: Mon, 15 Apr 2024 16:28:59 +0800 [thread overview]
Message-ID: <ZhzlS1htaCaAWGmv@Laptop-X1> (raw)
In-Reply-To: <2f82d982bf2a7c23dbd8ae63e94c3655ce9f92c8.1712940759.git.petrm@nvidia.com>
On Fri, Apr 12, 2024 at 07:03:11PM +0200, Petr Machata wrote:
> This test lacks a topology diagram, making the setup not obvious.
> Add one.
>
> Cc: David Ahern <dsahern@gmail.com>
> Signed-off-by: Petr Machata <petrm@nvidia.com>
> ---
> .../net/forwarding/router_mpath_nh.sh | 35 +++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/tools/testing/selftests/net/forwarding/router_mpath_nh.sh b/tools/testing/selftests/net/forwarding/router_mpath_nh.sh
> index 3f0f5dc95542..2ba44247c60a 100755
> --- a/tools/testing/selftests/net/forwarding/router_mpath_nh.sh
> +++ b/tools/testing/selftests/net/forwarding/router_mpath_nh.sh
> @@ -1,6 +1,41 @@
> #!/bin/bash
> # SPDX-License-Identifier: GPL-2.0
>
> +# +-------------------------+
> +# | H1 |
> +# | $h1 + |
> +# | 192.0.2.2/24 | |
> +# | 2001:db8:1::2/64 | |
> +# +-------------------|-----+
> +# |
> +# +-------------------|----------------------+
> +# | | R1 |
> +# | $rp11 + |
> +# | 192.0.2.1/24 |
> +# | 2001:db8:1::1/64 |
> +# | |
> +# | + $rp12 + $rp13 |
> +# | | 169.254.2.12/24 | 169.254.3.13/24 |
> +# | | fe80:2::12/64 | fe80:3::13/64 |
> +# +--|--------------------|------------------+
> +# | |
> +# +--|--------------------|------------------+
> +# | + $rp22 + $rp23 |
> +# | 169.254.2.22/24 169.254.3.23/24 |
> +# | fe80:2::22/64 fe80:3::23/64 |
> +# | |
> +# | $rp21 + |
> +# | 198.51.100.1/24 | |
> +# | 2001:db8:2::1/64 | R2 |
> +# +-------------------|----------------------+
> +# |
> +# +-------------------|-----+
> +# | | |
> +# | $h2 + |
> +# | 198.51.100.2/24 |
> +# | 2001:db8:2::2/64 H2 |
> +# +-------------------------+
> +
> ALL_TESTS="
> ping_ipv4
> ping_ipv6
> --
> 2.43.0
>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
next prev parent reply other threads:[~2024-04-15 8:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 17:03 [PATCH net-next 00/10] selftests: Assortment of fixes Petr Machata
2024-04-12 17:03 ` [PATCH net-next 01/10] selftests: net: Unify code of busywait() and slowwait() Petr Machata
2024-04-15 7:21 ` Hangbin Liu
2024-04-12 17:03 ` [PATCH net-next 02/10] selftests: forwarding: lib.sh: Validate NETIFS Petr Machata
2024-04-15 7:47 ` Hangbin Liu
2024-04-12 17:03 ` [PATCH net-next 03/10] selftests: forwarding: bail_on_lldpad() should SKIP Petr Machata
2024-04-15 7:46 ` Hangbin Liu
2024-04-12 17:03 ` [PATCH net-next 04/10] selftests: drivers: hw: Fix ethtool_rmon Petr Machata
2024-04-12 17:03 ` [PATCH net-next 05/10] selftests: drivers: hw: ethtool.sh: Adjust output Petr Machata
2024-04-12 17:03 ` [PATCH net-next 06/10] selftests: drivers: hw: Include tc_common.sh in hw_stats_l3 Petr Machata
2024-04-12 17:03 ` [PATCH net-next 07/10] selftests: mlxsw: ethtool_lanes: Wait for lanes parameter dump explicitly Petr Machata
2024-04-12 17:03 ` [PATCH net-next 08/10] selftests: forwarding: router_mpath_nh: Add a diagram Petr Machata
2024-04-15 8:28 ` Hangbin Liu [this message]
2024-04-15 12:39 ` David Ahern
2024-04-12 17:03 ` [PATCH net-next 09/10] selftests: forwarding: router_mpath_nh_res: " Petr Machata
2024-04-15 8:31 ` Hangbin Liu
2024-04-12 17:03 ` [PATCH net-next 10/10] selftests: forwarding: router_nh: " Petr Machata
2024-04-15 8:31 ` Hangbin Liu
2024-04-16 10:20 ` [PATCH net-next 00/10] selftests: Assortment of fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhzlS1htaCaAWGmv@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.