From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 772ABC04FFE for ; Mon, 29 Apr 2024 12:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=359x1PKhAyHtMkK/vfg2dPAMOncA3H2TWjtf6Bw1En4=; b=QV2DahfN0g6bb+wcn/I6sDp6Q3 bgSqN7WgIZd6atCD4TJ3X3BwsrQLDmHO5x5lCIiQAQiXuH4fa0wSLuJjZ9eHgXYaDuGIJC8H+jfrP w+FnqOwVKd1Bw5XbXnuOuEACfCy3zbyQXOCw0rdLYmkpO9O3Ov9igca+1ruJ5PR6oeq+qW3dUlGkD m/ZJxXEesBEW/B3RiToHg5I4w4elSH/Le9tptmxxDhylShOZHqlLtibaVLfTIC1vDL4zUAmQQyvE1 wZo5ai8Vhe1TX/r5xkExYt4oP6mcEO6nPoDLIuYVRTuv9MuciZFsHqtd6Mv9wWhCie4MVKpf6DKnS 7SG1RcZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1QLK-00000002lX2-33tE; Mon, 29 Apr 2024 12:42:50 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1QLH-00000002lWY-1yD4; Mon, 29 Apr 2024 12:42:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=359x1PKhAyHtMkK/vfg2dPAMOncA3H2TWjtf6Bw1En4=; b=vYbycYWT4MBRluDs5xVIosCe64 PoAiVqtvB/HQB7xzaPjqvvXwoJk7GZsxbrkQg4SeLfaY9e6Q/9QwK674915+AG/aqy5rAIy/fZdGI sr23cYjAxdQ2jSvbWcuxLmxJK4TFe2UqbsnOdSYc1lyJFum1Poq8h+zValqB+Op9LtF7B/0JNAj6f 1367WEZ0biSe8kNKt/WHyA7wStFD2iZ/J3Wcuas4Qr6FefpCj6t6qMZ4Stcf/KqTgZmFi8R++jHBL 6Ixq+5mv1xgFNPHDV239kY/XTgDiXBc0ymvAH4MoaBnXHuG7pLs8UiNqa8IAMiRyvBhUCalMSlGrk 4UkxbCXw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:38466) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s1QL7-0003AY-2P; Mon, 29 Apr 2024 13:42:37 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1s1QL6-0000rC-48; Mon, 29 Apr 2024 13:42:36 +0100 Date: Mon, 29 Apr 2024 13:42:35 +0100 From: "Russell King (Oracle)" To: Boy Wu =?utf-8?B?KOWQs+WLg+iqvCk=?= Cc: "linus.walleij@linaro.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "andreyknvl@gmail.com" , "dvyukov@google.com" , "kasan-dev@googlegroups.com" , Iverlin Wang =?utf-8?B?KOeOi+iLs+mclik=?= , "mark.rutland@arm.com" , Light Chen =?utf-8?B?KOmZs+aYseWFiSk=?= , "ryabinin.a.a@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "glider@google.com" , "matthias.bgg@gmail.com" , "vincenzo.frascino@arm.com" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH v2] arm: kasan: clear stale stack poison Message-ID: References: <20240410073044.23294-1-boy.wu@mediatek.com> <292f9fe4bab26028aa80f63bf160e0f2b874a17c.camel@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <292f9fe4bab26028aa80f63bf160e0f2b874a17c.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240429_054247_538316_62C19C84 X-CRM114-Status: GOOD ( 22.48 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, Apr 29, 2024 at 07:51:49AM +0000, Boy Wu (吳勃誼) wrote: > On Sun, 2024-04-28 at 15:45 +0100, Russell King (Oracle) wrote: > > On Fri, Apr 12, 2024 at 10:37:06AM +0200, Linus Walleij wrote: > > > On Wed, Apr 10, 2024 at 9:31 AM boy.wu wrote: > > > > > > > From: Boy Wu > > > > > > > > We found below OOB crash: > > > > > > Thanks for digging in! > > > > > > Pleas put this patch into Russell's patch tracker so he can apply > > it: > > > https://www.armlinux.org.uk/developer/patches/ > > > > Is this a bug fix? If so, having a Fixes: tag would be nice... > > > > This is a patch for cpuidle flow when KASAN enable, that is in ARM64 > but not in ARM, so add to ARM. > > The reference commits did not mention fix any commits. > [1] commit 0d97e6d8024c ("arm64: kasan: clear stale stack poison") > [2] commit d56a9ef84bd0 ("kasan, arm64: unpoison stack only with > CONFIG_KASAN_STACK") These are not suitable for use as a Fixes: tag because these commits refer to code in another part of the tree that has nothing to do with the BUG() dump that is contained within your commit message. I ask again... Is this a bug fix? Is it a regression? Is it something that used to work that no longer works? When did it break? Has it always been broken? Has it been broken since KASAN was introduced on 32-bit ARM? I'm not applying this commit until I get *proper* answers to these questions so that I can work out whether this needs to go in -rc or whether it waits until the next merge window... and whether it needs a Fixes: tag or not. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6320C4345F for ; Mon, 29 Apr 2024 12:43:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MAyoOQMca69j5ZqA5gLQ5ajDWbabb9LttqYMwbvEc7A=; b=eNP2xLty+N9kZs 92vEhxtfJSitcXUD+Bcyc6tGbqSS/O85I8A8Gb+j4kGidNQhm0gc5WEnalc3pEyHcYYN/e3Pw5DXa pPC2Rz1PGqnLiSx0zl4WaB6Vwc5ztDt4y348FTLuRAv9WRh1d+o4qySaOqP/pHZ5jwry0Aiz4bHzi qUYBlQTOQaBTEBpVVwoMHS2gvpXBdbZneyVcJqDsjaXea0Na0yhOW3R1SBpUn+uMLcppLno8O1A1X c2NPnQzG4J1vCcQdb8P8RvtUuPm2JvuUI3f3oqoxIB3gah56sife3LvY0VuUQux2DLE3FdgD85aUk pFGdpoo9b8e/ARmcKByg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1QLL-00000002lXA-0Tli; Mon, 29 Apr 2024 12:42:51 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1QLH-00000002lWY-1yD4; Mon, 29 Apr 2024 12:42:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=359x1PKhAyHtMkK/vfg2dPAMOncA3H2TWjtf6Bw1En4=; b=vYbycYWT4MBRluDs5xVIosCe64 PoAiVqtvB/HQB7xzaPjqvvXwoJk7GZsxbrkQg4SeLfaY9e6Q/9QwK674915+AG/aqy5rAIy/fZdGI sr23cYjAxdQ2jSvbWcuxLmxJK4TFe2UqbsnOdSYc1lyJFum1Poq8h+zValqB+Op9LtF7B/0JNAj6f 1367WEZ0biSe8kNKt/WHyA7wStFD2iZ/J3Wcuas4Qr6FefpCj6t6qMZ4Stcf/KqTgZmFi8R++jHBL 6Ixq+5mv1xgFNPHDV239kY/XTgDiXBc0ymvAH4MoaBnXHuG7pLs8UiNqa8IAMiRyvBhUCalMSlGrk 4UkxbCXw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:38466) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s1QL7-0003AY-2P; Mon, 29 Apr 2024 13:42:37 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1s1QL6-0000rC-48; Mon, 29 Apr 2024 13:42:36 +0100 Date: Mon, 29 Apr 2024 13:42:35 +0100 From: "Russell King (Oracle)" To: Boy Wu =?utf-8?B?KOWQs+WLg+iqvCk=?= Cc: "linus.walleij@linaro.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "andreyknvl@gmail.com" , "dvyukov@google.com" , "kasan-dev@googlegroups.com" , Iverlin Wang =?utf-8?B?KOeOi+iLs+mclik=?= , "mark.rutland@arm.com" , Light Chen =?utf-8?B?KOmZs+aYseWFiSk=?= , "ryabinin.a.a@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "glider@google.com" , "matthias.bgg@gmail.com" , "vincenzo.frascino@arm.com" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH v2] arm: kasan: clear stale stack poison Message-ID: References: <20240410073044.23294-1-boy.wu@mediatek.com> <292f9fe4bab26028aa80f63bf160e0f2b874a17c.camel@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <292f9fe4bab26028aa80f63bf160e0f2b874a17c.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240429_054247_538316_62C19C84 X-CRM114-Status: GOOD ( 22.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBcHIgMjksIDIwMjQgYXQgMDc6NTE6NDlBTSArMDAwMCwgQm95IFd1ICjlkLPli4Po qrwpIHdyb3RlOgo+IE9uIFN1biwgMjAyNC0wNC0yOCBhdCAxNTo0NSArMDEwMCwgUnVzc2VsbCBL aW5nIChPcmFjbGUpIHdyb3RlOgo+ID4gIE9uIEZyaSwgQXByIDEyLCAyMDI0IGF0IDEwOjM3OjA2 QU0gKzAyMDAsIExpbnVzIFdhbGxlaWogd3JvdGU6Cj4gPiA+IE9uIFdlZCwgQXByIDEwLCAyMDI0 IGF0IDk6MzHigK9BTSBib3kud3UgPGJveS53dUBtZWRpYXRlay5jb20+IHdyb3RlOgo+ID4gPiAK PiA+ID4gPiBGcm9tOiBCb3kgV3UgPGJveS53dUBtZWRpYXRlay5jb20+Cj4gPiA+ID4KPiA+ID4g PiBXZSBmb3VuZCBiZWxvdyBPT0IgY3Jhc2g6Cj4gPiA+IAo+ID4gPiBUaGFua3MgZm9yIGRpZ2dp bmcgaW4hCj4gPiA+IAo+ID4gPiBQbGVhcyBwdXQgdGhpcyBwYXRjaCBpbnRvIFJ1c3NlbGwncyBw YXRjaCB0cmFja2VyIHNvIGhlIGNhbiBhcHBseQo+ID4gaXQ6Cj4gPiA+IGh0dHBzOi8vd3d3LmFy bWxpbnV4Lm9yZy51ay9kZXZlbG9wZXIvcGF0Y2hlcy8KPiA+IAo+ID4gSXMgdGhpcyBhIGJ1ZyBm aXg/IElmIHNvLCBoYXZpbmcgYSBGaXhlczogdGFnIHdvdWxkIGJlIG5pY2UuLi4KPiA+IAo+IAo+ IFRoaXMgaXMgYSBwYXRjaCBmb3IgY3B1aWRsZSBmbG93IHdoZW4gS0FTQU4gZW5hYmxlLCB0aGF0 IGlzIGluIEFSTTY0Cj4gYnV0IG5vdCBpbiBBUk0sIHNvIGFkZCB0byBBUk0uCj4gCj4gVGhlIHJl ZmVyZW5jZSBjb21taXRzIGRpZCBub3QgbWVudGlvbiBmaXggYW55IGNvbW1pdHMuCj4gWzFdIGNv bW1pdCAwZDk3ZTZkODAyNGMgKCJhcm02NDoga2FzYW46IGNsZWFyIHN0YWxlIHN0YWNrIHBvaXNv biIpCj4gWzJdIGNvbW1pdCBkNTZhOWVmODRiZDAgKCJrYXNhbiwgYXJtNjQ6IHVucG9pc29uIHN0 YWNrIG9ubHkgd2l0aAo+IENPTkZJR19LQVNBTl9TVEFDSyIpCgpUaGVzZSBhcmUgbm90IHN1aXRh YmxlIGZvciB1c2UgYXMgYSBGaXhlczogdGFnIGJlY2F1c2UgdGhlc2UgY29tbWl0cwpyZWZlciB0 byBjb2RlIGluIGFub3RoZXIgcGFydCBvZiB0aGUgdHJlZSB0aGF0IGhhcyBub3RoaW5nIHRvIGRv IHdpdGgKdGhlIEJVRygpIGR1bXAgdGhhdCBpcyBjb250YWluZWQgd2l0aGluIHlvdXIgY29tbWl0 IG1lc3NhZ2UuCgpJIGFzayBhZ2Fpbi4uLiBJcyB0aGlzIGEgYnVnIGZpeD8KCklzIGl0IGEgcmVn cmVzc2lvbj8KCklzIGl0IHNvbWV0aGluZyB0aGF0IHVzZWQgdG8gd29yayB0aGF0IG5vIGxvbmdl ciB3b3Jrcz8KCldoZW4gZGlkIGl0IGJyZWFrPwoKSGFzIGl0IGFsd2F5cyBiZWVuIGJyb2tlbj8K CkhhcyBpdCBiZWVuIGJyb2tlbiBzaW5jZSBLQVNBTiB3YXMgaW50cm9kdWNlZCBvbiAzMi1iaXQg QVJNPwoKSSdtIG5vdCBhcHBseWluZyB0aGlzIGNvbW1pdCB1bnRpbCBJIGdldCAqcHJvcGVyKiBh bnN3ZXJzIHRvIHRoZXNlCnF1ZXN0aW9ucyBzbyB0aGF0IEkgY2FuIHdvcmsgb3V0IHdoZXRoZXIg dGhpcyBuZWVkcyB0byBnbyBpbiAtcmMKb3Igd2hldGhlciBpdCB3YWl0cyB1bnRpbCB0aGUgbmV4 dCBtZXJnZSB3aW5kb3cuLi4gYW5kIHdoZXRoZXIgaXQKbmVlZHMgYSBGaXhlczogdGFnIG9yIG5v dC4KCi0tIApSTUsncyBQYXRjaCBzeXN0ZW06IGh0dHBzOi8vd3d3LmFybWxpbnV4Lm9yZy51ay9k ZXZlbG9wZXIvcGF0Y2hlcy8KRlRUUCBpcyBoZXJlISA4ME1icHMgZG93biAxME1icHMgdXAuIERl Y2VudCBjb25uZWN0aXZpdHkgYXQgbGFzdCEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK