All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Hannes Reinecke <hare@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCHv3] nvme-tcp: strict pdu pacing to avoid send stalls on TLS
Date: Mon, 29 Apr 2024 15:09:49 +0100	[thread overview]
Message-ID: <Zi-qLa4LMvRhQFWD@kbusch-mbp.mynextlight.net> (raw)
In-Reply-To: <20240418103945.140664-1-hare@kernel.org>

On Thu, Apr 18, 2024 at 12:39:45PM +0200, Hannes Reinecke wrote:
> TLS requires a strict pdu pacing via MSG_EOR to signal the end
> of a record and subsequent encryption. If we do not set MSG_EOR
> at the end of a sequence the record won't be closed, encryption
> doesn't start, and we end up with a send stall as the message
> will never be passed on to the TCP layer.
> So do not check for the queue status when TLS is enabled but
> rather make the MSG_MORE setting dependent on the current
> request only.

Thanks, applied to nvme-6.9.


      parent reply	other threads:[~2024-04-29 14:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18 10:39 [PATCHv3] nvme-tcp: strict pdu pacing to avoid send stalls on TLS Hannes Reinecke
2024-04-18 11:01 ` Sagi Grimberg
2024-04-29 14:09 ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zi-qLa4LMvRhQFWD@kbusch-mbp.mynextlight.net \
    --to=kbusch@kernel.org \
    --cc=hare@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.