From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C86D15AAD9; Thu, 18 Apr 2024 10:21:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713435694; cv=none; b=bd7/6N5LhhhYbfab3j82Zk/0Cg/PMjHbOC+Fwb1U4CI4wf4P4Ljjyx+4zS8eOYhtJyHU5iSm1oegfZJgTQHgRp21m1dIc5L5ldKYgW6imos+OynGcy7GWLrpuzqv0J4ZklTp7E2OSB4HNjuv7miARB0nJVeIJDAdXHcXfYocrSA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713435694; c=relaxed/simple; bh=GIF39x+DoxCddvDNRomXCworfiQAca8ygUjDy3+kOkw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EgpGF4OF2T51IvROcPFCNlgkLQPpqYIMOyAm+tqk2ViNJUx0g4QjNfjeYKbVtuR3IJ9Tz0JMB9OkrYoxdBSrM8NuPf6FOq3Bgb70tS0mjlLVD3QUv9rPabXmP1+57eQhs8/ESsl9O8A0dyfT5ecgorpjUBnq8GjtUJOxoK0QYtc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SELAoNeX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SELAoNeX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDE78C113CC; Thu, 18 Apr 2024 10:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713435694; bh=GIF39x+DoxCddvDNRomXCworfiQAca8ygUjDy3+kOkw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SELAoNeXc3Beu0HbaRnXjo5QYZwKVoBtQiv3DGWKIGD1ByoQxYtKIRMmvzmqWXRIs l28WXlrgf45drPhQ9fcY+C862qqlcZ84I3lISaD2oLaKCzcGbAykPBulJ9k6bwvlRz LV8NaKjnWubu4ei2CwJbivkB4YEQEKSRsSyVzaW8Mxs5W6YReOjEi+EuEAD86bBnwS qFPhIxsVlHHsOebyI08OR68Lghu75Srbh8a5UrbpGFwRlRYkMIVyzmMjHu+Dqlrqq9 fLqc6ctyg9Ep6vn3VgTN09QBUzcZ5AVisQI/jdvTkZRhUWxPwNNaW0QWW5GqKdhOFZ JlWziN6p3qThQ== Date: Thu, 18 Apr 2024 13:20:17 +0300 From: Mike Rapoport To: Nadav Amit Cc: Linux Kernel Mailing List , Andrew Morton , Andy Lutomirski , Arnd Bergmann , Catalin Marinas , Christoph Hellwig , Helge Deller , Lorenzo Stoakes , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Palmer Dabbelt , Peter Zijlstra , Russell King , Song Liu , Steven Rostedt , Thomas Gleixner , Uladzislau Rezki , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "open list:MEMORY MANAGEMENT" , linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, the arch/x86 maintainers Subject: Re: [RFC PATCH 3/7] module: prepare to handle ROX allocations for text Message-ID: References: <20240411160526.2093408-1-rppt@kernel.org> <20240411160526.2093408-4-rppt@kernel.org> <0C4B9C1A-97DE-4798-8256-158369AF42A4@gmail.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0C4B9C1A-97DE-4798-8256-158369AF42A4@gmail.com> On Tue, Apr 16, 2024 at 12:36:08PM +0300, Nadav Amit wrote: > > > > On 11 Apr 2024, at 19:05, Mike Rapoport wrote: > > > > @@ -2440,7 +2479,24 @@ static int post_relocation(struct module *mod, const struct load_info *info) > > add_kallsyms(mod, info); > > > > /* Arch-specific module finalizing. */ > > - return module_finalize(info->hdr, info->sechdrs, mod); > > + ret = module_finalize(info->hdr, info->sechdrs, mod); > > + if (ret) > > + return ret; > > + > > + for_each_mod_mem_type(type) { > > + struct module_memory *mem = &mod->mem[type]; > > + > > + if (mem->is_rox) { > > + if (!execmem_update_copy(mem->base, mem->rw_copy, > > + mem->size)) > > + return -ENOMEM; > > + > > + vfree(mem->rw_copy); > > + mem->rw_copy = NULL; > > + } > > + } > > + > > + return 0; > > } > > I might be missing something, but it seems a bit racy. > > IIUC, module_finalize() calls alternatives_smp_module_add(). At this > point, since you don’t hold the text_mutex, some might do text_poke(), > e.g., by enabling/disabling static-key, and the update would be > overwritten. No? Right :( Even worse, for UP case alternatives_smp_unlock() will "patch" still empty area. So I'm thinking about calling alternatives_smp_module_add() from an additional callback after the execmem_update_copy(). Does it make sense to you? -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C912C4345F for ; Thu, 18 Apr 2024 10:21:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u3Y5e4nU5UXHJxP2vw2Ibp2/jpVa/NW8HM5b02lIHlA=; b=aGM+MYv37EhAmd Z0pk7TTF29/f9eq85VD7uSpma4dorES/PB/c3Az5Px8QU51Y8EzBHy99On3za9UOAtWpEWbewiaeh Bb/yuUW0C6zXVURHHSzCxOJPwNaTFmrQN75DXH9AOpIcOs20TodwQkcGRu2e2Y6716DsqvRnEMEO8 1VbEOt2w5rsvM/lLbQd1mE55q3Z2nhLrXjhgtAZ4Blc1JlaYNouxZGVJ4N4LffNEdDY4Jhj2hK+6C WzVzLaJ5rHuP4KeqRueToRpaP0Gg6WpT6KbyYqSEjuz404O6N9VxQJFL4waxnkZbHwV/zg4Jhw85E ZsjZgNffzTQJRGYReYCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxOtg-00000001mDg-0yCl; Thu, 18 Apr 2024 10:21:40 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxOtb-00000001mB5-2fwJ; Thu, 18 Apr 2024 10:21:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7E10D617AF; Thu, 18 Apr 2024 10:21:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDE78C113CC; Thu, 18 Apr 2024 10:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713435694; bh=GIF39x+DoxCddvDNRomXCworfiQAca8ygUjDy3+kOkw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SELAoNeXc3Beu0HbaRnXjo5QYZwKVoBtQiv3DGWKIGD1ByoQxYtKIRMmvzmqWXRIs l28WXlrgf45drPhQ9fcY+C862qqlcZ84I3lISaD2oLaKCzcGbAykPBulJ9k6bwvlRz LV8NaKjnWubu4ei2CwJbivkB4YEQEKSRsSyVzaW8Mxs5W6YReOjEi+EuEAD86bBnwS qFPhIxsVlHHsOebyI08OR68Lghu75Srbh8a5UrbpGFwRlRYkMIVyzmMjHu+Dqlrqq9 fLqc6ctyg9Ep6vn3VgTN09QBUzcZ5AVisQI/jdvTkZRhUWxPwNNaW0QWW5GqKdhOFZ JlWziN6p3qThQ== Date: Thu, 18 Apr 2024 13:20:17 +0300 From: Mike Rapoport To: Nadav Amit Cc: Linux Kernel Mailing List , Andrew Morton , Andy Lutomirski , Arnd Bergmann , Catalin Marinas , Christoph Hellwig , Helge Deller , Lorenzo Stoakes , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Palmer Dabbelt , Peter Zijlstra , Russell King , Song Liu , Steven Rostedt , Thomas Gleixner , Uladzislau Rezki , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "open list:MEMORY MANAGEMENT" , linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, the arch/x86 maintainers Subject: Re: [RFC PATCH 3/7] module: prepare to handle ROX allocations for text Message-ID: References: <20240411160526.2093408-1-rppt@kernel.org> <20240411160526.2093408-4-rppt@kernel.org> <0C4B9C1A-97DE-4798-8256-158369AF42A4@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0C4B9C1A-97DE-4798-8256-158369AF42A4@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240418_032135_774272_8EC35C40 X-CRM114-Status: GOOD ( 18.27 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBcHIgMTYsIDIwMjQgYXQgMTI6MzY6MDhQTSArMDMwMCwgTmFkYXYgQW1pdCB3cm90 ZToKPiAKPiAKPiA+IE9uIDExIEFwciAyMDI0LCBhdCAxOTowNSwgTWlrZSBSYXBvcG9ydCA8cnBw dEBrZXJuZWwub3JnPiB3cm90ZToKPiA+IAo+ID4gQEAgLTI0NDAsNyArMjQ3OSwyNCBAQCBzdGF0 aWMgaW50IHBvc3RfcmVsb2NhdGlvbihzdHJ1Y3QgbW9kdWxlICptb2QsIGNvbnN0IHN0cnVjdCBs b2FkX2luZm8gKmluZm8pCj4gPiAJYWRkX2thbGxzeW1zKG1vZCwgaW5mbyk7Cj4gPiAKPiA+IAkv KiBBcmNoLXNwZWNpZmljIG1vZHVsZSBmaW5hbGl6aW5nLiAqLwo+ID4gLQlyZXR1cm4gbW9kdWxl X2ZpbmFsaXplKGluZm8tPmhkciwgaW5mby0+c2VjaGRycywgbW9kKTsKPiA+ICsJcmV0ID0gbW9k dWxlX2ZpbmFsaXplKGluZm8tPmhkciwgaW5mby0+c2VjaGRycywgbW9kKTsKPiA+ICsJaWYgKHJl dCkKPiA+ICsJCXJldHVybiByZXQ7Cj4gPiArCj4gPiArCWZvcl9lYWNoX21vZF9tZW1fdHlwZSh0 eXBlKSB7Cj4gPiArCQlzdHJ1Y3QgbW9kdWxlX21lbW9yeSAqbWVtID0gJm1vZC0+bWVtW3R5cGVd Owo+ID4gKwo+ID4gKwkJaWYgKG1lbS0+aXNfcm94KSB7Cj4gPiArCQkJaWYgKCFleGVjbWVtX3Vw ZGF0ZV9jb3B5KG1lbS0+YmFzZSwgbWVtLT5yd19jb3B5LAo+ID4gKwkJCQkJCSBtZW0tPnNpemUp KQo+ID4gKwkJCQlyZXR1cm4gLUVOT01FTTsKPiA+ICsKPiA+ICsJCQl2ZnJlZShtZW0tPnJ3X2Nv cHkpOwo+ID4gKwkJCW1lbS0+cndfY29weSA9IE5VTEw7Cj4gPiArCQl9Cj4gPiArCX0KPiA+ICsK PiA+ICsJcmV0dXJuIDA7Cj4gPiB9Cj4gCj4gSSBtaWdodCBiZSBtaXNzaW5nIHNvbWV0aGluZywg YnV0IGl0IHNlZW1zIGEgYml0IHJhY3kuCj4gCj4gSUlVQywgbW9kdWxlX2ZpbmFsaXplKCkgY2Fs bHMgYWx0ZXJuYXRpdmVzX3NtcF9tb2R1bGVfYWRkKCkuIEF0IHRoaXMKPiBwb2ludCwgc2luY2Ug eW91IGRvbuKAmXQgaG9sZCB0aGUgdGV4dF9tdXRleCwgc29tZSBtaWdodCBkbyB0ZXh0X3Bva2Uo KSwKPiBlLmcuLCBieSBlbmFibGluZy9kaXNhYmxpbmcgc3RhdGljLWtleSwgYW5kIHRoZSB1cGRh dGUgd291bGQgYmUKPiBvdmVyd3JpdHRlbi4gTm8/CgpSaWdodCA6KApFdmVuIHdvcnNlLCBmb3Ig VVAgY2FzZSBhbHRlcm5hdGl2ZXNfc21wX3VubG9jaygpIHdpbGwgInBhdGNoIiBzdGlsbCBlbXB0 eQphcmVhLgoKU28gSSdtIHRoaW5raW5nIGFib3V0IGNhbGxpbmcgYWx0ZXJuYXRpdmVzX3NtcF9t b2R1bGVfYWRkKCkgZnJvbSBhbgphZGRpdGlvbmFsIGNhbGxiYWNrIGFmdGVyIHRoZSBleGVjbWVt X3VwZGF0ZV9jb3B5KCkuCgpEb2VzIGl0IG1ha2Ugc2Vuc2UgdG8geW91PwoKLS0gClNpbmNlcmVs eSB5b3VycywKTWlrZS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt cmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A71AC04FF8 for ; Thu, 18 Apr 2024 10:22:19 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=SELAoNeX; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VKv3G0WC2z3dH4 for ; Thu, 18 Apr 2024 20:22:18 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=SELAoNeX; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=rppt@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VKv2S71Nfz3bnL for ; Thu, 18 Apr 2024 20:21:36 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7E10D617AF; Thu, 18 Apr 2024 10:21:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDE78C113CC; Thu, 18 Apr 2024 10:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713435694; bh=GIF39x+DoxCddvDNRomXCworfiQAca8ygUjDy3+kOkw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SELAoNeXc3Beu0HbaRnXjo5QYZwKVoBtQiv3DGWKIGD1ByoQxYtKIRMmvzmqWXRIs l28WXlrgf45drPhQ9fcY+C862qqlcZ84I3lISaD2oLaKCzcGbAykPBulJ9k6bwvlRz LV8NaKjnWubu4ei2CwJbivkB4YEQEKSRsSyVzaW8Mxs5W6YReOjEi+EuEAD86bBnwS qFPhIxsVlHHsOebyI08OR68Lghu75Srbh8a5UrbpGFwRlRYkMIVyzmMjHu+Dqlrqq9 fLqc6ctyg9Ep6vn3VgTN09QBUzcZ5AVisQI/jdvTkZRhUWxPwNNaW0QWW5GqKdhOFZ JlWziN6p3qThQ== Date: Thu, 18 Apr 2024 13:20:17 +0300 From: Mike Rapoport To: Nadav Amit Subject: Re: [RFC PATCH 3/7] module: prepare to handle ROX allocations for text Message-ID: References: <20240411160526.2093408-1-rppt@kernel.org> <20240411160526.2093408-4-rppt@kernel.org> <0C4B9C1A-97DE-4798-8256-158369AF42A4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0C4B9C1A-97DE-4798-8256-158369AF42A4@gmail.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Zijlstra , Catalin Marinas , Song Liu , linux-riscv@lists.infradead.org, Will Deacon , linux-arch@vger.kernel.org, Helge Deller , the arch/x86 maintainers , Russell King , Christoph Hellwig , linux-trace-kernel@vger.kernel.org, Arnd Bergmann , Steven Rostedt , Mathieu Desnoyers , Andy Lutomirski , Thomas Gleixner , Andrew Morton , linux-arm-kernel@lists.infradead.org, Lorenzo Stoakes , linux-parisc@vger.kernel.org, "open list:MEMORY MANAGEMENT" , Linux Kernel Mailing List , Luis Chamberlain , Uladzislau Rezki , Palmer Dabbelt , Masa mi Hiramatsu , bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-modules@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Apr 16, 2024 at 12:36:08PM +0300, Nadav Amit wrote: > > > > On 11 Apr 2024, at 19:05, Mike Rapoport wrote: > > > > @@ -2440,7 +2479,24 @@ static int post_relocation(struct module *mod, const struct load_info *info) > > add_kallsyms(mod, info); > > > > /* Arch-specific module finalizing. */ > > - return module_finalize(info->hdr, info->sechdrs, mod); > > + ret = module_finalize(info->hdr, info->sechdrs, mod); > > + if (ret) > > + return ret; > > + > > + for_each_mod_mem_type(type) { > > + struct module_memory *mem = &mod->mem[type]; > > + > > + if (mem->is_rox) { > > + if (!execmem_update_copy(mem->base, mem->rw_copy, > > + mem->size)) > > + return -ENOMEM; > > + > > + vfree(mem->rw_copy); > > + mem->rw_copy = NULL; > > + } > > + } > > + > > + return 0; > > } > > I might be missing something, but it seems a bit racy. > > IIUC, module_finalize() calls alternatives_smp_module_add(). At this > point, since you don’t hold the text_mutex, some might do text_poke(), > e.g., by enabling/disabling static-key, and the update would be > overwritten. No? Right :( Even worse, for UP case alternatives_smp_unlock() will "patch" still empty area. So I'm thinking about calling alternatives_smp_module_add() from an additional callback after the execmem_update_copy(). Does it make sense to you? -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FB1FC4345F for ; Thu, 18 Apr 2024 10:21:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w4YfLAKMFLmNczJz+62PtmhMpmxvPlaV4J+pHCAXXb8=; b=EaBFs63aYdTrNQ /SeYHSXYfEEmV8Jyb8rRyI8KhxcIQJhi/TuXlGLMOty0m1kcnONrA1q74brup7OFwRDkKhdmlge6l CMlLOx9Lb9azCNor2XKw2wfFxz92U2Eg/pPGbMtteSU3JPDoXMwNIbElCrYGDSk+YEVqqUxI26xnT NPvOA8B6SiXWcmljzdQ5CILsL4IBsJ1i8F+FXjN9bOTjtPrsX4fmwDyJAWAgd1pFANOw5Y0Kq5UZ8 2Up51mh3+k2WLk8bPMvLn1Hxz/hu43LUyly8FbH3PQcUBgrX42f8JoixVlpnL19msiWzbkGeacVCe SFc0Igu4Dr4L0rucGqCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxOtf-00000001mD9-0dDG; Thu, 18 Apr 2024 10:21:39 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxOtb-00000001mB5-2fwJ; Thu, 18 Apr 2024 10:21:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7E10D617AF; Thu, 18 Apr 2024 10:21:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDE78C113CC; Thu, 18 Apr 2024 10:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713435694; bh=GIF39x+DoxCddvDNRomXCworfiQAca8ygUjDy3+kOkw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SELAoNeXc3Beu0HbaRnXjo5QYZwKVoBtQiv3DGWKIGD1ByoQxYtKIRMmvzmqWXRIs l28WXlrgf45drPhQ9fcY+C862qqlcZ84I3lISaD2oLaKCzcGbAykPBulJ9k6bwvlRz LV8NaKjnWubu4ei2CwJbivkB4YEQEKSRsSyVzaW8Mxs5W6YReOjEi+EuEAD86bBnwS qFPhIxsVlHHsOebyI08OR68Lghu75Srbh8a5UrbpGFwRlRYkMIVyzmMjHu+Dqlrqq9 fLqc6ctyg9Ep6vn3VgTN09QBUzcZ5AVisQI/jdvTkZRhUWxPwNNaW0QWW5GqKdhOFZ JlWziN6p3qThQ== Date: Thu, 18 Apr 2024 13:20:17 +0300 From: Mike Rapoport To: Nadav Amit Cc: Linux Kernel Mailing List , Andrew Morton , Andy Lutomirski , Arnd Bergmann , Catalin Marinas , Christoph Hellwig , Helge Deller , Lorenzo Stoakes , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Palmer Dabbelt , Peter Zijlstra , Russell King , Song Liu , Steven Rostedt , Thomas Gleixner , Uladzislau Rezki , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "open list:MEMORY MANAGEMENT" , linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, the arch/x86 maintainers Subject: Re: [RFC PATCH 3/7] module: prepare to handle ROX allocations for text Message-ID: References: <20240411160526.2093408-1-rppt@kernel.org> <20240411160526.2093408-4-rppt@kernel.org> <0C4B9C1A-97DE-4798-8256-158369AF42A4@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0C4B9C1A-97DE-4798-8256-158369AF42A4@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240418_032135_774272_8EC35C40 X-CRM114-Status: GOOD ( 18.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBcHIgMTYsIDIwMjQgYXQgMTI6MzY6MDhQTSArMDMwMCwgTmFkYXYgQW1pdCB3cm90 ZToKPiAKPiAKPiA+IE9uIDExIEFwciAyMDI0LCBhdCAxOTowNSwgTWlrZSBSYXBvcG9ydCA8cnBw dEBrZXJuZWwub3JnPiB3cm90ZToKPiA+IAo+ID4gQEAgLTI0NDAsNyArMjQ3OSwyNCBAQCBzdGF0 aWMgaW50IHBvc3RfcmVsb2NhdGlvbihzdHJ1Y3QgbW9kdWxlICptb2QsIGNvbnN0IHN0cnVjdCBs b2FkX2luZm8gKmluZm8pCj4gPiAJYWRkX2thbGxzeW1zKG1vZCwgaW5mbyk7Cj4gPiAKPiA+IAkv KiBBcmNoLXNwZWNpZmljIG1vZHVsZSBmaW5hbGl6aW5nLiAqLwo+ID4gLQlyZXR1cm4gbW9kdWxl X2ZpbmFsaXplKGluZm8tPmhkciwgaW5mby0+c2VjaGRycywgbW9kKTsKPiA+ICsJcmV0ID0gbW9k dWxlX2ZpbmFsaXplKGluZm8tPmhkciwgaW5mby0+c2VjaGRycywgbW9kKTsKPiA+ICsJaWYgKHJl dCkKPiA+ICsJCXJldHVybiByZXQ7Cj4gPiArCj4gPiArCWZvcl9lYWNoX21vZF9tZW1fdHlwZSh0 eXBlKSB7Cj4gPiArCQlzdHJ1Y3QgbW9kdWxlX21lbW9yeSAqbWVtID0gJm1vZC0+bWVtW3R5cGVd Owo+ID4gKwo+ID4gKwkJaWYgKG1lbS0+aXNfcm94KSB7Cj4gPiArCQkJaWYgKCFleGVjbWVtX3Vw ZGF0ZV9jb3B5KG1lbS0+YmFzZSwgbWVtLT5yd19jb3B5LAo+ID4gKwkJCQkJCSBtZW0tPnNpemUp KQo+ID4gKwkJCQlyZXR1cm4gLUVOT01FTTsKPiA+ICsKPiA+ICsJCQl2ZnJlZShtZW0tPnJ3X2Nv cHkpOwo+ID4gKwkJCW1lbS0+cndfY29weSA9IE5VTEw7Cj4gPiArCQl9Cj4gPiArCX0KPiA+ICsK PiA+ICsJcmV0dXJuIDA7Cj4gPiB9Cj4gCj4gSSBtaWdodCBiZSBtaXNzaW5nIHNvbWV0aGluZywg YnV0IGl0IHNlZW1zIGEgYml0IHJhY3kuCj4gCj4gSUlVQywgbW9kdWxlX2ZpbmFsaXplKCkgY2Fs bHMgYWx0ZXJuYXRpdmVzX3NtcF9tb2R1bGVfYWRkKCkuIEF0IHRoaXMKPiBwb2ludCwgc2luY2Ug eW91IGRvbuKAmXQgaG9sZCB0aGUgdGV4dF9tdXRleCwgc29tZSBtaWdodCBkbyB0ZXh0X3Bva2Uo KSwKPiBlLmcuLCBieSBlbmFibGluZy9kaXNhYmxpbmcgc3RhdGljLWtleSwgYW5kIHRoZSB1cGRh dGUgd291bGQgYmUKPiBvdmVyd3JpdHRlbi4gTm8/CgpSaWdodCA6KApFdmVuIHdvcnNlLCBmb3Ig VVAgY2FzZSBhbHRlcm5hdGl2ZXNfc21wX3VubG9jaygpIHdpbGwgInBhdGNoIiBzdGlsbCBlbXB0 eQphcmVhLgoKU28gSSdtIHRoaW5raW5nIGFib3V0IGNhbGxpbmcgYWx0ZXJuYXRpdmVzX3NtcF9t b2R1bGVfYWRkKCkgZnJvbSBhbgphZGRpdGlvbmFsIGNhbGxiYWNrIGFmdGVyIHRoZSBleGVjbWVt X3VwZGF0ZV9jb3B5KCkuCgpEb2VzIGl0IG1ha2Ugc2Vuc2UgdG8geW91PwoKLS0gClNpbmNlcmVs eSB5b3VycywKTWlrZS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK