From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DF67C4345F for ; Thu, 18 Apr 2024 12:04:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 605614012F; Thu, 18 Apr 2024 12:04:38 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id d1Z4UGiNDsvf; Thu, 18 Apr 2024 12:04:34 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 7847B40523 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1713441874; bh=37f3ccn//ByTUoAR5JHG4cni1pFUTiZHTlyJI9lNZHw=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Cf6GAf8Ejpmoab6GJKMeum7RohX089EQKlecKaWn2aM8Va4bCAZpZfBPsG2Pwk4ed s+rt6YqusG4BYIWBoxVcis05icMapQDGx1Nt+ggglJ6970LO0o+sTsjOaeN/VdhWi9 plUZOmuRaIWK8jn237KrTATlXJwyqcFpoODoAdEC8JCLOIHEHtTNHNWK1fsQxt9LhL o8AjMp5gi6uYRMFPPWcYEmygBIiONVz59uwtkogdFm1jrreiv0FyQ4UEvqyzD43R7i XbBIn5K3huFfAF2/AECF4KOxYQreaFHH3yF7V4ayyFsAiKwltGPs41D9dXwoNR+wmC v2U7FHA6BXEeQ== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 7847B40523; Thu, 18 Apr 2024 12:04:34 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 9F3F81BF373 for ; Thu, 18 Apr 2024 12:04:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 97230402C4 for ; Thu, 18 Apr 2024 12:04:32 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 4HjPE5auszZ0 for ; Thu, 18 Apr 2024 12:04:27 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::629; helo=mail-ej1-x629.google.com; envelope-from=jiri@resnulli.us; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org DB301402BC DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org DB301402BC Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by smtp4.osuosl.org (Postfix) with ESMTPS id DB301402BC for ; Thu, 18 Apr 2024 12:04:24 +0000 (UTC) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a51f9ad7684so40128066b.2 for ; Thu, 18 Apr 2024 05:04:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713441863; x=1714046663; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=37f3ccn//ByTUoAR5JHG4cni1pFUTiZHTlyJI9lNZHw=; b=cWpeqtYEYwOK9uJiOx4H5rVMZfj+Gf/tYgc7O5YXnfve5D0VaXnsJ4GNTQQ+ll4jR6 DaH4sqx61Pwl0rC2/xzSnGkYv//1xPp/yIkfRz0X7eKpSBZly9s6hYBf2eijx/ectkte 3mA1u2jfQyB05x6uPESzADuPct9o9q31orkx42VwwABMiJxZpZKKKFmnMLM1677nA+iy aNvVrBiSgvyB2190Mjys5uKDwQWDBocIxMGdOd6mQUngbXYyOV3mq0jxMz9IX3bpnNyC YRuKw5bNHzn4KXqCRAKD7UmjoQ0egmRk7eU7PBxATA08XUsn7ydZBbuu3LFcfuXX1b35 0DdA== X-Gm-Message-State: AOJu0YxNdoUS4l5h6/ZZgo8VDY5wPTj1wbH9Y+PLCp3rPD8IoKVZghLK mdD43RVf6MUX8+bNE2QxQ85snONCKvNnaZPIZG3JwEZhgLRnk/3tgU+Cmywsyq8= X-Google-Smtp-Source: AGHT+IH7SHBw7rC7zllH17bUzX7FhKAwi9y3jf1g1iOqWa0GZ7feR7s5nEWChL+Fwranei5nHBwbRg== X-Received: by 2002:a50:cdc1:0:b0:56b:986b:b4e7 with SMTP id h1-20020a50cdc1000000b0056b986bb4e7mr2035401edj.27.1713441862964; Thu, 18 Apr 2024 05:04:22 -0700 (PDT) Received: from localhost (78-80-105-131.customers.tmcz.cz. [78.80.105.131]) by smtp.gmail.com with ESMTPSA id s12-20020aa7c54c000000b0057025ea16f2sm790411edr.39.2024.04.18.05.04.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 05:04:22 -0700 (PDT) Date: Thu, 18 Apr 2024 14:04:21 +0200 From: Jiri Pirko To: Michal Swiatkowski Message-ID: References: <20240417142028.2171-1-michal.swiatkowski@linux.intel.com> <20240417142028.2171-6-michal.swiatkowski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240417142028.2171-6-michal.swiatkowski@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1713441863; x=1714046663; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=37f3ccn//ByTUoAR5JHG4cni1pFUTiZHTlyJI9lNZHw=; b=j3daUWZf2YgLIVLp8EY7aKQGTwbWF2W1ijpcOCtMvM8cdiX8g5GmgcrdG4/qDbhiLn lrsVsOaBE37mJSd8SliXLVyNIDE8b2ULhOPta5kt74Mj0qrmIbv0dRIeKMWYOm691Mm1 QBK82kEnV9IDXGKKrvkBf7nHxt0i/WqbcMSBXJlbyk/OaHYV9iIvq6AyFw0WRpn59g55 Y4vjby9f4Ccc3qrSBsixvUPScya3HB/l0M4xOy2XMwkGSjsVPrgStwGZmYlAVGc80b/v 6dhBqu7hCqcnv2iQazWkR5ke5vBmY6fixEYrVl7Dm1A5xTqNxt5NIuiaMJJoGQ7JYA2O 8LJg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=none (p=none dis=none) header.from=resnulli.us X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=j3daUWZf Subject: Re: [Intel-wired-lan] [iwl-next v4 5/8] ice: allocate devlink for subfunction X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: maciej.fijalkowski@intel.com, mateusz.polchlopek@intel.com, netdev@vger.kernel.org, jiri@nvidia.com, michal.kubiak@intel.com, intel-wired-lan@lists.osuosl.org, pio.raczynski@gmail.com, sridhar.samudrala@intel.com, jacob.e.keller@intel.com, wojciech.drewek@intel.com, przemyslaw.kitszel@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Wed, Apr 17, 2024 at 04:20:25PM CEST, michal.swiatkowski@linux.intel.com wrote: >From: Piotr Raczynski [...] >+/** >+ * ice_allocate_sf - Allocate devlink and return SF structure pointer >+ * @dev: the device to allocate for >+ * >+ * Allocate a devlink instance for SF. >+ * >+ * Return: void pointer to allocated memory >+ */ >+struct ice_sf_priv *ice_allocate_sf(struct device *dev) This is devlink instance for SF auxdev. Please make sure it is properly linked with the devlink port instance using devl_port_fn_devlink_set() See mlx5 implementation for inspiration. >+{ >+ return ice_devlink_alloc(dev, sizeof(struct ice_sf_priv), >+ &ice_sf_devlink_ops); >+} >+ [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B988A15AAAD for ; Thu, 18 Apr 2024 12:04:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713441868; cv=none; b=KfVHwshF5luyaevyLgbeeP9VF5MFYC0uiWVg5Ms9mlf6e+uLNvQZEKhZh4K7lXjS5SsjDwNZp/lgSnNTDAUe0R6bXXFdqwKU4wHtAjDhPl+8PCIsb0rDiCWv7ACWThO6/CxhJtJUrdFCK805k2w7XAXn9sSvppfsOq12ZAMqhy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713441868; c=relaxed/simple; bh=NSPObthoUmWtROw3vEjSYKn7j4ROgyyvv74mVjGyD/0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DmDUuYUeBtor3OMkADH7bM8UIdffLjNQ+xuiEDtdBHjWqizRQbC+G0OKUpMZULTnL4UpREyheOf3hP6Z/Xo5DFqAv3xZgyJbDYzTBsQwYWB7dG1Ut4GQa4F8BfS/xIYhMj3ZkKllMM2oqakNQLd82NTSwxZ/fnC/jlHFXaac+8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=ThsJEsHB; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="ThsJEsHB" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-56e4a148aeeso330997a12.2 for ; Thu, 18 Apr 2024 05:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1713441863; x=1714046663; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=37f3ccn//ByTUoAR5JHG4cni1pFUTiZHTlyJI9lNZHw=; b=ThsJEsHByxVy/qHY75hWmjqUvyKtpOI73bsVC3aGtxJiL5H6itVNCtCqNHml6jdCBz N/3O7dvAr832t2wXJGw9HQQ7v1cCKfNxvT9VrWHBlUKRv8bwFsSgiX4LurUnGH/4WWrY 1GIsO2dNkLDHyxw2tBJ0qozV7LQCFDXmxXds+TD3BYMQ37T5Yr+S6aD41k8o/4KCGR12 1TgdjhF1aV/RcGOKmLTRvZ7vKK14XBfp5njavRiZ5q8ix3mp7Rk/sycCj2wRRgUgLrTX iz6XY/j0Dx5HoxBzcuFx8pkkRj7MFKoXpxxRrjOT2d/dbcV9eVL/+nlLYTpkGkfVuBXq UHZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713441863; x=1714046663; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=37f3ccn//ByTUoAR5JHG4cni1pFUTiZHTlyJI9lNZHw=; b=ENxaDg9E/NO8z/zTN2INxJE6XP/SvxTaBClEw6dgKLx/OP2XzWI5IawDByDw7/r+y7 RXaFEzUwnfq2Jvj7d7YeTlOQu+d5YNKmEif8WDRxitFxDlgnN0PJREtqmtj9psLx7lnH pQzeVdcWFctSN85uO9nmCj7EhjtAzBoh/+QXBVfZ6s8/kWA3SoC4ucYGijf4twX18nal XhyPJ5Ejo7OEqx48GUdTTI31h3Yo4V0EV1XjuRWjutRv9xLqt6TQ/W7rGK/UIxtzmXVD ourmksJEc87mkx/GeFNTaUv8jru7rBTDbH3X/gfsYjfnVISBwSc4m92RLcA7Kyx3/zxK VL5Q== X-Forwarded-Encrypted: i=1; AJvYcCVAGDrrSvIKgrX6/dFLp3FccRIv+5AsuUZAnjh6XmVvAbPRMe1VPyXWA4O6v3csBzrRx363yIvhBCmWh+yLSjnjmi4laNof X-Gm-Message-State: AOJu0Ywrl+PqHEQxz1gfcWJJJwdCotGOPtURgfHpv2Ci4eRm/HhSadii 2/lLjFRfq+nVj6ChIcMxkfHHWnclzE8k90JdvnoMPo57d/y3cdTk1I2cVwJbbzA= X-Google-Smtp-Source: AGHT+IH7SHBw7rC7zllH17bUzX7FhKAwi9y3jf1g1iOqWa0GZ7feR7s5nEWChL+Fwranei5nHBwbRg== X-Received: by 2002:a50:cdc1:0:b0:56b:986b:b4e7 with SMTP id h1-20020a50cdc1000000b0056b986bb4e7mr2035401edj.27.1713441862964; Thu, 18 Apr 2024 05:04:22 -0700 (PDT) Received: from localhost (78-80-105-131.customers.tmcz.cz. [78.80.105.131]) by smtp.gmail.com with ESMTPSA id s12-20020aa7c54c000000b0057025ea16f2sm790411edr.39.2024.04.18.05.04.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 05:04:22 -0700 (PDT) Date: Thu, 18 Apr 2024 14:04:21 +0200 From: Jiri Pirko To: Michal Swiatkowski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, jacob.e.keller@intel.com, michal.kubiak@intel.com, maciej.fijalkowski@intel.com, sridhar.samudrala@intel.com, przemyslaw.kitszel@intel.com, wojciech.drewek@intel.com, pio.raczynski@gmail.com, jiri@nvidia.com, mateusz.polchlopek@intel.com Subject: Re: [iwl-next v4 5/8] ice: allocate devlink for subfunction Message-ID: References: <20240417142028.2171-1-michal.swiatkowski@linux.intel.com> <20240417142028.2171-6-michal.swiatkowski@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240417142028.2171-6-michal.swiatkowski@linux.intel.com> Wed, Apr 17, 2024 at 04:20:25PM CEST, michal.swiatkowski@linux.intel.com wrote: >From: Piotr Raczynski [...] >+/** >+ * ice_allocate_sf - Allocate devlink and return SF structure pointer >+ * @dev: the device to allocate for >+ * >+ * Allocate a devlink instance for SF. >+ * >+ * Return: void pointer to allocated memory >+ */ >+struct ice_sf_priv *ice_allocate_sf(struct device *dev) This is devlink instance for SF auxdev. Please make sure it is properly linked with the devlink port instance using devl_port_fn_devlink_set() See mlx5 implementation for inspiration. >+{ >+ return ice_devlink_alloc(dev, sizeof(struct ice_sf_priv), >+ &ice_sf_devlink_ops); >+} >+ [...]