From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BB3FC4345F for ; Thu, 18 Apr 2024 13:02:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 4BCE040512; Thu, 18 Apr 2024 13:02:41 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id TFsg8I-MEnhe; Thu, 18 Apr 2024 13:02:36 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org C1AE140542 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1713445356; bh=SSEbkJW70zZ5sfWUXf2fhvkwK3iAvAImkQZWLi4d0MA=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=69NtkHoYIZHBsoroDRoksJxArgj04aHKawBTCO0DJeCypnqigCf+iWGQ21faoKJ6w twD25lOyKqkDo9qLnYKVqb90RPvYS6RgtkEf1mzeVoqSRKA2jRzGN1zwP36F49Vvs1 cm0Lbse1dSkKnd/B33gpRAStrCo8D99Kk9JsUrRHgpqpmuKFZLORyW/3WoSf/Y2by0 92p0TQ1e+Vv/gOkFiJsi7wurhYEX+enD8FoqGp/8JP1Nf3bDTlozmILvHRqUhG+l7x uT25bbLL6gfwUFaEIXpR2I7Cg61BxYZ7g59xPp8OxpIrqAiuJTe3aMNle7bdxcv7A5 QqeMGlfwGd7bw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id C1AE140542; Thu, 18 Apr 2024 13:02:36 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id BC5111BF373 for ; Thu, 18 Apr 2024 13:02:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A3EF660905 for ; Thu, 18 Apr 2024 13:02:35 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id N_0FHadL3Oxq for ; Thu, 18 Apr 2024 13:02:30 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::434; helo=mail-wr1-x434.google.com; envelope-from=jiri@resnulli.us; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 1C4A66062E DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1C4A66062E Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by smtp3.osuosl.org (Postfix) with ESMTPS id 1C4A66062E for ; Thu, 18 Apr 2024 13:02:27 +0000 (UTC) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-343b92e54f5so630279f8f.0 for ; Thu, 18 Apr 2024 06:02:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713445346; x=1714050146; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SSEbkJW70zZ5sfWUXf2fhvkwK3iAvAImkQZWLi4d0MA=; b=I4T8WI1oO5vdoqQLHOkyrebnE4MTWtkdHggUSZSXWDXFQz98z4b46UXPRz40qJgWGH /sMbebRKLfiL7QhGeMIZbMLenrteiFPT3lcyMe5lYwyLbByZ2d4tLBNC4RyPb1D9XDuk /tZ7Q1B1wVkM4Pp8oGpOj/yolS43680HSZDJ9GWhjnsjlR1xYTDePQ3YbNT6UenXsbG9 yeZArI7zZuVmpYa+Q+CSXU+rK7irTXsmyj2EFr5MEBzeFlJme3zu3af+4m25YmYNMwdS 9fmzCPYAhkrJ1Lry7ruYmvBLV5rPiVPww1zxAok1hgDclCQhEQyG1ZOQA3Ebh/O8aAqV o52Q== X-Gm-Message-State: AOJu0YwtlDXBGYBlAMsHQr4OnkATN/yTd0uZaQ404DuAmv44bGqBIkSS rxbqYGu9QnujRbZDP1uRpJUhN8keB+3MwlzcW/4Lv97Xisc64TSm8FqVLI1FGR4= X-Google-Smtp-Source: AGHT+IEfMG36kM24Iof7e34MrpQEhFq9W2iWI9PjZtvx7h35noSdT2wLL+gDJZ9fjBh5ZhYFG0//zg== X-Received: by 2002:a5d:558e:0:b0:33e:5fb4:49d1 with SMTP id i14-20020a5d558e000000b0033e5fb449d1mr1565460wrv.44.1713445345962; Thu, 18 Apr 2024 06:02:25 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id a12-20020a056000100c00b00349ceadededsm1805262wrx.16.2024.04.18.06.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 06:02:25 -0700 (PDT) Date: Thu, 18 Apr 2024 15:02:21 +0200 From: Jiri Pirko To: Michal Swiatkowski Message-ID: References: <20240417142028.2171-1-michal.swiatkowski@linux.intel.com> <20240417142028.2171-7-michal.swiatkowski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240417142028.2171-7-michal.swiatkowski@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1713445346; x=1714050146; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SSEbkJW70zZ5sfWUXf2fhvkwK3iAvAImkQZWLi4d0MA=; b=h1gLrICY9xxUTG4nvl8EjWmELU1I+F90TRxpIH0olVBpcrWiwCC2plq83LbJeIlb0n DxTvp2rApCdp9fve2eM69WBwdhQ+fofignFs8NvWLejR1ReD3K0EL2xZAl4Jzz576G1d LrrAin+clL/CmjgwX1cIHXYPhecK0dnMpcaxlnTFnOGJ744RevVgIYhA7iE7VCYutXFz /x4erniacbfjWMvJLmOG9nbKYGAQ4UyjoB9IuTl7Vi1qdFBEcX6r8mKc0hQI/XySb2E8 xOJL7e3tTfgq4wvjJUSTelPyPjL6tXdTzNcECe2yUxNZ1sjszKE6HJLlqKhu6FIOonlo 9nlw== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=none (p=none dis=none) header.from=resnulli.us X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=h1gLrICY Subject: Re: [Intel-wired-lan] [iwl-next v4 6/8] ice: base subfunction aux driver X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: maciej.fijalkowski@intel.com, mateusz.polchlopek@intel.com, netdev@vger.kernel.org, jiri@nvidia.com, michal.kubiak@intel.com, intel-wired-lan@lists.osuosl.org, pio.raczynski@gmail.com, sridhar.samudrala@intel.com, jacob.e.keller@intel.com, wojciech.drewek@intel.com, przemyslaw.kitszel@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Wed, Apr 17, 2024 at 04:20:26PM CEST, michal.swiatkowski@linux.intel.com wrote: >From: Piotr Raczynski [...] >+static int ice_sf_dev_probe(struct auxiliary_device *adev, >+ const struct auxiliary_device_id *id) >+{ >+ struct ice_sf_dev *sf_dev = ice_adev_to_sf_dev(adev); >+ struct ice_dynamic_port *dyn_port = sf_dev->dyn_port; >+ struct ice_vsi_cfg_params params = {}; >+ struct ice_vsi *vsi = dyn_port->vsi; >+ struct ice_pf *pf = dyn_port->pf; >+ struct device *dev = &adev->dev; >+ struct ice_sf_priv *priv; >+ struct devlink *devlink; >+ int err; >+ >+ params.type = ICE_VSI_SF; >+ params.pi = pf->hw.port_info; >+ params.flags = ICE_VSI_FLAG_INIT; >+ >+ priv = ice_allocate_sf(&adev->dev); >+ if (!priv) { >+ dev_err(dev, "Subfunction devlink alloc failed"); >+ return -ENOMEM; >+ } >+ >+ priv->dev = sf_dev; >+ sf_dev->priv = priv; >+ devlink = priv_to_devlink(priv); >+ >+ devlink_register(devlink); Do register at the very end. Btw, currently the error path seems to be broken, leaving devlink instance allocated and registered. >+ devl_lock(devlink); >+ >+ err = ice_vsi_cfg(vsi, ¶ms); >+ if (err) { >+ dev_err(dev, "Subfunction vsi config failed"); >+ goto err_devlink_unlock; >+ } >+ >+ err = ice_devlink_create_sf_dev_port(sf_dev); >+ if (err) { >+ dev_err(dev, "Cannot add ice virtual devlink port for subfunction"); >+ goto err_vsi_decfg; >+ } >+ >+ err = ice_fltr_add_mac_and_broadcast(vsi, vsi->netdev->dev_addr, >+ ICE_FWD_TO_VSI); >+ if (err) { >+ dev_err(dev, "can't add MAC filters %pM for VSI %d\n", >+ vsi->netdev->dev_addr, vsi->idx); >+ goto err_devlink_destroy; >+ } >+ >+ ice_napi_add(vsi); >+ devl_unlock(devlink); >+ >+ return 0; >+ >+err_devlink_destroy: >+ ice_devlink_destroy_sf_dev_port(sf_dev); >+err_vsi_decfg: >+ ice_vsi_decfg(vsi); >+err_devlink_unlock: >+ devl_unlock(devlink); >+ return err; [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF4D312F379 for ; Thu, 18 Apr 2024 13:02:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713445353; cv=none; b=WfeBdj2ePBmSj5mi/EGiQupYzSmFuNEh/Xnw+nSqY6r2cry674i1ss7i4chuOQsUQiOkfzEeaeVO8vvMdMarioBl28D+ffRZ2qWJNx9JWkVhaLN7E6wSQzM9p5RfnFGhU/PgHYacHzbG8GKldQy4kTr8NXy4Eb9lfN+V2P6gbxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713445353; c=relaxed/simple; bh=5OMP7MjSmX2lFnzHlVvUnOXWhZ9hLW8Cw7igkhXBWPg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JY0Vo+RucYME1MlS4KXD+hgsnMGO6nwy+WrMYApYVqoBNT2zwFVVpJLfrxZ44PVFFy51g2HLxB40uhfqW6IZuvsJy152ngMf9f1pbt8yLHnPfW3v4nvRojtTl/6YMjaz9mUOFWb7nqPvmkbTVNVq41rlWcX1sgVvuVfGnISXbVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=TE/Cg4L8; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="TE/Cg4L8" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-418a02562b3so6907305e9.3 for ; Thu, 18 Apr 2024 06:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1713445346; x=1714050146; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SSEbkJW70zZ5sfWUXf2fhvkwK3iAvAImkQZWLi4d0MA=; b=TE/Cg4L8t2ddBAwQB7fPhIbsw5c41kFNHycnWe2ty5CmtY/Ua15b3KCmQAuo5xOJz8 pd3948uKspeaEJNXXtVMcLAzO0ysPltybk4HsUkBHn7aldFVNmnQUlb/7b6glk+QgL1o 4WRjX7dyGMbY48YveKoKu7fRPt5+0rsbksBV/U2GU8DVZppI25/McrKLPxaNsxsqTNeX xbx8N2PZjmPQ9tjBRyE+ZfU3DtlAoWCJX2rz4YONqGzx630g4mylbxvDcnUE6e4ldc+o To/+4BrP0BUTTcziNa73j8T8vnB1GS0Rm1xrCFLzeheuE2BtwDXTCw2KzqRfF9dPN3Kq OsdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713445346; x=1714050146; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SSEbkJW70zZ5sfWUXf2fhvkwK3iAvAImkQZWLi4d0MA=; b=ESVsbi1ss4vIEWabSVz6gMFWp8T3p9voFdJwOJowrbi5YZzKQD+laXm4sRjUT9353O axyMx/IVztO3AoQL4JoaJ2tLvn+h/17hbUCZ5UHptqa+F6JrGTQIKjFcDTLafFN+aemm W5jtNMKj8faNnCypMAo21hgOpnnPiofvRVxU58UYB2Q7c/fDxzLNyhYVqPzQfDLYb2oy 6d3Xolz1mX5k2jfswPkcdPWbzX6T7niJrsBBOjlfVB6mmVx3Rb/XhiZAierFQkiqYtU7 q2YERXhYAl0JZPX+QzaZOfXbD6PKCR1CR2sCvihTKlrG4y9N0Ag5lEa+66Z20FPcvO6K 8iQg== X-Forwarded-Encrypted: i=1; AJvYcCWJ4vdvh54o8vnMNcHFZv0AeH+SWnucR3i8NkdKjsWd3JoXgrbKtlpAbrKZRE2iGZQlOYtlNqJbwJ70znr0nmjUEWGhARK/ X-Gm-Message-State: AOJu0YxiVCfZzBHgKRId6SrmNP2HywxidaU8X7TyMiElOLk2B+ORTqT5 6QsP+dSohsavppMMcueNn7+SQxPV979Fz0T5iXpknAJfmXDIHjgL/8VYdaFHCXA= X-Google-Smtp-Source: AGHT+IEfMG36kM24Iof7e34MrpQEhFq9W2iWI9PjZtvx7h35noSdT2wLL+gDJZ9fjBh5ZhYFG0//zg== X-Received: by 2002:a5d:558e:0:b0:33e:5fb4:49d1 with SMTP id i14-20020a5d558e000000b0033e5fb449d1mr1565460wrv.44.1713445345962; Thu, 18 Apr 2024 06:02:25 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id a12-20020a056000100c00b00349ceadededsm1805262wrx.16.2024.04.18.06.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 06:02:25 -0700 (PDT) Date: Thu, 18 Apr 2024 15:02:21 +0200 From: Jiri Pirko To: Michal Swiatkowski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, jacob.e.keller@intel.com, michal.kubiak@intel.com, maciej.fijalkowski@intel.com, sridhar.samudrala@intel.com, przemyslaw.kitszel@intel.com, wojciech.drewek@intel.com, pio.raczynski@gmail.com, jiri@nvidia.com, mateusz.polchlopek@intel.com Subject: Re: [iwl-next v4 6/8] ice: base subfunction aux driver Message-ID: References: <20240417142028.2171-1-michal.swiatkowski@linux.intel.com> <20240417142028.2171-7-michal.swiatkowski@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240417142028.2171-7-michal.swiatkowski@linux.intel.com> Wed, Apr 17, 2024 at 04:20:26PM CEST, michal.swiatkowski@linux.intel.com wrote: >From: Piotr Raczynski [...] >+static int ice_sf_dev_probe(struct auxiliary_device *adev, >+ const struct auxiliary_device_id *id) >+{ >+ struct ice_sf_dev *sf_dev = ice_adev_to_sf_dev(adev); >+ struct ice_dynamic_port *dyn_port = sf_dev->dyn_port; >+ struct ice_vsi_cfg_params params = {}; >+ struct ice_vsi *vsi = dyn_port->vsi; >+ struct ice_pf *pf = dyn_port->pf; >+ struct device *dev = &adev->dev; >+ struct ice_sf_priv *priv; >+ struct devlink *devlink; >+ int err; >+ >+ params.type = ICE_VSI_SF; >+ params.pi = pf->hw.port_info; >+ params.flags = ICE_VSI_FLAG_INIT; >+ >+ priv = ice_allocate_sf(&adev->dev); >+ if (!priv) { >+ dev_err(dev, "Subfunction devlink alloc failed"); >+ return -ENOMEM; >+ } >+ >+ priv->dev = sf_dev; >+ sf_dev->priv = priv; >+ devlink = priv_to_devlink(priv); >+ >+ devlink_register(devlink); Do register at the very end. Btw, currently the error path seems to be broken, leaving devlink instance allocated and registered. >+ devl_lock(devlink); >+ >+ err = ice_vsi_cfg(vsi, ¶ms); >+ if (err) { >+ dev_err(dev, "Subfunction vsi config failed"); >+ goto err_devlink_unlock; >+ } >+ >+ err = ice_devlink_create_sf_dev_port(sf_dev); >+ if (err) { >+ dev_err(dev, "Cannot add ice virtual devlink port for subfunction"); >+ goto err_vsi_decfg; >+ } >+ >+ err = ice_fltr_add_mac_and_broadcast(vsi, vsi->netdev->dev_addr, >+ ICE_FWD_TO_VSI); >+ if (err) { >+ dev_err(dev, "can't add MAC filters %pM for VSI %d\n", >+ vsi->netdev->dev_addr, vsi->idx); >+ goto err_devlink_destroy; >+ } >+ >+ ice_napi_add(vsi); >+ devl_unlock(devlink); >+ >+ return 0; >+ >+err_devlink_destroy: >+ ice_devlink_destroy_sf_dev_port(sf_dev); >+err_vsi_decfg: >+ ice_vsi_decfg(vsi); >+err_devlink_unlock: >+ devl_unlock(devlink); >+ return err; [...]