From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
linux-kernel@vger.kernel.org,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
"Brady Norander" <bradynorander@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Mark Brown" <broonie@kernel.org>,
"Mark Hasemeyer" <markhas@chromium.org>,
"Takashi Iwai" <tiwai@suse.com>,
linux-sound@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda: intel-dsp-config: Fix Huawei Matebook D14 NBLB-WAX9N quirk detection
Date: Thu, 18 Apr 2024 17:07:57 +0300 [thread overview]
Message-ID: <ZiEpPVYoC1RqsdA9@smile.fi.intel.com> (raw)
In-Reply-To: <5e6ba980c0738199589749b68b83f2d730512107.1713430105.git.mchehab@kernel.org>
On Thu, Apr 18, 2024 at 09:48:27AM +0100, Mauro Carvalho Chehab wrote:
> Newer Matebook D14 model comes with essx8336 and supports SOF,
> but the initial models use the legacy driver, with a Realtek ALC 256
> AC97 chip on it.
>
> The BIOS seems to be prepared to be used by both models, so
> it contains an entry for ESSX8336 on its DSDT table.
>
> Add a quirk, as otherwise dspconfig driver will try to load
> SOF, causing audio probe to fail.
...
> + .ident = "Huawei NBLB-WAX9N",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "HUAWEI"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "NBLB-WAX9N"),
> + }
I would leave a trailing comma to avoid unneeded churn in the future in case
this gets extended.
> + },
> + {}
> + }
Ditto.
> + },
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-04-18 14:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 8:48 [PATCH] ALSA: hda: intel-dsp-config: Fix Huawei Matebook D14 NBLB-WAX9N quirk detection Mauro Carvalho Chehab
2024-04-18 10:04 ` Mauro Carvalho Chehab
2024-04-18 13:24 ` Pierre-Louis Bossart
2024-04-18 20:22 ` Mauro Carvalho Chehab
2024-04-29 12:17 ` Takashi Iwai
2024-04-29 12:25 ` Andy Shevchenko
2024-04-29 13:51 ` Pierre-Louis Bossart
2024-04-29 15:00 ` Takashi Iwai
2024-04-18 14:06 ` Andy Shevchenko
2024-04-18 14:09 ` Takashi Iwai
2024-04-18 14:07 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiEpPVYoC1RqsdA9@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=bradynorander@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=markhas@chromium.org \
--cc=mchehab@kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.