From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Fri, 19 Apr 2024 06:58:06 -0700 Subject: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback In-Reply-To: <20240419112432.GB2972@willie-the-truck> References: <20240405115815.3226315-1-pbonzini@redhat.com> <20240405115815.3226315-2-pbonzini@redhat.com> <20240412104408.GA27645@willie-the-truck> <86jzl2sovz.wl-maz@kernel.org> <86h6g5si0m.wl-maz@kernel.org> <20240418141932.GA1855@willie-the-truck> <20240419112432.GB2972@willie-the-truck> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Apr 19, 2024, Will Deacon wrote: > > @@ -663,10 +669,22 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hva_range(struct kvm *kvm, > > break; > > } > > r.ret |= range->handler(kvm, &gfn_range); > > + > > + /* > > + * Use a precise gfn-based TLB flush when possible, as > > + * most mmu_notifier events affect a small-ish range. > > + * Fall back to a full TLB flush if the gfn-based flush > > + * fails, and don't bother trying the gfn-based flush > > + * if a full flush is already pending. > > + */ > > + if (range->flush_on_ret && !need_flush && r.ret && > > + kvm_arch_flush_remote_tlbs_range(kvm, gfn_range.start, > > + gfn_range.end - gfn_range.start + 1)) > > What's that '+ 1' needed for here? (a) To see if you're paying attention. (b) Because more is always better. (c) Because math is hard. (d) Because I haven't tested this. (e) Both (c) and (d). From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 718A012DD8A for ; Fri, 19 Apr 2024 13:58:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713535091; cv=none; b=cxsPUDLbkQ0bbREooD0XSpnwX5B7wqqHmzdnZWpcyKtapY7gdgKJUpNRnvg8YAWMsh2GtWRdEc3w46l/g79LAAdP3YoAYd8rX4HBnpKQQvNI31rRcoG7XkSRzJlPycGG2to/ZaLCDF6dWNpXvUlEHUENZjUJ5V/fxh3bW1pt1a4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713535091; c=relaxed/simple; bh=gKtJtEltb2GnPLMyuxs+G7n5EiHdmrtpBSJFJerWnT0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Pt/+tg0vD0iMYAsmVekgBSV2oXR++VrttKfrpPrwu7amIc0CKUMKiPhhpOVcKB4QPPDCEBAlAKMyKF0zL8nS04qu0z3Nl7A0GSeMJh7/wJEoLmHjdjGr+E0EQlT49pmwwSz5cjDQGe3Gwa4C7vSxgsN4J7capsaHAQnBrHDiWBQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=AmC3DxMj; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AmC3DxMj" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-de45daf49deso4296603276.2 for ; Fri, 19 Apr 2024 06:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713535088; x=1714139888; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=KgrnEQ6mmP0jFk5Zb1SZY9boKJybsIIVble8n571sqI=; b=AmC3DxMjFCegBnTpEWg1lUcUpV/VxpGFZJlpGry2hKL07jxm+aL70Gd8MxvTIiV4iu 0S0610mUtepQsWNPvITcNz4Q3t5rwkWqojVMB+vH/uuKWDuUjqPXoKTJ7e76GDX+YbH4 ayXMXc6M9v4AxQ0gVx3oolqhHNY/PbiOKyDwnwv9Q4LNIQVTae9UItAu+BbtAop8F4Y/ Tvy9N5zBfq/Nw1iNHwT/qhX0acHc0w8ts9a2tzI6YA/7AU+9LeNoEBWStygreFBKctnF TSrEP/Xd5GOp1jdZ4CGcXMN103RSI+3c6IYiHnT2RqMOC0xb2qpnrVryDJGuByNCy9Zn Q2Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713535088; x=1714139888; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KgrnEQ6mmP0jFk5Zb1SZY9boKJybsIIVble8n571sqI=; b=TSC209ocVgXzLka6UeCYUEXo6th7sL2WCuiZGuzT0umrKkBi7PnJ/bY3HkeBMy+VtO Gl+vw/PVfx/XvvJtXxYxb6jb8AfPMxH/kH2wQzXG2s64z5yhw1ahKmrrskJf6CHbw6Q5 kDFj+BS+rQC9SuE7t2brE6PzNpxEOK08lF978rxiGhTe44ypT4XKaAXdQWB1hxgG/8rj 39dHiM12h9+tbBrHVulwkoaQLcEr819C2+vV2AYNkksHCekpAJNWMJZ6gVu2IehZ9bxi Dg8JM/5M5j3EjH7NkmiAw3Oxl9jMpkllICvJDieuTr+lt/NMUBoZZW2YU5q9Vb7xvFUw 9F5w== X-Forwarded-Encrypted: i=1; AJvYcCXtHxteRPvO2DcENAGite4TpvQo3SaJh5wGgeMj5NId/RkYxxRi5ku2ypv4KxvLh5ShYPAV9r+McXKPydRnWaoLUe3CUlyL X-Gm-Message-State: AOJu0YybQaq9viyL94pArhgFq/4z1ZUzxBn94YLq9u/YH+YUPro6mUm+ FqUz5F0WhIRsp9odj/7P/lH1l0mXqXn0PzW4oyyCAr1348S8JfjP0+LJYnpfFemQzTByIKqqISU KAw== X-Google-Smtp-Source: AGHT+IGomtDJcb51lvQMFTT5YaGoxW/vZTzkUSuhiTLoa8vZxcxiKEVXH4dmB1G1pZ9i7NSp+ryn6A1areA= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:ad8d:0:b0:dc6:e5d3:5f03 with SMTP id z13-20020a25ad8d000000b00dc6e5d35f03mr543024ybi.4.1713535088599; Fri, 19 Apr 2024 06:58:08 -0700 (PDT) Date: Fri, 19 Apr 2024 06:58:06 -0700 In-Reply-To: <20240419112432.GB2972@willie-the-truck> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405115815.3226315-1-pbonzini@redhat.com> <20240405115815.3226315-2-pbonzini@redhat.com> <20240412104408.GA27645@willie-the-truck> <86jzl2sovz.wl-maz@kernel.org> <86h6g5si0m.wl-maz@kernel.org> <20240418141932.GA1855@willie-the-truck> <20240419112432.GB2972@willie-the-truck> Message-ID: Subject: Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback From: Sean Christopherson To: Will Deacon Cc: Marc Zyngier , Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Oliver Upton , Tianrui Zhao , Bibo Mao , Thomas Bogendoerfer , Nicholas Piggin , Anup Patel , Atish Patra , Andrew Morton , David Hildenbrand , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Fri, Apr 19, 2024, Will Deacon wrote: > > @@ -663,10 +669,22 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hva_range(struct kvm *kvm, > > break; > > } > > r.ret |= range->handler(kvm, &gfn_range); > > + > > + /* > > + * Use a precise gfn-based TLB flush when possible, as > > + * most mmu_notifier events affect a small-ish range. > > + * Fall back to a full TLB flush if the gfn-based flush > > + * fails, and don't bother trying the gfn-based flush > > + * if a full flush is already pending. > > + */ > > + if (range->flush_on_ret && !need_flush && r.ret && > > + kvm_arch_flush_remote_tlbs_range(kvm, gfn_range.start, > > + gfn_range.end - gfn_range.start + 1)) > > What's that '+ 1' needed for here? (a) To see if you're paying attention. (b) Because more is always better. (c) Because math is hard. (d) Because I haven't tested this. (e) Both (c) and (d). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAA72C4345F for ; Fri, 19 Apr 2024 13:58:59 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=DuHVRzYi; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VLbpp2pj0z3cZR for ; Fri, 19 Apr 2024 23:58:58 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=DuHVRzYi; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::b49; helo=mail-yb1-xb49.google.com; envelope-from=3chgizgykdcmrd9mibfnnfkd.bnlkhmtwoob-cdukhrsr.nyk9ar.nqf@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VLbny6q9Bz3cPh for ; Fri, 19 Apr 2024 23:58:13 +1000 (AEST) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-de468af2b73so3536036276.0 for ; Fri, 19 Apr 2024 06:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713535088; x=1714139888; darn=lists.ozlabs.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=KgrnEQ6mmP0jFk5Zb1SZY9boKJybsIIVble8n571sqI=; b=DuHVRzYiOW23zTL7IpDcG/NB5pqJsYSOVMtoCGnp+UMf8FCGd2xzI4/kxO6OJtgu9N yEJbHywi1oohdVm0WTf/AUm3F3+Vw22bhVxlrrc33lnohl6RoW9OrbdKA05TYdjkeOmY QelhmP8zxmxsMAByxLC6y31UzO/5blS+xynLzc4oXGfpLuMPpb3MA7xGeFx4jzvtN7co b9wvJVuTpU5of17gFtiyB2b/eWzi3ZvtiYQAWjnKFjn7T1CEHqPIBTsMYxUTaO+yngRi 5HlQvc3C/CMt88DVVzy2UkXUJTx5Xs7FGjCasH+foTWsaGGP8QbxsXdPtyIeoyGToXzq chew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713535088; x=1714139888; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KgrnEQ6mmP0jFk5Zb1SZY9boKJybsIIVble8n571sqI=; b=VhCpQ/8zD79QNYUyKMOWa/8ZjzE+JTrtLSCIZR/v7ixPIq5xVt+IdLLBQOhjRaQrGZ ax2UACs7CcsKW6IzDtNfoGpZMp69sIgpgw05T9w2bowTdNEKRfvmv2q1U3qbna0V7epc Y40lgtnZ1gNMYZ0USOdat/VnNVZqg3RYqCj5fkxV1MsSgq6AcazXpTbVau1Iv9N7ubUA szc6/5LHM7Y8QuC1Ti5pe8o+7r7ejQzh1tD0K/nvtCStM8zuCKsZtaBuKuirgZzq8Dva vJYwrwYoitgWqgGc8n8BAT8MvKe2FCpywxZSCPOFyQQhcN7nT9bFQ1rvDrhX28jSs7xK 97fQ== X-Forwarded-Encrypted: i=1; AJvYcCV+JArCindkxoR0xSZ57/DfIddWxvOoVkJFDseWvNRWf0l3CpDJbznjMOX0F4WPzvFBQZVyeo8cApjUhyo9LwRc0WUZgsslMTicsVJzmA== X-Gm-Message-State: AOJu0YziDUVv06dwbEcPBAe+W+u95Xa0/UPsANlOzjfEvifZ/CkS4yQN RIm8cz+Wea8dBVpwsFGRfFdQjOZTS3g4hkEl/t2F6nqNL4DkU5ndbwOqUMLh2XWRNI8r1TJ/hKE wOA== X-Google-Smtp-Source: AGHT+IGomtDJcb51lvQMFTT5YaGoxW/vZTzkUSuhiTLoa8vZxcxiKEVXH4dmB1G1pZ9i7NSp+ryn6A1areA= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:ad8d:0:b0:dc6:e5d3:5f03 with SMTP id z13-20020a25ad8d000000b00dc6e5d35f03mr543024ybi.4.1713535088599; Fri, 19 Apr 2024 06:58:08 -0700 (PDT) Date: Fri, 19 Apr 2024 06:58:06 -0700 In-Reply-To: <20240419112432.GB2972@willie-the-truck> Mime-Version: 1.0 References: <20240405115815.3226315-1-pbonzini@redhat.com> <20240405115815.3226315-2-pbonzini@redhat.com> <20240412104408.GA27645@willie-the-truck> <86jzl2sovz.wl-maz@kernel.org> <86h6g5si0m.wl-maz@kernel.org> <20240418141932.GA1855@willie-the-truck> <20240419112432.GB2972@willie-the-truck> Message-ID: Subject: Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback From: Sean Christopherson To: Will Deacon Content-Type: text/plain; charset="us-ascii" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, David Hildenbrand , linux-mips@vger.kernel.org, linux-mm@kvack.org, Marc Zyngier , linux-trace-kernel@vger.kernel.org, Nicholas Piggin , Bibo Mao , loongarch@lists.linux.dev, Atish Patra , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , linux-kernel@vger.kernel.org, Oliver Upton , linux-perf-users@vger.kernel.org, kvm-riscv@lists.infradead.org, Anup Patel , Paolo Bonzini , Andrew Morton , Tianrui Zhao , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Apr 19, 2024, Will Deacon wrote: > > @@ -663,10 +669,22 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hva_range(struct kvm *kvm, > > break; > > } > > r.ret |= range->handler(kvm, &gfn_range); > > + > > + /* > > + * Use a precise gfn-based TLB flush when possible, as > > + * most mmu_notifier events affect a small-ish range. > > + * Fall back to a full TLB flush if the gfn-based flush > > + * fails, and don't bother trying the gfn-based flush > > + * if a full flush is already pending. > > + */ > > + if (range->flush_on_ret && !need_flush && r.ret && > > + kvm_arch_flush_remote_tlbs_range(kvm, gfn_range.start, > > + gfn_range.end - gfn_range.start + 1)) > > What's that '+ 1' needed for here? (a) To see if you're paying attention. (b) Because more is always better. (c) Because math is hard. (d) Because I haven't tested this. (e) Both (c) and (d). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13511C4345F for ; Fri, 19 Apr 2024 13:58:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=+Wc7CiY8xskibxfkf57wqhZ4SG/2JcpfywgtDdk7SFY=; b=finmiGLLer8OLdbWYZveFR2iIP bf+ADhJxP9qw4SqungfWmYlK11jCPyRj9UBo6NpSQKXF8g/Obdn6EbrA0ji53hnnx3fmXmsCGPnXW GbOT61X1PfVTggtXwRf44SMf1VD4JyZ5IlZ9oNnrwGTCZ63d5oDE2gGBeRFN8JPZDl2tOZaxaZFwg bLXWoP/AC+GJ0JIaNGEd42XVp7TgUIDoAvhPUuMXo6lrP4N8tcOiD50vv/sQ+rd8oaaH7sH1ubsBo 7mw8iaIKPdoWT4flatHAZkPLOvpZnepbU5Fq8YPfUXAlDJhx9LBWbr+OHuMvUCzqdFAwDaH/+YbUL SME5oAEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxoko-00000005qxQ-0B62; Fri, 19 Apr 2024 13:58:14 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxokl-00000005qvH-148d for linux-arm-kernel@lists.infradead.org; Fri, 19 Apr 2024 13:58:12 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-61ae9ff0322so41567487b3.3 for ; Fri, 19 Apr 2024 06:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713535088; x=1714139888; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=KgrnEQ6mmP0jFk5Zb1SZY9boKJybsIIVble8n571sqI=; b=J2y67Dt+aZGTkrHGr2VFtzhAT64SPk/ao5FviH8TFzOk28cn/47oOiDMXQYlqVPxdg ntLxulvGGo6dzVajbqeGWsK0ck2GrK4kyJuXK8oEG3XEilEgROsYXZU0mWXUAbyQH59I 0tIoi99qlOGPr2npkhf+maBXWso/tPtMNCOZuFVxM34hFmWKTk77G8/DRhU+cyiY36hN pKXGoyew6H9fbgEI8kMXpW5/X2CVtIXzFF5BKC47SdWY8AQnUAfzoLG4Fd73VP3Jxvrk 2N9xwfFHMCfs1t8VRGgPXStFLYG+P1BM8gIPM92N9o0ajdE45KUfqjx1Tbc54tojsX8p fZnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713535088; x=1714139888; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KgrnEQ6mmP0jFk5Zb1SZY9boKJybsIIVble8n571sqI=; b=Ob5PoIuypGVK771JfopBTSNWEP008wVB8ArnKTaHVKk6bK0lfJrIMBEnFf2ZZrzUG7 jauTc96uPauv5gdebope3NM4CL0nDWn/RTCGps/fRdDSD/4nIE93BSVH6w8j/rfpoNUe 9DgPH+NLzSfIs18WQm2Uo80YGktlcgbfL437seC2VolMnk3a0Zdvn0bdDq0UFxHlRQ/x Qk5723+pPQ4cMtphqAnte81F8xxMY8oGfjNDc4D8+SUL9yhRmoRaERgRhklSnt4Vmofh +GhcCji3LiJEHkhTtXooNoSsWj6Uz368+59gw9mqtckpK7JDI0oCAWmsg0F+hjbeivSm fZ9w== X-Forwarded-Encrypted: i=1; AJvYcCVKhOYTu5e+OWnlQCDYXN8L2nqygrpxGm8i4znyehYXezNKEhO4oGRmu1ZkqjKK+nNkNS2CSXHMwY7mFOGgTkIiYLSUNSk+SJ+7PJBKq/LqKVk162c= X-Gm-Message-State: AOJu0YydNXhBQgzerBfChmSMww9KvNZ95UVEdjSiAIgt1x7MTersOE2z pbwVyQipKMQSDTrsIeM9BrpGbDV34qL0QWWndYsCBchD0YMBY0nkZMz9JW1Q37Wk4nXfUYIImSp ZPw== X-Google-Smtp-Source: AGHT+IGomtDJcb51lvQMFTT5YaGoxW/vZTzkUSuhiTLoa8vZxcxiKEVXH4dmB1G1pZ9i7NSp+ryn6A1areA= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:ad8d:0:b0:dc6:e5d3:5f03 with SMTP id z13-20020a25ad8d000000b00dc6e5d35f03mr543024ybi.4.1713535088599; Fri, 19 Apr 2024 06:58:08 -0700 (PDT) Date: Fri, 19 Apr 2024 06:58:06 -0700 In-Reply-To: <20240419112432.GB2972@willie-the-truck> Mime-Version: 1.0 References: <20240405115815.3226315-1-pbonzini@redhat.com> <20240405115815.3226315-2-pbonzini@redhat.com> <20240412104408.GA27645@willie-the-truck> <86jzl2sovz.wl-maz@kernel.org> <86h6g5si0m.wl-maz@kernel.org> <20240418141932.GA1855@willie-the-truck> <20240419112432.GB2972@willie-the-truck> Message-ID: Subject: Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback From: Sean Christopherson To: Will Deacon Cc: Marc Zyngier , Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Oliver Upton , Tianrui Zhao , Bibo Mao , Thomas Bogendoerfer , Nicholas Piggin , Anup Patel , Atish Patra , Andrew Morton , David Hildenbrand , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240419_065811_315794_1BBA2FF9 X-CRM114-Status: GOOD ( 12.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 19, 2024, Will Deacon wrote: > > @@ -663,10 +669,22 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hva_range(struct kvm *kvm, > > break; > > } > > r.ret |= range->handler(kvm, &gfn_range); > > + > > + /* > > + * Use a precise gfn-based TLB flush when possible, as > > + * most mmu_notifier events affect a small-ish range. > > + * Fall back to a full TLB flush if the gfn-based flush > > + * fails, and don't bother trying the gfn-based flush > > + * if a full flush is already pending. > > + */ > > + if (range->flush_on_ret && !need_flush && r.ret && > > + kvm_arch_flush_remote_tlbs_range(kvm, gfn_range.start, > > + gfn_range.end - gfn_range.start + 1)) > > What's that '+ 1' needed for here? (a) To see if you're paying attention. (b) Because more is always better. (c) Because math is hard. (d) Because I haven't tested this. (e) Both (c) and (d). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel