From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12014C4345F for ; Fri, 19 Apr 2024 19:20:37 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rxtmm-0001eM-AV; Fri, 19 Apr 2024 19:20:36 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rxtmk-0001eD-AU for linux-f2fs-devel@lists.sourceforge.net; Fri, 19 Apr 2024 19:20:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LjtNqhMd4KLJBjb4qm491I62qzWU2d5FNisqXR9zf1E=; b=eBlP2ZhalzzxZhdQquVKWtuAja ZAl0gCLJeEEzkMdshQS5fE2IIxOkjt1Qr2L8ty/FQXVNf7YxcLdTrCDN5s2sqjq+kgfkrK9pJkePP oEeFXBCgqpviEh8/BVbp73cgQkRW/ufSkFLsqnu4S2Gf+iwUPPIvNPad1xjSvNr/Oy18=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=LjtNqhMd4KLJBjb4qm491I62qzWU2d5FNisqXR9zf1E=; b=AeSBW5Mx/fjn/niXkOXZZsXrm4 oahFLk3q92nsGahA6FHxdn/1shf+8AzwRz00rRsB85x+Vp4qOJtCpBV+HymGyqL9FGRlcPlAI/1Vu 07Cc6nSO9JVJ6EdM5DwD8cmwg+ipY3tX9opOJgcIn4Um1GhxLvWtPhhAKJwfgj9SPtHw=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1rxtmi-0006v2-VI for linux-f2fs-devel@lists.sourceforge.net; Fri, 19 Apr 2024 19:20:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B10F0619E1; Fri, 19 Apr 2024 17:50:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21301C072AA; Fri, 19 Apr 2024 17:50:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713549038; bh=rvTw9ZrNgQLrxwznc8Svvfzom1CX7emLfaumx2oM7sM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KsaZaGFwPHe2vKZa0qajwmUlD6nHyZZibR4e7m6LU3KgavQ57SBW/qLg4xjJ3RPLB Jg83FoAvguNj+ZmZyZLl0+h3tZiSwc7Jtm5kp7W1DGxHcIJVSjoXAjQyL82U2+ux6W mKt2fbRiQeyBsySecMUPuA0gGVMTMgQDMoCCaooqSDAIk1IHfV4Reoz8QymuVqe9jo ctxKxFgqmnPbcCgjei3N13cQkIMvLfZOoVyD6SUh0WVc9Zp3blPu90p3WCXV56j/Z1 EL1mzJje8xXFAPGTtBmrR5xdphNnf+Kp4Secbll2QAuwDKf06MvDUG8tVooF1UYB/b WBG2YWpEigtbw== Date: Fri, 19 Apr 2024 17:50:36 +0000 From: Jaegeuk Kim To: Juhyung Park Message-ID: References: <20240409203411.1885121-1-jaegeuk@kernel.org> <20240409203411.1885121-3-jaegeuk@kernel.org> <050a93dc-d9a8-44bd-9a83-83718e95f04d@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1rxtmi-0006v2-VI Subject: Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMDQvMTksIEp1aHl1bmcgUGFyayB3cm90ZToKPiBPbiBTYXQsIEFwciAxMywgMjAyNCBhdCA1 OjU34oCvQU0gSmFlZ2V1ayBLaW0gPGphZWdldWtAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4g T24gMDQvMTEsIENoYW8gWXUgd3JvdGU6Cj4gPiA+IE9uIDIwMjQvNC8xMCA0OjM0LCBKYWVnZXVr IEtpbSB3cm90ZToKPiA+ID4gPiBmMmZzX3JhX21ldGFfcGFnZXMgY2FuIHRyeSB0byByZWFkIGFo ZWFkIG9uIGludmFsaWQgYmxvY2sgYWRkcmVzcyB3aGljaCBpcwo+ID4gPiA+IG5vdCB0aGUgY29y cnVwdGlvbiBjYXNlLgo+ID4gPgo+ID4gPiBJbiB3aGljaCBjYXNlIHdlIHdpbGwgcmVhZCBhaGVh ZCBpbnZhbGlkIG1ldGEgcGFnZXM/IHJlY292ZXJ5IHcvIE1FVEFfUE9SPwo+IAo+IEluIG15IGNh c2UsIGl0IHNlZW1zIGxpa2UgaXQncyBNRVRBX1NJVCwgYW5kIGl0J3MgdHJpZ2dlcmVkIHJpZ2h0 IGFmdGVyIG1vdW50Lgo+IGZzY2sgZGV0ZWN0cyBpbnZhbGlkX2Jsa2FkZHIsIGFuZCB3aGVuIHRo ZSBrZXJuZWwgbW91bnRzIGl0LCBpdAo+IGltbWVkaWF0ZWx5IGZsYWdzIGludmFsaWRfYmxrYWRk ciBhZ2FpbjoKPiAKPiBbICAgIDYuMzMzNDk4XSBpbml0OiBbbGliZnNfbWdyXSBSdW5uaW5nIC9z eXN0ZW0vYmluL2ZzY2suZjJmcyAtYSAtYwo+IDEwMDAwIC0tZGVidWctY2FjaGUgL2Rldi9ibG9j ay9zZGExMwo+IFsgICAgNi4zMzc2NzFdIGZzY2suZjJmczogSW5mbzogRml4IHRoZSByZXBvcnRl ZCBjb3JydXB0aW9uLgo+IFsgICAgNi4zMzc5NDddIGZzY2suZjJmczogSW5mbzogbm90IGV4aXN0 IC9wcm9jL3ZlcnNpb24hCj4gWyAgICA2LjMzODAxMF0gZnNjay5mMmZzOiBJbmZvOiBjYW4ndCBm aW5kIC9zeXMsIGFzc3VtaW5nIG5vcm1hbCBibG9jayBkZXZpY2UKPiBbICAgIDYuMzM4Mjk0XSBm c2NrLmYyZnM6IEluZm86IE1LRlMgdmVyc2lvbgo+IFsgICAgNi4zMzgzMTldIGZzY2suZjJmczog ICAiNS4xMC4xNjAtYW5kcm9pZDEyLTktZ2U1Y2ZlYzQxYzhlMiIKPiBbICAgIDYuMzM4MzY2XSBm c2NrLmYyZnM6IEluZm86IEZTQ0sgdmVyc2lvbgo+IFsgICAgNi4zMzgzODBdIGZzY2suZjJmczog ICBmcm9tICI1LjEwLWFydGVyOTciCj4gWyAgICA2LjMzODM5M10gZnNjay5mMmZzOiAgICAgdG8g IjUuMTAtYXJ0ZXI5NyIKPiBbICAgIDYuMzM4NDE0XSBmc2NrLmYyZnM6IEluZm86IHN1cGVyYmxv Y2sgZmVhdHVyZXMgPSAxNDk5IDogIGVuY3J5cHQKPiB2ZXJpdHkgZXh0cmFfYXR0ciBwcm9qZWN0 X3F1b3RhIHF1b3RhX2lubyBjYXNlZm9sZAo+IFsgICAgNi4zMzg0MjldIGZzY2suZjJmczogSW5m bzogc3VwZXJibG9jayBlbmNyeXB0IGxldmVsID0gMCwgc2FsdCA9Cj4gMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAKPiBbICAgIDYuMzM4NDQyXSBmc2NrLmYyZnM6IEluZm86IGNoZWNr cG9pbnQgc3RvcCByZWFzb246IHNodXRkb3duKDE4MCkKPiBbICAgIDYuMzM4NDU1XSBmc2NrLmYy ZnM6IEluZm86IGZzIGVycm9yczogaW52YWxpZF9ibGthZGRyCj4gWyAgICA2LjMzODQ2OF0gZnNj ay5mMmZzOiBJbmZvOiBTZWdtZW50cyBwZXIgc2VjdGlvbiA9IDEKPiBbICAgIDYuMzM4NDgwXSBm c2NrLmYyZnM6IEluZm86IFNlY3Rpb25zIHBlciB6b25lID0gMQo+IFsgICAgNi4zMzg0OTJdIGZz Y2suZjJmczogSW5mbzogdG90YWwgRlMgc2VjdG9ycyA9IDU4OTcxNTcxICgyMzAzNTcgTUIpCj4g WyAgICA2LjM0MDU5OV0gZnNjay5mMmZzOiBJbmZvOiBDS1BUIHZlcnNpb24gPSAyYjdlM2IyOQo+ IFsgICAgNi4zNDA2MjBdIGZzY2suZjJmczogSW5mbzogdmVyc2lvbiB0aW1lc3RhbXAgY3VyOiAx OTc4OTI5NiwgcHJldjogMTg0MDcwMDgKPiBbICAgIDYuNjc3MDQxXSBmc2NrLmYyZnM6IEluZm86 IGNoZWNrcG9pbnQgc3RhdGUgPSA0NiA6ICBjcmMKPiBjb21wYWN0ZWRfc3VtbWFyeSBvcnBoYW5f aW5vZGVzIHN1ZGRlbi1wb3dlci1vZmYKPiBbICAgIDYuNjc3MDUyXSBmc2NrLmYyZnM6IFtGU0NL XSBDaGVjayBub2RlIDEgLyA3MTI5MzcgKDAuMDAlKQo+IFsgICAgOC45OTc5MjJdIGZzY2suZjJm czogW0ZTQ0tdIENoZWNrIG5vZGUgNzEyOTQgLyA3MTI5MzcgKDEwLjAwJSkKPiBbICAgMTAuNjI5 MjA1XSBmc2NrLmYyZnM6IFtGU0NLXSBDaGVjayBub2RlIDE0MjU4NyAvIDcxMjkzNyAoMjAuMDAl KQo+IFsgICAxMi4yNzgxODZdIGZzY2suZjJmczogW0ZTQ0tdIENoZWNrIG5vZGUgMjEzODgwIC8g NzEyOTM3ICgzMC4wMCUpCj4gWyAgIDEzLjc2ODE3N10gZnNjay5mMmZzOiBbRlNDS10gQ2hlY2sg bm9kZSAyODUxNzMgLyA3MTI5MzcgKDQwLjAwJSkKPiBbICAgMTcuNDQ2OTcxXSBmc2NrLmYyZnM6 IFtGU0NLXSBDaGVjayBub2RlIDM1NjQ2NiAvIDcxMjkzNyAoNTAuMDAlKQo+IFsgICAxOS44OTE2 MjNdIGZzY2suZjJmczogW0ZTQ0tdIENoZWNrIG5vZGUgNDI3NzU5IC8gNzEyOTM3ICg2MC4wMCUp Cj4gWyAgIDIzLjI1MTMyN10gZnNjay5mMmZzOiBbRlNDS10gQ2hlY2sgbm9kZSA0OTkwNTIgLyA3 MTI5MzcgKDcwLjAwJSkKPiBbICAgMjguNDkzNDU3XSBmc2NrLmYyZnM6IFtGU0NLXSBDaGVjayBu b2RlIDU3MDM0NSAvIDcxMjkzNyAoODAuMDAlKQo+IFsgICAyOS42NDA4MDBdIGZzY2suZjJmczog W0ZTQ0tdIENoZWNrIG5vZGUgNjQxNjM4IC8gNzEyOTM3ICg5MC4wMCUpCj4gWyAgIDMwLjcxODM0 N10gZnNjay5mMmZzOiBbRlNDS10gQ2hlY2sgbm9kZSA3MTI5MzEgLyA3MTI5MzcgKDEwMC4wMCUp Cj4gWyAgIDMwLjcyNDE3Nl0gZnNjay5mMmZzOgo+IFsgICAzMC43MzcxNjBdIGZzY2suZjJmczog W0ZTQ0tdIE1heCBpbWFnZSBzaXplOiAxNjc1MDYgTUIsIEZyZWUgc3BhY2U6IDYyODUwIE1CCj4g WyAgIDMwLjczNzE2NF0gZnNjay5mMmZzOiBbRlNDS10gVW5yZWFjaGFibGUgbmF0IGVudHJpZXMK PiAgICAgICAgICBbT2suLl0gWzB4MF0KPiBbICAgMzAuNzM3NjM4XSBmc2NrLmYyZnM6IFtGU0NL XSBTSVQgdmFsaWQgYmxvY2sgYml0bWFwIGNoZWNraW5nCj4gICAgICAgICAgW09rLi5dCj4gWyAg IDMwLjczNzY0MF0gZnNjay5mMmZzOiBbRlNDS10gSGFyZCBsaW5rIGNoZWNraW5nIGZvciByZWd1 bGFyIGZpbGUKPiAgICAgICAgICBbT2suLl0gWzB4ZF0KPiBbICAgMzAuNzM3NjQxXSBmc2NrLmYy ZnM6IFtGU0NLXSB2YWxpZF9ibG9ja19jb3VudCBtYXRjaGluZyB3aXRoIENQCj4gICAgICAgICAg W09rLi5dIFsweDI4Yjk4ZTZdCj4gWyAgIDMwLjczNzY0NF0gZnNjay5mMmZzOiBbRlNDS10gdmFs aWRfbm9kZV9jb3VudCBtYXRjaGluZyB3aXRoIENQIChkZQo+IGxvb2t1cCkgIFtPay4uXSBbMHhh ZTBlOV0KPiBbICAgMzAuNzM3NjQ2XSBmc2NrLmYyZnM6IFtGU0NLXSB2YWxpZF9ub2RlX2NvdW50 IG1hdGNoaW5nIHdpdGggQ1AKPiAobmF0IGxvb2t1cCkgW09rLi5dIFsweGFlMGU5XQo+IFsgICAz MC43Mzc2NDddIGZzY2suZjJmczogW0ZTQ0tdIHZhbGlkX2lub2RlX2NvdW50IG1hdGNoZWQgd2l0 aCBDUAo+ICAgICAgICAgIFtPay4uXSBbMHhhNzRhM10KPiBbICAgMzAuNzM3NjQ5XSBmc2NrLmYy ZnM6IFtGU0NLXSBmcmVlIHNlZ21lbnRfY291bnQgbWF0Y2hlZCB3aXRoIENQCj4gICAgICAgICAg W09rLi5dIFsweDdhYTNdCj4gWyAgIDMwLjczNzY2Ml0gZnNjay5mMmZzOiBbRlNDS10gbmV4dCBi bG9jayBvZmZzZXQgaXMgZnJlZQo+ICAgICAgICAgIFtPay4uXQo+IFsgICAzMC43Mzc2NjNdIGZz Y2suZjJmczogW0ZTQ0tdIGZpeGluZyBTSVQgdHlwZXMKPiBbICAgMzAuNzM3ODY3XSBmc2NrLmYy ZnM6IFtGU0NLXSBvdGhlciBjb3JydXB0ZWQgYnVncwo+ICAgICAgICAgIFtPay4uXQo+IFsgICAz MC43Mzc4OTNdIGZzY2suZjJmczogW3VwZGF0ZV9zdXBlcmJsb2NrOiA3NjVdIEluZm86IERvbmUg dG8KPiB1cGRhdGUgc3VwZXJibG9jawo+IFsgICAzMC45NjA2MTBdIGZzY2suZjJmczoKPiBbICAg MzAuOTYwNjE4XSBmc2NrLmYyZnM6IERvbmU6IDI0LjYyMjk1NiBzZWNzCj4gWyAgIDMwLjk2MDYy MF0gZnNjay5mMmZzOgo+IFsgICAzMC45NjA2MjJdIGZzY2suZjJmczogYywgdSwgUkEsIENILCBD TSwgUmVwbD0KPiBbICAgMzAuOTYwNjI3XSBmc2NrLmYyZnM6IDEwMDAwIDEwMDAwIDQzNjAwNTE3 IDQyNjA1NDM0IDk5NTA4MyA5ODUwODMKPiBbICAgMzAuOTYzMjc0XSBGMkZTLWZzIChzZGExMyk6 IFVzaW5nIGVuY29kaW5nIGRlZmluZWQgYnkgc3VwZXJibG9jazoKPiB1dGY4LTEyLjEuMCB3aXRo IGZsYWdzIDB4MAo+IFsgICAzMC45OTUzNjBdIF9fZjJmc19pc192YWxpZF9ibGthZGRyOiB0eXBl PTIKPiAKPiAoTWFudWFsbHkgYWRkZWQgdGhhdCBwcmludCBeKQo+IAo+IFsgICAzMC45OTUzNjld IC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQo+IFsgICAzMC45OTUzNzVdIFdB Uk5JTkc6IENQVTogNyBQSUQ6IDEgYXQgZjJmc19oYW5kbGVfZXJyb3IrMHgxOC8weDNjCj4gWyAg IDMwLjk5NTM3OF0gQ1BVOiA3IFBJRDogMSBDb21tOiBpbml0IFRhaW50ZWQ6IEcgUyAgICAgIFcK PiA1LjEwLjIwOS1hcnRlcjk3LXIxNS1rZXJuZWxzdS1nMDg2N2QwZTRmMWQyICM2Cj4gWyAgIDMw Ljk5NTM3OV0gSGFyZHdhcmUgbmFtZTogUXVhbGNvbW0gVGVjaG5vbG9naWVzLCBJbmMuIENhcGUg UVJECj4gd2l0aCBQTTgwMTAgKERUKQo+IFsgICAzMC45OTUzODBdIHBzdGF0ZTogMjI0MDAwMDUg KG56Q3YgZGFpZiArUEFOIC1VQU8gK1RDTyBCVFlQRT0tLSkKPiBbICAgMzAuOTk1MzgyXSBwYyA6 IGYyZnNfaGFuZGxlX2Vycm9yKzB4MTgvMHgzYwo+IFsgICAzMC45OTUzODRdIGxyIDogX19mMmZz X2lzX3ZhbGlkX2Jsa2FkZHIrMHgyYTQvMHgyYjAKPiBbICAgMzAuOTk1Mzg1XSBzcCA6IGZmZmZm ZjgwMjA5ZTc5YjAKPiBbICAgMzAuOTk1Mzg2XSB4Mjk6IGZmZmZmZjgwMjA5ZTc5YjAgeDI4OiAw MDAwMDAwMDAwMDAwMDM3Cj4gWyAgIDMwLjk5NTM4OF0geDI3OiAwMDAwMDAwMDAwMDAwMWM3IHgy NjogMDAwMDAwMDAyMDEyMDEyMQo+IFsgICAzMC45OTUzODldIHgyNTogMDAwMDAwMDAwMDAwMDBk OSB4MjQ6IDAwMDAwMDAwMDAwMDAwMDAKPiBbICAgMzAuOTk1MzkwXSB4MjM6IGZmZmZmZmZmMDBm MWE3MDAgeDIyOiAwMDAwMDAwMDAwMDAwODI4Cj4gWyAgIDMwLjk5NTM5MV0geDIxOiBmZmZmZmY4 MDQ2MmFhMDAwIHgyMDogZmZmZmZmODA0NjJhYTAwMAo+IFsgICAzMC45OTUzOTJdIHgxOTogMDAw MDAwMDAwMDAwMDAwMiB4MTg6IGZmZmZmZmZmZmZmZmZmZmYKPiBbICAgMzAuOTk1MzkzXSB4MTc6 IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMGZmZmYwMDAwCj4gWyAgIDMwLjk5NTM5NF0g eDE1OiAwMDAwMDAwMDAwMDAwMDA0IHgxNDogZmZmZmZmZDE2NzVhYzZkMAo+IFsgICAzMC45OTUz OTVdIHgxMzogMDAwMDAwMDAwMDAwMDAwMyB4MTI6IDAwMDAwMDAwMDAwMDAwMDMKPiBbICAgMzAu OTk1Mzk2XSB4MTE6IDAwMDAwMDAwZmZmZmZmZmYgeDEwOiAwMDAwMDAwMDAwMDAwMDAwCj4gWyAg IDMwLjk5NTM5N10geDkgOiAwMDAwMDAwMTAwMDAwMDAxIHg4IDogMDAwMDAwMDEwMDAwMDAwMAo+ IFsgICAzMC45OTUzOThdIHg3IDogNjQ2OTZjNjE3NjVmNzM2OSB4NiA6IGZmZmZmZmQxNjgxMjc5 ZTgKPiBbICAgMzAuOTk1Mzk5XSB4NSA6IDAwMDAwMDAwMDAwMDAwMWYgeDQgOiAwMDAwMDAwMDAw MDAwMDAxCj4gWyAgIDMwLjk5NTQwMF0geDMgOiAwMDAwMDAwMDAwMDAwMDAwIHgyIDogZmZmZmZm ODlmMDNkZWRjOAo+IFsgICAzMC45OTU0MDFdIHgxIDogMDAwMDAwMDAwMDAwMDAwMiB4MCA6IGZm ZmZmZjgwNDYyYWEwMDAKPiBbICAgMzAuOTk1NDAzXSBDYWxsIHRyYWNlOgo+IFsgICAzMC45OTU0 MDRdIGYyZnNfaGFuZGxlX2Vycm9yKzB4MTgvMHgzYwo+IFsgICAzMC45OTU0MDVdIF9fZjJmc19p c192YWxpZF9ibGthZGRyKzB4MmE0LzB4MmIwCj4gWyAgIDMwLjk5NTQwNl0gZjJmc19pc192YWxp ZF9ibGthZGRyKzB4MTAvMHgyMAo+IFsgICAzMC45OTU0MDddIGYyZnNfcmFfbWV0YV9wYWdlcysw eGUwLzB4MjMwCj4gWyAgIDMwLjk5NTQwOV0gYnVpbGRfc2l0X2VudHJpZXMrMHhhOC8weDU4MAo+ IFsgICAzMC45OTU0MTFdIGYyZnNfYnVpbGRfc2VnbWVudF9tYW5hZ2VyKzB4MTI0LzB4MTcwCj4g WyAgIDMwLjk5NTQxMl0gZjJmc19maWxsX3N1cGVyKzB4NzhjLzB4ZDFjCj4gWyAgIDMwLjk5NTQx NV0gbW91bnRfYmRldisweDE2OC8weDFhYwo+IFsgICAzMC45OTU0MTZdIGYyZnNfbW91bnQrMHgx OC8weDI0Cj4gWyAgIDMwLjk5NTQxOF0gbGVnYWN5X2dldF90cmVlLmxsdm0uOTE0Nzg0NTc3OTU1 OTcxNTA4MysweDMwLzB4NWMKPiBbICAgMzAuOTk1NDE5XSB2ZnNfZ2V0X3RyZWUrMHgzMC8weGUw Cj4gWyAgIDMwLjk5NTQyMV0gZG9fbmV3X21vdW50KzB4MTQwLzB4MzU4Cj4gWyAgIDMwLjk5NTQy Ml0gcGF0aF9tb3VudCsweDFmYy8weDRlOAo+IFsgICAzMC45OTU0MjNdIF9fYXJtNjRfc3lzX21v dW50KzB4MTUwLzB4Mjk0Cj4gWyAgIDMwLjk5NTQyNV0gZWwwX3N2Y19jb21tb24ubGx2bS4xNTY5 ODQ1NDk1MjE1NDk2NTc4NysweGE4LzB4MTM4Cj4gWyAgIDMwLjk5NTQyNl0gZG9fZWwwX3N2Yysw eDI0LzB4OTAKPiBbICAgMzAuOTk1NDI5XSBlbDBfc3ZjKzB4MTAvMHgxYwo+IFsgICAzMC45OTU0 MzBdIGVsMF9zeW5jX2hhbmRsZXIrMHhjYy8weGU0Cj4gWyAgIDMwLjk5NTQzMl0gZWwwX3N5bmMr MHgxYTAvMHgxYzAKPiBbICAgMzAuOTk1NDMzXSAtLS1bIGVuZCB0cmFjZSAzYjgzMjk1ZTBjZGFj OTRlIF0tLS0KPiBbICAgMzEuMDA1MDExXSBGMkZTLWZzIChzZGExMyk6IE1vdW50ZWQgd2l0aCBj aGVja3BvaW50IHZlcnNpb24gPSAyYjdlM2IyOQo+IFsgICAzMS4wMDUxNzZdIGluaXQ6IFtsaWJm c19tZ3JdCj4gX19tb3VudChzb3VyY2U9L2Rldi9ibG9jay9ib290ZGV2aWNlL2J5LW5hbWUvdXNl cmRhdGEsdGFyZ2V0PS9kYXRhLHR5cGU9ZjJmcyk9MDoKPiBTdWNjZXNzCj4gWyAgIDMxLjAwNzc0 OV0gaW5pdDogVXNlcmRhdGEgbW91bnRlZCB1c2luZyAvdmVuZG9yL2V0Yy9mc3RhYi5xY29tIHJl c3VsdCA6IDAKPiAKPiAKPiBJIHdhcyBiaXNlY3RpbmcgYSBsb25nIGJvb3QgdGltZSAoMjQgYWRk aXRpb25hbCBzZWNvbmRzKSBpc3N1ZSwgd2hpY2gKPiBpcyBhbHdheXMgcmVwcm9kdWNpYmxlLCBh bmQgZm91bmQgY29tbWl0IDMxZjg1Y2NjODRiOCAoImYyZnM6IHVuaWZ5Cj4gdGhlIGVycm9yIGhh bmRsaW5nIG9mIGYyZnNfaXNfdmFsaWRfYmxrYWRkciIpIHRvIGJlIGNhdXNpbmcgaXQuCj4gCj4g SSdsbCBqdXN0IHJldmVydCB0aGF0IHBhdGNoIGxvY2FsbHkuIFNlZW1zIGxpa2UgSmFlZ2V1aydz IGRldiBicmFuY2gKPiBkb2Vzbid0IGhhdmUgdGhlIGZpeCBmb3IgdGhpcyBzcGVjaWZpY2FsbHkg eWV0LgoKSSB3YXMgc3VzcGVjdGluZyBmMmZzX3JhX21ldGFfcGFnZXMoKSBjb3VsZCB0cnkgdG8g cmVhZCBvdXQgYmV5b25kIHRoZSBib3VuZGFyeQpiZWZvcmUsIGJ1dCBpdCBzZWVtcyB5b3UgaGl0 IHRoZSBjYXNlLiBDYW4geW91IGNoZWNrIHRoaXMgcGF0Y2ggYWRkcmVzcyB0aGF0PwoKPiAKPiBU aGFua3MuCj4gCj4gPgo+ID4gSSB3YXMgdHJ5aW5nIHRvIGRlYnVnIGFub3RoZXIgaXNzdWUsIGJ1 dCBmb3VuZCB0aGUgcm9vdCBjYXVzZS4gTGV0IG1lIGRyb3AgdGhpcwo+ID4gcGF0Y2guCj4gPgo+ ID4gPgo+ID4gPiBUaGFua3MsCj4gPiA+Cj4gPiA+ID4KPiA+ID4gPiBGaXhlczogMzFmODVjY2M4 NGI4ICgiZjJmczogdW5pZnkgdGhlIGVycm9yIGhhbmRsaW5nIG9mIGYyZnNfaXNfdmFsaWRfYmxr YWRkciIpCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogSmFlZ2V1ayBLaW0gPGphZWdldWtAa2VybmVs Lm9yZz4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgIGZzL2YyZnMvY2hlY2twb2ludC5jIHwgOSArKysr Ky0tLS0KPiA+ID4gPiAgIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDQgZGVsZXRp b25zKC0pCj4gPiA+ID4KPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZnMvZjJmcy9jaGVja3BvaW50LmMg Yi9mcy9mMmZzL2NoZWNrcG9pbnQuYwo+ID4gPiA+IGluZGV4IGVhYzY5OGI4ZGQzOC4uYjAxMzIw NTAyNjI0IDEwMDY0NAo+ID4gPiA+IC0tLSBhL2ZzL2YyZnMvY2hlY2twb2ludC5jCj4gPiA+ID4g KysrIGIvZnMvZjJmcy9jaGVja3BvaW50LmMKPiA+ID4gPiBAQCAtMTc5LDIyICsxNzksMjIgQEAg c3RhdGljIGJvb2wgX19mMmZzX2lzX3ZhbGlkX2Jsa2FkZHIoc3RydWN0IGYyZnNfc2JfaW5mbyAq c2JpLAo+ID4gPiA+ICAgICAgICAgICAgIGJyZWFrOwo+ID4gPiA+ICAgICBjYXNlIE1FVEFfU0lU Ogo+ID4gPiA+ICAgICAgICAgICAgIGlmICh1bmxpa2VseShibGthZGRyID49IFNJVF9CTEtfQ05U KHNiaSkpKQo+ID4gPiA+IC0gICAgICAgICAgICAgICAgICAgZ290byBlcnI7Cj4gPiA+ID4gKyAg ICAgICAgICAgICAgICAgICBnb3RvIGNoZWNrX29ubHk7Cj4gPiA+ID4gICAgICAgICAgICAgYnJl YWs7Cj4gPiA+ID4gICAgIGNhc2UgTUVUQV9TU0E6Cj4gPiA+ID4gICAgICAgICAgICAgaWYgKHVu bGlrZWx5KGJsa2FkZHIgPj0gTUFJTl9CTEtBRERSKHNiaSkgfHwKPiA+ID4gPiAgICAgICAgICAg ICAgICAgICAgIGJsa2FkZHIgPCBTTV9JKHNiaSktPnNzYV9ibGthZGRyKSkKPiA+ID4gPiAtICAg ICAgICAgICAgICAgICAgIGdvdG8gZXJyOwo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgZ290 byBjaGVja19vbmx5Owo+ID4gPiA+ICAgICAgICAgICAgIGJyZWFrOwo+ID4gPiA+ICAgICBjYXNl IE1FVEFfQ1A6Cj4gPiA+ID4gICAgICAgICAgICAgaWYgKHVubGlrZWx5KGJsa2FkZHIgPj0gU0lU X0koc2JpKS0+c2l0X2Jhc2VfYWRkciB8fAo+ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgYmxr YWRkciA8IF9fc3RhcnRfY3BfYWRkcihzYmkpKSkKPiA+ID4gPiAtICAgICAgICAgICAgICAgICAg IGdvdG8gZXJyOwo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgZ290byBjaGVja19vbmx5Owo+ ID4gPiA+ICAgICAgICAgICAgIGJyZWFrOwo+ID4gPiA+ICAgICBjYXNlIE1FVEFfUE9SOgo+ID4g PiA+ICAgICAgICAgICAgIGlmICh1bmxpa2VseShibGthZGRyID49IE1BWF9CTEtBRERSKHNiaSkg fHwKPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgIGJsa2FkZHIgPCBNQUlOX0JMS0FERFIoc2Jp KSkpCj4gPiA+ID4gLSAgICAgICAgICAgICAgICAgICBnb3RvIGVycjsKPiA+ID4gPiArICAgICAg ICAgICAgICAgICAgIGdvdG8gY2hlY2tfb25seTsKPiA+ID4gPiAgICAgICAgICAgICBicmVhazsK PiA+ID4gPiAgICAgY2FzZSBEQVRBX0dFTkVSSUM6Cj4gPiA+ID4gICAgIGNhc2UgREFUQV9HRU5F UklDX0VOSEFOQ0U6Cj4gPiA+ID4gQEAgLTIyOCw2ICsyMjgsNyBAQCBzdGF0aWMgYm9vbCBfX2Yy ZnNfaXNfdmFsaWRfYmxrYWRkcihzdHJ1Y3QgZjJmc19zYl9pbmZvICpzYmksCj4gPiA+ID4gICAg IHJldHVybiB0cnVlOwo+ID4gPiA+ICAgZXJyOgo+ID4gPiA+ICAgICBmMmZzX2hhbmRsZV9lcnJv cihzYmksIEVSUk9SX0lOVkFMSURfQkxLQUREUik7Cj4gPiA+ID4gK2NoZWNrX29ubHk6Cj4gPiA+ ID4gICAgIHJldHVybiBmYWxzZTsKPiA+ID4gPiAgIH0KPiA+Cj4gPgo+ID4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IExpbnV4LWYyZnMtZGV2ZWwg bWFpbGluZyBsaXN0Cj4gPiBMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldAo+ ID4gaHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vbGludXgtZjJm cy1kZXZlbAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkxpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0CkxpbnV4LWYyZnMtZGV2ZWxAbGlzdHMuc291 cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZv L2xpbnV4LWYyZnMtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAB914D110 for ; Fri, 19 Apr 2024 17:50:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713549038; cv=none; b=UpgROASSB8DcANgEJ3ue1SaMhdUS5+5R45YovQazm4W/KNziq5B8nazx5eV8vfY1SHNXnZh4z/Bv7ADHSHWTRphFmTGIZRsbM0VnqEoSRyTPeXnaaO7eup0UlXKhX3wzpH0CJYBF6QsbWF+rXrDKw/O+2rWq3jwgbqcQ1SfuPk4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713549038; c=relaxed/simple; bh=rvTw9ZrNgQLrxwznc8Svvfzom1CX7emLfaumx2oM7sM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qP3aWt4tBSeqq4OEmrXWvuntTo8iY5MksUfBFEw6urKLmaY/R35cL8o/LpJ3hn4TnDxOeuAi7tReTR1tJgG962Ib3UpAvqmSv5BpBjOMYpvj80k1eliNo2+eU/FYjRwv9+71YXC4x78ItgoQIquqQAJTRWApN2XgCTzkLVAqFzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KsaZaGFw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KsaZaGFw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21301C072AA; Fri, 19 Apr 2024 17:50:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713549038; bh=rvTw9ZrNgQLrxwznc8Svvfzom1CX7emLfaumx2oM7sM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KsaZaGFwPHe2vKZa0qajwmUlD6nHyZZibR4e7m6LU3KgavQ57SBW/qLg4xjJ3RPLB Jg83FoAvguNj+ZmZyZLl0+h3tZiSwc7Jtm5kp7W1DGxHcIJVSjoXAjQyL82U2+ux6W mKt2fbRiQeyBsySecMUPuA0gGVMTMgQDMoCCaooqSDAIk1IHfV4Reoz8QymuVqe9jo ctxKxFgqmnPbcCgjei3N13cQkIMvLfZOoVyD6SUh0WVc9Zp3blPu90p3WCXV56j/Z1 EL1mzJje8xXFAPGTtBmrR5xdphNnf+Kp4Secbll2QAuwDKf06MvDUG8tVooF1UYB/b WBG2YWpEigtbw== Date: Fri, 19 Apr 2024 17:50:36 +0000 From: Jaegeuk Kim To: Juhyung Park Cc: Chao Yu , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address Message-ID: References: <20240409203411.1885121-1-jaegeuk@kernel.org> <20240409203411.1885121-3-jaegeuk@kernel.org> <050a93dc-d9a8-44bd-9a83-83718e95f04d@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 04/19, Juhyung Park wrote: > On Sat, Apr 13, 2024 at 5:57 AM Jaegeuk Kim wrote: > > > > On 04/11, Chao Yu wrote: > > > On 2024/4/10 4:34, Jaegeuk Kim wrote: > > > > f2fs_ra_meta_pages can try to read ahead on invalid block address which is > > > > not the corruption case. > > > > > > In which case we will read ahead invalid meta pages? recovery w/ META_POR? > > In my case, it seems like it's META_SIT, and it's triggered right after mount. > fsck detects invalid_blkaddr, and when the kernel mounts it, it > immediately flags invalid_blkaddr again: > > [ 6.333498] init: [libfs_mgr] Running /system/bin/fsck.f2fs -a -c > 10000 --debug-cache /dev/block/sda13 > [ 6.337671] fsck.f2fs: Info: Fix the reported corruption. > [ 6.337947] fsck.f2fs: Info: not exist /proc/version! > [ 6.338010] fsck.f2fs: Info: can't find /sys, assuming normal block device > [ 6.338294] fsck.f2fs: Info: MKFS version > [ 6.338319] fsck.f2fs: "5.10.160-android12-9-ge5cfec41c8e2" > [ 6.338366] fsck.f2fs: Info: FSCK version > [ 6.338380] fsck.f2fs: from "5.10-arter97" > [ 6.338393] fsck.f2fs: to "5.10-arter97" > [ 6.338414] fsck.f2fs: Info: superblock features = 1499 : encrypt > verity extra_attr project_quota quota_ino casefold > [ 6.338429] fsck.f2fs: Info: superblock encrypt level = 0, salt = > 00000000000000000000000000000000 > [ 6.338442] fsck.f2fs: Info: checkpoint stop reason: shutdown(180) > [ 6.338455] fsck.f2fs: Info: fs errors: invalid_blkaddr > [ 6.338468] fsck.f2fs: Info: Segments per section = 1 > [ 6.338480] fsck.f2fs: Info: Sections per zone = 1 > [ 6.338492] fsck.f2fs: Info: total FS sectors = 58971571 (230357 MB) > [ 6.340599] fsck.f2fs: Info: CKPT version = 2b7e3b29 > [ 6.340620] fsck.f2fs: Info: version timestamp cur: 19789296, prev: 18407008 > [ 6.677041] fsck.f2fs: Info: checkpoint state = 46 : crc > compacted_summary orphan_inodes sudden-power-off > [ 6.677052] fsck.f2fs: [FSCK] Check node 1 / 712937 (0.00%) > [ 8.997922] fsck.f2fs: [FSCK] Check node 71294 / 712937 (10.00%) > [ 10.629205] fsck.f2fs: [FSCK] Check node 142587 / 712937 (20.00%) > [ 12.278186] fsck.f2fs: [FSCK] Check node 213880 / 712937 (30.00%) > [ 13.768177] fsck.f2fs: [FSCK] Check node 285173 / 712937 (40.00%) > [ 17.446971] fsck.f2fs: [FSCK] Check node 356466 / 712937 (50.00%) > [ 19.891623] fsck.f2fs: [FSCK] Check node 427759 / 712937 (60.00%) > [ 23.251327] fsck.f2fs: [FSCK] Check node 499052 / 712937 (70.00%) > [ 28.493457] fsck.f2fs: [FSCK] Check node 570345 / 712937 (80.00%) > [ 29.640800] fsck.f2fs: [FSCK] Check node 641638 / 712937 (90.00%) > [ 30.718347] fsck.f2fs: [FSCK] Check node 712931 / 712937 (100.00%) > [ 30.724176] fsck.f2fs: > [ 30.737160] fsck.f2fs: [FSCK] Max image size: 167506 MB, Free space: 62850 MB > [ 30.737164] fsck.f2fs: [FSCK] Unreachable nat entries > [Ok..] [0x0] > [ 30.737638] fsck.f2fs: [FSCK] SIT valid block bitmap checking > [Ok..] > [ 30.737640] fsck.f2fs: [FSCK] Hard link checking for regular file > [Ok..] [0xd] > [ 30.737641] fsck.f2fs: [FSCK] valid_block_count matching with CP > [Ok..] [0x28b98e6] > [ 30.737644] fsck.f2fs: [FSCK] valid_node_count matching with CP (de > lookup) [Ok..] [0xae0e9] > [ 30.737646] fsck.f2fs: [FSCK] valid_node_count matching with CP > (nat lookup) [Ok..] [0xae0e9] > [ 30.737647] fsck.f2fs: [FSCK] valid_inode_count matched with CP > [Ok..] [0xa74a3] > [ 30.737649] fsck.f2fs: [FSCK] free segment_count matched with CP > [Ok..] [0x7aa3] > [ 30.737662] fsck.f2fs: [FSCK] next block offset is free > [Ok..] > [ 30.737663] fsck.f2fs: [FSCK] fixing SIT types > [ 30.737867] fsck.f2fs: [FSCK] other corrupted bugs > [Ok..] > [ 30.737893] fsck.f2fs: [update_superblock: 765] Info: Done to > update superblock > [ 30.960610] fsck.f2fs: > [ 30.960618] fsck.f2fs: Done: 24.622956 secs > [ 30.960620] fsck.f2fs: > [ 30.960622] fsck.f2fs: c, u, RA, CH, CM, Repl= > [ 30.960627] fsck.f2fs: 10000 10000 43600517 42605434 995083 985083 > [ 30.963274] F2FS-fs (sda13): Using encoding defined by superblock: > utf8-12.1.0 with flags 0x0 > [ 30.995360] __f2fs_is_valid_blkaddr: type=2 > > (Manually added that print ^) > > [ 30.995369] ------------[ cut here ]------------ > [ 30.995375] WARNING: CPU: 7 PID: 1 at f2fs_handle_error+0x18/0x3c > [ 30.995378] CPU: 7 PID: 1 Comm: init Tainted: G S W > 5.10.209-arter97-r15-kernelsu-g0867d0e4f1d2 #6 > [ 30.995379] Hardware name: Qualcomm Technologies, Inc. Cape QRD > with PM8010 (DT) > [ 30.995380] pstate: 22400005 (nzCv daif +PAN -UAO +TCO BTYPE=--) > [ 30.995382] pc : f2fs_handle_error+0x18/0x3c > [ 30.995384] lr : __f2fs_is_valid_blkaddr+0x2a4/0x2b0 > [ 30.995385] sp : ffffff80209e79b0 > [ 30.995386] x29: ffffff80209e79b0 x28: 0000000000000037 > [ 30.995388] x27: 00000000000001c7 x26: 0000000020120121 > [ 30.995389] x25: 00000000000000d9 x24: 0000000000000000 > [ 30.995390] x23: ffffffff00f1a700 x22: 0000000000000828 > [ 30.995391] x21: ffffff80462aa000 x20: ffffff80462aa000 > [ 30.995392] x19: 0000000000000002 x18: ffffffffffffffff > [ 30.995393] x17: 0000000000000000 x16: 00000000ffff0000 > [ 30.995394] x15: 0000000000000004 x14: ffffffd1675ac6d0 > [ 30.995395] x13: 0000000000000003 x12: 0000000000000003 > [ 30.995396] x11: 00000000ffffffff x10: 0000000000000000 > [ 30.995397] x9 : 0000000100000001 x8 : 0000000100000000 > [ 30.995398] x7 : 64696c61765f7369 x6 : ffffffd1681279e8 > [ 30.995399] x5 : 000000000000001f x4 : 0000000000000001 > [ 30.995400] x3 : 0000000000000000 x2 : ffffff89f03dedc8 > [ 30.995401] x1 : 0000000000000002 x0 : ffffff80462aa000 > [ 30.995403] Call trace: > [ 30.995404] f2fs_handle_error+0x18/0x3c > [ 30.995405] __f2fs_is_valid_blkaddr+0x2a4/0x2b0 > [ 30.995406] f2fs_is_valid_blkaddr+0x10/0x20 > [ 30.995407] f2fs_ra_meta_pages+0xe0/0x230 > [ 30.995409] build_sit_entries+0xa8/0x580 > [ 30.995411] f2fs_build_segment_manager+0x124/0x170 > [ 30.995412] f2fs_fill_super+0x78c/0xd1c > [ 30.995415] mount_bdev+0x168/0x1ac > [ 30.995416] f2fs_mount+0x18/0x24 > [ 30.995418] legacy_get_tree.llvm.9147845779559715083+0x30/0x5c > [ 30.995419] vfs_get_tree+0x30/0xe0 > [ 30.995421] do_new_mount+0x140/0x358 > [ 30.995422] path_mount+0x1fc/0x4e8 > [ 30.995423] __arm64_sys_mount+0x150/0x294 > [ 30.995425] el0_svc_common.llvm.15698454952154965787+0xa8/0x138 > [ 30.995426] do_el0_svc+0x24/0x90 > [ 30.995429] el0_svc+0x10/0x1c > [ 30.995430] el0_sync_handler+0xcc/0xe4 > [ 30.995432] el0_sync+0x1a0/0x1c0 > [ 30.995433] ---[ end trace 3b83295e0cdac94e ]--- > [ 31.005011] F2FS-fs (sda13): Mounted with checkpoint version = 2b7e3b29 > [ 31.005176] init: [libfs_mgr] > __mount(source=/dev/block/bootdevice/by-name/userdata,target=/data,type=f2fs)=0: > Success > [ 31.007749] init: Userdata mounted using /vendor/etc/fstab.qcom result : 0 > > > I was bisecting a long boot time (24 additional seconds) issue, which > is always reproducible, and found commit 31f85ccc84b8 ("f2fs: unify > the error handling of f2fs_is_valid_blkaddr") to be causing it. > > I'll just revert that patch locally. Seems like Jaegeuk's dev branch > doesn't have the fix for this specifically yet. I was suspecting f2fs_ra_meta_pages() could try to read out beyond the boundary before, but it seems you hit the case. Can you check this patch address that? > > Thanks. > > > > > I was trying to debug another issue, but found the root cause. Let me drop this > > patch. > > > > > > > > Thanks, > > > > > > > > > > > Fixes: 31f85ccc84b8 ("f2fs: unify the error handling of f2fs_is_valid_blkaddr") > > > > Signed-off-by: Jaegeuk Kim > > > > --- > > > > fs/f2fs/checkpoint.c | 9 +++++---- > > > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > > > > index eac698b8dd38..b01320502624 100644 > > > > --- a/fs/f2fs/checkpoint.c > > > > +++ b/fs/f2fs/checkpoint.c > > > > @@ -179,22 +179,22 @@ static bool __f2fs_is_valid_blkaddr(struct f2fs_sb_info *sbi, > > > > break; > > > > case META_SIT: > > > > if (unlikely(blkaddr >= SIT_BLK_CNT(sbi))) > > > > - goto err; > > > > + goto check_only; > > > > break; > > > > case META_SSA: > > > > if (unlikely(blkaddr >= MAIN_BLKADDR(sbi) || > > > > blkaddr < SM_I(sbi)->ssa_blkaddr)) > > > > - goto err; > > > > + goto check_only; > > > > break; > > > > case META_CP: > > > > if (unlikely(blkaddr >= SIT_I(sbi)->sit_base_addr || > > > > blkaddr < __start_cp_addr(sbi))) > > > > - goto err; > > > > + goto check_only; > > > > break; > > > > case META_POR: > > > > if (unlikely(blkaddr >= MAX_BLKADDR(sbi) || > > > > blkaddr < MAIN_BLKADDR(sbi))) > > > > - goto err; > > > > + goto check_only; > > > > break; > > > > case DATA_GENERIC: > > > > case DATA_GENERIC_ENHANCE: > > > > @@ -228,6 +228,7 @@ static bool __f2fs_is_valid_blkaddr(struct f2fs_sb_info *sbi, > > > > return true; > > > > err: > > > > f2fs_handle_error(sbi, ERROR_INVALID_BLKADDR); > > > > +check_only: > > > > return false; > > > > } > > > > > > _______________________________________________ > > Linux-f2fs-devel mailing list > > Linux-f2fs-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel